| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
I noticed that the first time I run the page cycler the test numbers
are worse, probably because the test pages are not in cache. We
already have this code on Mac and I don't see why it shouldn't apply
to all systems.
Review URL: http://codereview.chromium.org/2096005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in the UI test framework:
- WaitUntilCookieValue
- WaitUntilCookieNonEmpty
- WaitUntilJavaScriptCondition
This helps reduce number of arbitrary "magic timeouts" which are different
in each test.
We don't remove the test timeout parameter, because it varies depending on test case,
and for now we don't have a better solution. Trying a "naive" way leads to hangs
on flaky tests.
TEST=UI-based tests
BUG=none
Review URL: http://codereview.chromium.org/1557001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
test from 10 to 5, to make sure all tests finish in less than 10
minutes (seems to be a problem only on the Vista perf bot).
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1089006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=chase
Review URL: http://codereview.chromium.org/1141003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1147001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
important return values are not ignored.
The macro used here, WARN_UNUSED_RESULT, takes effect only for GCC,
but that's enough since we have bots for all platforms.
Adding these warnings already detected some cases where a return value
was ignored. In some of them the test was trying to get the information
about success "some other way", in some it could sometimes confuse test
failure with test success.
TEST=ui_tests
BUG=none
Review URL: http://codereview.chromium.org/948002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Reverts r40097.
BUG=36871
TEST=page_cycler_moz-http is green
Review URL: http://codereview.chromium.org/661449
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG:36871
Review URL: http://codereview.chromium.org/660162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
way too much time to run on the release perf bots.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/552238
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
same suite and print out only the running time.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/549142
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also drops fragile code.
TEST=Covered by ui_tests.
BUG=10840
Review URL: http://codereview.chromium.org/545006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/465141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Originally committed in r32954. The underlying problem
was fixed in r33704 and r33736.
BUG=28764
TEST=morejs page cycler continues to get results for
reference build
Review URL: http://codereview.chromium.org/460124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29225
TEST=PageCyclerTest.Intl2File test should succeed.
Review URL: http://codereview.chromium.org/460102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Speculative fix to address bad perf results for
reference build. An error message that's being printed
at the same time as the test results is believed to
be causing the graphing code to incorrectly read those
results.
BUG=none
TEST=sane linux morejs reference graph result
Review URL: http://codereview.chromium.org/437024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
file:// URLs. It turns out teams were already depending on
this and we didn't want to break them.
Instead, group file:// access with NPAPI in the extension
install prompt.
Note: this is a pure revert of r402029 and r402069 (sorry
Finnur!) except the changes in extension_install_ui.cc,
which are new.
BUG=28456
Review URL: http://codereview.chromium.org/430003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
perf overview dashboard) for memory_test, but not for page_cycler.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/418034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move PrintIOPerfInfo(), PrintMemoryUsageInfo() and PrintSystemCommitCharge()
into the UITest base class so both page_cycler and memory_test will be
able to use them. Make the user data dir a parameter so that memory_test
will be able to point to its temporary copy.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/402052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/401015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This requires a command line flag for the page cycler tests,
since those load file:// urls.
BUG=27877
TEST=Bunch of tests affected.
Review URL: http://codereview.chromium.org/402029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/385023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
inherently unsafe in multi-threaded apps because it stores the string in a global buffer. It should never be used. If you want to log an error, use PLOG and friends, or if that's too high-level then use safe_strerror().
TEST=built on Linux in 32-bit and 64-bit mode; ran base_unittests in each case; ran Chromium itself in each case; try servers
BUG=none
Review URL: http://codereview.chromium.org/261055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
of wstrings. Also convert template_user_data_ in UITest to be
a FilePath.
Review URL: http://codereview.chromium.org/273021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- reduce header dependencies
- remove things that shouldn't be #included in a header, like string_util.h and theme_resources.h!
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/245011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This includes two things:
-A profile containing 10 different extensions, each with 1 content script.
(We already had one with 1 extension).
-Changes to page_cycler_tests.cc to add versions of MozFile and MorejsFile
run with 1 and 10 extensions having a content script. (Only the 1-extension
case will be run by default on the buildbots).
BUG=14037
TEST=none
Review URL: http://codereview.chromium.org/235013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
source root.
Fix some tests that were manually getting sourcedir from DIR_EXE instead of using DIR_SOURCE_ROOT.
BUG=none
TEST=rm -r out, ln -s /somedir/out out, run tests
Review URL: http://codereview.chromium.org/192064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the proxy doesn't respond (e.g., due to a timeout).
BUG=none
TEST=Hopefully the Mac valgrind bots will more reliably run all their tests (although there are likely more issues like this lurking).
Review URL: http://codereview.chromium.org/149281
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12357
TEST=page cycler runs to completion
Review URL: http://codereview.chromium.org/155003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This patch makes it harder for process handles with more privileges
to leak to untrusted places.
Review URL: http://codereview.chromium.org/125260
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
runs. Since the reference run always comes second, it seems like it gets the UBC advantage and everything is a little after (when using two of the same builds). So try to load all the needed data into the UBC before we start the tests.
Review URL: http://codereview.chromium.org/131057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Spawn PS to collect the data and parse the output.
Add ifdef checks in the page cyclers so on mac we can use the other helper since base methods can't ever be made to work.
BUG=none
TEST=memory info should now show in the waterfall and on the perf graphs for the page cycler tests.
Review URL: http://codereview.chromium.org/125254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
reference build which would change the baseline on lot of tests and not just the page cycler.
Enable the intl* tests on mac.
TEST=the intl page cycler tests will run and also the reference version will.
BUG=8390
Review URL: http://codereview.chromium.org/125210
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
when it isn't the failure is obvious and easy-to-diagnose.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119447
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
(built from src@18159).
Enable the reference page cycle tests on the mac.
Review URL: http://codereview.chromium.org/122039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=mark
Review URL: http://codereview.chromium.org/123016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
task window.
BUG=none
TEST=perf bots should have memory numbers now like linux.
Review URL: http://codereview.chromium.org/118436
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
notifications directly in channel background thread. Add support for listener-less ChannelProxy.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113722
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We were crashing while trying to load fonts. Your patch for font
fallback fixes the crash.
Review URL: http://codereview.chromium.org/112061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=mmoss
Review URL: http://codereview.chromium.org/115724
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the final RSS size and the total VM size.
Review URL: http://codereview.chromium.org/113217
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99298
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Accompanying buildbot changes @ http://codereview.chromium.org/67234
Review URL: http://codereview.chromium.org/79017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DomFile and DhtmlFile corpus sets. Not enabling Intl1File, Intl2File yet coz
they crash Chromium.
Not enabling PageCyclerReferenceTest yet coz we don't yet have a reference
build.
Review URL: http://codereview.chromium.org/67127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- move code only used by tests to chrome/test
- make a better, more portable abstraction
For now, it still only works on Windows. But this is the first step
to porting this part of code.
Patch by phajdan.jr@chromium.org: <http://codereview.chromium.org/54003>
Review URL: http://codereview.chromium.org/67004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/53121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Use using_v8 rather than referencing the libs directly.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This is terrible. We need to get the build going, but adding all these
libs is really bad :(
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Switch from wstring to string where needed.
Review URL: http://codereview.chromium.org/42303
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/40221
Patch from Craig Schlenter <craig.schlenter@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11386 0039d316-1c4b-4281-b951-d872f2087c98
|