| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
It has been converted to Telemetry and is no longer run on the bots.
BUG=None
TEST=compile performance_ui_tests
Review URL: https://chromiumcodereview.appspot.com/14566005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Motivation: Data collection exposed in this CL is needed by upcoming startup tests we're writing using Telemtry.
Expose a new window.statsCollectionController object to JS and move existing histogram reading code into it since that seemed misplaced in DOMAutomationController.
Add a new --enable-stats-collection-bindings to activate said object.
Example usage in telemtry:
with browser.Create() as b:
b.tabs[0].Navigate("http://www.google.com")
b.tabs[0].WaitForDocumentReadyStateToBeComplete()
print b.tabs[0].EvaluateJavaScript('statsCollectionController.tabLoadTiming()')
BUG=None
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202620
Review URL: https://chromiumcodereview.appspot.com/12389073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Collect tab timing information for use in telementry-based startup tests
>
> Motivation: Data collection exposed in this CL is needed by upcoming startup tests we're writing using Telemtry.
>
> Expose a new window.statsCollectionController object to JS and move existing histogram reading code into it since that seemed misplaced in DOMAutomationController.
>
> Add a new --enable-stats-collection-bindings to activate said object.
>
> Example usage in telemtry:
> with browser.Create() as b:
> b.tabs[0].Navigate("http://www.google.com")
> b.tabs[0].WaitForDocumentReadyStateToBeComplete()
> print b.tabs[0].EvaluateJavaScript('statsCollectionController.tabLoadTiming()')
>
> BUG=None
>
> Review URL: https://chromiumcodereview.appspot.com/12389073
TBR=jeremy@chromium.org
Review URL: https://codereview.chromium.org/16160006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Motivation: Data collection exposed in this CL is needed by upcoming startup tests we're writing using Telemtry.
Expose a new window.statsCollectionController object to JS and move existing histogram reading code into it since that seemed misplaced in DOMAutomationController.
Add a new --enable-stats-collection-bindings to activate said object.
Example usage in telemtry:
with browser.Create() as b:
b.tabs[0].Navigate("http://www.google.com")
b.tabs[0].WaitForDocumentReadyStateToBeComplete()
print b.tabs[0].EvaluateJavaScript('statsCollectionController.tabLoadTiming()')
BUG=None
Review URL: https://chromiumcodereview.appspot.com/12389073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke both windows clobber and official builders' compile with this error:
771>Link:
771> Creating library ..\..\..\build\Release\lib\gcp_portmon64.lib and
object ..\..\..\build\Release\lib\gcp_portmon64.exp
771>base.lib(path_service.obj) : fatalerror LNK1112: module machine type 'X86'
conflicts with target machine type 'x64'
771>
771>Build FAILED.
> Move FileEnumerator to its own file, do some refactoring.
>
> It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked.
>
> BUG=175002
> R=rvargas@chromium.org
>
> Review URL: https://codereview.chromium.org/13165005
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/14824006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked.
BUG=175002
R=rvargas@chromium.org
Review URL: https://codereview.chromium.org/13165005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit e59558b78e8c6a1b0bd916a724724b638c3c91b6.
Revert "Fix build after r193020."
This reverts commit 558a35897f6b3ffbcaefde927c1f150b815d140a.
Revert "Really fix build after r193020."
This reverts commit e3748a79b523a8d365d4a33ef986eebb4186fa78.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
string_piece.h was moved into base/strings/ in r191206 -
https://chromiumcodereview.appspot.com/12982018/
TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/13247007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This moves includes from using base/sys_string_conversions.h to the new location in base/strings/sys_string_conversions.h
BUG=196305
Review URL: https://codereview.chromium.org/13042020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will provide one measure of the overhead of
enabling accessibility and help catch regressions.
BUG=137057
Review URL: https://chromiumcodereview.appspot.com/12213026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Add utf_string_conversions to base namespace.
>
> This adds "using"s for all functions so those can be fixed in a separate pass.
>
> This converts the "Wide" versions of the functions in the Chrome directory as a first pass on the changeover.
>
> BUG=
>
> Review URL: https://codereview.chromium.org/12314090
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/12315071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds "using"s for all functions so those can be fixed in a separate pass.
This converts the "Wide" versions of the functions in the Chrome directory as a first pass on the changeover.
BUG=
Review URL: https://codereview.chromium.org/12314090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=sky
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Automated clean up of style checker errors that were missed due to the plugin
not being executed on implementation files.
BUG=115047
TBR=brettw, satorux
Review URL: https://chromiumcodereview.appspot.com/12253025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/12213104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
string_number_conversions in some chrome subdirectories.
Review URL: https://codereview.chromium.org/12218065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These units are recorded in the graphs.dat file, and can then be used to determine whether the test has improved or regressed when the graph goes up.
Review URL: https://chromiumcodereview.appspot.com/11234012
TBR=sullivan@chromium.org
Review URL: https://codereview.chromium.org/11365067
TBR=sullivan@chromium.org
Review URL: https://codereview.chromium.org/11361218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
recorded in the graphs.dat file, and can then be used to determine whether the test has improved or regressed when the graph goes up.
Review URL: https://chromiumcodereview.appspot.com/11234012
TBR=sullivan@chromium.org
Review URL: https://codereview.chromium.org/11365067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
graphs.dat file, and can then be used to determine whether the test has improved or regressed when the graph goes up.
Review URL: https://chromiumcodereview.appspot.com/11234012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes the chrome browser expose a JS object for retrieving histograms if a command line flag is passed. Page cycler then gets the histograms by executing JS via the test automation API.
BUG=145352
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159668
Review URL: https://chromiumcodereview.appspot.com/10905073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original description:
Page cyclers: output memory histograms (approach: expose JS object)
This CL makes the chrome browser expose a JS object for retrieving histograms if a command line flag is passed. Page cycler then gets the histograms by executing JS via the test automation API.
BUG=145352
Review URL: https://chromiumcodereview.appspot.com/10905073
TBR=marja@chromium.org
Review URL: https://codereview.chromium.org/11027020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes the chrome browser expose a JS object for retrieving histograms if a command line flag is passed. Page cycler then gets the histograms by executing JS via the test automation API.
BUG=145352
Review URL: https://chromiumcodereview.appspot.com/10905073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a resubmit of a previously reverted commit:
https://chromiumcodereview.appspot.com/10736064/
BUG=108171
Review URL: https://chromiumcodereview.appspot.com/10787010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
infrastructure.
BUG=108171
Review URL: https://chromiumcodereview.appspot.com/10736064
TBR=tedvessenes@gmail.com
Review URL: https://chromiumcodereview.appspot.com/10781003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=108171
Review URL: https://chromiumcodereview.appspot.com/10736064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add supporting WPR extension.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9956045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
subclasses.
BUG=115925
TEST=
Review URL: http://codereview.chromium.org/9501001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=115479
TBR=thakis
Review URL: https://chromiumcodereview.appspot.com/9463036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
browser tests.
BUG=107745
Review URL: http://codereview.chromium.org/8971004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These changes address issue #106655. All variants of StringToInt have been
converted to use the StringPiece class. One instance of conversion, in
chrome/browser/history/text_database.cc, required copying an underlying
string. This is because the string type in question could use 8 or 16
bit characters depending on the OS type, and because StringPiece is not
implemented as a template, the code cannot specify whether to create a
StringPiece or StringPiece16. This should be remedied in a future CL.
R=erikwright@chromium.org
BUG=106655
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114929
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114944
Review URL: http://codereview.chromium.org/8921006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert due to compile breakage on ChromeOS.
These changes address issue #106655. All variants of StringToInt have been
converted to use the StringPiece class. One instance of conversion, in
chrome/browser/history/text_database.cc, required copying an underlying
string. This is because the string type in question could use 8 or 16
bit characters depending on the OS type, and because StringPiece is not
implemented as a template, the code cannot specify whether to create a
StringPiece or StringPiece16. This should be remedied in a future CL.
R=erikwright@chromium.org
BUG=106655
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114929
Review URL: http://codereview.chromium.org/8921006
TBR=tedvessenes@gmail.com
Review URL: http://codereview.chromium.org/8990002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These changes address issue #106655. All variants of StringToInt have been
converted to use the StringPiece class. One instance of conversion, in
chrome/browser/history/text_database.cc, required copying an underlying
string. This is because the string type in question could use 8 or 16
bit characters depending on the OS type, and because StringPiece is not
implemented as a template, the code cannot specify whether to create a
StringPiece or StringPiece16. This should be remedied in a future CL.
R=erikwright@chromium.org
BUG=106655
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114929
Review URL: http://codereview.chromium.org/8921006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These changes address issue #106655. All variants of StringToInt have been
converted to use the StringPiece class. One instance of conversion, in
chrome/browser/history/text_database.cc, required copying an underlying
string. This is because the string type in question could use 8 or 16
bit characters depending on the OS type, and because StringPiece is not
implemented as a template, the code cannot specify whether to create a
StringPiece or StringPiece16. This should be remedied in a future CL.
R=erikwright@chromium.org
BUG=106655
TEST=
Review URL: http://codereview.chromium.org/8921006
TBR=tedvessenes@gmail.com
Review URL: http://codereview.chromium.org/8984007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These changes address issue #106655. All variants of StringToInt have been
converted to use the StringPiece class. One instance of conversion, in
chrome/browser/history/text_database.cc, required copying an underlying
string. This is because the string type in question could use 8 or 16
bit characters depending on the OS type, and because StringPiece is not
implemented as a template, the code cannot specify whether to create a
StringPiece or StringPiece16. This should be remedied in a future CL.
R=erikwright@chromium.org
BUG=106655
TEST=
Review URL: http://codereview.chromium.org/8921006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Set a variable to indicate that the result report page
is loaded. See detailed analysis in crbug.com/53140.
This is relanding r101718 after a revert at r101778.
BUG=53140
TBR=jnd@chromium.org
TEST=page cycler stays green
Review URL: http://codereview.chromium.org/7941015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change broke all of the page cycler tests on the
chromium.perf waterfall.
TBR=jnd@chromium.org
BUG=53140
TEST=page cyclers work again
Review URL: http://codereview.chromium.org/7941010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
variable to indicate that the result report page is loaded. See detailed analysis in crbug.com/53140.
BUG=53140
Review URL: http://codereview.chromium.org/7904005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This will make it easier to choose the right timeout.
BUG=none
Review URL: http://codereview.chromium.org/7744031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
Move all performance tests under chrome/test/perf.
This also gets rid of directories containing only 1-2 files.
BUG=90905
Review URL: http://codereview.chromium.org/7578004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95481 0039d316-1c4b-4281-b951-d872f2087c98
|