| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Preventative maintenance for abstract classes that do not declare virtual
destructors. Base classes that do not declare their destructors as virtual
could potentially lead to memory leaks.
These files were discovered using the -Wnon-virtual-dtor flag in g++.
r=jar
BUG=47469
Review URL: http://codereview.chromium.org/3032046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54408 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
| |
BUG=50273
TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux
TBR: erg
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The closure.h file just defines a callback type. But base/callback.h already
define a callback with the same type, but with a different name. So just use
the callback from base instead.
BUG=26443
TEST=trybots
Signed-off-by: Thiago Farina <tfarina@chromium.org>
Review URL: http://codereview.chromium.org/2966009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52662 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
| |
some CV broadcasts in SyncerThread, as changing vault_ fields and not signalling seems dubious (and I caught a hang in the debugger where the thread was waiting for an already true condition, thus deadlocked).
BUG=46807,39070
Review URL: http://codereview.chromium.org/2923006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52259 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Accomplished by:
(a) Plumbing the const CommitMessage into process_commit_response_command.cc, so that we can know the server state better (IS_DEL is no longer authoritative if !
which spilled over into a couple test expectations.
(b) Relaxing the enforced invariants that version==0 implied !ServerKnows, for items with client tags.
(c) Use ID renaming instead of delete/recreate to handle collisions on the unique tag.
(d) Upon deletion, version number goes to 0 so that the server knows to process the item as a recreate, if it gets undeleted. Previously, the server number would get synthesized on the client by incrementing the last known version number.
(e) Add unit tests for pretty much every ordering of delete/undelete I could come up with.
BUG=46769
TEST=unit tests; repeatedly uninstalled/installed extensions
Review URL: http://codereview.chromium.org/2844037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52209 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
| |
several tests to fail their SaveChanges()es. Add unit test for the DBS migrations.
BUG=47466
TEST=sync_unit_tests (and included new tests).
Review URL: http://codereview.chromium.org/2830027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51225 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
syncer thread has not yet been started or it has been started and is waiting for a connection.
From an API standpoint, the caller of SyncerThread::Pause and SyncerThread::Resume should not need to consider if the thread is already running. The channel responses (PAUSED and RESUMED) should be the same regardless. Furthermore, edge cases like "pause before thread is started and resume after thread is started" should be handled correctly.
This change is supposed to be fixing various offline startup problems we've been having and it includes a new integration test for this. However, it is not yet complete but we might need to check this is before it is ready.
TEST=unit
BUG=45814
Review URL: http://codereview.chromium.org/2814014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
I didn't want to mix these in with other changes that are due
to real expectations changes.
BUG=46769 (related work)
TEST=sync_unit_tests
Review URL: http://codereview.chromium.org/2811031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50791 0039d316-1c4b-4281-b951-d872f2087c98
|
