summaryrefslogtreecommitdiffstats
path: root/chrome/test/tab_switching
Commit message (Collapse)AuthorAgeFilesLines
* GTTF: Make WaitForTabCountToBecome automation call not Sleep.phajdan.jr@chromium.org2010-09-071-2/+3
| | | | | | | | | | | | Sleeping is an unreliable method to wait for things. Instead, we set up an observer. BUG=none TEST=none Review URL: http://codereview.chromium.org/3300011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58731 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58563 - GTTF: Make WaitForTabCountToBecome automation call not Sleep.gavinp@chromium.org2010-09-041-1/+1
| | | | | | | | | | | | | | | | | (unfortunately, Mac & Windows started failing tab perf tests on this change) Sleeping is an unreliable method to wait for things. Instead, we set up an observer. BUG=none TEST=none Review URL: http://codereview.chromium.org/3300011 TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3344009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58566 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Make WaitForTabCountToBecome automation call not Sleep.phajdan.jr@chromium.org2010-09-031-1/+1
| | | | | | | | | | | | Sleeping is an unreliable method to wait for things. Instead, we set up an observer. BUG=none TEST=none Review URL: http://codereview.chromium.org/3300011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58563 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Extract performance-testing-specific parts of UITestBase to UIPerfTest.phajdan.jr@chromium.org2010-08-261-2/+2
| | | | | | | | | | | In the future this may even be used to tune some settings/behaviors (like timeouts) for performance tests. TEST=ui_tests, page_cycler_*, etc BUG=none Review URL: http://codereview.chromium.org/3137040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57552 0039d316-1c4b-4281-b951-d872f2087c98
* Use Environment::SetVar in more places.tfarina@chromium.org2010-08-131-4/+5
| | | | | | | | | | | | Make use of Environment::SetVar API to replace the calls to the Windows function SetEnvironmentVariable. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3076042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55993 0039d316-1c4b-4281-b951-d872f2087c98
* Tab switching tests does not fail when running from an interactivensylvain@chromium.org2010-08-111-11/+2
| | | | | | | | | | | | | desktop. We need to ensure we always run it that way instead. Eventually we should add code to tell us the reason of the failure. BUG=46751 Review URL: http://codereview.chromium.org/3046039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55709 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Clean up some headers in tab_contents_delegate.h.erg@google.com2010-08-101-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3145001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55635 0039d316-1c4b-4281-b951-d872f2087c98
* The TabSwitch test is marked as FAILS, but TabSwitchRef was not. Nownsylvain@chromium.org2010-08-011-1/+3
| | | | | | | | | | the reference build also fails. BUG=46751 Review URL: http://codereview.chromium.org/2884059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54503 0039d316-1c4b-4281-b951-d872f2087c98
* Convert a bunch of easy AppendSwitchWithValue to *ASCII.evan@chromium.org2010-07-301-1/+1
| | | | | | | | | For this patch, I skipped over any instance where it wasn't a nearly trivial change. Review URL: http://codereview.chromium.org/3069014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54285 0039d316-1c4b-4281-b951-d872f2087c98
* Use FAILS_TabSwitch instead of DISABLED_TabSwitch.michaeln@chromium.org2010-06-171-1/+1
| | | | | | | | | | BUG=46751 TEST=n/a TBR=jhawkins Review URL: http://codereview.chromium.org/2802008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50065 0039d316-1c4b-4281-b951-d872f2087c98
* Disable TabSwitchingUITest TabSwitch on windows, started failing after a ↵michaeln@chromium.org2010-06-171-1/+8
| | | | | | | | | | | | webkit roll. BUG=46751 TEST=none TBR=bulach Review URL: http://codereview.chromium.org/2811012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50060 0039d316-1c4b-4281-b951-d872f2087c98
* Convert variables in chrome/common/env_vars.cc from wchar_t to char. Enable ↵thestig@chromium.org2010-04-061-3/+3
| | | | | | | | | | ChromeLoggingTest along the way. BUG=none TEST=none Review URL: http://codereview.chromium.org/1559016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43738 0039d316-1c4b-4281-b951-d872f2087c98
* cleanup: Include base/path_service.h in tests that use it.thestig@chromium.org2010-03-311-0/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1571004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43163 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Make automation framework more solid by making sure thatphajdan.jr@chromium.org2010-03-161-4/+7
| | | | | | | | | | | | | | | | | | | important return values are not ignored. The macro used here, WARN_UNUSED_RESULT, takes effect only for GCC, but that's enough since we have bots for all platforms. Adding these warnings already detected some cases where a return value was ignored. In some of them the test was trying to get the information about success "some other way", in some it could sometimes confuse test failure with test success. TEST=ui_tests BUG=none Review URL: http://codereview.chromium.org/948002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41696 0039d316-1c4b-4281-b951-d872f2087c98
* Add tab switch test launch arguments directly.chase@chromium.org2009-12-211-1/+9
| | | | | | | | | | BUG=none TEST=tab switching test runs without needing additional arguments Review URL: http://codereview.chromium.org/502091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35083 0039d316-1c4b-4281-b951-d872f2087c98
* Add reference build to tab switching tests.chase@chromium.org2009-12-141-74/+108
| | | | | | | | | | | | | | | | | Moves 'UseReferenceBuild' from NewTabUIStartupTest into UITest. Run multiple tab switching tests for the current and reference build. Locate the debug log based on the current browser directory. Reformat the output of the test so we print "times" as our test type instead of "tab_switch" (probably requires a perf dashboard update). BUG=25200 TEST=tab switching test also tests reference build Review URL: http://codereview.chromium.org/491090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34483 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable tab switching test.chase@chromium.org2009-12-081-1/+1
| | | | | | | | | | | | | | After some debugging on the interactive perf system, it appears the screen was locked (or at least locked up). Current theory is this is why OnPaint wasn't being called and the histogram wasn't being populated. BUG=28968 TEST=tab switching test runs on slaves Review URL: http://codereview.chromium.org/463053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34093 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Re-enable tab switching test."chase@chromium.org2009-12-071-1/+1
| | | | | | | | | | | | | Originally committed in r33997, still causing red on vista interactive perf. BUG=28968 TEST=tab switching test is disabled TBR=ben Review URL: http://codereview.chromium.org/467041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34007 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable tab switching test.chase@chromium.org2009-12-071-1/+1
| | | | | | | | | | | | Disabled in r33278 but works locally for me. Need to re-enable to test if it is still failing on the slaves. BUG=28968 TEST=tab switching test runs on slaves Review URL: http://codereview.chromium.org/466060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33997 0039d316-1c4b-4281-b951-d872f2087c98
* Disable TabSwitchingUITest.GenerateTabSwitchStatshamaji@chromium.org2009-11-301-1/+1
| | | | | | | | | | BUG=28968 TEST=none TBR=nsylvain Review URL: http://codereview.chromium.org/448009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33278 0039d316-1c4b-4281-b951-d872f2087c98
* Use TabSwitchPaintDuration in tab switching test.chase@chromium.org2009-11-191-20/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | Modified the tab switching test to use the new tab switch paint duration histogram in place of the whiteout duration histogram. As a measure, whiteout duration would not carry a value if we kept the backing store around for a tab, and we would end up with a result of zero instead of a useful result. Local results with the new measure are consistent with the number of operations we perform on the tabs. The tab switching test now fails if it cannot locate the correct histogram. In that case, it will output the contents of the log file for remote debugging. BUG=4104 TEST=count of tab switch paint duration histogram results in tab switching test equals number of tabs used in test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32196 Review URL: http://codereview.chromium.org/385121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32543 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Use TabSwitchPaintDuration in tab switching test."chase@chromium.org2009-11-171-21/+20
| | | | | | | | | | | | | | Turns vista perf red. Original review URL: http://codereview.chromium.org/385121. Original revision r32196. TBR=nsylvain BUG=4104 TEST=vista perf tab switching test goes green Review URL: http://codereview.chromium.org/402024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32202 0039d316-1c4b-4281-b951-d872f2087c98
* Use TabSwitchPaintDuration in tab switching test.chase@chromium.org2009-11-171-20/+21
| | | | | | | | | | | | | | | | | | | | | | | | Modified the tab switching test to use the new tab switch paint duration histogram in place of the whiteout duration histogram. As a measure, whiteout duration would not carry a value if we kept the backing store around for a tab, and we would end up with a result of zero instead of a useful result. Local results with the new measure are consistent with the number of operations we perform on the tabs. The tab switching test now fails if it cannot locate the correct histogram. In that case, it will output the contents of the log file for remote debugging. BUG=4104 TEST=count of tab switch paint duration histogram results in tab switching test equals number of tabs used in test Review URL: http://codereview.chromium.org/385121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32196 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add a RWH_TabSwitchPaintDuration histogram."chase@chromium.org2009-11-111-22/+20
| | | | | | | | | | | | Causes tab_switching_test to go red. Reverting this commit which is part of the investigation. BUG=4104 TEST=tab_switching_test goes green Review URL: http://codereview.chromium.org/384049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31683 0039d316-1c4b-4281-b951-d872f2087c98
* Add a RWH_TabSwitchPaintDuration histogram.chase@chromium.org2009-11-111-20/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The RWH_TabSwitchPaintDuration histogram calculates the amount of time it took after a particular view was selected for it to be fully painted. I modified the tab switching test to use the new tab switch paint duration histogram in place of the whiteout duration histogram. As a measure, whiteout duration would not carry a value if we kept the backing store around for a tab, and we would end up with a result of zero instead of a useful result. Local results with the new measure are consistent with the number of operations we perform on the tabs. The tab switching test now fails if it cannot locate the correct histogram. In that case, it will output the contents of the log file for remote debugging. BUG=4104 TEST=count of tab switch paint duration histogram results in tab switching test equals number of tabs used in test First committed as: http://src.chromium.org/viewvc/chrome?view=rev&revision=31632 Reverted in: 31645 Review URL: http://codereview.chromium.org/378038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31679 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 31632 - looks like it broke some tests.dpranke@google.com2009-11-111-21/+20
| | | | | | | | | | R=chase@chromium.org TEST=tab_switching_test BUG=none Review URL: http://codereview.chromium.org/389006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31645 0039d316-1c4b-4281-b951-d872f2087c98
* Add a RWH_TabSwitchPaintDuration histogram.chase@chromium.org2009-11-111-20/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | The RWH_TabSwitchPaintDuration histogram calculates the amount of time it took after a particular view was selected for it to be fully painted. I modified the tab switching test to use the new tab switch paint duration histogram in place of the whiteout duration histogram. As a measure, whiteout duration would not carry a value if we kept the backing store around for a tab, and we would end up with a result of zero instead of a useful result. Local results with the new measure are consistent with the number of operations we perform on the tabs. The tab switching test now fails if it cannot locate the correct histogram. BUG=4104 TEST=count of tab switch paint duration histogram results in tab switching test equals number of tabs used in test Review URL: http://codereview.chromium.org/378038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31632 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Remove an unused variable.jhawkins@chromium.org2009-09-291-2/+1
| | | | | | | | | CID=1650 BUG=none TEST=none Review URL: http://codereview.chromium.org/251036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27549 0039d316-1c4b-4281-b951-d872f2087c98
* Updated comment in tab_switching.cc to replect that Tab-switching test in ↵sidchat@chromium.org2009-09-251-1/+1
| | | | | | | | | | buildbot was outputting 0 because it was missing command line flag -log-level=0. log-level decides the amount of output in the log file, and histograms come under log-level 0. The default was 1, which meant that histograms were not logged - hence the results always showed 0. BUG=www.crbug.com/22965 TEST=none Review URL: http://codereview.chromium.org/239006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27150 0039d316-1c4b-4281-b951-d872f2087c98
* Hack to make tests work if out is a symlink: see if the current dir is the ↵mattm@chromium.org2009-09-101-3/+1
| | | | | | | | | | | | | source root. Fix some tests that were manually getting sourcedir from DIR_EXE instead of using DIR_SOURCE_ROOT. BUG=none TEST=rm -r out, ln -s /somedir/out out, run tests Review URL: http://codereview.chromium.org/192064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25898 0039d316-1c4b-4281-b951-d872f2087c98
* coverity: Check the return value of PathService::Get.jhawkins@chromium.org2009-08-131-2/+2
| | | | | | | | | CID=5737 BUG=none TEST=none Review URL: http://codereview.chromium.org/165488 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23383 0039d316-1c4b-4281-b951-d872f2087c98
* Make the logging dir on mac write outside the bundle in debug, this makes ↵thomasvl@chromium.org2009-06-121-13/+20
| | | | | | | | | | | | | | | | the file easier to find, and for unittests that try to scan it (like tab_switching), they then don't have to walk into the bundle. Compile tab_switching_test on mac/linux. Add a dep for app to tab_switching_test so building it also make sure the app is built (since it runs the app) Update tab_switching_test Use FilePath in all cases instead of wstring. Limit how long it will spin looking for the log log file so the test can't hang. TEST=the new test is built on mac/linux BUG=none Review URL: http://codereview.chromium.org/126049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18277 0039d316-1c4b-4281-b951-d872f2087c98
* Convert various chrome tests to gyp generation:sgk@chromium.org2009-06-041-206/+0
| | | | | | | | | | | | | | | | | * common/ipc_tests.vcproj * test/activex_test_control/activex_test_control.vcproj * test/automated_ui_tests/automated_ui_tests.vcproj * test/memory_test/memory_test.vcproj * test/reliability/reliability_tests.vcproj * test/selenium/selenium_tests.vcproj * test/tab_switching/tab_switching.vcproj Add an msvs_guid to the 'url_fetch_test' target and delete its .vcproj. Convert a tab to white space. BUG=none TEST=none Review URL: http://codereview.chromium.org/118182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17611 0039d316-1c4b-4281-b951-d872f2087c98
* Make automation proxy objects to ref_counted. That allows to process async ↵stoyan@chromium.org2009-05-281-2/+2
| | | | | | | | | | | notifications directly in channel background thread. Add support for listener-less ChannelProxy. BUG=none TEST=none Review URL: http://codereview.chromium.org/113722 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17093 0039d316-1c4b-4281-b951-d872f2087c98
* Replace chrome_process_filter with chrome_process_util.estade@chromium.org2009-04-091-0/+12
| | | | | | | | | | | | | | - move code only used by tests to chrome/test - make a better, more portable abstraction For now, it still only works on Windows. But this is the first step to porting this part of code. Patch by phajdan.jr@chromium.org: <http://codereview.chromium.org/54003> Review URL: http://codereview.chromium.org/67004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13476 0039d316-1c4b-4281-b951-d872f2087c98
* Switching things to FilePath:phajdan.jr@chromium.org2009-04-071-10/+9
| | | | | | | | | | | | | | | | Remove following deprecated wstring-using functions: net/net_util: FilePathToFileURL net/net_util: FileURLToFilePath Switch net/base/upload_data to FilePath. Switch upload-related parts of net/url_request/url_request to FilePath. Made necessary adjustments in rest of code (a lot). Review URL: http://codereview.chromium.org/63011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13242 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the checked-in scons configuration files.sgk@google.com2009-04-011-172/+0
| | | | | | Review URL: http://codereview.chromium.org/53121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12982 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup in automation. Remove WaitForTabCountToChange.phajdan.jr@chromium.org2009-03-301-5/+4
| | | | | | | | | | WaitForTabCountToBecome is easier to use and more reliable. Also removed Windows2000-specific code from accessibility unit tests. Review URL: http://codereview.chromium.org/45070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12774 0039d316-1c4b-4281-b951-d872f2087c98
* Make startup_tests print results on Linux.phajdan.jr@chromium.org2009-03-181-3/+3
| | | | | | | | Switch from wstring to string where needed. Review URL: http://codereview.chromium.org/42303 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11963 0039d316-1c4b-4281-b951-d872f2087c98
* Removed unneeded includes of base/time.h.thestig@chromium.org2009-03-161-1/+0
| | | | | | Review URL: http://codereview.chromium.org/48019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11766 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGEdeanm@chromium.org2009-03-101-1/+0
| | | | | | | | | Normalize end of file newlines in chrome/. All files end in a single newline. Review URL: http://codereview.chromium.org/42015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
* Generate all chrome .vcproj files:sgk@google.com2009-01-171-24/+100
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Path name translation (/ to \) of various MSVSTool attributes. * Explicit keyword= arguments to MSVSProject. This will likely go away eventually in favor of uniform behavior. * Add a relative_path_substitutions array that can be used to substitute in Visual Studio variable like $(OutDir). * Add a local_directory_prefix that can be set to './' to only affect files in the current directory. * Additional Keyword ordering in Tool attributes to continue to match the default order Visual Studio generates. * Add a Derived() proxy class that can wrap a File node to tell the .vcproj generation that we want the derived file, not its source(s), in the file list. * In the individual *.scons files, add the necessary files (mostly .h files) to file lists, and update MSVSProject() calls with the additional necessary information. Result is identical .vcproj files modulo the following differences: * Four locales .vcproj files (da, en-US, he and zh-TW) with source file orders that don't match the other locale .vcproj files have re-ordered file lists to match the rest. * Cosmetic XML changes (white space, ending tags) in: chrome/app/chrome_dll.vcproj chrome/app/generated_resources.vcproj net/build/net_resources.vcproj * Removal or addition of ./ prefixes from various files that don't match the other file specifications within their individual .vcproj files: chrome/installer/util/util.vcproj net/build/net.vcproj net/build/net_unittests.vcproj * Add missing empty sections (<ToolFiles>, <References>, <Globals>) for consistency with other .vcproj files: chrome/tools/test/image_diff/image_diff.vcproj third_party/libpng/libpng.vcproj third_party/zlib/zlib.vcproj * Add missing RootNameSpace attribute: chrome/test/automation/automation.vcproj testing/gtest.vcproj * Use && instead of \r\n as a command separator, to sidestep XML-generation problems: chrome/app/chrome_exe.vcproj * Remove unnecessary (?) duplicate files in the file list: chrome/browser/views/browser_views.vcproj (event_utils.cc and event_utils.h were duplicated) Review URL: http://codereview.chromium.org/17603 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8253 0039d316-1c4b-4281-b951-d872f2087c98
* Initial generation of native Visual Studio solution filessgk@google.com2008-12-191-1/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (project files still to come). To wit: * Solution file configuration is in *_sln.scons files (base\base_sln.scons, chrome\chrome_sln.scons). * Individual Project file configuration is in the the .scons file for the relevant target (base\base_unittests.scons, third_party\libxml\libxml.scons, etc.)--that is, where their file lists will live. * MSVSProject() calls are currently placeholders that establish the existence of Project Nodes (and Project dependencies) but don't yet have actual Project configuration information (file lists, .vsprops, etc.). * Configuraiton is very manual. In particular, the entries in the .sln file will be written out in exactly the order specified in the configuration(s). The current ordering is taken from our existing .sln files, so we can generate virtually the same configurations on output. * Generated solution files are nearly byte-for-byte identical with our existing .sln files, modulo: * net\dump_cache has a WebsiteProperties sections (making that configurable per project isn't important right now); * sandbox\sandbox.sln was missing a dependency of base.vcproj on on debug_message.vcproj (present in other .sln files) * webkit\webkit.sln was missing dependencies of WebCore.vcproj on libxml_config.vcproj and libxslt_config.vcproj (present in chrome.sln); * add a handful of other miscellaneous missing dependencies on various .vcproj definitions in chrome.sln (present in other .sln files). * remove stats_viewer.csproj from chrome.sln (sorry, mbelshe), which was complicating the solution configuration with unnecessary (for us) "Mixed Platform" types; * All MSVSFolder(), MSVSProject() and MSVSSolution() calls have hard-wired guid= values taken from our existing configuration, so we can: 1) verify generation of working configs; 2) minimize diffs when checking in generated .sln files. We can remove these in the future in favor of extracting them from existing .sln files if we wish. * Add ChromeMSVSFolder(), ChromeMSVSProject() and ChromeMSVSSolution() wrappers to chromium_builders.py, that gate the underlying call to the env.MSVS*() builders based on whether env.Bit('msvs') is set (i.e., we're in --mode=msvs). * Remove platform-specific gating of to-be-ported .scons files that we now need to load on any platform to generate coheren MSVS files. Move the env.Bit('windows') tests for actually building their executables into the individual .scons files. Review URL: http://codereview.chromium.org/14472 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7297 0039d316-1c4b-4281-b951-d872f2087c98
* Convert from using env['PLATFORM'] directly to using the more flexiblesgk@google.com2008-12-181-1/+1
| | | | | | | | | | | | | | | | | | and better-thought-out Hammer env.Bits() idioms: * env['PLATFORM'] == 'win32' => env.Bit('windows') * env['PLATFORM'] == 'posix' => env.Bit('linux') * env['PLATFORM'] == 'darwin' => env.Bit('mac') New idioms: * env.Bit('posix') => really does mean "any POSIX platform" * env.AnyBits('mac', 'linux') => specifically mac or linux, excluding other POSIX platforms Where we were using compound conditionals (e.g., "env['PLATFORM'] in ('posix', 'darwin')") I tried to take my best shot at translating the intent (i.e., "env.Bits('posix')" for something POSIX, "not env.Bits('mac')" for something not yet ported to Mac, etc.) Review URL: http://codereview.chromium.org/15051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7270 0039d316-1c4b-4281-b951-d872f2087c98
* Switch back svn:eol-style=native for .sln, .vcproj and .vsprops files.maruel@chromium.org2008-12-161-194/+194
| | | | | | | Patch fails otherwise on non-Windows platforms. Review URL: http://codereview.chromium.org/14478 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7093 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of kPathSeparator on windows. Port some wstring function to take ↵estade@chromium.org2008-12-041-2/+2
| | | | | | | | FilePaths. Re-enable relevant posix unit tests. Review URL: http://codereview.chromium.org/12893 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6387 0039d316-1c4b-4281-b951-d872f2087c98
* Changed svn:eol-style of all .sln and .vcproj files to CRLFscherkus@chromium.org2008-12-041-194/+194
| | | | | | Review URL: http://codereview.chromium.org/13133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6372 0039d316-1c4b-4281-b951-d872f2087c98
* Un-duplicate EvictFileFromSystemCache.deanm@chromium.org2008-11-252-5/+0
| | | | | | | | | Change required for http://codereview.chromium.org/9639 . Review URL: http://codereview.chromium.org/12407 Patch from Pawel Hajdan Jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6006 0039d316-1c4b-4281-b951-d872f2087c98
* Next round of SCons changes:sgk@google.com2008-11-142-79/+74
| | | | | | | | | | | | | | | | | | | * Add 'gdm_fp' to the $LIBS setting in base\using_base.scons (to be removed when that library moves into base\third_party). * Have the grit Scanner search the Repository() copy of the source file (necessary now that $TARGET_ROOT has changed). * Change all the SConscript files underneath chrome\test and chrome\tools to *.scons files, including updating their contents with the current patterns. * Add dependencies of the local_settings_*.res files on the corresponding google_chrome_string_*.rc files, so they get generated properly. * Add generation of the chrome_exe.res resource file. * Comment out some unnecessary .lib settings in the base construction environment. Review URL: http://codereview.chromium.org/10745 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5480 0039d316-1c4b-4281-b951-d872f2087c98
* Using $CHROME_SRC_DIR in place of hash/..bradnelson@google.com2008-10-221-1/+1
| | | | | | | | This will facilitate changing where the main sconstruct lives. Review URL: http://codereview.chromium.org/7847 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3725 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 07:02:41 +0000