summaryrefslogtreecommitdiffstats
path: root/chrome/test/test_browser_window.h
Commit message (Collapse)AuthorAgeFilesLines
* Refactored the screenshot mechanism.rkc@chromium.org2011-01-101-1/+7
| | | | | | | | | | | | Added a new method to browser window to get a screenshot in a platform independent way. Changed user feedback UI code to use the new method. BUG=65119 TEST=Tested with sending feedback with the new code. Screenshots are being taken and sent correctly. Review URL: http://codereview.chromium.org/6145001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70951 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent extensions from moving tabs that are being dragged. This fixes a ↵jstritar@chromium.org2010-12-221-0/+1
| | | | | | | | | | | crash on Windows and Linux related to extensions moving or removing tabs that are being dragged. This also prevents extensions from removing a window that the user is dragging tabs within. BUG=53799 TEST=See bug report. Review URL: http://codereview.chromium.org/4856004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69952 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in instant that resulted in flickery fade. The problem wouldsky@chromium.org2010-12-151-1/+1
| | | | | | | | | | | | | | | | | | | happen if instant wouldn't load the current url and you continued typing. For example, if the search engine doesn't support the instant API on each key press you would see the page fade out, then snap in. The fix is to make sure instant stays active until destroyed. That way if the preview is no longer valid, but instant is still active the page can remain faded out. This also adds a couple more tests for better coverage. BUG=66720 66539 TEST=see bug Review URL: http://codereview.chromium.org/5701008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69201 0039d316-1c4b-4281-b951-d872f2087c98
* Enable to show the keyboard overlay by shortcut key.mazda@chromium.org2010-12-021-0/+3
| | | | | | | | | BUG=chromium-os:6268 TEST=manually on the netbook Review URL: http://codereview.chromium.org/5440001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67962 0039d316-1c4b-4281-b951-d872f2087c98
* Add "create Application Shortcut" to the app menu on NTP.skerner@google.com2010-11-301-1/+3
| | | | | | | | | BUG=52451 TEST=Manually create app shortcuts for urls and apps. Review URL: http://codereview.chromium.org/5273004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67664 0039d316-1c4b-4281-b951-d872f2087c98
* Make pink's TabContentsWrapper change compile on Windows.ben@chromium.org2010-11-181-1/+1
| | | | | | | | | | Code by pinkerton@, with modifications by evanm and myself to get it to build on windows/linux/chromeos. BUG=none TEST=none Review URL: http://codereview.chromium.org/4694008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66626 0039d316-1c4b-4281-b951-d872f2087c98
* Handle resize corner layout entirely in the BrowserView (views) or ↵alekseys@chromium.org2010-11-161-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | BrowserWindow* (Mac) and extend RenderViewHost with a concept of reserved contents rect, a place to show extra stuff, such as Sidebar's mini tab UI. sidebar UI implementation warranted this change (mini tabs UI and resize corner area for sidebar contents). TabContentsDelegate::GetRootWindowResizerRect() is no more, reserved contents area is now cached in RenderWidgetHostView and updated upon view resize. Views: BrowserView is responsible for the actual layout and reserved contents area update. Mac: TabContentsController now manages all TabContents views in the main browser window to solve two problems, first to prevent contents flickering during tab change not only for the page, but for the sidebar and devtools contents too and, second, to monitor contents view frame changes and update reserved contents area accordingly. BUG=51084 TEST=All tests should pass, this is a refactoring CL. Review URL: http://codereview.chromium.org/3547008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66332 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Include browser.h -> ui/browser.h [Part 2].jhawkins@chromium.org2010-11-161-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5046002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66229 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the current page dim out when transitioning to instant preview.sky@chromium.org2010-11-151-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4932001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66164 0039d316-1c4b-4281-b951-d872f2087c98
* Renames and moves match preview classes to instant. This doesn'tsky@chromium.org2010-10-051-3/+3
| | | | | | | | | | | | contain any changes other than renaming/moving, as such I'm TBRing. BUG=54833 TEST=none TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/3602015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61553 0039d316-1c4b-4281-b951-d872f2087c98
* Changes instant around to support multiple loaders. This issky@chromium.org2010-10-041-1/+1
| | | | | | | | | | | | | | | | | | | | | necessitated by needing to hold off on showing instant results until I know if the server really supports instant. This change is mostly refactoring to enable this. Most of what was MatchPreview has been moved into MatchPreviewLoader. LoaderManager is used to determine which MatchPreviewLoader to use as well as keeping around a cache of them. MatchPreview for the most part delegates to LoaderManager and MatchPreviewLoader now. I'll rename all these classes to instant (and move into its own directory) next. BUG=54833 TEST=none Review URL: http://codereview.chromium.org/3541008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61441 0039d316-1c4b-4281-b951-d872f2087c98
* Makes match preview send the dimensions of the omnibox to the page.sky@chromium.org2010-09-221-0/+1
| | | | | | | | | BUG=54833 TEST=none Review URL: http://codereview.chromium.org/3417011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60153 0039d316-1c4b-4281-b951-d872f2087c98
* Bunch of match preview tweaks:sky@chromium.org2010-09-141-5/+7
| | | | | | | | | | | | | | | | . Makes MatchPreview owned by Browser rather than each TabContents. . Makes MatchPreview dismiss when the omnibox closes. . Supports the ability to send script to the page rather than reloading on every keystroke. . Supports receiving results from the page that drives the suggest text in the omnbox. BUG=54833 TEST=none Review URL: http://codereview.chromium.org/3332022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59428 0039d316-1c4b-4281-b951-d872f2087c98
* remove toolstripserikkay@chromium.org2010-08-121-2/+0
| | | | | | | | | | | BUG=51703 BUG=30178 BUG=25106 TEST=none Review URL: http://codereview.chromium.org/3129003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55921 0039d316-1c4b-4281-b951-d872f2087c98
* Making window.focus() work in Chrome.jcivelli@chromium.org2010-08-111-0/+1
| | | | | | | | | | | | | | | | A patch on the WebKit side https://bugs.webkit.org/show_bug.cgi?id=43542 ensures we get the correct notification when window.focus()/blur() is called. This CL makes the browser active/unactive in response to the focus/blur message. BUG=29643 TEST=Visit gmail. Open an IM conversation window and pop-it out. Focus the browser (so the IM window is in the back). Click on the person name in the IM section of gmail. The conversation window should be brought back to the front. Repeat but this time minimize the conversation window. Review URL: http://codereview.chromium.org/3060045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55678 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Add tabpose windowthakis@chromium.org2010-07-301-0/+1
| | | | | | | | | | | | | | | | | | | | The window doesn't have any contents yet, which makes its appearance look a bit janky for now. BUG=50307 TEST= * All the following happens only if --enable-expose-for-tabs is passed in, else all of it should be disabled. * In a browser window, hit cmd-f10 or three-finger-swipe down. A grey overlay with a gradient at the top should appear. * The overlay should cover tab contents, eventual info bars, the bookmarks bar if it's detached (but not the bookmarks bar if it's not detached), and eventual attached inspector windows. It should not cover the download shelf if it's open. * The window should block clicks on the tab strip and the download shelf for now. * The overlay should close on three-finger-swipe up, click, esc, enter, and space. * Every open browser window should have its own overlay, and they should be independent of each other. * If a browser window with an overlay window is active, most menu items should be greyed out, and all browser-related keyboard shortcuts should be disabled. * In particular, hitting cmd-f10 twice should open only one overlay per browser window * The overlay should have the correct size with a UI scale factor > 1 Review URL: http://codereview.chromium.org/2819070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54349 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Attemp 2 at:sky@chromium.org2010-07-211-1/+0
| | | | | | | | | | | | | | | | Makes the toolbar visible for apps again. Here's the set of patches I reverted: 49016, 47119, 47177, 46930, 46775, and the UI changes for 45566) If you see anything missing, please let me know. Also, there are some grd strings no longer necessary. I'll nuke those separately. BUG=49013 TEST=none TBR=finnur Review URL: http://codereview.chromium.org/3056003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53204 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 53062 - Makes the toolbar visible for apps again. Here's the set of ↵pinkerton@chromium.org2010-07-201-0/+1
| | | | | | | | | | | | | | | | | | patches I reverted: 49016, 47119, 47177, 46930, 46775, and the UI changes for 45566. If you see anything missing, please let me know. Also, there are some grd strings no longer necessary. I'll nuke those separately. BUG=49013 TEST=none Review URL: http://codereview.chromium.org/2888020 TBR=sky@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53073 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the toolbar visible for apps again. Here's the set of patches Isky@chromium.org2010-07-201-1/+0
| | | | | | | | | | | | | | reverted: 49016, 47119, 47177, 46930, 46775, and the UI changes for 45566. If you see anything missing, please let me know. Also, there are some grd strings no longer necessary. I'll nuke those separately. BUG=49013 TEST=none Review URL: http://codereview.chromium.org/2888020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53062 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the page and app menus.pkasting@chromium.org2010-07-201-2/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3033007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52985 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r52486. Display a tab modal dialog of the allowed/blocked cookies.jochen@chromium.org2010-07-161-0/+1
| | | | | | | | | BUG=45230 TEST=CollectedCookiesTest.* Review URL: http://codereview.chromium.org/3034007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52655 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 52486 - Display a tab modal dialog of the allowed/blocked cookies.dmaclach@chromium.org2010-07-151-1/+0
| | | | | | | | | | | | BUG=45230 TEST=CollectedCookiesTest.* Review URL: http://codereview.chromium.org/2907003 TBR=jochen@chromium.org Review URL: http://codereview.chromium.org/3016003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52505 0039d316-1c4b-4281-b951-d872f2087c98
* Display a tab modal dialog of the allowed/blocked cookies.jochen@chromium.org2010-07-151-0/+1
| | | | | | | | | BUG=45230 TEST=CollectedCookiesTest.* Review URL: http://codereview.chromium.org/2907003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52486 0039d316-1c4b-4281-b951-d872f2087c98
* Improve toolbar keyboard accessibility.dmazzoni@chromium.org2010-06-181-0/+3
| | | | | | | | | | | | Design doc: https://docs.google.com/a/google.com/Doc?docid=0ATICCjR-gNReY2djdjkyNnNfNzl4ZnpiODQ2Mg&hl=en BUG=40745 BUG=36728 BUG=36222 TEST=New test added to focus_manager_unittest.cc Review URL: http://codereview.chromium.org/2737010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50234 0039d316-1c4b-4281-b951-d872f2087c98
* Detach reload from omnibox, combine with stop, and eliminate go.pkasting@chromium.org2010-06-111-1/+1
| | | | | | | | | | This does the basic surgery on all three OSes without trying to fix up the visual appearance. As a result, things look pretty ugly. My intent is to at least put endcaps on the omnibox in a subsequent patch. BUG=45745,45762,45763 TEST=Reload and stop should be combined; go should be gone. Review URL: http://codereview.chromium.org/2677003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49492 0039d316-1c4b-4281-b951-d872f2087c98
* Rip out the multiprofile implementation.erg@chromium.org2010-06-101-2/+0
| | | | | | | | | | | Requested by Ben. Never worked on linux or OSX and apparently broken on Windows. Removal of the multiprofile code will make switching out the old AppMenuModel with the new WrenchMenuModel trivial. BUG=27177 TEST=none Review URL: http://codereview.chromium.org/2736001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49440 0039d316-1c4b-4281-b951-d872f2087c98
* Implement upgrade notifications.finnur@chromium.org2010-05-261-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we detect that the installed version is newer than the version you are running we show a little throbbing orange dot over the wrench menu. If you open the wrench menu and close it again, the throbbing will stop. However, if you look at the contents of the wrench menu you'll notice that the About box menu item has been removed and in its place is a menu item "Update Chrome Now" with a bright orange icon to draw your attention to it. Clicking on the icon shows a dialog box asking whether you want to restart Chrome. If you do, the browser restarts with your session restored (even if you have Session Restore turned off). Known issues: - Currently this is Windows only. We'll have to port this to Linux and do something differnet for Mac (which doesn't have the wrench menu). - Showing an icon in front of Update Chrome causes the checkbox for the bookmark bar menu to go away. Given that we will soon redesign the menus I'm not going to spend much time trying to fix it. BUG=27941 TEST=Wait for Chrome to be upgraded in the background, an orange dot should appear over the wrench menu and if you select Update Chrome your session should be retained. Review URL: http://codereview.chromium.org/2225003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48318 0039d316-1c4b-4281-b951-d872f2087c98
* Provide accessibility support for Window_win.ctguil@chromium.org2010-05-171-1/+1
| | | | | | | | TEST=Ensure that the About Chrome dialog has proper accessibility role. BUG=none Review URL: http://codereview.chromium.org/1838002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47454 0039d316-1c4b-4281-b951-d872f2087c98
* Collapse toolbars in app tabs.aa@chromium.org2010-05-081-0/+1
| | | | | | Review URL: http://codereview.chromium.org/2016002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46775 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: focus devtools on breakpoint while docked (Linux & Mac fix).pfeldman@chromium.org2010-05-031-1/+0
| | | | | | Review URL: http://codereview.chromium.org/1846001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46212 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at relanding your patch. I believe the problem was the removal of ↵sky@chromium.org2010-04-301-0/+1
| | | | | | | | | | | | the observer in ~TabStrip. By the time TabStrip's destructor was run the model's destructor had already run. I've changed BrowserView to explicitly delete the TabStrip before the browser. See the change between v1 and v2 of this patch in BrowserView for the relevant part. BUG=none TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/1817001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46071 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 45906 - Relands your patch to have an option for enabling vertical ↵sky@chromium.org2010-04-291-1/+0
| | | | | | | | | | | | | | | | | | tabs. I've added the following additions: . made the layout work for opaque_browser_frame. . Only show the menu if the user supplied enableverticaltabs. BUG=none TEST=none Review URL: http://codereview.chromium.org/1708014 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/1795010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45915 0039d316-1c4b-4281-b951-d872f2087c98
* Relands your patch to have an option for enabling vertical tabs. I'vesky@chromium.org2010-04-291-0/+1
| | | | | | | | | | | | | added the following additions: . made the layout work for opaque_browser_frame. . Only show the menu if the user supplied --enable-vertical-tabs. BUG=none TEST=none Review URL: http://codereview.chromium.org/1708014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45906 0039d316-1c4b-4281-b951-d872f2087c98
* Don't select all when autofocusing the location bar on New Tab creation. ↵pkasting@chromium.org2010-04-231-1/+1
| | | | | | | | | | Users could already be typing in the omnibox before the load commits (e.g. due to a slow renderer process startup) and this typing would then be selected and overwritten. BUG=41466 TEST=On a very slow machine, typing before a new tab finishes loading should not be selected or cleared once the tab finishes loading. Review URL: http://codereview.chromium.org/1738004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45406 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 45065 - Relanding this. Originally landed as ↵ben@chromium.org2010-04-201-1/+0
| | | | | | | | | | | | | | | | http://codereview.chromium.org/1001003 but reverted due to reliability crashes. Relanding so I can see what those crashes are. Please do not revert without informing me. BUG=none TEST=none Review URL: http://codereview.chromium.org/1655010 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/1715001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45077 0039d316-1c4b-4281-b951-d872f2087c98
* Re-landing this. Originally landed as http://codereview.chromium.org/1001003 ↵ben@chromium.org2010-04-201-0/+1
| | | | | | | | | | | | | but reverted due to reliability crashes. Re-landing so I can see what those crashes are. Please do not revert without informing me. BUG=none TEST=none Review URL: http://codereview.chromium.org/1655010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45065 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-311-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43216 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting this CL to fix the interactive ui test failures.ananta@chromium.org2010-03-261-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert 42498 - Keyboard accessibility for the page and app menus. Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/1428001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42779 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-241-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42498 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix browser side handling of moveTo by resizing the content area; ↵erg@chromium.org2010-03-241-1/+1
| | | | | | | | | | | | | | | | | not the window." This reverts commit 2ce3ea80b627f58acb97802b0cc182b3a2bdf809 (r40386). This seems to tickle some weird race condition where the renderer and the browser process disagree about the size of the window. I'm reverting this change as 38685 is scarier then 27365. TEST=none BUG=38785,27365 Review URL: http://codereview.chromium.org/1259004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42494 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42465 - Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-241-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reverting because newly added Test*MenuKeyboardAccess tests fail on some of the Windows buildbots, and possibly a XP Perf regression. Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/1257003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42468 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-241-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42465 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Keyboard accessibility for the page and app menus.", rev 42234 and ↵maruel@chromium.org2010-03-221-1/+0
| | | | | | | | | | 42236. TBR=dmazzoni Review URL: http://codereview.chromium.org/1158004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42239 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-221-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42234 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Keyboard accessibility for the page and app menus."maruel@chromium.org2010-03-221-1/+0
| | | | | | | | | | This reverts commit 42217. TBR=dmzazzoni Review URL: http://codereview.chromium.org/1154003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42218 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-221-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42217 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r42156, r42157, r42160. Allow dynamic switching in and out of ↵thestig@chromium.org2010-03-201-1/+0
| | | | | | | | | | | | sidetabs mode. Reliability bot and Linux CrOS browser_tests all had crashes in ~TabStrip. BUG=none TEST=none Review URL: http://codereview.chromium.org/1141005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42176 0039d316-1c4b-4281-b951-d872f2087c98
* Allow dynamic switching in and out of sidetabs mode.ben@chromium.org2010-03-191-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1001003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42156 0039d316-1c4b-4281-b951-d872f2087c98
* Add some bookmark bar hooks for pyauto.jrg@chromium.org2010-03-051-0/+1
| | | | | | | | | | | Refactor the implementation for x-platform happiness. Add simple pyauto script that uses it (but needs http://crbug.com32292 fixed before it works without tweaking). Review URL: http://codereview.chromium.org/670001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40782 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 08:47:04 +0000