| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Otherwise the whole string (with spaces) is passed to Chrome, and it doesn't work.
BUG=none
TEST=ui tests should work
Review URL: http://codereview.chromium.org/276073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I tried fixing all the Windows code but there's a *ton* of it.
This change will at least prevent people from adding new code that
uses the deprecated version (as that won't compile on Lin/Mac).
BUG=24672
Review URL: http://codereview.chromium.org/293013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
table are current.
By default, the NTP only uses data from the last 90 days, but the
generated profile was created back in late 2008. Manually migrate
the dates before launching chrome.
This will probably impact the NTP perf tests, but it should give
us a more realistic baseline.
BUG=24369
TBR=brettw
(Take 3 at landing this patch, this time with the proper fix for
non-existent History files).
Review URL: http://codereview.chromium.org/264053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
segment_usage"""
startup_tests are failing.
This reverts commit r28870.
TBR=finnur
Review URL: http://codereview.chromium.org/274026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
segment_usage""
This re-lands commit r28844 with a fix to make sure the History database
exists before trying to update the dates.
TBR=brettw
Review URL: http://codereview.chromium.org/266066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
A check is failing during page cycler tests so the test is going red.
This reverts commit r28844.
TBR=chase
Review URL: http://codereview.chromium.org/264049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Javascript can communicate with it. The required html, javascript and nexe files are checked in into the NaCl tree.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28796
Review URL: http://codereview.chromium.org/272005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
table are current.
By default, the NTP only uses data from the last 90 days, but the
generated profile was created back in late 2008. Manually migrate
the dates before launching chrome.
This will probably impact the NTP perf tests, but it should give
us a more realistic baseline.
BUG=24369
Review URL: http://codereview.chromium.org/267056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Excluding chrome/browser/...)
Landing patch for Jacob Mandelson. Original review: http://codereview.chromium.org/195067
BUG=none
TEST=base_unittests & app_unittests
Review URL: http://codereview.chromium.org/267076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and verifies that Javascript can communicate with it. The required html, javascript and nexe files are checked in into the NaCl tree.
Review URL: http://codereview.chromium.org/272005
TBR=gregoryd@google.com
Review URL: http://codereview.chromium.org/270080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Javascript can communicate with it. The required html, javascript and nexe files are checked in into the NaCl tree.
Review URL: http://codereview.chromium.org/272005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/270062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
of wstrings. Also convert template_user_data_ in UITest to be
a FilePath.
Review URL: http://codereview.chromium.org/273021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
depended on this, so to make the DEPS work out, I made a new base/test
directory where I moved the testing-related files into a new directory
base/test.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/266038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and onload.""
This reverts commit r28209 and relands r28199.
The failure seems to have been flaky (it passed on the other bots and on the following run). I want to
try to land again. If it fails again, I'll disable the test.
TBR=mattm
Review URL: http://codereview.chromium.org/268003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
can shut down gracefully when many posix-based system halt or reboot while Chrome is open.
SIGTERM may come in on any thread, so the handler creates a Task object that wraps up a call to BrowserList::CloseAllBrowsers(true) and Posts it to the message loop of the UI thread. Thus, we both get out of the signal handler quickly and can deal with the signal on any thread.
BUG=23551
TEST=covered by BrowserTest.PosixSessionEnd
Review URL: http://codereview.chromium.org/255036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
which failed on XP Perf (single).
This reverts commit r28199.
TBR=tony
Review URL: http://codereview.chromium.org/265002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TabContents sends a notification which is picked up by the browser
automation controller which keeps a map of events and times. Add
an automation IPC so that tests can get these values from the
browser automation controller. Finally, add a feature startup test
to collect these values.
This is just to get some consistent timings from the buildbot.
BUG=23120
Review URL: http://codereview.chromium.org/246105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WorkerHttpLayoutTests.
The crash is caused by lighttpd server starting on the foreground mode and it messed up with the command window host.
To work around this, we start the http server on the background mode if running UI test under Windows 7.
BUG=23303
TEST=none
Review URL: http://codereview.chromium.org/257047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Update GetDownloadDirectory to take FilePath instead of wstring to avoid conversions "To and From wstring".
BUG=None
TEST=run ui_tests.exe
Review URL: http://codereview.chromium.org/243047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/212048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
If that doesn't fix it, then maybe the crash_service.exe isn't running?
TEST=none
BUG=22569
Review URL: http://codereview.chromium.org/215048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The main way is making the sleep timout shorter.
BUG=22063
TEST=BrowserEncodingTest.TestEncodingAutoDetect.
Review URL: http://codereview.chromium.org/209030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, build the reliability_tests target on Linux.
Neither of the new targets have trybots or buildbots yet, however, they do work for me locally.
BUG=19085
Review URL: http://codereview.chromium.org/209022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- disable unreliable RestoreTab action
- make more command sync, waiting for their completion
TEST=none
BUG=21547, 21636
Review URL: http://codereview.chromium.org/196096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert "Fix Mac by disabling some UI tests on it."
Too many failures.
TBR=huanr
Review URL: http://codereview.chromium.org/193118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- disable unreliable RestoreTab action
- make more command sync, waiting for their completion
TEST=none
BUG=21547, 21636
Review URL: http://codereview.chromium.org/196096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm not sure what's happening, so I'm going to log that.
This should answer the question if the leftover processes are renderers,
or if it's the main browser process, etc.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/180046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- wait for the second browser process to finish
- only initialize user dir once
Will it kill flakiness? Who knows.
TEST=none
http://crbug.com/20546
Review URL: http://codereview.chromium.org/181016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r24792.
TBR=estade
Review URL: http://codereview.chromium.org/179028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most of these are classes with virtual methods lacking virtual destructors
or NULL used in non-pointer context.
BUG=none
TEST=app_unittests && base_unittests
--gtest_filter=-ConditionVariableTest.LargeFastTaskTest
patch by Jacob Mandelson <jlmjlm [at] gmail>
http://codereview.chromium.org/171028/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= none
TEST= none
Review URL: http://codereview.chromium.org/173444
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
details.This change list is based on http://codereview.chromium.org/18417 which was written by xlyuan@chromiumBug=5515 ( http://crbug.com/5515 )
Review URL: http://codereview.chromium.org/165393
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the build.
Review URL: http://codereview.chromium.org/174148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, do proper cleanup before browser shutdown in MetricsService UI test.
I hope this will reduce the flakiness.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/173023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and custom frame + gtk theme.
By default, we try to detect custom frame or not based on the
window manager. On the bots, we run the startup tests in Xvfb
with no window manager running, so they don't get the custom
frame.
Review URL: http://codereview.chromium.org/174032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Convert one ErrorPage UI test to use it.
The rest of the tests will require more work.
TEST=Covered by ui_tests.
http://crbug.com/19361, http://crbug.com/19395
Review URL: http://codereview.chromium.org/174015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Broke the page cyclers.
TBR=tony
Review URL: http://codereview.chromium.org/174065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Convert one ErrorPage UI test to use it.
The rest of the tests will require more work.
TEST=Covered by ui_tests.
http://crbug.com/19361, http://crbug.com/19395
Review URL: http://codereview.chromium.org/174015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/19376
Review URL: http://codereview.chromium.org/173010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/18767
TEST= none
Review URL: http://codereview.chromium.org/165478
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165463
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
file to ensure that the images are picked up for the complex theme tests.
BUG= http://crbug.com/18767
TEST= none
Review URL: http://codereview.chromium.org/164402
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/18767
TEST= none
Review URL: http://codereview.chromium.org/165168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
http://crbug.com/18085
Review URL: http://codereview.chromium.org/159658
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/159548
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update the UI to not say tips or recommendations.
BUG=None
TEST=Starting chrome should not show any tips byt default
Review URL: http://codereview.chromium.org/160138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG= none.
TEST= New NTP should come up with a default title in Tips and Suggestions box, then be loaded with actual data from popgadget.
Review URL: http://codereview.chromium.org/149255
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the proxy doesn't respond (e.g., due to a timeout).
BUG=none
TEST=Hopefully the Mac valgrind bots will more reliably run all their tests (although there are likely more issues like this lurking).
Review URL: http://codereview.chromium.org/149281
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=thakis
Review URL: http://codereview.chromium.org/146061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19085 0039d316-1c4b-4281-b951-d872f2087c98
|