summaryrefslogtreecommitdiffstats
path: root/chrome/test/ui_test_utils.h
Commit message (Collapse)AuthorAgeFilesLines
* Refactoring the sync integration tests.rsimha@chromium.org2010-06-211-0/+5
| | | | | | | | | | | | | The sync integration tests were written over a 2 year period, and were designed at a time when bookmarks were the only data-type being synced. Since then, they have mushroomed and resulted in significant duplication of code and non-uniformity in coding style. This changelist is the first step towards reorganizing the integration tests for all sync data types into a levelized class hierarchy, where there is a class containing all the data and functionality required to test each data-type. This should make adding tests for new data-types significantly easier. BUG=46052,43917 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/2863008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50376 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing flakyness of the browser test:jcivelli@chromium.org2010-04-191-4/+35
| | | | | | | | | | | | BrowserTest.PageLanguageDetection. BUG=40962 TEST=The test should not be flaky anymore. Review URL: http://codereview.chromium.org/1642002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44903 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 57501:57508 + fixing the path to the script that starts adumi@chromium.org2010-04-131-2/+1
| | | | | | | | | | | | | | websocket server. Submitting this as a 2-sided patch to make it easier to roll it back if something breaks. BUG=none TEST=none TBR=antonm Review URL: http://codereview.chromium.org/1521026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44336 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43950 - Revert 43931 [GTTF] Clean up browser tests:viettrungluu@chromium.org2010-04-081-4/+36
| | | | | | | | | | | | | | | | | | | | | | | | [original revert broke compile; will disable tests in another CL instead] use more ui_test_utils functions to simplify the code expose more consistent and powerful utilities in ui_test_utils minor style improvements move some tests from DISABLED to FLAKY so we don't lose coverage remove redundant timeouts check more return values TEST=browser_tests BUG=none Review URL: http://codereview.chromium.org/1571002 TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/1520026 TBR=viettrungluu@chromium.org, phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/1518020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43951 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43931 - [GTTF] Clean up browser tests:viettrungluu@chromium.org2010-04-081-36/+4
| | | | | | | | | | | | | | | | | | | use more ui_test_utils functions to simplify the code expose more consistent and powerful utilities in ui_test_utils minor style improvements move some tests from DISABLED to FLAKY so we don't lose coverage remove redundant timeouts check more return values TEST=browser_tests BUG=none Review URL: http://codereview.chromium.org/1571002 TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/1520026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43950 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Clean up browser tests:phajdan.jr@chromium.org2010-04-081-4/+36
| | | | | | | | | | | | | | | | - use more ui_test_utils functions to simplify the code - expose more consistent and powerful utilities in ui_test_utils - minor style improvements - move some tests from DISABLED to FLAKY so we don't lose coverage - remove redundant timeouts - check more return values TEST=browser_tests BUG=none Review URL: http://codereview.chromium.org/1571002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43931 0039d316-1c4b-4281-b951-d872f2087c98
* Merge UiTest::GetTest* and ui_test_utils::GetTest*. Convert these utility ↵thestig@chromium.org2010-03-311-1/+11
| | | | | | | | | | functions to use FilePaths. BUG=none TEST=none Review URL: http://codereview.chromium.org/1567009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43190 0039d316-1c4b-4281-b951-d872f2087c98
* * Add / exhanced tests for state transition.oshima@chromium.org2010-03-281-0/+6
| | | | | | | | | | | | | * Found and fixed the following bug in this test. (yay!) minimize if no sticky / new notification exists after Remove * Replaced RunAllPending with InProcessBrowserTest::RunAllPendingEvents BUG=http://crosbug/2027 TEST=two new browser tests and one updated browser test. Review URL: http://codereview.chromium.org/1357005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42921 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where triggering session restore while the browser wassky@chromium.org2010-03-261-0/+3
| | | | | | | | | | | | | | already running would end up creating an extra tab. BUG=11594 TEST=open chrome with a single tabbed browser, turn on session restore, navigate to a page with a popup, close the tabbed browser, create a new window ala control-n (or double click on the desktop), and make the restored window doesn't end upw Review URL: http://codereview.chromium.org/1371002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42766 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for interacting with the DOM in browser_tests.kkania@chromium.org2010-03-181-0/+5
| | | | | | | | | BUG=none TEST=none Reivew url: http://codereview.chromium.org/660046 Review URL: http://codereview.chromium.org/1051005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42026 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Remove the internal timeout of extension browser tests.phajdan.jr@chromium.org2010-03-171-3/+2
| | | | | | | | | | | | | | | Now we have a global timeout for browser tests enforced by out of process test launcher. Having too many different timeouts all over the place makes debugging issues harder. TEST=browser_tests BUG=none Review URL: http://codereview.chromium.org/1046001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41823 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 41789 - Add support for DOM interaction in browser tests via C++.kkania@chromium.org2010-03-171-5/+0
| | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/660046 TBR=kkania@chromium.org Review URL: http://codereview.chromium.org/971004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41807 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for DOM interaction in browser tests via C++.kkania@chromium.org2010-03-171-0/+5
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/660046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41789 0039d316-1c4b-4281-b951-d872f2087c98
* Fix websocket_server.py pathukai@chromium.org2010-03-161-1/+4
| | | | | | | | | BUG=none TEST=pass WebSocket browser_test. Review URL: http://codereview.chromium.org/952001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41666 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the feed sniffing testing part of the RSS extension.finnur@chromium.org2010-03-121-3/+0
| | | | | | | | | | | I suspect it is the cause of the flakiness. BUG=37109 TEST=Watch the bots to see if it is still flaky. Review URL: http://codereview.chromium.org/870008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41478 0039d316-1c4b-4281-b951-d872f2087c98
* Icons are loaded asynchronously for browser actions, so thefinnur@chromium.org2010-03-101-1/+5
| | | | | | | | | | | | | | test must wait on the extension being updated if no icon is found. I think this should fix the flakiness in the test. BUG=None TEST=Fixing a browser test (hopefully). Review URL: http://codereview.chromium.org/772001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41144 0039d316-1c4b-4281-b951-d872f2087c98
* RSS feed subscription localization, part 2. finnur@chromium.org2010-03-021-0/+3
| | | | | | | | | | | | | | | Re-enabling the tests that were disabled in the first pass. Also changing how we substitute localization values (using direct method that avoids flashing __MSG__const while the page is loading). Also made some minor fixes after testing various locales. BUG=37109 TEST=This CL is about enabling automated tests. Review URL: http://codereview.chromium.org/660328 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40354 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SSLUITest.TestHTTPSErrorWithNoNavEntryagl@chromium.org2010-03-011-0/+101
| | | | | | | | | TEST=SSLUITest.TestHTTPSErrorWithNoNavEntry BUG=none http://codereview.chromium.org/660206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40285 0039d316-1c4b-4281-b951-d872f2087c98
* Add an WebSocket extension browsertest.rafaelw@chromium.org2010-02-251-0/+40
| | | | | | | | | | | This adds a simple browsertest that sanity checks that WebSockets can be opened and used from extension processes. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/660011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39961 0039d316-1c4b-4281-b951-d872f2087c98
* One more attempt at landing this CL.jcampan@chromium.org2010-01-211-0/+4
| | | | | | | | | | | | | | | | There are now memory errors in the CLD library that cause memory crashers in reliability tests. I will add reliability failures to the know_crashes.txt file while the memory errors are being fixed. Original review: http://codereview.chromium.org/492024/show BUG=30662 TEST=Run the unit-tests. TBR=brettw Review URL: http://codereview.chromium.org/555014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36707 0039d316-1c4b-4281-b951-d872f2087c98
* Add 3 tests for extension installation. Fix and re-enable UpdatePermissions ↵kkania@chromium.org2010-01-201-1/+6
| | | | | | | | | | test. BUG=none TEST=none Review URL: http://codereview.chromium.org/547017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36679 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 36589 - Still failing the reliability tests.jcampan@chromium.org2010-01-201-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | Another try at landing this. It caused several tests to fails previously. There was a crasher in some Windows code in the CLD that has been removed by the port of the CLD code to Linux and Mac. That should hopefully make everything work now. Enabling language detection on page load. A memory error has been fixed in the CLD library in the meantime. This should hopefully fixes the crashers in the reliability tests. Note that this version is actually simpler than the original review since the detection is now performed in the renderer. (So the CLD code runs sandboxed.) Original review: http://codereview.chromium.org/492024/show BUG=30662 TEST=Run the unittests. TBR=brettw Review URL: http://codereview.chromium.org/552049 TBR=jcampan@chromium.org Review URL: http://codereview.chromium.org/554015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36603 0039d316-1c4b-4281-b951-d872f2087c98
* Another try at landing this.jcampan@chromium.org2010-01-201-0/+4
| | | | | | | | | | | | | | | | | | | | | | It caused several tests to fails previously. There was a crasher in some Windows code in the CLD that has been removed by the port of the CLD code to Linux and Mac. That should hopefully make everything work now. Enabling language detection on page load. A memory error has been fixed in the CLD library in the meantime. This should hopefully fixes the crashers in the reliability tests. Note that this version is actually simpler than the original review since the detection is now performed in the renderer. (So the CLD code runs sandboxed.) Original review: http://codereview.chromium.org/492024/show BUG=30662 TEST=Run the unit-tests. TBR=brettw Review URL: http://codereview.chromium.org/552049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36589 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 36442 - Still causing test failuresjcampan@chromium.org2010-01-161-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | 4th attempt at landing this. It caused several tests to fails previously. Cannot repro any of the failure. I am suspecting a clobber would have probably fixed it. (there is a change in one of the IPC messages that probably messed up the build somehow). No code change. Enabling language detection on page load. A memory error has been fixed in the CLD library in the meantime. This should hopefully fixes the crashers in the reliability tests. Note that this version is actually simpler than the original review since the detection is now performed in the renderer. (So the CLD code runs sandboxed.) Original review: http://codereview.chromium.org/492024/show BUG=30662 TEST=Run the unittests. TBR=brettw Review URL: http://codereview.chromium.org/548057 TBR=jcampan@chromium.org Review URL: http://codereview.chromium.org/536085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36447 0039d316-1c4b-4281-b951-d872f2087c98
* 4th attempt at landing this.jcampan@chromium.org2010-01-161-0/+4
| | | | | | | | | | | | | | | | | | | | | It caused several tests to fails previously. Cannot repro any of the failure. I am suspecting a clobber would have probably fixed it. (there is a change in one of the IPC messages that probably messed up the build somehow). No code change. Enabling language detection on page load. A memory error has been fixed in the CLD library in the meantime. This should hopefully fixes the crashers in the reliability tests. Note that this version is actually simpler than the original review since the detection is now performed in the renderer. (So the CLD code runs sandboxed.) Original review: http://codereview.chromium.org/492024/show BUG=30662 TEST=Run the unit-tests. TBR=brettw Review URL: http://codereview.chromium.org/548057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36442 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 36362 - It breaks NACLTests and Chrome Frame Testsjcampan@chromium.org2010-01-151-4/+0
| | | | | | | | | | | | | | | | | | | | 3rd attempt at landing the language detection on page load. A memory error has been fixed in the CLD library in the meantime. This should hopefully fixes the crashers in the reliability tests. Note that this version is actually simpler than the original review since the detection is now performed in the renderer. (So the CLD code runs sandboxed.) Original review: http://codereview.chromium.org/492024/show BUG=30662 TEST=Run the unittests. Review URL: http://codereview.chromium.org/518075 TBR=jcampan@chromium.org Review URL: http://codereview.chromium.org/546062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36364 0039d316-1c4b-4281-b951-d872f2087c98
* 3rd attempt at landing the language detection on page load.jcampan@chromium.org2010-01-151-0/+4
| | | | | | | | | | | | | | | | A memory error has been fixed in the CLD library in the meantime. This should hopefully fixes the crashers in the reliability tests. Note that this version is actually simpler than the original review since the detection is now performed in the renderer. (So the CLD code runs sandboxed.) Original review: http://codereview.chromium.org/492024/show BUG=30662 TEST=Run the unit-tests. Review URL: http://codereview.chromium.org/518075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36362 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 35735 - Relanding the language detection code.jcampan@chromium.org2010-01-071-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | Still causes redness on the reliability bot. The code would crash if multiple PageContents notifications were received rapidly. The CLDHelper now notifies the TabContents directly and the TabContents ensures only one language detection can be performed at a time. Added unittests to validate these cases in web_contents_unittest.cc. Note that patch set 1 is the original patch, patch set 2 contains the new changes. Original review: http://codereview.chromium.org/492024/show BUG=30662 TEST=Run the unittests. Review URL: http://codereview.chromium.org/504051 TBR=jcampan@chromium.org Review URL: http://codereview.chromium.org/523149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35753 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the language detection code.jcampan@chromium.org2010-01-071-0/+4
| | | | | | | | | | | | | | | | | | | | The code would crash if multiple PageContents notifications were received rapidly. The CLDHelper now notifies the TabContents directly and the TabContents ensures only one language detection can be performed at a time. Added unit-tests to validate these cases in web_contents_unittest.cc. Note that patch set 1 is the original patch, patch set 2 contains the new changes. Original review: http://codereview.chromium.org/492024/show BUG=30662 TEST=Run the unit-tests. Review URL: http://codereview.chromium.org/504051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35735 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting the CLD CL altogether, the reliability bot is still red.jcampan@chromium.org2009-12-171-4/+0
| | | | | | | | | BUG=30681 TEST=None TBR=brettw Review URL: http://codereview.chromium.org/504048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34867 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the language detection happen with every page load jcampan@chromium.org2009-12-161-0/+4
| | | | | | | | | | | | | | | | | | | | as we do with the page indexing. (The language detection was previously done on demand when the extension related API was querying it.) Once detected the language is stored on the navigation entry. It'll be used for the upcoming translation feature. Also I moved the existing language detection from the UI to the file thread. The change required few changes for the chrome.tabs.detectLanguage extension API to still work. BUG=None TEST=Run the browser tests and unit-tests. Review URL: http://codereview.chromium.org/492024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34728 0039d316-1c4b-4281-b951-d872f2087c98
* Move use_host_network test out of ChromeFrame.stoyan@chromium.org2009-11-191-1/+6
| | | | | | | | Some refactoring of ExternalTabUITestMockClient. TEST=ui_tests Review URL: http://codereview.chromium.org/384058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32504 0039d316-1c4b-4281-b951-d872f2087c98
* GMocking Externaltab tests.stoyan@google.com2009-11-041-0/+29
| | | | | | | | | | | Yet I cannot delete AutomationProxyForExternalTab because it is used by extension_uitest.cc. Enable some tests meanwhile - now they should be stable enough. BUG=18797,24664 TEST=ui_tests ok Review URL: http://codereview.chromium.org/339009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31016 0039d316-1c4b-4281-b951-d872f2087c98
* Implements tests for testing browser's overall key events handling behavior.suzhe@chromium.org2009-10-231-0/+7
| | | | | | | | | | | | This CL implements some basic tests for testing browser's overall key events handling behavior. This CL depends on http://codereview.chromium.org/235039 and http://codereview.chromium.org/195062. Currently, only Linux and Windows are supported. The tests assume US keyboard layout is used and no IME is activated. We still need to investigate how to write tests that involving different keyboard layout and input methods. BUG=none TEST=none Review URL: http://codereview.chromium.org/268035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29866 0039d316-1c4b-4281-b951-d872f2087c98
* Add a browser test for extensions autoupdate.asargent@chromium.org2009-10-141-1/+9
| | | | | | | | | BUG=17826,19403 TEST=none Review URL: http://codereview.chromium.org/270019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28923 0039d316-1c4b-4281-b951-d872f2087c98
* The focus would only be restored properly the first time thejcampan@chromium.org2009-10-021-0/+9
| | | | | | | | | | | find-in-bar box was closed. Also wrote an interactive ui test and took the opportunity to convert the existing find-in-bar interactive ui test to be a browser test. BUG=23599 TEST=See bug. Review URL: http://codereview.chromium.org/251064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27875 0039d316-1c4b-4281-b951-d872f2087c98
* This CL makes the browser focus tests faster by replacingjcampan@chromium.org2009-09-181-0/+7
| | | | | | | | | | | | some time-outs with notifications. BUG=22065 TEST=Run the interactive tests, especially BrowserFocusTest*FocusTraversal* These tests should run in few seconds. Review URL: http://codereview.chromium.org/210013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26597 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds a test to insure we are not regressing on http://crbug.com/19941jcampan@chromium.org2009-09-151-0/+6
| | | | | | | | | | | We would crash when an SSL error would happen on a page with no navigation entry. TEST=Run the test. BUG=http://crbug.com/19941 Review URL: http://codereview.chromium.org/196115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26224 0039d316-1c4b-4281-b951-d872f2087c98
* Convert parts of errorpage_uitest.cc to be not flaky.phajdan.jr@chromium.org2009-08-151-4/+9
| | | | | | | | | TEST=Covered by browser_tests. http://crbug.com/19361, http://crbug.com/19395 Review URL: http://codereview.chromium.org/169002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23500 0039d316-1c4b-4281-b951-d872f2087c98
* The focus would be messed-up when reloading a crashed tab, also causing ↵jcampan@chromium.org2009-07-291-0/+3
| | | | | | | | | | | | accelerators to be broken. This CL also makes sure to keep the focus on the location bar when reloading the NTP. BUG=http://crbug.com/14954 TEST=See bug. Review URL: http://codereview.chromium.org/160206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21961 0039d316-1c4b-4281-b951-d872f2087c98
* Convert JavascriptAlertActivatesTab to browser_tests framework.phajdan.jr@chromium.org2009-07-101-0/+5
| | | | | | | | | | | | This should make it non-flaky, so I un-disabled the test. I also added necessary plumbing so we can wait for AppModalDialog to appear and close it. TEST=Covered by browser_tests. http://crbug.com/16062 Review URL: http://codereview.chromium.org/149460 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20400 0039d316-1c4b-4281-b951-d872f2087c98
* Convert crash recovery tests to browser test framework, which should reduce ↵phajdan.jr@chromium.org2009-07-081-0/+8
| | | | | | | | | | | flakiness. TEST=none http://crbug.com/16054 Review URL: http://codereview.chromium.org/149235 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20182 0039d316-1c4b-4281-b951-d872f2087c98
* Add an ExtensionBrowserTest base class that allows in-process browser tests ↵aa@chromium.org2009-07-041-5/+5
| | | | | | | | of extensions using ExtensionsService directly, rather than TestExtensionLoaded. Use it to re-enable some old browser tests that had been disabled. Review URL: http://codereview.chromium.org/150213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19930 0039d316-1c4b-4281-b951-d872f2087c98
* reenable RenderViewHostManager browertest, add DownloadsCompleteObserver to ↵rafaelw@chromium.org2009-07-021-0/+5
| | | | | | | | | | ui_test_utils. R=aa Review URL: http://codereview.chromium.org/151189 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19811 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash as a result of my previous change to fix the memory leak in ↵jam@chromium.org2009-05-221-0/+2
| | | | | | | | | | WebCacheManager. BUG=12362 TEST=added regression test Review URL: http://codereview.chromium.org/113754 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16775 0039d316-1c4b-4281-b951-d872f2087c98
* Migrating the SSL UI tests to be browser tests.jcampan@chromium.org2009-04-291-33/+28
| | | | | | | | | | | | | Reenabling all of them. Hopefully it'll help with flakiness. Note that I am keeping the SSL UI tests alive until the browser test framework has been ported to Mac and Linux. BUG=6584,2136 TEST=Run the browser tests. Review URL: http://codereview.chromium.org/101013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14901 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing <string> include for release build.finnur@chromium.org2009-04-171-0/+2
| | | | | | | | TBR=jcampan Review URL: http://codereview.chromium.org/67255 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13947 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 10573: Dismissing Find-in page doesn't set focusfinnur@chromium.org2009-04-171-1/+39
| | | | | | | | | | | | | | | | | | | | | | | | | to the link found. We no longer use the selection controller to highlight the active match. Before this change, the focus would not be set if the user had changed the selection. After this change, the focus will be set unless the user has selected something on the page. I also wrote an in-browser unit test for this to catch this regression in the future, but it is disabled due to problem with running multiple in-process browser tests in a row (teardown problem). BUG=10573 TEST=Covered by in process browser test now, see bug for repro steps. Review URL: http://codereview.chromium.org/79024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13945 0039d316-1c4b-4281-b951-d872f2087c98
* Scrape search definitions from forms that have onsubmit handlers. The ↵ben@chromium.org2009-04-101-0/+10
| | | | | | | | | | | | | | | | scraping is done after submit events are handled by the page DOM so doing this is safe. Adds test infrastructure for determining that scraping occurs on submit: - allow testserver to be configured to serve pages from / on the server - provide a ui test util that navigates and waits for N subsequent redirections/navigations before returning control to the test to handle automated submission Eric, please review the test server changes. Scott, please look over everything else. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13444 Review URL: http://codereview.chromium.org/62145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13491 0039d316-1c4b-4281-b951-d872f2087c98
* revert until I can figure out why the tests are hangingben@chromium.org2009-04-091-10/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13448 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 15:06:47 +0000