summaryrefslogtreecommitdiffstats
path: root/chrome/test/webdriver/commands/response.cc
Commit message (Collapse)AuthorAgeFilesLines
* Revert recent changes to base::Valuestevenjb@google.com2011-08-261-1/+1
| | | | | | | | | | | | | | | | | | Reverts: 98223: base: Add AsList() function to Value API. 98266: base: Add AsBinary() function to Value API. There are two issues with these commits: 1. libcros uses base::Value to pass data to Chrome. It includes values.h from libchrome which contains its own copy. This is a terrible design flaw in libcros and is being addressed (http://crosbug.com/19576), however we need some time to address this before we can make these changes without breaking Chrome on ChromeOS. 2. AsList() and AsBinary() should be const. The fact that they were not const caused re-factoring that changed const Value& input arguments to Value*, which is against the spec. When we re-introduce this, these members should be made const. BUG=chromium-os:19604 TEST=Check bots + ChromeOS autotests Review URL: http://codereview.chromium.org/7753020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98378 0039d316-1c4b-4281-b951-d872f2087c98
* base: Add AsList() function to Value API.tfarina@chromium.org2011-08-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | This function should simplify some constructions. Instead of: if (!value->IsType(Value::TYPE_LIST)) return false; ListValue* list_value = static_cast<ListValue*>(value); You can do: ListValue* list_value = value->AsList(); if (!list_value) return false; BUG=None TEST=base_unittests --gtest_filter=Values* R=evan@chromium.org,tony@chromium.org Review URL: http://codereview.chromium.org/7714004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98223 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 97557; Original review at: http://codereview.chromium.org/7648053kkania@chromium.org2011-08-221-1/+1
| | | | | | | | | | | | | | | [chromedriver] Add chrome.detach option for configuring Chrome not to quit when its automation client disconnects. chrome.detach is currently implemented by using a NamedProxyLauncher. We also add a new switch that accomplishes the same purpose. Also, modify pre-post command execution steps in two ways: 1) wait for loads post execution, in case pyauto issues a non-webdriver command which expects the load to be finished 2) only return a frame checking error if no alert is present BUG=87676, 93438 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97655 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 97557 - [chromedriver] Add chrome.detach option for configuring ↵nirnimesh@chromium.org2011-08-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Chrome not to quit when its automation client disconnects. chrome.detach is currently implemented by using a NamedProxyLauncher. We also add a new switch that accomplishes the same purpose. Also, modify pre-post command execution steps in two ways: 1) wait for loads post execution, in case pyauto issues a non-webdriver command which expects the load to be finished 2) only return a frame checking error if no alert is present Reverting because of chromedriver_tests failure on windows. http://build.chromium.org/p/chromium.pyauto/builders/Win%20XP/builds/9846/steps/chromedriver_tests/logs/stdio ERROR: chromedriver_tests.DetachProcessTest.testDetachProcess: "None" ---------------------------------------------------------------------- Traceback (most recent call last): File "E:\b\build\slave\Win_XP\build\src\chrome\test\webdriver\test\chromedriver_tests.py", line 357, in testDetachProcess os.kill(pid, 0) # Would throw if process no longer exists AttributeError: 'module' object has no attribute 'kill' Feel free to recommit after fix (no review necessary) BUG=87676,93438 TEST=none Review URL: http://codereview.chromium.org/7648053 TBR=kkania@chromium.org Review URL: http://codereview.chromium.org/7696022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97611 0039d316-1c4b-4281-b951-d872f2087c98
* [chromedriver] Add chrome.detach option for configuring Chrome not to quitkkania@chromium.org2011-08-201-1/+1
| | | | | | | | | | | | | | | | | when its automation client disconnects. chrome.detach is currently implemented by using a NamedProxyLauncher. We also add a new switch that accomplishes the same purpose. Also, modify pre-post command execution steps in two ways: 1) wait for loads post execution, in case pyauto issues a non-webdriver command which expects the load to be finished 2) only return a frame checking error if no alert is present BUG=87676,93438 TEST=none Review URL: http://codereview.chromium.org/7648053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97557 0039d316-1c4b-4281-b951-d872f2087c98
* Fix minor issues in chromedriver dealing with design mode, frame switching,kkania@chromium.org2011-07-191-1/+1
| | | | | | | | | | | and opacity. Also, clean up some of the error messages. BUG=88685,88686,88810,88957 TEST=none Review URL: http://codereview.chromium.org/7347010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92946 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor error handling in chromedriver. Introduce new error class ↵kkania@chromium.org2011-05-201-40/+6
| | | | | | | | | | | | containing a webdriver error code, possible error details, and a stack trace. Also some minor cleanup of the command files. BUG=none TEST=none Review URL: http://codereview.chromium.org/7042018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86081 0039d316-1c4b-4281-b951-d872f2087c98
* Send screenshots back to the client for debiggingjmikhail@google.com2011-03-291-0/+26
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5572001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79721 0039d316-1c4b-4281-b951-d872f2087c98
* Return the full cookie details in TestingAutomationProvider and pass aroundkkania@chromium.org2011-03-261-5/+14
| | | | | | | | | | | | | | | | a JSON dictionary instead of a cookie string. Deprecate the old JSON cookie interface, but do not remove because it is still being used by old automation servers. Will remove when version 12 reaches stable. Also fix the stack trace in response errors to conform to the spec. BUG=none TEST=none Review URL: http://codereview.chromium.org/6705004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79495 0039d316-1c4b-4281-b951-d872f2087c98
* Fix finding the location in view of elements. This fixes mouse commands on ↵kkania@chromium.org2011-02-251-1/+1
| | | | | | | | | | scrollable pages as well. BUG=none TEST=none Review URL: http://codereview.chromium.org/6574015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76010 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build. Forgot to explictly add file while patching.kkania@chromium.org2011-02-191-0/+78
BUG=none TEST=none TBR=rsleevi Review URL: http://codereview.chromium.org/6544032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75507 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-04-03 12:42:40 +0000