| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disabling some downloads tests which fail on the official builder only when run
via buildbot, while I debug this.
BUG=54942
TEST=
Review URL: http://codereview.chromium.org/3301017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Spanish google page data file is used by some tests. Add it back.
BUG=
TEST=
Review URL: http://codereview.chromium.org/3351018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=brettw
BUG=51345
Review URL: http://codereview.chromium.org/3296015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This patch implements chrome.experimental.management.install() which is only available for use by the web store. Calling with an extensionId, causes the download url to be constructed internally and downloaded and then cause the installation to bypass the normal permissions dialog.
BUG=27431,54148
Review URL: http://codereview.chromium.org/3353015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
production of search results in the InMemoryURLIndex. Unit test the production of results. Minor change in URLHistoryProvuder unit test setup.
BUG=None
TEST=None (unit tests added)
Review URL: http://codereview.chromium.org/3364004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original description:
Added a media UI test case for fullscreen video implementation for Windows (which is not committed yet). However, it is currently disabled until the webkit patches are here.
Also changed the other cases in media_uitest.cc to stop using Sleep() in test code. Instead, NotificationObserver and NotificationRegistrar are used.
Thirdly, moved media_uitest.cc from ui_tests to interactive_ui_tests.
TEST=ui_tests, interactive_ui_tests
BUGS=54838
Review URL: http://codereview.chromium.org/3322009
TBR=imcheng@chromium.org
Review URL: http://codereview.chromium.org/3318020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
application-default preference values.
This allows notifications to be sent properly when another PrefStore takes control from a default value.
BUG=52719
TEST=covered by PrefValueStoreTest.* unit tests
Review URL: http://codereview.chromium.org/3331016
TBR=pam@chromium.org
[Reverting because it causes PrefsControllerTest.ValidateCustomHomePagesTable to crash on Mac.]
Review URL: http://codereview.chromium.org/3353019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=jam@chromium.org
BUG=48544
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
values.
This allows notifications to be sent properly when another PrefStore takes control from a default value.
BUG=52719
TEST=covered by PrefValueStoreTest.* unit tests
Review URL: http://codereview.chromium.org/3331016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(which is not committed yet). However, it is currently disabled until the webkit patches are here.
Also changed the other cases in media_uitest.cc to stop using Sleep() in test code. Instead, NotificationObserver and NotificationRegistrar are used.
Thirdly, moved media_uitest.cc from ui_tests to interactive_ui_tests.
TEST=ui_tests, interactive_ui_tests
BUGS=54838
Review URL: http://codereview.chromium.org/3322009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
extension background pages created a new browser instead of a
tab.
BUG=54768
TEST=
Review URL: http://codereview.chromium.org/3352009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FramedBrowserWindowTest.DoesHideTitle needed changes in a different
CL.
TBR=mark@chromium.org
BUG=30384
TEST=green valgrind unit tests.
Review URL: http://codereview.chromium.org/3303019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It was suggested that it might work better as an interactive test (previously it was a UI test). I recently moved it to interactive tests, so now I am speculatively enabling it.
BUG=46616
TEST=doesn't time out (try bots/waterfall)
Review URL: http://codereview.chromium.org/3307018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reduce the dataset used for translate tests. Retaining only one page per
langugage. The additional pages don't have much text content and don't
necessarily improve coverage, but make the runtime slow.
BUG=
TEST=
Review URL: http://codereview.chromium.org/3297021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the host browser with a ChromeFrame instance. If a ChromeFrame instance was loaded with a given profile, the bho used to always forward top-level navigation requests to a CF full-tab instance using the default (iexplore) profile. This caused problems with the automation channel, and the navigation would not complete.
I also cleaned up the gcf and host networking registry keys used by Chrome-Frame so that ActiveX instances will also respect their values.
TEST=None
BUG=None
Review URL: http://codereview.chromium.org/3295019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use an observer instead, to wait more reliably.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3344006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Figure while I'm sheriffing, should do some valgrind gardening. I
tested these on my 10.6 box, and all seem to work fine:
DownloadUtilTest.AddFileToPasteboardTest
FindPasteboardTest.ReadingFromPboardUpdatesFindText
FindPasteboardTest.SendsNotificationWhenTextChanges
RenderViewTest.MacTestCmdUp
ClearBrowsingDataControllerTest.*
RenderViewTest.OnPrintPages
RenderViewTest.Print*
TabStripControllerTest.AddRemoveTabs
BUG=21479,30378,30379,30386,30396,30397
TEST=Mac valgrind green
Review URL: http://codereview.chromium.org/3322016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See previous patch at http://codereview.chromium.org/2830010/show
This patch puts the responsibility of waiting on the test rather than making ui_test.cc robust.
The reason for moving the test to interactive tests (instead of straight up ui tests) is that waving the mouse around can break the test.
BUG=46614
TEST=test passes many times locally; try bots
Review URL: http://codereview.chromium.org/3338013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests.
The sync integration tests currently access the network to communicate
with the notification server. We need to move to a model where all
server accesses are stubbed out by local servers. This is the first step
towards implementing a local notification server.
BUG=53933,53931
TEST=sync_integration_tests
First time committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58768
Review URL: http://codereview.chromium.org/3326007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=54280
TEST=accessible only via unit test checked in this CL
Original patch by raz@chromium.org
Original review: http://codereview.chromium.org/3293007
Review URL: http://codereview.chromium.org/3310018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Failures:
http://build.chromium.org/buildbot/waterfall/builders/XP%20Tests/builds/22649/steps/browser_tests/logs/stdio
http://build.chromium.org/buildbot/waterfall/builders/Vista%20Tests/builds/22157/steps/browser_tests/logs/stdio
( RUN ) sendFinancialPing
( FAILED ) sendFinancialPing
Got EXTENSION_TEST_FAILED notification.
.\browser\extensions\extension_rlz_apitest.cc(67): error: Value of: RunExtensionTest("rlz")
Actual: false
Expected: true
FAIL (no message)
at Object.callback (chrome-extension://acmddjjmpkiijbjcdpchhmniojioobgh/test.js:147:63)
at Object.<anonymous> (chrome/ExtensionProcessBindings:124:19)
[ FAILED ] ExtensionApiTest.Rlz (1531 ms)
BUG=54294
TEST=green tests
TBR=rogerta@google.com
Review URL: http://codereview.chromium.org/3371006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of the chrome extension API, since a false does not represent an error. Added
an optional callback to the API so that caller can determine if the ping was
sent or not.
BUG=54294
TEST=n/a
Review URL: http://codereview.chromium.org/3358012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
superseded by layout test
BUG=
TEST=
Review URL: http://codereview.chromium.org/3356011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=50943
TEST=ExtensionApiTest.WebNavigationEvents
Review URL: http://codereview.chromium.org/3369007
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3359013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=50943
TEST=WebNavigationEvents doesn't fail
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3352011
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3291017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=50943
TEST=WebNavigationEvents doesn't fail
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3352011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50943
TEST=ExtensionApiTest.WebNavigationEvents
Review URL: http://codereview.chromium.org/3369007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=50943
TEST=ExtensionApiTest.WebNavigationEvents
Review URL: http://codereview.chromium.org/3307013
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3317013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50943
TEST=ExtensionApiTest.WebNavigationEvents
Review URL: http://codereview.chromium.org/3307013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3232003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To quote chron's original patch (http://codereview.chromium.org/3148036/show)
<blockquote>
This patch removes: authenticator.cc, auth_watcher.cc
removes calls to user_settings.cc, removes an authenticate PB request to the server, and moves token storage into the Chrome TokenService. This patch introduces the SigninManager, which is an interim solution for user management prior to moving the system into chrome.
Other changes include removing the dependency on the sync backend to be running while the sync wizard is intially displayed. This means that the backend can be brought up in response to credentials becoming available. The backend now is always provided credentials on startup. If an auth error occurs, it propogates it up via a notification. Some event handlers were removed and streamlined for more straightforward sync system startup.
</blockquote>
BUG=51001, 50293, 35158
TEST=Unit tests && Start up sync, log in, log out, run with expired credentials, run with new gaia credentials, run with gaia credentials updated while system is syncing. Try logging in with incorrect username. Trigger CAPTCHA. Try logging out and in repeatedly. Check about:sync works. Try going offline and back online again. Expire gaia credentials and try renewing it with the UI dialog.
Review URL: http://codereview.chromium.org/3305003
TBR=johnnyg@chromium.org
Review URL: http://codereview.chromium.org/3310019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To quote chron's original patch (http://codereview.chromium.org/3148036/show)
<blockquote>
This patch removes: authenticator.cc, auth_watcher.cc
removes calls to user_settings.cc, removes an authenticate PB request to the server, and moves token storage into the Chrome TokenService. This patch introduces the SigninManager, which is an interim solution for user management prior to moving the system into chrome.
Other changes include removing the dependency on the sync backend to be running while the sync wizard is intially displayed. This means that the backend can be brought up in response to credentials becoming available. The backend now is always provided credentials on startup. If an auth error occurs, it propogates it up via a notification. Some event handlers were removed and streamlined for more straightforward sync system startup.
</blockquote>
BUG=51001, 50293, 35158
TEST=Unit tests && Start up sync, log in, log out, run with expired credentials, run with new gaia credentials, run with gaia credentials updated while system is syncing. Try logging in with incorrect username. Trigger CAPTCHA. Try logging out and in repeatedly. Check about:sync works. Try going offline and back online again. Expire gaia credentials and try renewing it with the UI dialog.
Review URL: http://codereview.chromium.org/3305003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
conditions.
BUG=50217
TEST=Remove suppressions in chrome/test/data/valgrind/sync_unit_tests.gtest-tsan.txt, then run sync_unit_tests with tsan to confirm no race conditions involving store_birthday.
Original patch by: zea@chromium.org
Original review: http://codereview.chromium.org/3333011/show
Review URL: http://codereview.chromium.org/3340008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the integration tests.
The sync integration tests currently access the network to communicate
with the notification server. We need to move to a model where all
server accesses are stubbed out by local servers. This is the first step
towards implementing a local notification server.
BUG=53933,53931
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/3326007
TBR=rsimha@chromium.org
Review URL: http://codereview.chromium.org/3318016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests.
The sync integration tests currently access the network to communicate
with the notification server. We need to move to a model where all
server accesses are stubbed out by local servers. This is the first step
towards implementing a local notification server.
BUG=53933,53931
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/3326007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sleeping is an unreliable method to wait for things.
Instead, we set up an observer.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3300011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
a layout test
BUG=53664
TEST=DevToolsSanityTest.TestExpandScope
Review URL: http://codereview.chromium.org/3291013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/3362009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=glider
Review URL: http://codereview.chromium.org/3293012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
crashes. Preconnect seems to be working properly.
BUG=none
TEST=none
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/3342017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is going to be used by the password/form autofill to trigger the
suggestion popup, as part of the effort in moving that code out of WebKit.
BUG=None
TEST=Run unit-tests.
Review URL: http://codereview.chromium.org/3090007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(unfortunately, Mac & Windows started failing tab perf tests on this change)
Sleeping is an unreliable method to wait for things.
Instead, we set up an observer.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3300011
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3344009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sleeping is an unreliable method to wait for things.
Instead, we set up an observer.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3300011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
off for applications/extensions in M7. This change is aiming for a small diff, since I'm going to turn it right back on once this is cherrypicked. Thus there's some small redundancy, e.g. in render_view.cc.
BUG=45881
TEST=included
Review URL: http://codereview.chromium.org/3324002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
UI Tests currently leaks a temp dir which contains another empty dir named
test_user_data which appears to be unused. Get rid of it, so that we don't
create and leak temp dirs.
BUG=54271
TEST=No leftover temp dir when running ui_tests or pyauto tests
Review URL: http://codereview.chromium.org/3333013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
last_accessed and creation_time fields.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3347005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
so that gcl try works correctly; will submit only after the above.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3301012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=browser_tests.exe --gtest_filter=*PopupFromInfobar*
Review URL: http://codereview.chromium.org/3127037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original message:
"""
Move the keyboard files from base/ to app/.
Also moves the associated classes/enums from base:: to app::.
TEST=try bots compile
BUG=NONE
Review URL: http://codereview.chromium.org/3165064
"""
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3354005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=ExtensionTest.IsPrivilegeIncrease
Review URL: http://codereview.chromium.org/3341007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58411 0039d316-1c4b-4281-b951-d872f2087c98
|