| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The token service now supports serialization of tokens into the web database. The token service doesn't actually know the email of the user though, and it's assumed that whoever is using the token service does. Not sure whether that's a bad choice or not, open to suggestions.
This CL adds a new DB table.
Design comments / corrections are welcome. Testing in Chromium OS is in progress and not yet done. This CL will not be submitted prior to more Chromium OS testing.
BUG=47092,47093
TEST=Unit tests included
Review URL: http://codereview.chromium.org/3061025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2969005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch from Anna Popivanova <annapop@chromium.org>.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3047050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45881
TEST=this CL
Review URL: http://codereview.chromium.org/3064048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to ChromeAppCacheService to override the default quota for an origin.
BUG=49993
TESTS=existing tests apply
Review URL: http://codereview.chromium.org/2819091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=mirandac@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=49234
Review URL: http://codereview.chromium.org/3123004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the plumbing needed for communicating with the Device Orientation code in WebKit.
RenderView provides an implementation of WebKit::WebDeviceOrientationClient: DeviceOrientationDispatcher. This communicates with the browser-side class device_orientation::DispatcherHost.
device_orientation::Provider, responsible for providing the orientation data, is just an empty shell for now.
BUG=44654
TEST=browser_tests --gtest_filter=DeviceOrientationBrowserTest.BasicTest
Review URL: http://codereview.chromium.org/2858049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
desktop. We need to ensure we always run it that way instead.
Eventually we should add code to tell us the reason of the
failure.
BUG=46751
Review URL: http://codereview.chromium.org/3046039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A patch on the WebKit side https://bugs.webkit.org/show_bug.cgi?id=43542
ensures we get the correct notification when window.focus()/blur() is called.
This CL makes the browser active/unactive in response to the focus/blur message.
BUG=29643
TEST=Visit gmail. Open an IM conversation window and pop-it out.
Focus the browser (so the IM window is in the back). Click on the person name in the IM section of gmail.
The conversation window should be brought back to the front.
Repeat but this time minimize the conversation window.
Review URL: http://codereview.chromium.org/3060045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Much remains to be converted.
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3076037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
from chrome-extension:// pages to the origin of the resource being requested.
BUG=51702
Review URL: http://codereview.chromium.org/3121003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The setup step in the sync integration tests sometimes fails on builders due to timing or networking issues. The tests, however, do not report the exact cause of failure. (Setup can fail due to a number of reasons).
Adding some logging that will help debug test failures.
BUG=51741
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/3160002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3145001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
accessibility event was received before the tab key was seen, then we
would prematurely quit the message loop and end up in
ui_controls::SendKeyPressNotifyWhenDone again, resulting in hitting
the DCHECK in ui_controls. Additionally if the test timed out we would
keep running other tests, resulting in hitting the DCHECK in ui_controls. I'm not sure which was happening, but either could have caused the DCHECK to get hit.
I'm going to leave the debugging code in for a few cycles.
I think we need a SendKeyPressAndBlock and callers ASSERT that it returns true. I'll look into that later though.
BUG=50864
TEST=this is only a test change
Review URL: http://codereview.chromium.org/3058039
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/3174001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55244
Review URL: http://codereview.chromium.org/3054028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
accessibility event was received before the tab key was seen, then we
would prematurely quit the message loop and end up in
ui_controls::SendKeyPressNotifyWhenDone again, resulting in hitting
the DCHECK in ui_controls. Additionally if the test timed out we would
keep running other tests, resulting in hitting the DCHECK in ui_controls. I'm not sure which was happening, but either could have caused the DCHECK to get hit.
I'm going to leave the debugging code in for a few cycles.
I think we need a SendKeyPressAndBlock and callers ASSERT that it returns true. I'll look into that later though.
BUG=50864
TEST=this is only a test change
Review URL: http://codereview.chromium.org/3058039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sync integration tests start off by using the XMPP port (5222) to connect to the sync notification server. Since this port is blocked on the chromium builders, the tests wait for upto a minute before they failover to the SSL/TCP port (443), by which time the tests time out and fail.
This checkin adds a switch that, when enabled, causes the tests to try the SSL/TCP port before the XMPP port.
BUG=50595
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/3050036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This hooks allows testers to test that always and never translate button that shows up after a user has accepted/declined translation several times.
Review URL: http://codereview.chromium.org/3061054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves MessageWithTuple::Read() back into the main ipc_message_utils.h
header from the private ipc_messsage_utils_impl.h header. In release mode, this
was causing link failures.
BUG=51411
TEST=none
Review URL: http://codereview.chromium.org/3069034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
case and support document refresh or reload.
When chrome crashes, we draw a poor man's sad tab (":-("), so that can clearly be improved.
Another thing is that if the chrome instance that crashed held several navigational entries, then that history is lost.
TEST=There are a couple of tests included, so run those (*TabCrash*) and also verify that when the chrome automation server is killed that we do the right thing. Also check info in bug report.
BUG=25839
Review URL: http://codereview.chromium.org/3061036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=stuartmorgan
BUG=30661,27447
Review URL: http://codereview.chromium.org/3127003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
View->Zoom. Currently we only support
Zoom in and zoom out as Chrome only supports these zoom levels.
Added an automation IPC message AutomationMsg_SetZoomLevel to set the zoom level in ChromeFrame.
The other change is in the active document in the handling of the attach external tab message. We now honor the
dimensions if any when we Launch the URL. This ensures that any windows opened outside chrome frame also honor these
dimensions.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=36000
Bug=36000
Review URL: http://codereview.chromium.org/3064049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Merge deprecated functions together.
TEST=compiles
Review URL: http://codereview.chromium.org/3029068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
testGeolocationPref - from Sunand
Review URL: http://codereview.chromium.org/3027048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this patch it was being passed to the child process
and was causing crashes becuase we can't restart the browser
in the same process after shutdown.
TEST=browser_tests
BUG=none
Review URL: http://codereview.chromium.org/3083023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of header file
dependencies) from the multiprocess test and the test_suite headers to .cc
files. Moves multiprocess_test to the test directory, and all of this stuff to
the existing base_test_support project. I also used the base namespace.
Previously other projects included this functionality just by #include because
it was all inline, so I had to add dependencies on base_test_support in a few
places.
Moves and renames the command line switch this was using to base_switches. Move
the base switch for process type to chrome switches.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3026055
TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/3035062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
New pyauto tool that installs themes and checks that they are installed correctly and don't crash the browser.
Review URL: http://codereview.chromium.org/3036025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This adds some more tests to autofill.py that test invalid input and unicode input.
Review URL: http://codereview.chromium.org/3054049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CONTROL messages.
The slowest cc files in chrome include render_messages.h and other IPC message
definitions. Including one of these files will bring in half of chrome because
in the IPC system previously required full class definitions due to
implementation details.
The new system allows forward declarations and places the implementations of
functions that need the full class definitions (ctor/dtor()/Log() and
superclass ctor/Read() methods) into a separate xxx_messages.cc file using a
parallel set of macros to ipc_message_macros.h. This has the added benefit
of moving most of the template instantiation junk into a small number of
files.
Pros:
- Will speed up compiling by a lot once everything is forward declared.
- Already, intermediary .o/.a files are smaller.
Cons:
- Adds a 4th pass to the messages system, this time in a different header.
BUG=51411
TEST=none
Review URL: http://codereview.chromium.org/2873090
TBR=erg@google.com
Review URL: http://codereview.chromium.org/3080040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dependencies) from the multiprocess test and the test_suite headers to .cc
files. Moves multiprocess_test to the test directory, and all of this stuff to
the existing base_test_support project. I also used the base namespace.
Previously other projects included this functionality just by #include because
it was all inline, so I had to add dependencies on base_test_support in a few
places.
Moves and renames the command line switch this was using to base_switches. Move
the base switch for process type to chrome switches.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3026055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
explicitly disallowed in Google code (DWORD).
This implicitly brought string_util into a number of files which got ASCII
conversion routimes. I replaced these with *ToUTF8 from utf_string_conversions
since I am trying to delete WideToASCII.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3063021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
don't have to do it when running the test.
Remove all the code in the test for copying files since it's no
longer needed.
The difference from before is we only copy over the pepper test
plugin on windows because it's the only platform with tests for
it. On Linux, unloading the plugin was causing random crashes
in tcmalloc.
Review URL: http://codereview.chromium.org/3015064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
python2.4 doesn't have os.SEEK_CUR. Replace with 0.
TBR=alyssad@chromium.org
Review URL: http://codereview.chromium.org/3087017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2819094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
testBigZip -- test downloads for a 1 GB file, from Sunand
This required methods to temporarily increase automation timeout, since it might not be possible to download 1 GB file in the default 25 secs.
testDownloadsPersistence -- verify that download history persists browser restart, from Srikanth
Review URL: http://codereview.chromium.org/3046030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is the part 4 and the latest of this series.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3029062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
On Mac, when restarting the browser, the url on the page is not restored in some cases. Fixing the test to account for that until the bug is fixed.
Review URL: http://codereview.chromium.org/3040045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit r55235.
Review URL: http://codereview.chromium.org/3090020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We should avoid crashing entire ui_tests in case of failure.
With EXPECT_TRUE we still see it, but tests continue to run.
TBR=huanr
Review URL: http://codereview.chromium.org/2868116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the default."
Introduced new crashes.
TBR=nshkrob
Review URL: http://codereview.chromium.org/3026059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The slowest cc files in chrome include render_messages.h and other IPC message
definitions. Including one of these files will bring in half of chrome because
in the IPC system previously required full class definitions due to
implementation details.
The new system allows forward declarations and places the implementations of
functions that need the full class definitions (ctor/dtor()/Log() and
superclass ctor/Read() methods) into a separate xxx_messages.cc file using a
parallel set of macros to ipc_message_macros.h. This has the added benefit
of moving most of the template instantiation junk into a small number of
files.
Pros:
- Will speed up compiling by a lot once everything is forward declared.
- Already, intermediary .o/.a files are smaller.
Cons:
- Adds a 4th pass to the messages system, this time in a different header.
BUG=51411
TEST=none
Review URL: http://codereview.chromium.org/2873090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/3054028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes two problems:
-While the API let you add your own separator items, we weren't actually
displaying those.
-There is some logic about automatically inserting separators for groups of
radio items, but it didn't work correctly (it inserted one if the very first
item was a radio item).
BUG=49730
TEST=Steps are outlined in bug. Also the browser test added should hopefully
cover the relevant cases.
Review URL: http://codereview.chromium.org/3026056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
have to do it when running the test.
Remove all the code in the test for copying files since it's no longer needed.
Review URL: http://codereview.chromium.org/3048048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Valgrind on Mac
BUG=51387
TBR=jeremy
Review URL: http://codereview.chromium.org/3005060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
into devtools front-end.
Added support for enumerating devtools extensions in devtools' DOM UI.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3074025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This will allow for having per plugin content settings, i.e. the content settings type would be plugin and the resource identifier would be to concrete plugin that is about to be loaded.
BUG=39252
TEST=unit_tests
Review URL: http://codereview.chromium.org/2878075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
knowledge the PrefService has of its two-levels-deep implementation.
Create a TestingPrefService::TestingPrefValueStore to allow tests to set the PrefStores directly, as they used to be able to do.
BUG=50722
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/3032058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3037044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55192 0039d316-1c4b-4281-b951-d872f2087c98
|