| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/656009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Just some basic observations I picked up while reading the code.
TEST=compiles, should have no functional change
Review URL: http://codereview.chromium.org/729003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser binaries
Problem:
The automation proxy interface kinda assumes that the running binary would
reside in the same directory as the browser binaries -- ie in Debug/Release
dirs. While this works for all C++ binaries like ui_tests, startup_tests,
this fails for pyauto tests since the running binary in this case is
/usr/bin/python (or some such system path).
This changeset lets pyauto explicitly specify the automation interface the
dir in which to look for chromium binaries.
Also, expose RunCommand method to pyauto.
BUG=37730
TEST=pyauto scripts should work without having to copy python to Debug/Release dirs
Review URL: http://codereview.chromium.org/695001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Provide platform-specific macros to swig.
- Update DEPS to use right swig updates
To be committed _after_ accompanying CL: http://codereview.chromium.org/661334
BUG=32285
TEST=None
Review URL: http://codereview.chromium.org/661342
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NPAPITester.ManyPlugins.
Make sure that the copied plugin gets deleted, and do it after
the browser has exited.
TEST=less flaky
BUG=28372
Review URL: http://codereview.chromium.org/668255
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
breaks dependencies on chrome from webkit, app, views
and base.
BUG=37649
TEST=compiles
Review URL: http://codereview.chromium.org/699001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Removed eol-style, executable and mergeinfo from BMP/GIF/ICO/JPEG files, and set correct mime-type.
* Removed executable and mergeinfo from .c/.cc/.cpp/.h/.m/.mm and .gyp files, and set eol-style to LF.
TBR=evanm
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
them settable in chrome.windows.create().
BUG=12658
BUG=28599
Review URL: http://codereview.chromium.org/669189
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of calling into the python port/http_server code directly. This is attempt #3 -
the actual fix for this was in WebKit r55602, where we fixed a dereference of an unset python attribute.
BUG=23099
R=maruel@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/669289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/672001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Temporarily remove RSS Extension support for locale 'fil' until we figure out why it
prevents some users from installing the extension.
Also revert the Feed link color to make the link more obvious to people (this
change is already live on the gallery -- just happened after I checked in my
last changes).
BUG=None
TEST=Locale 'fil' is no longer supported for the RSS extension. [Feed] link in subscribe
page should be blue now.
Review URL: http://codereview.chromium.org/671006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It does not work in all scenarions since from Chrome side an empty string is passed as target url.
Note in IE6 "Tools/Popup Blocker" menu is not visible if ChromeFrame is the activedocument. Have to support some IOleCommandTarget command..
BUG=34823
Review URL: http://codereview.chromium.org/668168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
With the recent DEPS update, the NaCl internal plugin works inside the Linux SUID sandbox.
BUG=36676
TEST=nacl_ui_tests
Review URL: http://codereview.chromium.org/669269
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27927
TEST=none
Review URL: http://codereview.chromium.org/668219
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enabled with the --enable-user-stylesheet flag which
causes chrome to read
<user-data-dir>/<profile>/User StyleSheet/Custom.css
at startup and set it as the user style sheet.
This version never reloads the user style sheet, I'll
have to bring back FileWatcher for that. I also put the user
stylesheet in a subdir because the implementation of
FileWatcher will watch the parent dir (this is what the OS
apis give me) and watching the profile dir will cause
lots of activity.
BUG=2393
Review URL: http://codereview.chromium.org/660349
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added Mac implementation of StatusIcon, and added a simple click callback that
displays the "extensions" tab when clicked on, to allow us to dogfood long-lived
extensions.
BUG=37375
Review URL: http://codereview.chromium.org/661454
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/669184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/160
and integrates the update to IsStandard in that version. Adds several internal
schemes as "standard" and initializes them at startup. Fixes a few hardcoded
URL schemes I noticed.
Make typing "//foo" into the URL bar treat slashes in "strict" mode on Windows,
which means we'll only accept UNC if you use backslashes. This matches IE's
behavior.
BUG=http://crbug.com/33038
TEST=covered by unit tests
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
get called asynchronously when the bits are actually copied to the screen,
rather than synchronously from inside the paint function. This makes it useful
for plugins to use the callback for rate limiting. This also adds a lot of
infrastructure for running tests on pepper devices, and includes a unit test
for the new flush behavior. I made the existing RenderProcess object an
abstract interface and made the existing MockProcess (renamed to be more clear)
implement that. This avoids a static cast that would actually crash during a
unit test because some code was hardcoded to expect a RenderProcess object.
This fixes base's IDMap iterator which has apparently never been used for an
IDMap with ownership semantics.
TEST=Unit test included
BUG=none
Original review URL: http://codereview.chromium.org/661124
Review URL: http://codereview.chromium.org/664001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Added py interface to it.
Review URL: http://codereview.chromium.org/668204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40812 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=nsylvain
Review URL: http://codereview.chromium.org/668199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/669215
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor the implementation for x-platform happiness.
Add simple pyauto script that uses it (but needs http://crbug.com32292
fixed before it works without tweaking).
Review URL: http://codereview.chromium.org/670001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
start code
BUG=23099
R=dglazkov@chromium.org, maruel@chromium.org
TEST=unit_tests passes
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40603
Review URL: http://codereview.chromium.org/660416
TBR=dpranke@chromium.org
Review URL: http://codereview.chromium.org/669191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=23099
R=dglazkov@chromium.org, maruel@chromium.org
TEST=unit_tests passes
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40603
Review URL: http://codereview.chromium.org/660416
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds ContentSettingImageModel to provide icon and tooltips for platform-specific ContentBlockedImageView.
(in preparation for:
http://codereview.chromium.org/650180/show
)
TEST=chrome/browser/content_setting_image_model_unittest.cc
Review URL: http://codereview.chromium.org/660279
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=36978
The unit test failure is fixed for Mac valgrind. Run it again.
Review URL: http://codereview.chromium.org/669023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
a bug number.
BUG=37431
TEST=Mac UI Valgrind doesn't hang
Review URL: http://codereview.chromium.org/669088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/669077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
installation on Windows.
NaCl uses two additional binaries on 64-bit Windows: nacl64.exe and nacl64.dll, so these binaries need to be installed and updated as part of Chrome installation/update.
Review URL: http://codereview.chromium.org/567028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=37239
Review URL: http://codereview.chromium.org/665007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This is to be either reverted or filed as a bug after a few bot cycles.
Review URL: http://codereview.chromium.org/669066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/37196
TEST=TODO
Review URL: http://codereview.chromium.org/667006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
start code
BUG=none
R=dglazkov@chromium.org
TEST=unit_tests passes
Review URL: http://codereview.chromium.org/660416
Review URL: http://codereview.chromium.org/668043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=dglazkov@chromium.org
TEST=unit_tests passes
Review URL: http://codereview.chromium.org/660416
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Including a hello world script.
Review URL: http://codereview.chromium.org/668004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds automation plumbing to support changing the content settings.
This change also fixes WaitForNavigation to watch for the LOAD_STOP event
instead of the NAV_ENTRY_COMMITTED event. This better matches the intent (I
think) of the automation interface, and it also matches the similar function
defined in ui_test_utils (used by browser tests). This also better matches the
NavigationNotificationObserver, which seems desirable given the implementation
of AutomationProvider::WaitForNavigation.
It turns out that only one UI test was using WaitForNavigation, and I confirmed
that it still functions properly.
This change also modifies the NavigationNotificationObserver to allow it to
watch for the current page load to complete. Normally, it waits for the first
LOAD_START or NAV_ENTRY_COMMITTED event to switch into the mode where it
watches for LOAD_STOP. However, that makes it not so useful for
WaitForNavigation, which is intended to be called after triggering the start of
a new navigation.
This change also makes it so that the cookie prompt supports the automation
message box 'OK' and 'Cancel' buttons, so that we can remotely press those
buttons.
Leveraging all of these changes enables some basic cookie prompting tests to be
written.
I had to modify browser_frame_win.cc to ensure that BrowserList::SetLastActive
is called even while running under remote desktop.
R=phajdan.jr@chromium.org
BUG=37182
TEST=cookie_modal_dialog_uitest.cc
Review URL: http://codereview.chromium.org/661102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when the locale is Norvegian,
Filipino or any Chrome languages that the translation server does not support.
The crash would happen in the translate infobar, the source index would be
-1 and would cause us to crash accessing that index in a vector.
This CL fixes that by cleaning up the list of supported languages, so they
match Chrome's locales.
Also it makes sure we don't create an infobar if for any reason one of the
language (source or target) is not supported.
BUG=37218
TEST=For each language Chrome can be run into, select that language and open
www.google.com. Check that the info-bar is shown for languages supported
by the Google translate server (see the list at http://translate.google.com/)
and for the supported language translating works.
Review URL: http://codereview.chromium.org/661434
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Reverts r40097.
BUG=36871
TEST=page_cycler_moz-http is green
Review URL: http://codereview.chromium.org/661449
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18717
TEST=ExtensionApiJsonValidityTest.WithV8
Review URL: http://codereview.chromium.org/661406
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
ThreadSanitizer on Mac due to the workq problem.
TBR=timurrrr
Review URL: http://codereview.chromium.org/661463
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
advertised. It will now
get called asynchronously when the bits are actually copied to the screen,
rather than synchronously from inside the paint function. This makes it useful
for plugins to use the callback for rate limiting.
This also adds a lot of infrastructure for running tests on pepper devices, and
includes a unit test for the new flush behavior.
I made the existing RenderProcess object an abstract interface and made the
existing MockProcess (renamed to be more clear) implement that. This avoids
a static cast that would actually crash during a unit test because some code
was hardcoded to expect a RenderProcess object.
This fixes base's IDMap iterator which has apparently never been used for an
IDMap with ownership semantics.
TEST=Unit test included
BUG=none
Review URL: http://codereview.chromium.org/661124
TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/660439
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
get called asynchronously when the bits are actually copied to the screen,
rather than synchronously from inside the paint function. This makes it useful
for plugins to use the callback for rate limiting.
This also adds a lot of infrastructure for running tests on pepper devices, and
includes a unit test for the new flush behavior.
I made the existing RenderProcess object an abstract interface and made the
existing MockProcess (renamed to be more clear) implement that. This avoids
a static cast that would actually crash during a unit test because some code
was hardcoded to expect a RenderProcess object.
This fixes base's IDMap iterator which has apparently never been used for an
IDMap with ownership semantics.
TEST=Unit test included
BUG=none
Review URL: http://codereview.chromium.org/661124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
instead.
Review URL: http://codereview.chromium.org/660430
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
now. The mac no longer needs 2 flags in order to load .nexes, it is only
behind the --internal-nacl flag like everyone else.
BUG=328 (tracked in the Native Client project)
TEST=Run Chrome on a Mac without the --enable-nacl-on-mac flag, and load a
.nexe. It should work.
Review URL: http://codereview.chromium.org/661370
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
we always read the cookies from
the host browser when the renderer requests them. This also cleans up the mess with the host network stack
code parsing cookies from the host looking for persistent cookies.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=34151
Bug=34151
Test=Covered by existing host network stack tests and chrome frame cookie tests.
Review URL: http://codereview.chromium.org/661290
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
window.
BUG=27365
TEST=none
Review URL: http://codereview.chromium.org/661187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-enabling the tests that were disabled in the first pass.
Also changing how we substitute localization values (using direct method that avoids flashing __MSG__const while the page is loading).
Also made some minor fixes after testing various locales.
BUG=37109
TEST=This CL is about enabling automated tests.
Review URL: http://codereview.chromium.org/660328
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=15620
TEST=none
Review URL: http://codereview.chromium.org/660327
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Disabling ExtensionBrowserTest.ParseFeed* tests. Will file P1 against Finnur.
Review URL: http://codereview.chromium.org/660147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40290 0039d316-1c4b-4281-b951-d872f2087c98
|