| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
processing the
AutomationMsg_InvalidateHandle message in the background thread and the TabProxy getting destroyed
in the UI thread which also removes the object from the map.
Fix is to remove the object from the map while processing the AutomationMsg_InvalidateHandle message
which ensures that it is processed in the IO thread. The automation handle tracker now maintains
a refcounted object map.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=36607
Bug=36607
Review URL: http://codereview.chromium.org/657057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=stuartmorgain@chromium.org
BUG=36670
TEST=stops some red on the waterfall
Review URL: http://codereview.chromium.org/657084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is too short.
That might trigger a translate infobar with the wrong language, it is better to show none.
BUG=36593
TEST=Open the pages reported in the bug. No translate infobar should be shown.
Review URL: http://codereview.chromium.org/652144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- Provide args to specifiy tab_index or window_index.
- Re-order the methods to group by functionality, rather than from where they
are implemented.
Review URL: http://codereview.chromium.org/650106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserImpl dtor assumes full construction of all sub-objects, this is not true
at least in one case (the try chrome again toast). See bug for more details
- Added a UI test to detect these shenaningans in all platforms
- had to hack ui_tests a bit, I hope is palatable
BUG=34799
TEST= UI test included
Review URL: http://codereview.chromium.org/571017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
runchromiumwebkittests and rebaselinechromiumwebkittests
BUG=23099
TBR=victorw
TEST=bots don't explode
Review URL: http://codereview.chromium.org/639001
TBR=dpranke@chromium.org
Review URL: http://codereview.chromium.org/650189
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
run-chromium-webkit-tests and rebaseline-chromium-webkit-tests
BUG=23099
R=victorw
TEST=bots don't explode
Review URL: http://codereview.chromium.org/639001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=rafaelw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=rafaelw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/570015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome?view=rev&revision=39374
Initial Geolocation implementation
Adds IPC plumbing.
Adds Infobar buttons for requesting permission
This change specifically:
ui_test_utils::WaitForAppModalDialog registers for listening to notifications too late, i.e., after the dialog had been triggered.
Exposes AppModalDialogObserver so that we can register, trigger the dialog, then wait for it.
Review URL: http://codereview.chromium.org/647048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to chrome/browser.
This is a part of an effort to remove bad dependency of chrome/common
on chrome/browser.
TEST=unit_tests and ui_tests, just moving code
BUG=none
Review URL: http://codereview.chromium.org/621004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a speculative fix for a crash that showed up on the reliability bot.
R=jam
BUG=36188
TEST=none
Review URL: http://codereview.chromium.org/646051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Additions include some low-hanging fruits:
- create tabs
- activate a tab by index
- apply any accelerator (like IDC_BACK, IDC_REFRESH)
- install and load an extension
Review URL: http://codereview.chromium.org/647006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG= 36188
TEST= none
Review URL: http://codereview.chromium.org/646038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds IPC plumbing.
Adds Infobar buttons for requesting permission
TEST=geolocation_browsertest.cc
Review URL: http://codereview.chromium.org/548188
TBR=bulach@chromium.org
Review URL: http://codereview.chromium.org/646027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG= 36161, 36163
TEST= none
Review URL: http://codereview.chromium.org/647026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adds IPC plumbing.
Adds Infobar buttons for requesting permission
TEST=geolocation_browsertest.cc
Review URL: http://codereview.chromium.org/548188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
--allow-file-access-from-files developer switch. Turn on this flag for the UI
tests, which depend on the old behaviour.
BUG=4197
TEST=WebKit test submitted upstream
TBR=abarth
Review URL: http://codereview.chromium.org/648003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also,
- add python documentation strings which get embedded in the generated
python classes (BUG 32287).
- Make utility methods public in ui_test.h
-
BUG=32287
TEST=None
Review URL: http://codereview.chromium.org/633004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=33220, 34564
TEST=test passes
Review URL: http://codereview.chromium.org/606009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
of the PSS that already includes bookmarks. This is a temporary solution until we have a proper component to manage the startup and shutdown of multiple data types.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=39143
Review URL: http://codereview.chromium.org/601037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
auth token in ServerConnectionManager.
TEST=manually tested using fiddler2 script.
BUG=35321
Review URL: http://codereview.chromium.org/605010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a lint warning in render_messages.h (supersedes http://codereview.chromium.org/464072/show)
Also implement a couple comments in geolocaiton/ in follow up to http://codereview.chromium.org/604019
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/600128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dimich
BUG=28439
TEST=none
Review URL: http://codereview.chromium.org/621002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ModelSafeGroup at a time.
Enforce ModelSafeGroup restrictions in the StatusController by DCHECKing if out-of-bounds.
Move OrderedCommitSet to its own file.
Removed some unused error counters and ResetTransientState calls that were useless.
BUG=31911
TEST=ProcessCommitResponseTest, OrderedCommitSetTest
Review URL: http://codereview.chromium.org/604045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21649
TEST=Ran updated browser tests.
Review URL: http://codereview.chromium.org/604057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/593111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/577015 for the review status of this CL.
BUG=None
TEST=ExtensionApiTest.Popup
Review URL: http://codereview.chromium.org/600101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=japhet
BUG=35467
TEST=none
Review URL: http://codereview.chromium.org/600090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This merely adds a way to enable content scripts and browser actions in incognito windows. They still don't work properly because none of the APIs work with incognito tabs.
The way to enable an extension is to add an "incognito" bit in the user prefs file. My plan is to add UI for this later.
BUG=32365
Review URL: http://codereview.chromium.org/567037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also includes a small valgrind error fix.
Review URL: http://codereview.chromium.org/598046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The chrome frame failure appears to be unrelated.
Add some tests to CookieMonster for overwriting persistent cookies, and checking that the PersistentCookieStore interface is exercised correctly.
Review URL: http://codereview.chromium.org/600040
TBR=eroman@chromium.org
Review URL: http://codereview.chromium.org/596048
TBR=eroman@chromium.org
Review URL: http://codereview.chromium.org/604012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Which datatypes are fetched is dictated by the ModelSafeRoutingInfo. We change the semantic of the ModelSafeRoutingInfo so that datatypes which should not be synced are not in the map. We will do GetUpdates for GROUP_PASSIVE datatypes.
BUG=29905
TEST=included unit tests
Review URL: http://codereview.chromium.org/594024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
even though this should be a strictly no-op change...
Add some tests to CookieMonster for overwriting persistent cookies, and checking that the PersistentCookieStore interface is exercised correctly.
Review URL: http://codereview.chromium.org/600040
TBR=eroman@chromium.org
Review URL: http://codereview.chromium.org/596048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
checking that the PersistentCookieStore interface is exercised correctly.
Review URL: http://codereview.chromium.org/600040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
test_shell.gyp. This allows the removal of webkit.gyp:pull_in_test_shell,
eliminating the circular relationship between webkit.gyp and test_shell.gyp.
The expected semantics of building all of test_shell during a webkit.gyp:All
build is performed are retained.
This change depends on GYP r781 (in Chromium at r38526) for GYP suffix
operator path section treatment. It also depends on Chromium r38519 and
r38658 for common.gypi treatment of chromium_code.
BUG=33186
TEST=Xcode no longer holds stale project files in memory
Review URL: http://codereview.chromium.org/602006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will re-introduce a mac performance regression but will make the code
correct.
R=mirandac (over shoulder)
BUG=34775,34078
TEST=none
Review URL: http://codereview.chromium.org/600045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/595013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Some also say it's good for reducing flakiness.
TEST=Changing ui_tests.
BUG=none
Review URL: http://codereview.chromium.org/593018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
read request in the automation job.
The crash based on the dump occurs while dereferencing a NULL message filter, which means that we received
a read request for a disconnected/terminated job. This happens when a request is paused while waiting for
the renderer to ack sent data packets
Following fixes:-
1. NULL check the message_filter pointer before dereferencing it in URLRequestAutomationJob::ReadRawData.
2. Only complete the job when we receive a Read request for it or if we have a pending read.
Added ASSERTS in OnDataAvailable to check if we receive unexpected data.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=34819
Bug=34819
Test=Covered by ui test.
Review URL: http://codereview.chromium.org/577033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=levin
BUG=35224
TEST=none
Review URL: http://codereview.chromium.org/597018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35224, 28439
TBR=levin
Review URL: http://codereview.chromium.org/601017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the API slightly. Previously, if someone called update with an empty object ({}) it would set the title to "". This was only documented in the code and not on the API page. Now that we support updating both the url and title it seems more reasonable to ignore a missing title.
BUG=34841
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Bookmarks
Review URL: http://codereview.chromium.org/591006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
shared worker is started.
Added tests for worker close and queued shared worker cases.
BUG=29998
TEST=new UI tests added.
Review URL: http://codereview.chromium.org/580007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34755,34078
TEST=none
Review URL: http://codereview.chromium.org/600026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the "show" function to work more like a number of our other dialogs (i.e. delcared in browser_dialogs.h), and adds a TabContentsDelegate function so the content blocked info bubbles can ask the appropriate window to show the dialog.
BUG=35084
TEST=Open the content settings dialog from either the options or a content blocked info bubble. Click its parent window. The dialog should stay on top of the parent.
Review URL: http://codereview.chromium.org/597009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=nick
Review URL: http://codereview.chromium.org/594017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
new index to syncable. Added new DB col to syncable. Renamed singleton tag to UNIQUE_CLIENT_TAG. Added syncapi layer support for unique client tags.
Hooked up wire protocol to use this index.
Downintegrate of sync.proto from trunk.
TEST=unit tests included
BUG=32636
Review URL: http://codereview.chromium.org/558015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38518 0039d316-1c4b-4281-b951-d872f2087c98
|