| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=66714
Review URL: http://codereview.chromium.org/5693004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation to a subsequent CL where Singleton<T> will restrict access to only the type being made singleton.
I also moved pepper::ResourceTracker to a lazy instance since there were too many places in code where this class was being accessed from and this was a smaller change than renaming methods in that case.
BUG=65298
TEST=all existing tests should pass.
Review URL: http://codereview.chromium.org/5685007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
'crx-less' web apps to extensions.
BUG=66127
TEST=
Review URL: http://codereview.chromium.org/5709004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://src.chromium.org/viewvc/chrome?view=rev&revision=67300
The change has been approved conditionally,
i.e. if the outstanding review comments are handled
in a follow-up as the top priority.
Two weeks have passed, and I have not seen the follow-up.
It is risky to keep this change in the tree, as it is already
non-trivial to revert.
Conflicts:
chrome/browser/automation/automation_provider.cc
chrome/test/ui/named_interface_uitest.cc
ipc/ipc_channel_posix.cc
TBR=nirnimesh
BUG=chromium-os:8512
TEST=none
Review URL: http://codereview.chromium.org/5707006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Seems to have cured itself.
BUG=59208
Review URL: http://codereview.chromium.org/5713003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added tests
1. testRemovePasswords
2. testFetchAnotherUser
3. testNeverSavePasswords
Added a method for constructing password dictionary
Modified testSavePassword in passwords.py
MOdified GoogleAccountsLogin and VerifyGoogleAccountCredsFilled in test_utils.py to take window index and tab index
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5379007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=66448
Review URL: http://codereview.chromium.org/5697004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
( Note: Data file related to the same test is submitted in a different CL)
Verify prefs to enabled/disables omnibox suggestions
Review URL: http://codereview.chromium.org/5556010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
since different environments may require users to have certain external policy extensions installed. This patch also fixes a crash when --disable-extensions is used with external extensions installed.
BUG=66070
TEST=ExtensionsServiceTest.ExternalUninstall
Review URL: http://codereview.chromium.org/5695004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
translate the page"
TEST=47250
Review URL: http://codereview.chromium.org/5557005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=None
Bug=None
1. Verify content on https page - https://www.google.com. Verify in regular,
incognito window
2. Verify that chrome works with some top websites. Browse a list of urls, each
time verify some key strings. This test will verify that chrome is not getting
blocked by user-agent test by those websites.
Review URL: http://codereview.chromium.org/5726001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=66448
Review URL: http://codereview.chromium.org/5725004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=66414
TEST=none
Review URL: http://codereview.chromium.org/5728003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=65859
TEST=yes please
Review URL: http://codereview.chromium.org/5519015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on WebKit r73697.
BUG=65619
TEST=browser_tests
Review URL: http://codereview.chromium.org/5695002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
flakyness.
This also ups the timeout time for actually running the test. We don't know
what the tests do (some of the file ones do a lot of I/O), so the short timeout
is somewhat dangerous. We have not historically had many problems with hanging
tests other than problems with startup (which has a shorter timeout), so I
think the longer test timeout is unlikely to cause problems.
TEST=this is
BUG=none
Review URL: http://codereview.chromium.org/5743002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
search engine supported instant but it doesn't.
BUG=66133
TEST=covered by interactive ui test. You can also manually test
Review URL: http://codereview.chromium.org/5771001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/5666001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5762001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/5206006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
User-triggerred unsafe downloads do not prompt anymore.
These tests need to be reimplemented to match expectations.
BUG=66081
Review URL: http://codereview.chromium.org/5680002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- test HTTP server was never started, starting it now;
- added missing test resource, simple_page.html;
BUG=57964
TEST=interactive_ui_tests, SidebarTest.SidebarNavigate should not hang
Review URL: http://codereview.chromium.org/5736001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=66072
Review URL: http://codereview.chromium.org/5731001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reworks the PrefStore interface, specifically:
- Split up the interface into PrefStore, which only provides reading functionality, and the derived PersistentPrefStore for the actual user pref store
- Remove the hurt-me-plenty prefs() function from PrefStore, instead provide Get/Set/Remove operations
- Remove special handling of default and user pref store from PrefValueStore and put it into PrefService
- Pref change notification handling now almost exclusively handled through PrefValueStore
- Adjust all consumers of these interfaces (but keep ConfigurationPolicyPrefStore untouched, that's up next on the list)
BUG=64232
TEST=existing unit tests
Review URL: http://codereview.chromium.org/5646003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
of having to include the files in a magic place because of xcode dependency issues, and just makes it simpler to create new IPC message classes. It also gets rid of including the X_messages_internal.h file multiple times, which simplifies things and should make the build a little faster.
In a future change, I will remove the "internal.h" files since they're no longer needed.
Review URL: http://codereview.chromium.org/5526008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24672
TEST=trybots
Review URL: http://codereview.chromium.org/5649003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The third notification was not showing because it did not fit on the screen.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5552007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/5560011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Contributed By: tburkard@chromium.org
BUG=None
TEST=trybots, no new unit tests
Review URL: http://codereview.chromium.org/5180005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also fixes up types and a bug in WindowedNotificationObserverWithDetails.
BUG=none
TEST=updated BrowserFocusTest.FocusTraversal
Review URL: http://codereview.chromium.org/5516005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a small step towards making all singleton classes use the Singleton<T> pattern within their code and not expect the callers to know about it.
This CL includes all files except those under chrome/browser, chrome/net, chrome/service and third_party/WebKit (these will be done in future CLs).
Suggested files to focus for reviewers:
- joi@ for files under src/ceee
- tommi@ for files under src/chrome_frame
- maruel@ for the rest of the files.
BUG=65298
TEST=all existing tests should continue to pass.
Review URL: http://codereview.chromium.org/5581008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a complete overhaul of PrefValueStore, PrefStore, PrefNotifier, and PrefService. Specifically:
- Add an observer interface to PrefStore that can be used to notify the upper layers of the pref system about value changes. Currently, it's unused mostly, but that'll change when we refactor ExtensionPrefStore and ConfigurationPolicyPrefStore.
- Make PrefNotifier be a dependency of PrefValueStore. That helps in keeping the pref change detection handling local to PrefValueStore.
- Clean up related unit tests, removing redundant mocks and gmockify others.
BUG=64893
TEST=Compiles and passes tests
Review URL: http://codereview.chromium.org/5441002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and remaining comments of 5005002.
See http://codereview.chromium.org/5005002.
BUG=48930
TEST=none
Review URL: http://codereview.chromium.org/5537002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add an option to Extension::GetDistinctHosts that strips the RCDs off the hosts.
BUG=65138
TEST=ExtensionsServiceTest, ExtensionTest
Review URL: http://codereview.chromium.org/5642001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61534
TEST=ExtensionApiTest.FileAPI
Review URL: http://codereview.chromium.org/5392001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a redesign for http://codereview.chromium.org/4852002/ following discussions.
The goal of this patch is to ensure that Chrome maintains the order in which extensions apply their preferences between restarts. This may be an issue if two extensions overwrite each others preferences. Furthermore, it ensures that preferences are persisted to disk between browser restarts. Therefore, previous settings are immediately available when the browser is restarted.
A description of the design has been published https://docs.google.com/a/google.com/document/d/1E_HX_cUpET1gH2gDunGIU1EOywMM6FEOuVU6TlpnSwo/edit?hl=en for review and comments. - Sorry, accessible Google internally only.
This CL requires http://codereview.chromium.org/5204006/
Contributed by battre@google.com
BUG=50726
TEST=none
Review URL: http://codereview.chromium.org/5213002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=31526
BUG=60840
TEST=TaskManagerBrowserTest.NoticeExtensionTabs
TEST=TaskManagerBrowserTest.NoticeAppTabs
Review URL: http://codereview.chromium.org/5526002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5512009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=65408
TEST=none
Review URL: http://codereview.chromium.org/5544009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=63816
TEST=none
Review URL: http://codereview.chromium.org/5255005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=63852
TEST=none
Review URL: http://codereview.chromium.org/5290003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5364002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change accommodates fetching 32bit and 64bit binaries for linux.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5608002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This one happened at http://www.elancasti.com.ar/categoria.php
BUG=47207
TEST=reliability
TBR=huanr
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the pref_value_store.h header from the pref_service.h
include list and cleans up any users that were getting the MessageLoop
and BrowserThread definitions indirectly through pref_service.h
BUG=64893
TEST=compiles and passes tests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67997
Review URL: http://codereview.chromium.org/5461001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change makes the interface to
WindowedNotificationObserverWithDetails closer to that of
WindowedNotificationObserver, which should make it easier to use more
broadly in testing utility code.
I have a follow-up CL that will be somewhat simplified by this change.
BUG=none
TEST=browser_tests compiles and passes
Review URL: http://codereview.chromium.org/5365008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/5519004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
off for background pages
We don't support turning compositing on for a background page currently and it doesn't seem necessary. This disables all GPU-requiring features for background pages for now. When we have valid use cases we can re-enable features as needed.
BUG=64512
TEST=load extension that uses 3d CSS in a background page and verify that there is no browser crash or GPU process created on startup
Review URL: http://codereview.chromium.org/5369008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
requiring 'experimental' permission without --enable-experimental-extension-apis
flag.
BUG=none
TEST=ExtensionManifestTest.ExperimentalPermission
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68098 0039d316-1c4b-4281-b951-d872f2087c98
|