| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
TEST=python chrome/test/functional/omnibox.py omnibox.OmniboxTest.testSelect
Review URL: http://codereview.chromium.org/2136010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
testNavigationStateOnSessionRestore -- from Sunand
testDownloadDirPref -- from Deepak
testToolbarButtonsPref, testHomepagePrefs -- from Rohit
TEST=python chrome/test/functional/prefs.py
Review URL: http://codereview.chromium.org/2087005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=44371
Review URL: http://codereview.chromium.org/2066008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=Ensure that the About Chrome dialog has proper accessibility role.
BUG=none
Review URL: http://codereview.chromium.org/1838002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DISABLED test that times out on Mac. (Original patch reviewed at http://codereview.chromium.org/2067003 )
Track "display" and "run" separately for mixed content, and make the latter downgrade the SSL state to "authentication broken".
Make the "display" state only affect the current tab (not the entire host).
Fix an SSL browser test by supplying the appropriate SiteInstance*.
Move a test from "disabled" to "flaky" since it at least passes for me.
Make the SSLManager header and .cc files put functions in the same order, and make that order somewhat saner.
BUG=15072, 18626, 40932, 42758
TEST=Covered by browser tests
Review URL: http://codereview.chromium.org/2063008
Review URL: http://codereview.chromium.org/2126005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=atwilson
BUG=44371,44371
Review URL: http://codereview.chromium.org/2132004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It needs to be after calling navigator.geolocation.getCurrentPosition()/watchPosition() rather than just accessing navigator.geolocation.
Depends on https://bugs.webkit.org/show_bug.cgi?id=38323.
BUG=42789
TEST=GeolocationBrowserTest.NoInfoBarBeforeStart
Review URL: http://codereview.chromium.org/1950001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- Display it on the about:net-internals page
- Collect it in the histogram Net.OSErrorsForGetAddrinfo.
Review URL: http://codereview.chromium.org/2134004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=44253,44254
TEST=media_unittests succeeds when run in valgrind
TBR=ajwong@chromium.org
Review URL: http://codereview.chromium.org/2103002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
test hangs in cases when the server fails to start.
The tests will still fail in that case, obviously,
but will no longer hang (or crash), which is an
improvement.
TEST=browser_tests
BUG=none
Review URL: http://codereview.chromium.org/2095004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Suppressing memcheck:cond error.
Following CL seems to be culprit.
http://src.chromium.org/viewvc/chrome?view=rev&revision=47333
BUG=44253,44254
TEST=linux/chromeos valgrind should cycle green
TBR=sergeyu@chromium.org
Review URL: http://codereview.chromium.org/2076003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/2067003 )
Track "display" and "run" separately for mixed content, and make the latter downgrade the SSL state to "authentication broken".
Make the "display" state only affect the current tab (not the entire host).
Fix an SSL browser test by supplying the appropriate SiteInstance*.
Move a test from "disabled" to "flaky" since it at least passes for me.
Make the SSLManager header and .cc files put functions in the same order, and make that order somewhat saner.
Falied TestGoodFrameNavigation on Mac 10.5 browser tests
among other things:
/b/slave/chromium-rel-mac-builder/build/src/chrome/browser/ssl/ssl_browser_tests.cc:43: Failure
Value of: entry->ssl().displayed_mixed_content()
Actual: false
Expected: displayed_mixed_content
Which is: true
BUG=15072, 18626, 40932, 42758
TEST=Covered by browser tests
Review URL: http://codereview.chromium.org/2063008
TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/2095006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=44220
TEST=none
TBR=huanr
Review URL: http://codereview.chromium.org/2131004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Track "display" and "run" separately for mixed content, and make the latter downgrade the SSL state to "authentication broken".
Make the "display" state only affect the current tab (not the entire host).
Fix an SSL browser test by supplying the appropriate SiteInstance*.
Move a test from "disabled" to "flaky" since it at least passes for me.
Make the SSLManager header and .cc files put functions in the same order, and make that order somewhat saner.
BUG=15072, 18626, 40932, 42758
TEST=Covered by browser tests
Review URL: http://codereview.chromium.org/2063008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2079005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=44220
TEST=none
Review URL: http://codereview.chromium.org/2070003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
launcher pinned to the location bar.
BUG=3190
TEST=The app launcher icon on the top-left corner of the browser should
be gone. Opening a new tab by pressing the + button or typing
CTRL-T should bring the app launcher, it should be located on top
of the location bar.
Review URL: http://codereview.chromium.org/2060004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Make the use of browser explicit for each json handler so that handlers
that need access to Browser* can have it. Omnibox needs it.
2. Add a simple test
TEST=python chrome/test/functional/omnibox.py
Review URL: http://codereview.chromium.org/2015010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modifies the AutoFill label inferencing logic to skip over <img> tags when deriving labels. It is common to use
small images as spacers between elements. Also, extends the phone number heuristics to recognize numbers that are
split into three fields of the form [xxx]-[yyy]-[zzzz] where xxx is the area code, yyy is the phone number prefix and zzz
is the phone number suffix.
Note: This change has a dependency on WebKit change: https://bugs.webkit.org/show_bug.cgi?id=38825.
Will need to wait for that to land before committing this change.
BUG=38218
TEST=FormManagerTest.LabelsInferredWithImageTags:FormStructureTest.ThreePartPhoneNumber:PhoneFieldTest.ThreePartPhoneNumber
TBR:jhawkins@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rest of IndexedDB) will be done in subsequent patches. Included in this patch
is a lot of other infrastructure for making IndexedDB work. Included is a
conversion from the DOMStorageDispatcherHost into a dispatcher host for all APIs
that have a backend in WebKit.
I named it WebKitAPIDispatcherHost. Since it's in browser/in_process_webkit and
it is for APIs that connect up to the WebKit API and it's used for APIs whose
backend is implemented in WebKit I thought the name was decent and not _too_
confusing, but if you have better ideas, please let me know.
This includes some code that you've already reviewed (darin), but a lot has
changed so please take a look at all of it.
TEST=Not much to test yet + behind a flag.
BUG=none
Review URL: http://codereview.chromium.org/1599009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
instead.
features.gypi isn't needed by glue, appcache or database.
Review URL: http://codereview.chromium.org/2070001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=38575
Review URL: http://codereview.chromium.org/2098003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for Chromium OS. Currently disabled by default behind a command line
switch, and containing a non-real URL for now, this code is at
prototype level. It works (when enabled and pointed at a functioning
cloud print service URL), has the beginnings of some unit tests, and
has the beginnings of deeper communication with the dialog contents,
and it shuts off the DOM UI access from the dialog contents.
Patch contributed by Scott Byer
Review URL: http://codereview.chromium.org/1769006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44119,44005
TEST=FirefoxProxySettingsTest.TestParseAutoConfigUrl
Review URL: http://codereview.chromium.org/2089004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=44064
TBR=rvargas
Review URL: http://codereview.chromium.org/2106003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
help documentation.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2071002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This includes info like version string, executable name, path, and so on.
Review URL: http://codereview.chromium.org/2009013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
views::View::PropagateNativeViewHierarchyChanged
BUG=44066
TEST=none
TBR=rvargas
Review URL: http://codereview.chromium.org/2088001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=44065
TEST=none
TBR=rvargas
Review URL: http://codereview.chromium.org/2064004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebCore::RenderInline::destroy ... HTMLParser::handleResidualStyleCloseTagAcrossBlocks
TEST=none
TBR=rvargas
BUG=44064
Review URL: http://codereview.chromium.org/2085001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ui_test.gtest_linux.txt instead to disable it only under Valgrind Linux.
TEST=none
TBR=rvargas,phajdan.jr
BUG=43974
Review URL: http://codereview.chromium.org/2078001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Visual inspection. The Omnibox should never become visible for tabs with a collapsed toolbar (app tabs). F11 twice should not show the Omnibox.
Review URL: http://codereview.chromium.org/2032015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=44015
Review URL: http://codereview.chromium.org/1987015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=39505
TEST=Should be able to add a bunch of context menu items and then change or
remove them using update and removeAll respectively.
Review URL: http://codereview.chromium.org/1736028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a duplicate of http://codereview.chromium.org/2027006 which was accidentally created in a read-only client.
BUG=None
TEST=ExtensionApiTest.Popup
Review URL: http://codereview.chromium.org/2003016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35027
TEST=None
TBR=antonm@chromium.org
Review URL: http://codereview.chromium.org/2015016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
on Valgrind bots.
TBR=glider,thestig
Review URL: http://codereview.chromium.org/2051010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem was the circular gyp dependency between webkit.gyp
and WebKit.gyp:
webkit.gyp:pull_in_webkit_unit_tests -> WebKit.gyp -> webkit.gyp:webkit_support.
The fix is to move webkit_support into its own gyp file (like we do
in an webkit only checkout). We can't use the same gyp file for in-
chromium and in-webkit because we need to change the include path for
features.gypi. In gyp, variable expansion happens after includes
(otherwise you'd have to expand variables twice and they could change
values), so we can't use a single gyp file for this.
Review URL: http://codereview.chromium.org/1995013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=41275
Review URL: http://codereview.chromium.org/2013015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=bauerb
TEST=ui_tests on 10.6 and ChromiumOS should go green.
BUG=43066
Review URL: http://codereview.chromium.org/1985014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
infobar response.
Moves GeolocationPermissionContext from GeolocationDispatcherHost up to profile.
TEST=GeolocationPermissionContextTests.MultipleOrigins or manual: open two tabs from the same origin with geolocation. Check both info bars are created. Reply to only one of them, check the other is gone.
BUG=40527
Review URL: http://codereview.chromium.org/1585036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add AutomationMsg_WaitForDownloadShelfVisibilityChange and use it in UITestBase for the download tests.
This should decrease flakiness of download tests.
TEST=DownloadTest.*, especially DownloadTest.[Dont]CloseNewTab*
BUG=43066
Review URL: http://codereview.chromium.org/2051002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Recent changes to chrome://net-internals (and about:net-internals) code no
longer sets the title as expected. Remove them.
TEST=python chrome/test/functional/special_tabs.py
Review URL: http://codereview.chromium.org/2041009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
infrastructure has been ported.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2057003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
500 test runs.
BUG=22666
TEST=none
Review URL: http://codereview.chromium.org/2000008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2016004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
as it's not crashing or hanging. Will file a suppression after a new Valgrind
run.
TBR=thestig
BUG=43764
TEST=none
Review URL: http://codereview.chromium.org/2006009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
disabled because it failed under valgrind. Now the test is specifically
disabled for Valgrind only.
TBR=johnnyg
BUG=43764
TEST=none
Review URL: http://codereview.chromium.org/2036008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Avoid using wall clock time, which can be changed by the user,
or impacted by Daylight Savings transitions etc.
BUG=14193
r=eroman
Review URL: http://codereview.chromium.org/1253005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2016002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46775 0039d316-1c4b-4281-b951-d872f2087c98
|