summaryrefslogtreecommitdiffstats
path: root/chrome/test
Commit message (Collapse)AuthorAgeFilesLines
* Don't grant unnecessary handle privileges in OpenProcessHandle.phajdan.jr@chromium.org2009-06-193-4/+4
| | | | | | | | | This patch makes it harder for process handles with more privileges to leak to untrusted places. Review URL: http://codereview.chromium.org/125260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18802 0039d316-1c4b-4281-b951-d872f2087c98
* First draft of web resource service; fetches data from a JSON feed mirandac@chromium.org2009-06-181-0/+2
| | | | | | | | | | and stores it in user prefs, where it can be used by the new tab page. BUG = http://crbug.com/13363 Review URL: http://codereview.chromium.org/125052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18766 0039d316-1c4b-4281-b951-d872f2087c98
* Implement a max worker count of 16 per tab and 64 total. Any workers ↵jam@chromium.org2009-06-181-0/+12
| | | | | | | | created after that are queued. Review URL: http://codereview.chromium.org/125242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18763 0039d316-1c4b-4281-b951-d872f2087c98
* Delete files from webkit/glue that have been made obsolete by correspondingdarin@chromium.org2009-06-181-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | files in webkit/api. Here's the mapping: webkit/glue/webdatasource.h -> webkit/api/public/WebDataSource.h webkit/glue/weberror.h -> webkit/api/public/WebURLError.h webkit/glue/weburlrequest.h -> webkit/api/public/WebURLRequest.h webkit/glue/webresponse.h -> webkit/api/public/WebURLResponse.h I kept the implementation of WebDataSource in webkit/glue for now because it helps to have it close to WebFrameImpl and WebFrameLoaderClient. To facilitate this change, I needed to make use of WrappedResourceRequest and WrappedResourceResponse from webkit/api/src within the implementation files of webkit/glue. This is only a temporary usage of webkit/api/src from the outside. It will go away when WebFrame, etc. get moved into webkit/api. I modified these wrapper classes to expose the 'bind' function so that I can re-bind a wrapper. This is used in WebDataSourceImpl::request() and related methods to allow the interface to return a const reference to a WebURLRequest and WebURLResponse. The changes here are fairly mechanical. I'm not too happy about the way WebDataSource::redirectChain now works. I would prefer a solution that didn't involve so much copying, but I'm not going to worry about optimizing that now. R=brettw BUG=10041 TEST=none Review URL: http://codereview.chromium.org/126286 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18747 0039d316-1c4b-4281-b951-d872f2087c98
* Try to even the page cycler tests between the current build and reference ↵thomasvl@chromium.org2009-06-181-9/+94
| | | | | | | | runs. Since the reference run always comes second, it seems like it gets the UBC advantage and everything is a little after (when using two of the same builds). So try to load all the needed data into the UBC before we start the tests. Review URL: http://codereview.chromium.org/131057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18745 0039d316-1c4b-4281-b951-d872f2087c98
* Remove tooltip from page_action and just use the name as the tooltip. We ↵finnur@chromium.org2009-06-171-2/+1
| | | | | | | | don't seem to have a need for having the name and the tooltip be separate. Review URL: http://codereview.chromium.org/125264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18642 0039d316-1c4b-4281-b951-d872f2087c98
* Add a helper on mac for collecting memory size info from a list of processes.thomasvl@chromium.org2009-06-173-0/+101
| | | | | | | | | | | Spawn PS to collect the data and parse the output. Add ifdef checks in the page cyclers so on mac we can use the other helper since base methods can't ever be made to work. BUG=none TEST=memory info should now show in the waterfall and on the perf graphs for the page cycler tests. Review URL: http://codereview.chromium.org/125254 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18635 0039d316-1c4b-4281-b951-d872f2087c98
* Consistently use int64 for integers holding number of milliseconds.phajdan.jr@chromium.org2009-06-171-2/+1
| | | | | | | | | | This applies only to things which use TimeDelta::InMilliseconds, because it returns int64. Before this patch callers static_casted that to int, and after this patch they use the returned value as int64. Review URL: http://codereview.chromium.org/126279 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18626 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when the ThumbnailGenerator.brettw@chromium.org2009-06-171-0/+4
| | | | | | | | | | This happens when the ThumbnailGenerator is initialized because the NotificationService doesn't exist yet. This patch adds a function that TabContentscalls to make sure it is registered to avoid this problem. Review URL: http://codereview.chromium.org/126239 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18572 0039d316-1c4b-4281-b951-d872f2087c98
* Raise the rlimit in the page cycler so we don't have to adapt a new ↵thomasvl@chromium.org2009-06-161-7/+59
| | | | | | | | | | | | reference build which would change the baseline on lot of tests and not just the page cycler. Enable the intl* tests on mac. TEST=the intl page cycler tests will run and also the reference version will. BUG=8390 Review URL: http://codereview.chromium.org/125210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18558 0039d316-1c4b-4281-b951-d872f2087c98
* submitted on behalf of rogerta (Roger Tawa).rafaelw@chromium.org2009-06-162-0/+84
| | | | | | | | | | Original issue: http://codereview.chromium.org/119325 r=rafaelw,Jói,stoyan,aa Review URL: http://codereview.chromium.org/125206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18555 0039d316-1c4b-4281-b951-d872f2087c98
* UI test for <video>hclam@chromium.org2009-06-162-0/+46
| | | | | | | | | | Simple ui test that goes through some test clips. TEST=MediaTest.* Review URL: http://codereview.chromium.org/125173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18550 0039d316-1c4b-4281-b951-d872f2087c98
* Adds kind-of-live thumbnail generation for a potential tab switcher.brettw@chromium.org2009-06-161-0/+4
| | | | | | | | | | | | | | | | | | | | This listens to tab events and tries to keep thumbnails ready to go. See thumbnail_generator.cc for a more detailed design. This adds a painting observer to the RenderWidgetHost to enable this new behavior, as well as a notification to allow the thumbnail generator to hook its observer in. There is also a new notification that a backing store has been disabled, which required making the backing stores know about their owning widget hosts. This component is currently disabled. We just need to uncomment the member in Profile and it will start to work. Original review: http://codereview.chromium.org/118420 Review URL: http://codereview.chromium.org/126101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18540 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18512 - Revert 18373 Consider a redirect following user gesture as ↵laforge@chromium.org2009-06-169-28/+225
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | userinitiated in maintaining navigation entries. Also, ignore redirect or machineinitiated new subframe navigations. The current code treats all redirects as machineinitiated in processing navigation to a new page (to fix Bugs 9663 and 10531). This is not always appropriate, because some sites, e.g., www.google.com/ig, use redirect to implement userinitiated navigation (Bug 11896). This change assumes that a machineinitiated redirect happens within 300ms since the last document load was completed, while a userinitiated one happens later. This assumption is not always correct, e.g., a user may cause transition within 300ms. But I cannot think of any better ways to tell if a redirect is machine initiated or userinitiated. I believe this change works good enough, at least better than the status quo. Review URL: http://codereview.chromium.org/115919 TEST=Open http://www.hp.com and observe it redirects to http://www.hp.com/#Product . Hit Back button and observe the former URL is not visited. Open http://www.google.com/ig and click tabs inside the page, and try hitting Back and Forward to see if the navigation is right. Open http://www.google.com/codesearch, search for something, click on a result item, and try hitting Back. BUG=11896,12820 TBR=yuzo@chromium.org Review URL: http://codereview.chromium.org/125202 TBR=laforge@chromium.org Review URL: http://codereview.chromium.org/126221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18522 0039d316-1c4b-4281-b951-d872f2087c98
* Remove type from page action manifest, since we are ignoring that value ↵finnur@chromium.org2009-06-161-2/+1
| | | | | | | | | | | | anyway at the moment. TBR=aa BUG=None TEST=None (RSS page action should work as before) Review URL: http://codereview.chromium.org/126214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18521 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18373 - Consider a redirect following user gesture as userinitiated ↵laforge@chromium.org2009-06-169-225/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | in maintaining navigation entries. Also, ignore redirect or machineinitiated new subframe navigations. The current code treats all redirects as machineinitiated in processing navigation to a new page (to fix Bugs 9663 and 10531). This is not always appropriate, because some sites, e.g., www.google.com/ig, use redirect to implement userinitiated navigation (Bug 11896). This change assumes that a machineinitiated redirect happens within 300ms since the last document load was completed, while a userinitiated one happens later. This assumption is not always correct, e.g., a user may cause transition within 300ms. But I cannot think of any better ways to tell if a redirect is machine initiated or userinitiated. I believe this change works good enough, at least better than the status quo. Review URL: http://codereview.chromium.org/115919 TEST=Open http://www.hp.com and observe it redirects to http://www.hp.com/#Product . Hit Back button and observe the former URL is not visited. Open http://www.google.com/ig and click tabs inside the page, and try hitting Back and Forward to see if the navigation is right. Open http://www.google.com/codesearch, search for something, click on a result item, and try hitting Back. BUG=11896,12820 TBR=yuzo@chromium.org Review URL: http://codereview.chromium.org/125202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18512 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies in chrome/browser/phajdan.jr@chromium.org2009-06-161-0/+1
| | | | | | | | In my scan of headers I got up to browser/gtk/ Review URL: http://codereview.chromium.org/126131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18500 0039d316-1c4b-4281-b951-d872f2087c98
* Removes entirely dead code paths related to ConstrainedWindows.erg@chromium.org2009-06-166-139/+1
| | | | | | | | | | - Removes parts of the interface that probably made sense at some time, but now only have a DLOG(INFO) as their implementation. Also remove their callers. - Remove all usage of the ConstrainedWindowProxy interface in the automation system. It was *never* used. - Rename constrianed_window_impl_interactive_uitests.cc to blocked_popup_container_interactive_uitest.cc. The test case hasn't tested code in constrained_window_impl.cc since the rewrite of the blocked popup system back last autumn. Review URL: http://codereview.chromium.org/125160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18498 0039d316-1c4b-4281-b951-d872f2087c98
* Fix up the sprintf to properly mark the string as a wide string.thomasvl@chromium.org2009-06-161-1/+1
| | | | | | Review URL: http://codereview.chromium.org/125191 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18493 0039d316-1c4b-4281-b951-d872f2087c98
* Bring url_fetch_test into compiling shape on mac/linux.thomasvl@chromium.org2009-06-161-6/+5
| | | | | | Review URL: http://codereview.chromium.org/126072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18488 0039d316-1c4b-4281-b951-d872f2087c98
* Close all browsers during InProcessBrowserTest cleanup, not just the main one.erikkay@google.com2009-06-162-33/+6
| | | | | | | | | | BUG=none TEST=ExtensionViewTest.Incognito Review URL: http://codereview.chromium.org/126175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18466 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily break the purify bot again so that I can get logaa@chromium.org2009-06-161-3/+0
| | | | | | | | entries needed to permanently fix. Review URL: http://codereview.chromium.org/125162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18462 0039d316-1c4b-4281-b951-d872f2087c98
* Enabling the tests after sgk reverted CL18441.anantha@chromium.org2009-06-161-2/+2
| | | | | | Review URL: http://codereview.chromium.org/125165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18461 0039d316-1c4b-4281-b951-d872f2087c98
* Move automated_ui_test_test to ui_tests from a library so it actually gets run.dkegel@google.com2009-06-162-4/+17
| | | | | | | | | | | Trivial tweaks to get most of it to build on Linux. BUG=none TEST=run ui_tests --gtest_filter=AutomatedUITestBase, verify that six to eight are enabled and all pass Review URL: http://codereview.chromium.org/125142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18460 0039d316-1c4b-4281-b951-d872f2087c98
* Disabled mini_installer tests to investigate the failures.anantha@chromium.org2009-06-151-2/+2
| | | | | | Review URL: http://codereview.chromium.org/125157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18448 0039d316-1c4b-4281-b951-d872f2087c98
* Start to get memory test compiling on mac & linux.thomasvl@chromium.org2009-06-151-20/+43
| | | | | | | | | | | | Block some memory checks with #if defined(win) to get things compiling. Switch some things over to file paths. Test doesn't work yet, but this atleast gets it compiling/linking now. TEST=none BUG=14098 Review URL: http://codereview.chromium.org/125124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18418 0039d316-1c4b-4281-b951-d872f2087c98
* Converting the RSS subscription page to use a background page, as opposed to ↵finnur@chromium.org2009-06-152-83/+81
| | | | | | | | | | | a toolstrip (since it has no toolstrip UI). BUG=None TEST=The RSS page action should work as before and should not take up any real estate in the toolstrip. Review URL: http://codereview.chromium.org/126143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18412 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable a failing test under Purify to green the tree. This ↵erikkay@google.com2009-06-151-0/+3
| | | | | | | | | | | | | | | change should be rolled back ASAP (when the underlying bug is fixed). BUG=crbug.com/14103 TEST=ExtensionsServiceTest.PackExtension under purify TBR=aa Review URL: http://codereview.chromium.org/125134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18392 0039d316-1c4b-4281-b951-d872f2087c98
* Use V8 benchmark suite version 4 on the buildbots.ager@chromium.org2009-06-1511-2536/+476
| | | | | | | BUG=12674 Review URL: http://codereview.chromium.org/126126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18384 0039d316-1c4b-4281-b951-d872f2087c98
* Consider a redirect following user gesture as user-initiated in maintainingyuzo@chromium.org2009-06-159-28/+225
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | navigation entries. Also, ignore redirect- or machine-initiated- new subframe navigations. The current code treats all redirects as machine-initiated in processing navigation to a new page (to fix Bugs 9663 and 10531). This is not always appropriate, because some sites, e.g., www.google.com/ig, use redirect to implement user-initiated navigation (Bug 11896). This change assumes that a machine-initiated redirect happens within 300ms since the last document load was completed, while a user-initiated one happens later. This assumption is not always correct, e.g., a user may cause transition within 300ms. But I cannot think of any better ways to tell if a redirect is machine- initiated or user-initiated. I believe this change works good enough, at least better than the status quo. Review URL: http://codereview.chromium.org/115919 TEST=Open http://www.hp.com and observe it redirects to http://www.hp.com/#Product . Hit Back button and observe the former URL is not visited. Open http://www.google.com/ig and click tabs inside the page, and try hitting Back and Forward to see if the navigation is right. Open http://www.google.com/codesearch, search for something, click on a result item, and try hitting Back. BUG=11896,12820 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18373 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed 3 tests that failed in hebrew enabled vistahbono@chromium.org2009-06-154-1/+41
| | | | | | | | | | | | | | | | | | | | | | | | | BrowserTest.NoTitle BrowserTest.Title AutomationProxyVisibleTest.WindowGetViewBounds Some notes : There has been a small regression in the UI tests which makes them get stuck even more on my very slow machine (maybe race conditions) however, the fixes i post here do not make this state any worse and fix these 3 tests above which always failed TEST=1. run ui_tests on a RTL windows (or use --extra-chrome-flags=--lang=he) 2. the 3 tests listed above will always fail, as they expect LTR behavior 3. this fixes it BUG=12636 http://code.google.com/p/chromium/issues/detail?id=12636 Original Patch by Yoav Zilberberg <yoav.zilberberg@gmail.com> Original review: http://codereview.chromium.org/118441 R=me,jeremy,sky Review URL: http://codereview.chromium.org/125036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18370 0039d316-1c4b-4281-b951-d872f2087c98
* Wean activex_shim from urlmon.lib:sgk@google.com2009-06-141-2/+2
| | | | | | | | | | | | | | Remove urlmon.lib from activex_shim's AdditionalDependencies. Add urlmon.lib to AdditionalDependencies in chrome_dll.vcproj and unittests.vcproj. Add activex_shim as a dependency of default_plugin, so the things that link against default_plugin get urlmon.lib from the activex_shim link_settings. BUG=none TEST=none Review URL: http://codereview.chromium.org/126103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18366 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r18359.sgk@google.com2009-06-141-2/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/125106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18360 0039d316-1c4b-4281-b951-d872f2087c98
* Convert chrome.dll to gyp generation.sgk@google.com2009-06-141-2/+2
| | | | | | | | | | | | | | | | Remove unnecessary addition of urlmon.lib to AdditionalDepenedencies of activex_shim. Add activex_shim as a dependency of default_plugin (so the things that link against it get urlmon.lib from the link_settings of activex_shim). Add urlmon.lib to AdditionalDependencies in unittests.vcproj (which is going away soon, but this makes the transition smooth). BUG=none TEST=none Review URL: http://codereview.chromium.org/126073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18359 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r18354.sgk@google.com2009-06-131-2/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/125100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18355 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary addition of urlmon.lib to AdditionalDependenciessgk@google.com2009-06-131-2/+2
| | | | | | | | | | | of activex_shim. Add it as a dependency of default_plugin. Add urlmon.lib to AdditionalDependencies in unittests.vcproj (going away soon, but this makes the transition smooth). BUG=none TEST=none Review URL: http://codereview.chromium.org/125099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18354 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies in browser/phajdan.jr@chromium.org2009-06-131-0/+1
| | | | | | | | | | | | - remove unneeded header includes - move implementation bits out of headers - more explicit header deps In my scan of headers I got up to (including) dom_ui. Review URL: http://codereview.chromium.org/126071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18353 0039d316-1c4b-4281-b951-d872f2087c98
* Change extension id format back to mp-decimal, and change theaa@chromium.org2009-06-1332-38/+32
| | | | | | | | length to 32 chars (exactly 128 bits). Review URL: http://codereview.chromium.org/126074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18351 0039d316-1c4b-4281-b951-d872f2087c98
* Verify signed .crx extension installationsrafaelw@chromium.org2009-06-1224-14/+31
| | | | | | | | | | | | | | | This is second try of: http://codereview.chromium.org/115682 that was comitted in in 18189 and reverted. BUG=12114 R=erikkay,wtc,aa Review URL: http://codereview.chromium.org/126014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18316 0039d316-1c4b-4281-b951-d872f2087c98
* DEPS cleanup.thestig@chromium.org2009-06-121-3/+0
| | | | | | Review URL: http://codereview.chromium.org/118317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18312 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the focus manager to not subclass HWNDs (but for the ↵jcampan@chromium.org2009-06-121-0/+2
| | | | | | | | top-windows).Components that have HWND now need to specifically let the FocusManager know when they get the native focus.This is the reason for the new GotFocus() notification on the RenderWidgetHostViewWin class.BUG=NoneTEST=Run the interactive tests, the unit-tests. Test that the focus is remembered correctly when switching windows, switching tabs. Test that focus traversal in the browser and in the option dialog works as expected. Review URL: http://codereview.chromium.org/122002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18301 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: refactor zygote supportagl@chromium.org2009-06-122-46/+40
| | | | | | | | | | | | | | | | | | | http://code.google.com/p/chromium/wiki/LinuxZygote * Move Chrome specific bits out of base * Move away from the idea of reserved file descriptors (which don't really work with zygotes) * Load resources before forking renderers (means that we don't need communication between the zygote process and the renderers) * Make sure that gdb works against the browser again * Make sure that we have different ASLR between the renderers and the browser. http://codereview.chromium.org/119335 (This is a reland. First landed in r18109, reverted in r18112.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18291 0039d316-1c4b-4281-b951-d872f2087c98
* Make the logging dir on mac write outside the bundle in debug, this makes ↵thomasvl@chromium.org2009-06-121-13/+20
| | | | | | | | | | | | | | | | the file easier to find, and for unittests that try to scan it (like tab_switching), they then don't have to walk into the bundle. Compile tab_switching_test on mac/linux. Add a dep for app to tab_switching_test so building it also make sure the app is built (since it runs the app) Update tab_switching_test Use FilePath in all cases instead of wstring. Limit how long it will spin looking for the log log file so the test can't hang. TEST=the new test is built on mac/linux BUG=none Review URL: http://codereview.chromium.org/126049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18277 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tab dragging test in automated UI test.huanr@chromium.org2009-06-126-122/+312
| | | | | | Review URL: http://codereview.chromium.org/119394 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18271 0039d316-1c4b-4281-b951-d872f2087c98
* Allow external hosts to handle the context menu and thus be able to ↵ananta@chromium.org2009-06-123-0/+21
| | | | | | | | | | | | | | | | | | | | customize it. Changes include 1. A HandleContextMenu function which can be implemented by a TabContentsDelegate. Currently only ExternalTabContainer implements this. 2. Removed InitMenu calls from the RenderViewContextMenu subclass constructors, We need the subclasses to be able to override individual AddMenuItem calls. The newly added RenderViewContextMenuExternalWin class derives from RenderViewContextMenuWin whose constructor calls InitMenu. This happens at a time when the vtable is not yet setup. To fix this we added an Init function to the RenderViewContextMenu base class which then calls a virtual function DoInit, which derived classes can override to perform specific initializations. 3. Added automation messages to send over context menu events to external hosts and back amit, please review everything. estade please review changes to tab_contents_view_gtk.cc and render_view_context_menu_gtk.cc. pinkerton please review changes to tab_contents_view_mac.mm and render_view_context_menu_mac.mm Review URL: http://codereview.chromium.org/119429 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18250 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak in my interstitial page test.willchan@chromium.org2009-06-121-13/+0
| | | | | | | | | | Re-enable leaky web_contents_unittest.cc interstitial test. Remove purify suppressions for leaky test. BUG=http://crbug.com/13937 Review URL: http://codereview.chromium.org/125033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18246 0039d316-1c4b-4281-b951-d872f2087c98
* Add known purify test failures.willchan@chromium.org2009-06-121-0/+13
| | | | | | | | | BUG=http://crbug.com/13937 TBR=erikkay Review URL: http://codereview.chromium.org/126022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18235 0039d316-1c4b-4281-b951-d872f2087c98
* Added another command line option to run the tests after profile backup.anantha@chromium.org2009-06-117-30/+83
| | | | | | | Also, Changed the hardcoded build labels (1.0, 2.0) to (2.0, 3.0). Review URL: http://codereview.chromium.org/118463 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18214 0039d316-1c4b-4281-b951-d872f2087c98
* Compile sunspider on mac and linux.thomasvl@chromium.org2009-06-111-2/+8
| | | | | | Review URL: http://codereview.chromium.org/126003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18201 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "BUG=12114"tc@google.com2009-06-1122-31/+14
| | | | | | | | | | | This reverts commit r18189. TBR=rafaelw Review URL: http://codereview.chromium.org/125004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18193 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-30 17:51:36 +0000