| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
plumbing"
This reverts commit b1e231ca824b2fb9a96bffc04f26eae336ff6ed5.
Also disable the transaction_get.html test, added in this CL.
BUG=
TEST=
Review URL: http://codereview.chromium.org/3466018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(depends on https://bugs.webkit.org/show_bug.cgi?id=44700)
TEST=IndexedDBBrowserTest.TransactionGetTest
This takes over http://codereview.chromium.org/3310022/show
Review URL: http://codereview.chromium.org/3394007
TBR=andreip@chromium.org
Review URL: http://codereview.chromium.org/3405031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(depends on https://bugs.webkit.org/show_bug.cgi?id=44700)
TEST=IndexedDBBrowserTest.TransactionGetTest
This takes over http://codereview.chromium.org/3310022/show
Review URL: http://codereview.chromium.org/3394007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The omnibox requires that it is focused before text input to it will
kick off the autocompletion providers. We add code
(edit->WaitForFocus()) to the test to wait for the focus to be obtained
before setting the omnibox’s text input and proceeding with the rest of
the test.
BUG=19876
TEST=Existing
Review URL: http://codereview.chromium.org/3348021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change checks the states of ctrl and shift keys when proceesing acclerators to prevent FocusManager from consuming ctrl+alt keys and shift+alt keys. Windows sends SC_KEYMENU commands not only when we type only an alt key but also when we type ctrl+alt keys and shift+alt keys, both are used for changing input languages and keyboard layouts. To prevent these keys from being accidentally consumed by FocusManager, we check the states of these keys and send them to FocusManager.
BUG=45091
TEST=interactive_ui_tests.exe --gtest_filter=KeyboardAccessTest.TestShiftAltMenuKeyboardAccess.
Review URL: http://codereview.chromium.org/3318022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
string_split.h
BUG=None
TEST=trybos
Review URL: http://codereview.chromium.org/3447008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
None of these crashes are new, but they didn't show up for the continuous build because of a chromebot bug.
Created bugs 56747, 56749, 56750 for these entries.
Review URL: http://codereview.chromium.org/3402029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The reason these tests were failing on the Mac is that they test something that the Mac explicitly doesn't support: opening a new window in the existing browser process by re-running from the command line. This ifdefs out the tests that don't apply to the Mac, and the helper method that they are built on so that new tests using it won't accidentally be run on the Mac.
BUG=45108
TEST=N/A
Review URL: http://codereview.chromium.org/3394018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Chromeos machine might not have enough space in /tmp/
BUG=crosbug.com/6856
TEST=
Review URL: http://codereview.chromium.org/3496004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
data dir.
BUG=None
TEST=Less flake, I hope.
Review URL: http://codereview.chromium.org/3443021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it possible for new tab replacement extensions to recreate the same
app launch experience as the built-in NTP (pinned tabs, launch containers,
etc.)
Also add the extension version to data we report about extensions via
the management API.
BUG=56325,55474
TEST=An extension using chrome.experimental.management.launchApp(<id>) should
work to launch an app the same way that app gets launched from the built-in
new tab page.
Review URL: http://codereview.chromium.org/3381019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NPAPI tests aren't currently runable under valgrind on the Mac.
TBR=atwilson
BUG=30661
TEST=Greener valgrind bots
Review URL: http://codereview.chromium.org/3400021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=45882
TEST=Test passes on Mac.
Review URL: http://codereview.chromium.org/3421031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Step 2: add a browsing data helper for indexed databases.
BUG=56248
TEST=CannedBrowsingDataIndexedDBHelperTest.*,BrowsingDataIndexedDBHelperTest.*
Review URL: http://codereview.chromium.org/3468007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This follows the pattern used by other chrome ui tests (desktopui_UITest, desktopui_BrowserTests).
Tests are run as user chronos (not as root) and drive chrome with a clean profile dir per test.
BUG=crosbug.com/4938, crosbug.com/1504
TEST=sh run_remote_tests.sh --remote=<remote> desktopui_PyAutoFunctionalTests
Review URL: http://codereview.chromium.org/3412026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Aside from reducing duplicated logic, I intend to change the
behavior of this (newly refactored) function.
BUG=46246
Review URL: http://codereview.chromium.org/3475008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=53495
TBR=mpcomplete@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
If a chrome test that uses a testserver were to crash, the testserver process ends up being orphaned, potentially affecting subsequent tests. This patch causes child processes of a test case to be killed along with the test case if it were to be abruptly terminated.
BUG=55808
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/3423012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=54955
TEST=PrefChangeRegistrarTest.*
Review URL: http://codereview.chromium.org/3304015
TBR=danno@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54955
TEST=PrefChangeRegistrarTest.*
Review URL: http://codereview.chromium.org/3304015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54833
TEST=none
Review URL: http://codereview.chromium.org/3417011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
AutoFill sync relies on the presence of a valid profile label. This change sets all profile labels prior to saving to the database.
BUG=56305
TEST=PersonalDataManager.*, manual test of creating a new profile, then checking the "Web Data" sqlite database to see that the profile label was set correctly.
Review URL: http://codereview.chromium.org/3471004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Merge Bookmark folders with different bookmarks
2. Merge different bookmark models moderately complex
3. Merge simple bookmark hierarchy subset under bookmark folder
Patch from Sunand Tullimalli <sunandt@chromium.org>.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3390012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm getting ready to run pyauto functional tests from autotest on chromeos.
Disabling tests that don't pass currently (and need investigation) to match
reality.
This leaves out around 100 tests which'll run and pass on chromeos.
BUG=crosbug.com/6856
TEST=
Review URL: http://codereview.chromium.org/3384018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also actually call the timeout initialization when running mini_installer_tests.exe.
BUG=0
TEST=0
Review URL: http://codereview.chromium.org/3447009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=55479
TEST=DontCreateIncognitoProfile
Review URL: http://codereview.chromium.org/3412005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Clang complained about this unused return value. Looks like a bug.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3343017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by Anna Popivanova <annapop@chromium.org>
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3424016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
'details' parameter
as if it was omitted.
BUG=55202
TEST=run browser_tests.exe --gtest_filter=SidebarApiTest.*
Manual test:
1. Open Developer Tools in any extension page.
2. Run the code
chrome.experimental.sidebar.getState(undefined,function(){})
(undefined can be replaced with null)
It should return the state of the sidebar in the current tab.
Review URL: http://codereview.chromium.org/3390015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When creating a context menu item from an extension, specifying one or more
patterns in the "targetUrlPatterns" should imply that your item only appears
on items with a matching link, and not in contexts that have no link (which
does not match, sort of by definition :) ).
BUG=49739
TEST=Follow steps in bug report.
Review URL: http://codereview.chromium.org/3420009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Skip registration screen when manifest is not defined or url is invalid.
BUG=http://code.google.com/p/chromium-os/issues/detail?id=6708, http://code.google.com/p/chromium-os/issues/detail?id=6749
TEST=Manual. Register screen is not shown when OEM customization is not specified. Additional system info is passed to register page.
Review URL: http://codereview.chromium.org/3459009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=thestig
BUG=25039
TEST=AutomationProxyTest.AppModalDialogTest
Review URL: http://codereview.chromium.org/3431015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3452015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeFrame rendered
pages. This allows a webpage to put up a confirmation dialog in its beforeunload handler
and potentially cancel the operation. We only support invoking unload handlers on the page
for IE full tab mode. To achieve this the active document handles the OLECMDID_ONUNLOAD
exec command which is passed by the DOCHOST to the object which allows us to potentially
cancel the operation.
Thanks to Stoyan for his help in authoring parts of this CL.
The AutomationMsg_RunUnloadHandlers message which is used only by ChromeFrame is now a sync
message which returns back a bool indicating whether the unload operation can be continued
or not. The ExternalTabContainer now implements the BeforeUnloadFired method in the
TabContentsDelegate and aborts the unload operation if the user chose to not proceed with
the unload.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=33200
Bug=33200
Test=Covered by existing unload event test. Will add a test which validates whether a page
can cancel the unload operation in a subsequent CL.
Review URL: http://codereview.chromium.org/3450014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
automation proxy interface.
BUG=52009
Review URL: http://codereview.chromium.org/3389016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
got reverted.
Added a media UI test case for fullscreen video implementation for Windows (which is not committed yet). However, it is currently disabled until the webkit patches are here.
Also changed the other cases in media_uitest.cc to stop using Sleep() in test code. Instead, NotificationObserver and NotificationRegistrar are used.
Thirdly, moved media_uitest.cc from ui_tests to interactive_ui_tests.
TEST=ui_tests, interactive_ui_tests
BUG=54838
Review URL: http://codereview.chromium.org/3407003
TBR=imcheng@chromium.org
Review URL: http://codereview.chromium.org/3448008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
functions in a js file. Also, removing media_uitest.cc which is now empty. (it was not removed on last commit due to some svn oddities)
BUG=none
TEST=MediaBrowserTest.*
Review URL: http://codereview.chromium.org/3454005
TBR=imcheng@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
webNavigation API.
Also, rewrite the onCommitted event such that AUTO_SUBFRAME events are also registered.
BUG=50943
TEST=WebNavigationEvents
Review URL: http://codereview.chromium.org/3383008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- during storing, all info in proxy config is serialized into a dictionary and persisted to device via SignedSettings::StoragePropertyOp
- during retrieving, value is retrieved from device via SignedSettings::RetrievePropertyOp and deserialized into proxy config
- modify API to return bool when setting proxy config from UI
- in DOMUI design, every interaction with the page triggers a call to update config in backend
- but, sometimes, the info is incomplete, e.g. single-proxy checkbox is checked but proxy server is still empty
- for such cases, config service caches the info (so that UI can get this info on the next Get), but doesn't activate or persist it, and returns false to UI
- wrote unittests for configuring socks proxy and bypass rules, serialize and deserialize, update unittest for code changes
- handle using stub implementation of libcros to make browser tests pass
BUG=chromium_os:5127
TEST=as owner, modify proxy config from UI, log out or reboot device, verify that proxy config is updated.
Review URL: http://codereview.chromium.org/3366028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
js file. Also, removing media_uitest.cc which is now empty. (it was not removed on last commit due to some svn oddities)
BUG=none
TEST=MediaBrowserTest.*
Review URL: http://codereview.chromium.org/3454005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3425009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MC_Merge_CaseInsensitivity_InNames, and fix test case
MC_BiDirectionalPushAddingBM, not to create bookmarkNode1 from bookmarkModel0.
Patch from Vivian Zhi <vivianz@chromium.org>.
BUG=NONE
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/3333030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a media UI test case for fullscreen video implementation for Windows (which is not committed yet). However, it is currently disabled until the webkit patches are here.
Also changed the other cases in media_uitest.cc to stop using Sleep() in test code. Instead, NotificationObserver and NotificationRegistrar are used.
Thirdly, moved media_uitest.cc from ui_tests to interactive_ui_tests.
TEST=ui_tests, interactive_ui_tests
BUG=54838
Review URL: http://codereview.chromium.org/3407003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change does not add support for displaying the keyboard. That will be provided (along with a more useful keyboard) in follow-up changes.
BUG=none
TEST=added new override test
Review URL: http://codereview.chromium.org/3362019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=55915
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
datatypes.
Some sync integration tests require functionality to enable or disable
sync for a given datatype.
BUG=55772,55650
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/3390007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ordering is not yet respected by all test runners.
BUG=0
TEST=0
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3400010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mpcomplete@chromium.org
BUG=53495
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59681 0039d316-1c4b-4281-b951-d872f2087c98
|