| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Add one for ChromeThreadTest_NotReleasedIfTargetThreadNonExistent_Test and remove the IEImporter one.
Review URL: http://codereview.chromium.org/372027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
selection on a find next.
BUG=20883
TEST=included
Review URL: http://codereview.chromium.org/335012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* event listener map rehash
* access pre check (restored because of bad merge in r30201)
BUG=23780, 26506
Landing for Vitaly.
Review URL: http://codereview.chromium.org/372018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The motivation is that this removes the sync IPC on every call to the spellchecker. Also, currently we spellcheck in the IO thread, which frequently needs to go to disk (in particular, the entire spellcheck dictionary starts paged out), so this will block just the single renderer when that happens, rather than the whole IO thread.
This breaks the SpellChecker class into two new classes.
1) On the browser side, we have SpellCheckHost. This class handles browser-wide tasks, such as keeping the custom words list in sync with the on-disk custom words dictionary, downloading missing dictionaries, etc. On Posix, it also opens the bdic file since the renderer isn't allowed to open files. SpellCheckHost is created and destroyed on the UI thread. It is initialized on the file thread.
2) On the renderer side, SpellChecker2. This class will one day be renamed SpellChecker. It handles actual checking of the words, memory maps the dictionary file, loads hunspell, etc. There is one SpellChecker2 per RenderThread (hence one per render process).
My intention is for this patch to move Linux to this new approach, and follow up with ports for Windows (which will involve passing a dictionary file name rather than a file descriptor through to the renderer) and Mac (which will involve adding sync ViewHost IPC callsfor when the platform spellchecker is enabled). Note that anyone using the platform spellchecker rather than Hunspell will get no benefit out of this refactor.
There should be no loss of functionality for Linux (or any other platform) in this patch. The following should all still work:
- dictionary is loaded lazily
- hunspell is initialized lazily, per renderer
- language changes work.
- Dynamic downloading of new dictionaries
- auto spell correct works (as well as toggling it).
- disabling spellcheck works.
- custom words work (including adding in one renderer and immediately having it take effect in other renderers, for certain values of "immediate")
TODO:
- move spellchecker unit tests to test SpellCheck2
- add sync IPC for platform spellchecker; port to Mac
- add dictionary location fallback; port to Windows
- remove SpellChecker classes from browser/
BUG=25677
Review URL: http://codereview.chromium.org/357003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=26749
Review URL: http://codereview.chromium.org/371006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
database and the autofill manager.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/360027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=26749
Review URL: http://codereview.chromium.org/360043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Use a test-specific subclass to isolate the stopgap use of 'ps'
to collect memory stats on Mac.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/342070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
UI for disabled extensions.
Also, desaturate the icons of disabled extensions to make them
look more disabledy.
BUG=25963
TEST=On the extensions page, disable an extension, then press
reload. You should see a greyscale version of the icon.
Review URL: http://codereview.chromium.org/360039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
toolsrip.
BUG=none
TEST=Manual testing on linux and windows.
Review URL: http://codereview.chromium.org/353025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/356003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
compile-time differences between Chrome Frame and Chrome.
Review URL: http://codereview.chromium.org/361023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
almost identical app menu.
This CL will toggle app menu depending on the status of toolbar.
- This is only for toolkit views build as gtk version does not toggle toolbar.
- The menu contnets are not fully sync'ed. We need some refactoring, when
we fully migrate to views.
Review URL: http://codereview.chromium.org/366010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=7228-7241
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/360037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=amit
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=rafaelw
BUG=None
TEST=This is fixing a test.
Review URL: http://codereview.chromium.org/367006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Yet I cannot delete AutomationProxyForExternalTab because it is used by extension_uitest.cc.
Enable some tests meanwhile - now they should be stable enough.
BUG=18797,24664
TEST=ui_tests ok
Review URL: http://codereview.chromium.org/339009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20793
TBR=dglazkov
Review URL: http://codereview.chromium.org/361013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
potentially hanging the interactive ui tests.
BUG=None
TEST=Run the interactive ui tests.
R=sky
Review URL: http://codereview.chromium.org/355024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use FilePath for real file paths.
- Use std::string for PathString on Windows as well
TODO in a separate CL:
- Get rid of PathString typedef completely and directly use std::string everywhere.
- Use wchar_t in syncapi.h/.cc and get rid of sync_char16.
TEST=Existing tests are sufficient since this CL does a lot of code refactoring.
BUG=26342
Review URL: http://codereview.chromium.org/340055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It doesn't yet work in full-browser scenario, but allows me
to write a simple test.
TEST=Covered by browser_tests.
BUG=21541
Review URL: http://codereview.chromium.org/341050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The browser processes gets the real process ids, so they look correct in the task manager. When it asks the zygote to reap a process, we use the process ids internal to the sandbox.
While we are at it, reap the sandbox process after it clones the zygote and figure out zygote's actual process id. Save the actual process id rather than that of the sandbox.
Original review: http://codereview.chromium.org/262020
This is try 2 - initialize the sandbox host and zygote for InProcessBrowserTest.
TBR=agl
BUG=20012, 20714, 23072
TEST=Process IDs for renderers should be correct in the task manager and you should be able to use the end process button to kill them.
Review URL: http://codereview.chromium.org/361002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original review: http://codereview.chromium.org/340057
TBR=mpcomplete@chromium.org
BUG=22103
TEST=Install a user script (such as from userscripts.org). You should get the extension install UI and the
script should show up in the extension management UI. It should also work, though some scripts use
Firefox-specific APIs and those won't work in Chromium.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Some devtool tests hang on Windows, one fails on Linux.
I need to investigate more.
BUG=None
TBR=rafael
Review URL: http://codereview.chromium.org/348067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
into problems when running several browser tests in the same process.
Turning previously failing tests on.
BUG=26540
TEST=Run the interactive UI tests on Windows and Linux.
Review URL: http://codereview.chromium.org/355014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26540
Review URL: http://codereview.chromium.org/341078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
document_idle."
Original code review: http://codereview.chromium.org/339064
BUG=26126
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Semantically, document-idle means "when the DOM is ready and layout has been idle for awhile", or more loosely, "as soon as we get around to it".
Right now this uses a simple heuristic. It injects scripts 200ms after DOMContentLoaded, or immediately after onload, whichever happens first.
BUG=26126
TEST=Manual. Extensions with content scripts should work.
Review URL: http://codereview.chromium.org/339064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
buildbot failures
Handle GTK enter and leave notification events and pass them to WebKit as
mouse move events. This prevents an HTML widget from staying in the mouseover
state when the cursor leaves the window. Add a new ui test that checks
the specific case that was broken by warping the mouse pointer inside and
outside the content area.
BUG=24660
TEST=ui_tests
patch by Dominic Mazzoni <dmazzoni [at] google>
original review: http://codereview.chromium.org/274010/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Need to add theme resources to this binary as well. Missed
in r30755.
TBR=rafael
Review URL: http://codereview.chromium.org/348049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This gives us one less file to load on startup. This does mean
that some tests need to explicitly include theme_resources.rc.
BUG=24035
Review URL: http://codereview.chromium.org/348033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25822
TEST=none
Review URL: http://codereview.chromium.org/343067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26506
TEST=None
Review URL: http://codereview.chromium.org/343085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/345039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebKit as "
This reverts http://src.chromium.org/viewvc/chrome?view=rev&revision=30726
TBR=estade
Review URL: http://codereview.chromium.org/343080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mouse move events. This prevents an HTML widget from staying in the mouseover
state when the cursor leaves the window. Add a new ui test that checks
the specific case that was broken by warping the mouse pointer inside and
outside the content area.
BUG=24660
TEST=ui_tests
patch by Dominic Mazzoni <dmazzoni [at] google>
original review: http://codereview.chromium.org/274010/show
Review URL: http://codereview.chromium.org/354010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently lengthReceived always has the same value as dataLength when Safari calls ResourceHandle::didReceiveData. In Chrome expected content length is passed as lengthReceived parameter which leads to incorrect content length to be stored in InspectorResource. InspectorResource expects lengthReceived to be the length of current data chunk(see InspectorResource::addLength). So I changed lengthReceived parameter to be dataLength.
Darin, I see your TODO comment at line 581 in http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/weburlloader_impl.cc?annotate=6296 (the comment was deleted later) so I think you are right person to review the change in weburlloader_impl.cc. Please look at weburlloader_impl.cc and feel free to leave devtools specific changes to Alex and Pavel.
BUG=25213
TEST=DevToolsSanityTest.TestResourceContentLength
Review URL: http://codereview.chromium.org/295041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The test hangs and/or crashes with both Valgrind tools we use.
BUG=25917,22608
Review URL: http://codereview.chromium.org/351006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=dank
Review URL: http://codereview.chromium.org/353004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ChromeThread instead.
BUG=25354
Review URL: http://codereview.chromium.org/342068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I'm submitting this as a separate CL so that the binary file lands and
that I can get good try server results.
TBR=mpcomplete
Review URL: http://codereview.chromium.org/339091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This re-plumbs the existing "TooNew" codepath to handle arbitrary error messages.
BUG=25822
TEST=Make your history files non-readable, run Chrome (Release), make sure you get a warning dialog.
Review URL: http://codereview.chromium.org/342048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
NPP_Destroy.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/338050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/340041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
permitting the tests to be run regardless of the underlying platform. Also some minor fixes and cleanup.
BUG=none
TEST=none
Original review at: http://codereview.chromium.org/329037
Review URL: http://codereview.chromium.org/345027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The functionality in the listen tests was added to the primary API tests when they were rewritten to be event driven.
TEST=ExtensionApiTest.History
BUG=none
Review URL: http://codereview.chromium.org/341047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30563 0039d316-1c4b-4281-b951-d872f2087c98
|