| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This file is not used in the test itself, but is referenced in a comment as
a reference "good" file in case the test fails (the test itself uses a hardcoded
SHA1 hash for speed/simplicity).
BUG=318373
R=gene@chromium.org
Review URL: https://codereview.chromium.org/64553007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutofillField
The rest of the Autofill code ignores this distinction, so no need to bother
with this extra, error-prone bookkeeping.
While here, also remove an obsolete hack.
BUG=none
TEST=none
R=estade@chromium.org
Review URL: https://codereview.chromium.org/69073003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This policy provider forwards its methods to a delegate policy provider, but
keeps its own state of initialization for each policy domain. This allows the
Profile PolicyService to have a ForwardingPolicyProvider instead of directly
reading from the platform provider, so that each Profile can be in a different
initialization state.
This means that the IsInitializationComplete() signal is now reliable and
never goes from "ready" to "not ready".
Also introduced a readiness signal for each domain at the SchemaRegistry.
This allows policy providers to determine when to reload based on the
availability of schemas for each component that supports policy.
All of that together means that the ManagedValueStoreCache (which implements
the API that allows extensions to read policy) can be greatly simplified, by
simply waiting for the IsInitializationComplete() signal before starting to
read policy values.
The SchemaRegistry updates also enable a similar simplification in the
ComponentCloudPolicyService, which will come later.
BUG=270667,108992,171477
Review URL: https://codereview.chromium.org/60823003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disable tests that no longer will work with Instant Extended. Most of these are
NTP4 tests that no longer make sense and should be deleted along with the rest
of NTP4 code. There are three actual test failures corresponding to an actual
bug or a bad interaction between the test and Instant Extended (all of these
have bugs filed for them).
(Note that this is split off from http://crrev.com/24733003.)
BUG=297915
Review URL: https://codereview.chromium.org/61003007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Apps that wish to enable the alwaysOnTop property for app windows must
now declare the "alwaysOnTopWindows" permission in their manifest.
This permission does not appear in install prompts.
BUG=314260, 171597
TEST=browser_tests (PlatformAppBrowserTest.WindowsApiAlwaysOnTop*).
Manual test: Create an app which does not specify this permission and
attempts to create a new window with the option enabled or calls
setAlwaysOnTop(true) on an existing window. The window should not be
always on top. The option should work for apps which do declare the
permission.
Review URL: https://codereview.chromium.org/68423003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
so that the rest of the change can be committed through CQ.
BUG=313797
NOTRY=true
TBR=asargent@chromium.org
Review URL: https://codereview.chromium.org/69953016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PolicyCertVerifier lives (at least partially) on IO to provide certificate trust anchors to the net subsystem.
The list of trust anchors is provided by the policy subsystem, which lives on UI.
On each usage of one of the trust anchors, the profile must be tainted by setting a specific Pref value, which must happen on UI.
There were several problems and bugs, all of which are solved with this CL:
- NetworkConfigurationUpdater keeps a PolicyCertVerifier* until destruction, although PolicyCertVerifier is invalidated earlier and destructed in parallel on IO.
- Instead of explicitly managing lifetime/dependencies, PolicyCertVerifier accesses ProfilePolicyConnector through a WeakPtr.
- Cyclic static dependency between ProfilePolicyConnector and PrefService.
- Each, the original profile and the OffTheRecordProfile (OTRProfile), have a separate PolicyCertVerifier instance. The ProfilePolicyConnector/UserNetworkConfigurationUpdater are shared however. This wasn't considered during the implementation of the latter. They only have a SetPolicyCertVerifier instead of a AddPolicyCertVerifier method.
- ProfilePolicyConnector stores a Profile* instead of a PrefService* .
This CL moves the certificate related parts out of ProfilePolicyConnector and puts them into a separate keyed service NetworkPolicyService (living on UI, taking care of syncing with IO) which is tightly coupled with the PolicyCertVerifier (purely living on IO).
The new dependencies are:
NetworkConfigurationUpdater --(Observer::OnTrustAnchorsChanged)-> NetworkPolicyService --(post to IO)-> PolicyCertVerifier --(run callback, post to UI)-> NetworkPolicyService
For a summary of the dependencies see the accompanying bug.
Depends on:
https://codereview.chromium.org/53923004/
BUG=312660, 77155
TBR=ben@chromium.org,jcivelli@chromium.org
Review URL: https://codereview.chromium.org/24153012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome_elf.dll is shipped in Chrome's version directory to
ease updates, and is loaded early in chrome.exe's lifetime
by making it a private assembly in a subfolder of
chrome.exe's folder (see
http://msdn.microsoft.com/library/aa374224.aspx).
BUG= http://crosbug.com/p/23889
Review URL: https://codereview.chromium.org/53793002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Code is based on TestingAutomationProvider::GetExtensionsInfo()
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/automation/testing_automation_provider.cc&l=3518-3584
BUG=220759
TEST=browser test, and manual testing
Review URL: https://codereview.chromium.org/70823002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is a browser test for the fix in https://codereview.chromium.org/69293008/.
BUG=282487
Review URL: https://codereview.chromium.org/70273002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=306137
Review URL: https://codereview.chromium.org/36073011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also fixes the idl parser and schema compiler to support arrays as return types.
BUG=179737
Review URL: https://codereview.chromium.org/57913004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL exposes the declarative WebRequest API to <webview>s.
This CL isolates rules registries on a per-<profile, embedder_process_id, webview_instance_id> tuple. For extensions, the pair <embedder_process_id, webview_instance_id> == <0, 0>.
Rules registries are now created on-demand rather than on creation of the RulesRegistryService. This is so that we only create rules registries for webviews if the webview adds rules. This also allows rules to be installed prior to initial navigation of a webview.
Sample code:
var webview = document.querySelector('webview');
var rule = {
conditions: [
new chrome.webViewRequest.RequestMatcher({ url: { hostSuffix: 'slashdot.org' } })
],
actions: [
new chrome.webViewRequest.CancelRequest()
]
};
webview.request.onRequest.addRules([rule])
BUG=273855
Review URL: https://codereview.chromium.org/28273006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We do not currently patch up the history correctly. Let's try to fix this by
just aborting prerenders which do this, rather than complicating the history
merge function. UMA will tell us if this is a problem and if this case turns
out to be important.
This does not affect the following:
- Calls to location.replace.
- <meta http-equiv=refresh> redirects with a timeout under 1 second.
- Code which sets location.href before the load event.
BUG=305660
TEST=PrerenderBrowserTest.PrerenderNewNavigationEntry
PrerenderBrowserTest.PrerenderLocationReplaceNavigateToFirst
PrerenderBrowserTest.PrerenderLocationReplaceNavigateToSecond
Review URL: https://codereview.chromium.org/68213005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
page (chrome://extensions page) to show it as disabled (not enable-bla) but still uninstallable.
BUG=307651
TEST=Set extension disable reason to 256 and watch the extension become disabled on the chrome://extensions page.
Review URL: https://codereview.chromium.org/59843014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When deleting individual history entries (using dropdown menu on desktop,
or the "X" button on mobile), the header for a day should be deleted at
as soon as the last entry for the day is deleted.
BUG=260823
TEST=See repro steps in bug.
R=sergiu@chromium.org
Review URL: https://codereview.chromium.org/68883002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The SchemaRegistry contains the components that the policy provider should load
policy for, as well as the expected policies and their types for each component.
Also killed the PolicyDomainDescriptor, which was a similar way of doing this
but had the problem of overlapping descriptors on shared policy providers.
BUG=270667
R=bartfab@chromium.org, jochen@chromium.org, kalman@chromium.org
Review URL: https://codereview.chromium.org/56623005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
If a password is submitted in an iframe, provisionally saved, and then the top frame navigates (live example is espn.com login), use the iframe form for saving.
BUG=282522
Review URL: https://codereview.chromium.org/64873002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem was that the test was waiting for any element to be deleted
from the DOM, but deleting a single history entry would result in several
DOM elements being deleted. The fix is to add a callback that is only
called when everything has been deleted.
BUG=242293
R=bauerb@chromium.org
Review URL: https://codereview.chromium.org/64123003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by:
$ git grep -l webkit/glue/webkit_glue.h > list.txt
$ for f in $(cat list.txt); do if ! grep -q 'PlatformFileInfoToWebFileInfo' $f ; then echo $f; fi; done
$ for f in $(cat list.txt); do if ! grep -q 'SetJavaScript' $f ; then echo $f; fi; done
BUG=None
TEST=unit_tests, content_unittests
R=thestig@chromium.org
TBR=joth,avi,jamesr
Review URL: https://codereview.chromium.org/59323005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Along the way, add FindVolumeInfoById() which will be used in
upcomig patches.
BUG=316077
TEST=none
R=kinaba@chromium.org
Review URL: https://codereview.chromium.org/68463002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=315884, 78045
TBR=owners
Review URL: https://codereview.chromium.org/67923002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
installed.
BUG=None
R=craigdh@chromium.org
Review URL: https://codereview.chromium.org/67483002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Asking for an available port and then using it later is a flaky pattern because
something else could use that port in the meantime.
This patch fixes the important cases by removing uses of GetAvailableLocalPort().
Remaining uses are mitigated by:
- Moving unavoidable uses of it as close to the use as possible.
- Renaming the method to GetUnreservedAvailableLocalPort().
BUG=304383
Review URL: https://codereview.chromium.org/67983002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
R=craigdh@chromium.org
TBR=navabi@chromium.org
Review URL: https://codereview.chromium.org/63373003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation for replacing "mount points" (paths like /Downloads)
with per-volume FileSystem objects.
BUG=316077
TEST=none
Review URL: https://codereview.chromium.org/66303002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reland of https://codereview.chromium.org/62713003/ - the original patch broke the Google Chrome OS official builder due to a missing dependency on the extensions api target in extensions/extensions.gyp.
* Move c/b/extensions/extension_process_manager.h to
extensions/browser/process_manager.h
* Rename ExtensionsProcessManager to ProcessManager
* Place it in the "extensions" namespace
BUG=313481
TEST=browser_tests, unit_tests
TBR=miket@chromium.org
Review URL: https://codereview.chromium.org/67253003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
reparented. Previously I assumed we didn't need to do this because new windows would get created when the constrained windows show up. But it turns out that for the find-bar case, the window will just be hidden if there's an existing find bar in another tab.
BUG=299224
TEST=see repro steps in comment 27 on the bug
R=ben@chromium.org
Review URL: https://codereview.chromium.org/67553003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
xvfb-run defaults to 8-bit framebuffers, which was causing problems for Aura.
BUG=316687
Review URL: https://codereview.chromium.org/67423003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=132674
Review URL: https://codereview.chromium.org/32223002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=275980
Review URL: https://codereview.chromium.org/34613015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This enables nacl_integration_tests to run via buildbot_nacl_integration.py
for Mac x86_64. It makes --bits work correctly on Mac, and allows the proper
--bits setting to be automatically detected based on the Chrome browser being
used for testing.
BUG=316401,316715
R=mseaborn@chromium.org
Review URL: https://codereview.chromium.org/67313002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
BUG=316933
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
It is failing flakily several times a day since Oct 30th.
BUG=316925
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
A number of tests including WebViewTest.Dialog_TestConfirmDialogDefaultGCCancel
no longer depend on running a test server and so they're far less likely to
time out. Renabling this test.
BUG=314809
Review URL: https://codereview.chromium.org/58953006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move FeatureSwitch to extensions/common/
Move the switches used in FeatureSwitch to extensions/common/switches.h (when necessary).
Update some uses of the switches to use feature switch instead of the commandline
BUG=159265
TBR=rdsmith@chromium.org (c/b/download)
TBR=sky@chromium.org (c/b/ui/, c/test/ui/)
Review URL: https://codereview.chromium.org/47923018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Compile error, runtime.h has moved?
> Move ExtensionProcessManager to src/extensions, part 4
>
> * Move c/b/extensions/extension_process_manager.h to
> extensions/browser/process_manager.h
> * Rename ExtensionsProcessManager to ProcessManager
> * Place it in the "extensions" namespace
>
> BUG=313481
> TEST=browser_tests, unit_tests
> R=miket@chromium.org
> TBR=sky@chromium.org for mechanical header file move affecting chrome/browser/
>
> Review URL: https://codereview.chromium.org/62713003
TBR=jamescook@chromium.org
Review URL: https://codereview.chromium.org/66213006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Move c/b/extensions/extension_process_manager.h to
extensions/browser/process_manager.h
* Rename ExtensionsProcessManager to ProcessManager
* Place it in the "extensions" namespace
BUG=313481
TEST=browser_tests, unit_tests
R=miket@chromium.org
TBR=sky@chromium.org for mechanical header file move affecting chrome/browser/
Review URL: https://codereview.chromium.org/62713003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://crrev.com/205027 changed the width of the entry times on
the history page. This causes the times to be ellipsized in e.g.
Arabic. However, if we go back to a fixed with of 90px, it looks
weird due to the extra whitespace allocate for the bookmark star.
The solution is to size the times dynamically, making them as wide
as the widest, up to a maximum of 90px.
BUG=304770
R=bauerb@chromium.org
Review URL: https://codereview.chromium.org/66673004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It required a dependency on webdriver which is better kept in the
downstream test.
BUG=None
TEST=None
NOTRY=True
Review URL: https://codereview.chromium.org/64713005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NetInternalsTest
BUG=315347
Review URL: https://codereview.chromium.org/64223004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> PPAPI: Add a test to make sure we detect crashes
>
> And bonus check that other tests *don't* crash. (Though it should be very rare that a test results in "PASS" and still crashes)
>
> Earlier patchsets have a fix for 244900, but we decided not to fix that. Because of 244900, we don't detect crashes on shutdown... so this doesn't actually cause test failures for 243118. But it's useful to make sure we don't regress on showing the infobar in crashes that happen prior to shutdown.
>
> BUG=244900,243118,247128
>
> Review URL: https://codereview.chromium.org/16114007
TBR=dmichael@chromium.org
Review URL: https://codereview.chromium.org/60733014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement fileSystemProvider.mount() that does not do anything meaningful
yet. The purpose of this patch is to add boilerplate files so adding new
code is easier.
Design doc of the API: http://goo.gl/lLXJYQ
BUG=248427
TEST=none
R=benwells@chromium.org, kinuko@chromium.org
TBR=thestig@chromium.org
# TBR thestig@ for chrome/renderer/resources/renderer_resources.grd
Review URL: https://codereview.chromium.org/50703013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Find privet destinations in print preview. Does not include actual printing or
capability fetching. Hidden behind --enable-privet-local-printing.
BUG=
Review URL: https://codereview.chromium.org/50493011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
And bonus check that other tests *don't* crash. (Though it should be very rare that a test results in "PASS" and still crashes)
Earlier patchsets have a fix for 244900, but we decided not to fix that. Because of 244900, we don't detect crashes on shutdown... so this doesn't actually cause test failures for 243118. But it's useful to make sure we don't regress on showing the infobar in crashes that happen prior to shutdown.
BUG=244900,243118,247128
Review URL: https://codereview.chromium.org/16114007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the LaunchContainer enum from
chrome/common/extensions/extension_constants.h's
extension_misc namespace to extensions/common/constants.h's
extensions namespace.
Also rename the LAUNCH_* values in the
ExtensionPref::LaunchType enum to LAUNCH_TYPE_* to make them
less likely to get confused with LaunchContainer's values.
BUG=313284
TBR=isherman@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/60353011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=315884
R=akalin@chromium.org, isherman@chromium.org, thestig@chromium.org, yzshen@chromium.org
TBR=piman, sergeyu
Review URL: https://codereview.chromium.org/65813002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the password bubble that pops up from the icon. These will replace the password infobar.
The code was previously nested in the code for the content settings but should be changed the functionality needed is too different and it is no content setting in any case.
To refactor this code, some of the code resembles the code used for the zoom icon and bubble.
Only the code for gtk and aura are refactored. The code for cocoa is removed for now and will be added again in another CL.
BUG=261628
Review URL: https://codereview.chromium.org/35333002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unreverts dump/import functionality for chrome://sync-internals, with fix for android.
Original review at https://codereview.chromium.org/60693002
BUG=309112
TBR=nyquist@chromium.org
Review URL: https://codereview.chromium.org/63603003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is a step towards reducing <webview> test flake.
BUG=none
TBR=fsamuel@chromium.org
Review URL: https://codereview.chromium.org/64803002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233674 0039d316-1c4b-4281-b951-d872f2087c98
|