| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2884054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3037034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
For this patch, I skipped over any instance where it wasn't a nearly trivial
change.
Review URL: http://codereview.chromium.org/3069014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on XP and Vista. Submitting without waiting for review, because the
"XP Perf (webkit.org)" is timing out because of this suite.
BUG=40123
TEST=none
TBR=chase@chromium.org
Review URL: http://codereview.chromium.org/3047026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r54235.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Flip the compile-time enable switch for speech input to on and add a
command-line switch to put the functionality behind. The command-line
flag will be used both on the Chromium side and in WebKit via
WebRuntimeFeatures.
This CL depends on the webkit patch https://bugs.webkit.org/show_bug.cgi?id=43146
BUG=none
TEST=browser_tests --gtest_filter=SpeechInputEnableSwitchTest.*
Review URL: http://codereview.chromium.org/3064017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=50548
Review URL: http://codereview.chromium.org/3043030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These are two common patterns in Chrome code: copying a
subset of switches from one CommandLine to another, and
appending a FilePath to a CommandLine. This sets me up
to do a lot more deprecation in a follow-up change.
Review URL: http://codereview.chromium.org/3012021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=brettw
Review URL: http://codereview.chromium.org/3061034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Separate all interactions with HistoryService out of DownloadManager
to new class DownloadHistory owned by the DownloadManager.
The goal is to create more smaller classes with clearly defined
responsibilities.
TEST=unit_tests, browser_tests, ui_tests
BUG=48913
Review URL: http://codereview.chromium.org/3071005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
unrelated file.
BUG=none
TEST=Test passes
Review URL: http://codereview.chromium.org/3029038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to net/test/test_server.h
No code changes, just a move.
TEST=none
BUG=49680
Review URL: http://codereview.chromium.org/3034038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=this is it
BUG=none
Review URL: http://codereview.chromium.org/3079006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Verifies the multiple downloads infobar.
Implemented by Venkat, who figured out how to reliably trigger the multiple
downloads infobar.
Review URL: http://codereview.chromium.org/3066017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
They don't work locally for me, and on the bots only Mac_Sandbox_Intentional_Leak3 is getting used, which is overly wide.
Review URL: http://codereview.chromium.org/2808079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=glider
BUG=42921
Review URL: http://codereview.chromium.org/3060027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2819063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3015026
TBR=dtseng@chromium.org
Review URL: http://codereview.chromium.org/3046031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3015026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The service will fetch tokens in the background and broadcast notifications after it's done.
Move some common constants out into a new file.
Modify TestNotificationTracker to support subclassing as it doesn't properly make a deep copy of notifications on the stack.
TEST=unit tests included
BUG=47093
Review URL: http://codereview.chromium.org/3024002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The python sync server does not support recursive deletion, as a result of which test cases that remove a directory of sync entries end up failing.
This checkin updates the sync server to support recursive deletion of sync entries and all their childen.
BUG=50306
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/3051019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3050018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
trybots.
BUG=46662
TBR=apatrick@chromium.org
Review URL: http://codereview.chromium.org/3072006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
tests.
BUG=46662
TEST=Manually test ui_tests.PepperTester.Pepper3D and npapi_pepper_test_plugin.
Review URL: http://codereview.chromium.org/3067007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3068004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3030022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's already enabled on windows by default. This of course applies only to the branded builds.
Also, make the path to imported pyauto binaries prettier by applying os.path.normpath
Change to chrome_switches.cc is to put a comment at the place where it belongs
Review URL: http://codereview.chromium.org/2873073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2857018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3007014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL includes:
1. Implementation of ui_test_utils_mac.mm
2. Fix for ui_controls_mac.mm
3. Port browser_keyevents_browsertest.cc to Mac and add some new tests for Mac.
4. Partially port browser_focus_uitest.cc to Mac, now can be compiled and run
on Mac but some tests fail.
5. Add two functions into ui_test_utils.h: HideNativeWindow() and
ShowAndFocusNativeWindow(). The latter one shows a window and grabs the input
focus, which is useful for tests depending on fake keyboard/mouse events.
Because browser_keyevents_browsertests.cc and browser_focus_uitest.cc
belong to interactive_ui_tests, which is not available on Mac (see
http://crbug.com/21276), in order to test them on Mac, you may want to
move them into browser_tests locally. But it won't work on build and try
bots, because these tests must be run with screen unlocked.
This CL depends on CL: http://codereview.chromium.org/2973004
and http://codereview.chromium.org/2805075
BUG=22515 Keyboard handling needs unit tests
BUG=48671 interactive_ui_test: BrowserKeyEventsTest.NormalKeyEvents is flaky
BUG=48936 Browser window is opened inactivated when running an InProcessBrowserTest.
TEST=none
Review URL: http://codereview.chromium.org/2986004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks.
r=jar
BUG=47469
Review URL: http://codereview.chromium.org/3032024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A field of the ViewHostMsg_Resource_Request structure was uninitialized.
Also, includes a fix for an ASSERT_EQ that listed the expected value second
instead of first.
R=oshima
BUG=50002
TEST=none
Review URL: http://codereview.chromium.org/3052014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3026016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add test register form page.
Added extra debug logging.
Full cycle:
1. Register screen navigates to chrome://register (host page).
2. host page requests DOMUI for register form URL: getRegistrationUrl msg on DOM load event.
3. Once URL is received it is loaded in an iframe.
4. When register form is loaded it sends get_user_info msg via postMessage to host page.
5. host page requests DOMUI for system/user info: getUserInfo msg.
6. Once info is received host page sends that to an iframe with set_user_info msg.
7. Register form notifies host page on registration success/skip status with complete_registration msg.
8. Based on registration result host page navigates to cros://register/[success|skipped] so that Out of box wizard is notified.
BUG= http://crosbug.com/4813
TEST=manual
Review URL: http://codereview.chromium.org/3058006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Several integration tests use the wrong method to wait for sync to complete, as a result of which they fail during verification.
Also making the condition for the detection of sync completion more robust.
BUG=50114
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/3037019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50273
TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux
TBR: erg
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sync integration tests currently use the method AwaitSyncCycleCompletion(), which ends up waiting for a sync event before it signals the end of a sync cycle. However, if it is called after the sync cycle is already complete, it ends up waiting for several seconds for a random unrelated sync event before it returns.
This checkin fixes this unnecessary delay by checking to see if the client has any unsynced items before it waits, thereby significantly speeding up the sync integration tests.
In addition to this, a new method called AwaitQuiescence() is now available to test cases so they can wait for racy updates initiated by multiple clients to propagate across the system.
BUG=49998
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/3041018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
because it is flaky.
TBR=jam
TEST=PPAPITest.Scrollbar
BUG=48544
Review URL: http://codereview.chromium.org/3028025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on Linux, because it is flaky.
TBR=estade
TEST=FastShutdown.SlowTermination
BUG=46614
Review URL: http://codereview.chromium.org/2825069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Prompts up the keychain dialog.
BUG=49378
Review URL: http://codereview.chromium.org/3040019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3055010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50061
TEST=reliability test passes.
Review URL: http://codereview.chromium.org/3070003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ThreadSanitizer since it contains harmful data races.
BUG=50217
TBR=glider
TEST=TSan/x64/FYI should become green
Review URL: http://codereview.chromium.org/3013032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3054004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50121
TBR=jvoung
Review URL: http://codereview.chromium.org/3030016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50002
TEST=none
Review URL: http://codereview.chromium.org/3009023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is same cause as 50002.
TBR=darin@chromium.org
BUG=50002
TEST=none
Review URL: http://codereview.chromium.org/3046019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3005028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
testFlashLoadsAfterKill
testBasics
testSingleFlashPluginProcess
Merge an old test into this.
Review URL: http://codereview.chromium.org/3051010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=50061
TEST=none
TBR=huanr
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53518 0039d316-1c4b-4281-b951-d872f2087c98
|