| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
measurements on OS X.
Right now, this only works for the current process; support for child processes will be added in a later CL.
BUG=13156,25454
TEST=Hook up task manager (connect menu item to commandDispatch:, give it the right tag). Stats for the browser process should now be right, and %cpu should be 0 (for now) for all other processes.
Review URL: http://codereview.chromium.org/500118
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/504068
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/505056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on OS X.
Right now, this only works for the current process; support for child processes will be added in a later CL.
BUG=13156,25454
TEST=Hook up task manager (connect menu item to commandDispatch:, give it the right tag). Stats for the browser process should now be right, and %cpu should be 0 (for now) for all other processes.
Review URL: http://codereview.chromium.org/500118
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/504068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
better support for x64 on Windows
TEST=none
BUG=29467
Review URL: http://codereview.chromium.org/501127
TBR=gregoryd@google.com
Review URL: http://codereview.chromium.org/500149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for x64 on Windows
TEST=none
BUG=29467
Review URL: http://codereview.chromium.org/501127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Right now, this only works for the current process; support for child processes will be added in a later CL.
BUG=13156,25454
TEST=Hook up task manager (connect menu item to commandDispatch:, give it the right tag). Stats for the browser process should now be right, and %cpu should be 0 (for now) for all other processes.
Review URL: http://codereview.chromium.org/500118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
correctly in IE. This was not
the case due to a race condition between put_src getting called for subsequent activex instances
and the external tab to hold the chrome frame instance getting created.
Fix is to pass in the URL if we have it when the automation client is initialized to launch the chrome
automation server. If not we navigate when the external tab is created. To achieve this we stuff in
all relevant parameters into a structure which is populated when the automation client is initialized.
I also changed the CreateExternalTab message to carry the referrer for the initial navigation.
Fixes http://code.google.com/p/chromium/issues/detail?id=28236
Test=added unit tests for the same. The firefox one is not working at this point. Disabled this test
for now while I debug it.
Bug=28236
Review URL: http://codereview.chromium.org/500123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.FLAKY_Bookmarks
Review URL: http://codereview.chromium.org/503053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(issue 29929).
Also, a little bit more UI polish:
Make sure really long titles don't destroy the layout of the subscribe page.
Move the Edit/Remove links closer to the combo box.
Add a link to the feed page so that people with desktop feed readers can get at the url.
BUG=http://crbug.com/29929
TEST=See bug 29929.
Review URL: http://codereview.chromium.org/500131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/505051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=30488
TEST=N/A
Review URL: http://codereview.chromium.org/501074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After r34888, there were two warm/t traces. Rename
the latter to be extension_empty to match the other
extension-related traces.
BUG=22287
TEST=mac startup perf goes green
Review URL: http://codereview.chromium.org/506067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Uninstall themes when all theme infobars are gone; not on each infobar's destruction.
There are multiple problems with the current implementation:
- It handles multiple tabs with theme install infobars badly.
- It has a subtle race condition where installing a second theme, and then
installing the original theme (note: not clicking undo) uninstalled both
themes.
Instead, only uninstall unused themes when all infobars are closed down.
BUG=none
TEST=Install theme A. Install theme B. Install theme A. Restart chrome. Theme A should show.
TEST=Install theme A in window 1. Install theme B in window 2. Install theme C in window 3. Clicking undo in any of those windows in any order should work.
Previous Review URL: http://codereview.chromium.org/504052
Review URL: http://codereview.chromium.org/501096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are ui_test crashes with this change.
This reverts commit r34874.
TBR=mirandac
Review URL: http://codereview.chromium.org/502063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
destruction.
There are multiple problems with the current implementation:
- It handles multiple tabs with theme install infobars badly.
- It has a subtle race condition where installing a second theme, and then
installing the original theme (note: not clicking undo) uninstalled both
themes.
Instead, only uninstall unused themes when all infobars are closed down.
BUG=none
TEST=Install theme A. Install theme B. Install theme A. Restart chrome. Theme A should show.
TEST=Install theme A in window 1. Install theme B in window 2. Install theme C in window 3. Clicking undo in any of those windows in any order should work.
Review URL: http://codereview.chromium.org/504052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/22287
Review URL: http://codereview.chromium.org/505041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a bug causing the page action onClick handler not to work (only affects certain Linux builds that don't have PageAction popup support, all other builds use the Popup).
Added copyright header.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/500024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
revision 34593. The crash occured
while dereferencing an invalid g_current_plugin_instance global which points to the last plugin instance we
yield control to. We maintain a local global stack for this variable which ensures that it gets set and
reset correctly in nested invocations. Turns out that this broke in a recent change which caused the global
to not get reset at times, thus leading to a crash when it was dereferenced.
I also changed the code which maintains the local global stack in NativeWndProc to only do this before we invoke
the plugin wndproc via CallWindowProc. The other cases like ThrottleMessage don't need to do this as they don't
yield control to the plugin.
Fixes http://code.google.com/p/chromium/issues/detail?id=30607
Bug=30607
Review URL: http://codereview.chromium.org/503037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Otherwise, just load like normal on the UI thread.
BUG=24163
Review URL: http://codereview.chromium.org/502005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=30681
TEST=None
TBR=brettw
Review URL: http://codereview.chromium.org/504048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/30397
TEST=Valgrind should still be happy.
Review URL: http://codereview.chromium.org/502020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This reapplies 34794 and 34779 with one additional fix,
which were reverted by 34798.
TBR=mpcomplete@chromium.org
BUG=30507
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/30382
TEST=Valgrind mac should stay happy.
Review URL: http://codereview.chromium.org/506055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=30607
TBR=ananta
Review URL: http://codereview.chromium.org/504047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG= 30702
TEST= none
Review URL: http://codereview.chromium.org/506056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=stuartmorgan
BUG=30681
Review URL: http://codereview.chromium.org/503043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
since language detection is temporarily disabled.
BUG=30662
TEST=None
TBR=brettw
Review URL: http://codereview.chromium.org/504041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=30661
TEST=none
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/502049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=30661
TEST=none
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/503040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=30360
TEST=none
Review URL: http://codereview.chromium.org/503039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Patch from Thiago Farina <thiago.farina@gmail.com>.
Review URL: http://codereview.chromium.org/498002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=30360, 30366, 30367, 30370, 37371, 30373, 30375, 30378, 30379, 30381, 30382, 30384, 30386, 30390, 30391, 30392, 30393, 30394, 30396, 30397, 30398
TEST=None
Review URL: http://codereview.chromium.org/505001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mpcomplete@chromium.org
BUG=30507
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=30507
Review URL: http://codereview.chromium.org/500085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Right click on a link in CF and select "save link as". You should immediately get the host browser's download UI. Before there could be a significant wait before this happened.
BUG=23561
Review URL: http://codereview.chromium.org/506042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=30507
Review URL: http://codereview.chromium.org/504033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=N/A
Review URL: http://codereview.chromium.org/503029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Use _MSG_ format for manifest fields instead of hard-coded names.
2. Localize manifest during installation procedure -> save localized version to prefs.
3. Add current_locale field to manifest so we can detect when chrome locale changes and re-localize manifest.
4. Adds prefs method to MigratePrefs&Write to disk.
5. General refactor of extension_file_util wrt l10n code.
6. Don't localize themes (we can revert this by adding default_locale and current_locale keys to allowed keys for theme section).
BUG=27360
Review URL: http://codereview.chromium.org/434015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=30607
TBR=stuartmorgan
Review URL: http://codereview.chromium.org/504029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28977
TEST=unit tests still work
Review URL: http://codereview.chromium.org/504027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
as we do with the page indexing. (The language detection was
previously done on demand when the extension related API was querying it.)
Once detected the language is stored on the navigation entry.
It'll be used for the upcoming translation feature.
Also I moved the existing language detection from the UI to
the file thread.
The change required few changes for the
chrome.tabs.detectLanguage extension API to still work.
BUG=None
TEST=Run the browser tests and unit-tests.
Review URL: http://codereview.chromium.org/492024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
extension processes.
BUG=29621
Review URL: http://codereview.chromium.org/505012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
EditSearchEngineCocoaControllerTest.
BUG=30390,30392
TEST=Run unit_tests under Valgrind.
Review URL: http://codereview.chromium.org/507010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
implicit non-virtual public destructors.
Was originally:
Replace public nonvirtual destructors in classes with virtual members
with protected nonvirtual destructors where possible, and with
public virtual destructors where destruction of a derived class occurs.
(Excluding chrome/browser/...)
(Part 4 of http://www.gotw.ca/publications/mill18.htm
has a rationale for why public nonvirtual destructors in classes with
virtual members is dangerous.)
Patch by: Jacob Mandelson (jlmjln@gmail.com)
BUG=none
TEST=base_unittests & app_unittests
Review URL: http://codereview.chromium.org/200106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/30391
TEST=Valgrind passes.
Review URL: http://codereview.chromium.org/507012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
install time.
Same as previous patch, except we now have a
BrowserThemeProvider::GetDefaultDisplayProperty() so we don't have UMRs in
ntp_resource_cache.cc.
BUG=24493,21121
TEST=All the new unit tests pass. All the complex theme startup tests go faster.
Previous Review URL: http://codereview.chromium.org/460050
Review URL: http://codereview.chromium.org/499004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moves 'UseReferenceBuild' from NewTabUIStartupTest
into UITest. Run multiple tab switching tests for
the current and reference build. Locate the debug log
based on the current browser directory. Reformat the
output of the test so we print "times" as our test
type instead of "tab_switch" (probably requires a perf
dashboard update).
BUG=25200
TEST=tab switching test also tests reference build
Review URL: http://codereview.chromium.org/491090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR: viettrungluu@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34435 0039d316-1c4b-4281-b951-d872f2087c98
|