| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
which failed on XP Perf (single).
This reverts commit r28199.
TBR=tony
Review URL: http://codereview.chromium.org/265002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23043
TBR=senorblanco
Review URL: http://codereview.chromium.org/242169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TabContents sends a notification which is picked up by the browser
automation controller which keeps a map of events and times. Add
an automation IPC so that tests can get these values from the
browser automation controller. Finally, add a feature startup test
to collect these values.
This is just to get some consistent timings from the buildbot.
BUG=23120
Review URL: http://codereview.chromium.org/246105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
popup.
BUG=23833,23835
TEST=none
Review URL: http://codereview.chromium.org/259065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Shows a Gmail logo with a strike out diagonal line when not logged in.
- Allows the user to click on the BrowserAction to log in.
- If there are unread emails on login, the GMail logo blinks.
- Shows the number of unread emails as a Badge (red in color!).
- Shows the number of unread emails as a tooltip text if hovered on.
- When a new email comes, the GMail logo blinks and the badge text updates.
BUG=23898
TEST=none
Review URL: http://codereview.chromium.org/246093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23976
Review URL: http://codereview.chromium.org/257064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to the renderer so this instance is in the callstack, destruction will have to be asynchronous and so scripting still won't work. This change also fixes use of PluginChannel after it's deleted (if this was the last instance).
BUG=23713, 23706
TEST=added ui test
Review URL: http://codereview.chromium.org/258026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23269
TEST=load the test_browser_action sample extension, and click the browser action. Watch it dynamically update.
Review URL: http://codereview.chromium.org/242150
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23832
TBR=mpcomplete
Review URL: http://codereview.chromium.org/257056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of incrementing a static counter.
BUG=21281
TEST=Load an unpacked extension from chrome://extensions/ that
does not have an ID in its manifest. The resulting ID should
be random-looking, not something like "aaaaaa".
Review URL: http://codereview.chromium.org/256049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=successful builds
Review URL: http://codereview.chromium.org/256059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the ChromeFrame Active Document
server. This allows the document server to receive a number of menu events like Find, View->Text Size, etc.
Thanks to Stoyan for helping me debug this :)
Clicking on Edit->Find in the menu in IE with this causes IEFrame to call our Active document's Exec implementation
with the IDM_FIND command. The handling here is to invoke our default Find handling. Added support for
honoring user text size selections. The next thing to be done is to honor the current text size setting while
launching Chrome.
I also fixed the rgs files to have LF as the terminating character.
This fixes Bug http://code.google.com/p/chromium/issues/detail?id=23667
Bug=23667
Review URL: http://codereview.chromium.org/243082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
revert previous checkin (compile failure due to bad merge resolution)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also fixes an issue where not all of the parts of WebPreferences were being serialized/deserialized across IPC.
BUG=23832
TEST=run set_page_color extension, when it sets the color, the popup
should close
Review URL: http://codereview.chromium.org/243096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
as it also hangs the linux valgrind bots sometimes.
BUG=22927
Review URL: http://codereview.chromium.org/257051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WorkerHttpLayoutTests.
The crash is caused by lighttpd server starting on the foreground mode and it messed up with the command window host.
To work around this, we start the http server on the background mode if running UI test under Windows 7.
BUG=23303
TEST=none
Review URL: http://codereview.chromium.org/257047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
hangs.
BUG=23580
TEST=green valgrind unit_tests
TBR stuartmorgan or pk
Review URL: http://codereview.chromium.org/251090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/246022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23780
TEST=none
Review URL: http://codereview.chromium.org/246088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm pretty new to the stability bot so I'm not sure if this is the
most appropriate thing to do or whether this should not be submitted
until the underlying problem has been investigated - let me know.
BUG=23780
TEST=should stop seeing this in stability bot redness
Review URL: http://codereview.chromium.org/255073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/251070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
failing on Linux.
TBR:estade
Review URL: http://codereview.chromium.org/259037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=23268
Review URL: http://codereview.chromium.org/256032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
clipboard_util to clipboard_util_win since it's Windows-only. This patch makes
test_shell depend on app as well. There should be no logic change.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/260003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
It is flakily failing on modules linux, about 1/10 runs.
Review URL: http://codereview.chromium.org/246081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
And update the version number (forgot in my last changelist). No code change there.
TBR=nsylvain
Review URL: http://codereview.chromium.org/255066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
there in the context of the iframe instead of doing this in the extension html page.
BUG=None
TEST=Covered by automated tests.
Review URL: http://codereview.chromium.org/246066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
window that extends below a browser action button when the browser is clicked. When it loses focus, it is automatically dismissed.
BUG=23596
TEST=none
Review URL: http://codereview.chromium.org/258011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
some redirects.
R=brettw
BUG=21353
TEST=none
Review URL: http://codereview.chromium.org/246073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
find-in-bar box was closed.
Also wrote an interactive ui test and took the opportunity to convert the existing find-in-bar interactive ui test to be a browser test.
BUG=23599
TEST=See bug.
Review URL: http://codereview.chromium.org/251064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/258016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I RDPed to a buildbot and it ran fine. So I think the problem is certain automation messages not working in plain ui tests. I will try putting this in an automated interactive ui test.
TBR=nsylvain
Review URL: http://codereview.chromium.org/242121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=23580
Review URL: http://codereview.chromium.org/259007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The trybots are failing that patch, so I am going to try checking in these changes separately, then try the rest of the patch.
TBR=nsylvain
Review URL: http://codereview.chromium.org/249064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the spellchecker objects from memory.
This reworks the SpellChecker management functions inside the ProfileImpl for simplicity. The only notable side effect is that GetSpellChecker() will now cause a notification if it inits |spellchecker_|, just like ReinitializeSpellChecker() already did. This was just to simplify the code; at the point this fires, no one will be listening yet, so it won't actually do anything.
Also use a temporary at one spot in browser_render_process_host.cc instead of calling a heavyweight function twice in a row.
BUG=23400
TEST=none
Review URL: http://codereview.chromium.org/259009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This avoids tabs maliciously preventing closing using ctrl+f4/ctrl+w/alt+f4, and also hung/slow renderers from making tab cycling sluggish.
BUG=5496
TEST=added ui test
Review URL: http://codereview.chromium.org/224023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
possible, making the file feel a little less verbose and more readable. (A few functions already did this.)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/249063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23379
TEST=Load the print_browser_action extension from the samples test dir and click it. The icon and name should update.
Review URL: http://codereview.chromium.org/242081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CID=5060
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/243039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
under src/.
TEST=TwoClientLiveBookmarksSyncTest
BUG=23478
Review URL: http://codereview.chromium.org/242085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Update GetDownloadDirectory to take FilePath instead of wstring to avoid conversions "To and From wstring".
BUG=None
TEST=run ui_tests.exe
Review URL: http://codereview.chromium.org/243047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also changes some sample code to use a random generic name ("PruningAlgorithm") instead of MemoryModel in hopes that no one will be confused.
This does not remove IdleTimer, even though it now has no users. I do plan to remove it, but I want to do that in a separate commit so it's easy to reference and revert if at some later point we want this functionality.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/242079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This parameter is used to support _self and other names that
need to be evaluated relative to a subframe.
R=jam
BUG=23009
TEST=none
Review URL: http://codereview.chromium.org/257005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
as WinMain hold the loader lock and may be causing dead-locks.
BUG=None
TEST=Run the browser tests.
R=darin
Review URL: http://codereview.chromium.org/242067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/242077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change does not completely eliminate webkit/glue/webview.h. Instead,
the old WebView extends from the new WebView temporarily as we complete
the transition.
R=dglazkov
BUG=10033
TEST=none
Review URL: http://codereview.chromium.org/257001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG= http://crbug.com/23436
TEST= Run startup tests with complex theme; note that complex theme is correctly displayed.
Review URL: http://codereview.chromium.org/242075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Belongs to http://codereview.chromium.org/254002
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/244044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/248040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
actions always show up in a submenu of the wrench menu, and
if they have an icon, they also show up in the toolbar area.
BUG=23380,22883
TEST=Added new automated tests for the command handling, but we need to test that the menu items show up manually. To do that, run with no extension installed, you should see "extensions" in the wrench menu. Add an extension that adds a browser action, you should now see an "extensions" submenu with "manage extensions" and the browser action(s) in the submenu.
Review URL: http://codereview.chromium.org/246037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27599 0039d316-1c4b-4281-b951-d872f2087c98
|