| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderViewHostDelegate::View and TabContentsDelegate interfaces.
Significant changes made by this CL:
1. The keyboard event handling code has been moved from TabContentsView implementation classes into BrowserWindow implementation classes.
Please refer to this discussion thread: http://groups.google.com/group/chromium-dev/browse_thread/thread/e6e0b5cc105659b7/9953c4308bb0000c
This change makes the keyboard event flow comply with the relationship between TabContents/TabContentsView and TabContentsDelegate/BrowserWindow.
Besides it, the code is also simplified a lot, for example, the keyboard event handling code in chrome/browser/views/tab_contents/tab_contents_view_{gtk,win}.cc are now merged into one copy and moved into chrome/browser/views/frame/browser_view.cc.
2. A pre-handle phrase has been added into the keyboard event handling flow. A keyboard event will be first sent to the browser for pre-handling before being sent to the renderer. Then if the event was not handled by the renderer, it'll be sent to the browser again for post-handling.
3. The keyboard accelerator handling code of Windows and Linux ports have been optimized to get rid off extra command lookup.
4. The keyboard event message flow between the browser and the renderer is changed back to full async mode, all complex logics introduced by revision 29857 are removed.
BUG=24479, 26054, 26131, 28839
TEST=See bug reports.
Review URL: http://codereview.chromium.org/400012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
callers of l10n_util::GetApplicationLocale to use this instead.
In the browser process, it's wrong to call
l10n_util::GetApplicationLocale with an empty string because then
it won't consider the user pref value when resolving the locale.
On Linux, it's also wrong to call l10n_util::GetApplicationLocale
after startup because the call touches disk and on Linux, we assume
that all of the program files can be deleted after startup (so
updates in place can work).
Review URL: http://codereview.chromium.org/476002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in a dropdown from the page action icon when you click on the icon.
If the page has only one feed, the dropdown does not appear and the
extension works as before.
BUG=None
TEST=Test this on a page with multiple feeds and make sure a dropdown
appears when you click on the RSS icon and that clicking each feed
name takes you to the extension 'subscribe?' page.
Review URL: http://codereview.chromium.org/475007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All data in recent history for this test is invalid as it isn't loading the NTP
image. Not sure how long this has been broken.
BUG=NONE
TEST=The performance of this test on the buildbot gets slower to include all
the time we weren't counting. (I am assuming around 300ms?)
Review URL: http://codereview.chromium.org/460150
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29759
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=rvargas
Review URL: http://codereview.chromium.org/466078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* name, values for callback seems to be on stack.
i changed const char* to string so that it can copy, and
also expect_eq can print string when failed.
BUG=None
TEST=Run unit_tests on valgrind.
Review URL: http://codereview.chromium.org/470006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=29758
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After some debugging on the interactive perf system, it
appears the screen was locked (or at least locked up).
Current theory is this is why OnPaint wasn't being
called and the histogram wasn't being populated.
BUG=28968
TEST=tab switching test runs on slaves
Review URL: http://codereview.chromium.org/463053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Originally committed in r32954. The underlying problem
was fixed in r33704 and r33736.
BUG=28764
TEST=morejs page cycler continues to get results for
reference build
Review URL: http://codereview.chromium.org/460124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
64x64 already is correct.
BUG=None
TEST=The RSS extension should not have white corners on the
gallery or in the install dialog.
Review URL: http://codereview.chromium.org/465115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29225
TEST=PageCyclerTest.Intl2File test should succeed.
Review URL: http://codereview.chromium.org/460102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
V8 2.0.3.1 (pulled in r33966) fixed this issue.
BUG=29565
TEST=Green reliability bot.
Review URL: http://codereview.chromium.org/464065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=finnur@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
allows the caller to specify the behaviour of the window focus when the pop-up is displayed.
I added a test for the new parameter in the ExtensionApiTest.FLAKY_Popup test. I also corrected a truncated string in the unit-test.
Because the pop-up actually uses two windows, I had to change the WidgetWin::Show() routine to also reposition the window at the top. If a window is shown and activated, it is automatically brought to the front. Because we don't activate the pop-up when we want to keep the focus in the current extension view, I had to bring it to the front so that it wouldn't be hidden behind the 'chrome-bubble' window.
BUG=none
TEST=ExtensionApiTest.FLAKY_Popup
Review URL: http://codereview.chromium.org/454019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
call FindPreference directly.
BUG=None
TEST=compiles and passes existing tests
Original patch by Thiago Farina <thiago.farina@gmail.com> at
http://codereview.chromium.org/460117/show
Review URL: http://codereview.chromium.org/463044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Originally committed in r33997, still causing red on
vista interactive perf.
BUG=28968
TEST=tab switching test is disabled
TBR=ben
Review URL: http://codereview.chromium.org/467041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disabled in r33278 but works locally for me. Need to
re-enable to test if it is still failing on the slaves.
BUG=28968
TEST=tab switching test runs on slaves
Review URL: http://codereview.chromium.org/466060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=sgjesse,huanr,patrick
BUG=29565
TEST=Green reliability bot.
Review URL: http://codereview.chromium.org/469005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
tests over to ExternalTabUITest.
BUG=27326
TEST=ui_tests.exe
Review URL: http://codereview.chromium.org/468013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=567
TEST=Visit a page, zoom in or out, then navigate to a different host. The new page should not be zoomed. Go back, or restart, or open a new tab and navigate to the old page, and it should be zoomed.
Review URL: http://codereview.chromium.org/437077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
are new enough.
BUG=28028
Review URL: http://codereview.chromium.org/463034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
do-nothing make.
TEST=manual browser test, trybots
BUG=none
Review URL: http://codereview.chromium.org/464031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to mutating extension functions, as discussed on chromium-dev and
in Extensions quotaserver design doc.
Add a hook in the dispatcher to have the quota service assess the request.
Wire up bookmarks.{create, move, remove, update} to the service.
BUG=19899
TEST=ExtensionsQuotaServiceTest, QuotaLimitHeuristicTest (both new)
Review URL: http://codereview.chromium.org/441006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
trace. i.e. http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Reliability/builds/7140/steps/reliability:%20complete%20result%20of%20previous%20build/logs/stdio
BUG=none
TEST=green reliability bot
Review URL: http://codereview.chromium.org/468009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(i.e. this is a plain vanilla build used when layers like base/allocator
are getting in the way of debugging)
and make sure they use msvcrt rather than libcmt
(libcmt is used to help shim malloc/free, but it gets
in the way of valgrind doing the same thing).
Sadly, this is now a gyp-time operation rather than a Configuration
option.
Had to remove hardcoded C prototype for _set_new_mode,
as that caused link errors.
Also add variables win_{release,debug}_{Optimization,RuntimeLibrary}
to let the valgrind build override those settings.
Fix calling convention on _set_new_mode to match the
one in <new.h>
BUG=none
TEST=build with ~/.gyp/include.gypi set as described in comment in common.gypi, gclient runhooks, do release build, verify all exe's and dll's linked against msvcrt dll
Review URL: http://codereview.chromium.org/455037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
set. This emulates the
behavior of other browsers and fixes http://code.google.com/p/chromium/issues/detail?id=28800
I added a UI test to validate that the plugin source URL is set on outgoing GetURL requests issued
by the plugin. To validate that the document URL is set as the referrer on the initial URL request
would take some more work. Will try and add that in a future CL.
I also changed the WebPluginImpl::RouteToFrame function to set the referrer on similar lines.
Bug=28800
Test=Covered by UI test
Review URL: http://codereview.chromium.org/459003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These tests (NotifyOtherProcessFailure and NotifyOtherProcessDifferingHost) involve killing the browser process, which under valgrind leaves incomplete valgrind output.
BUG=25176
TEST="tools/valgrind/chrome_tests.sh -t ui --gtest_filter=ProcessSingletonLinuxTest.\*" should not output any valgrind warnings.
Review URL: http://codereview.chromium.org/460003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29208
TEST=Happier Mac UI valgrind bots
Review URL: http://codereview.chromium.org/465010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
containing a privacy blacklist.
TEST=Covered by unit_tests.
BUG=21541
Review URL: http://codereview.chromium.org/453016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
bindings patch has been landed that should take care of this one.
BUG=29041
TEST=none
Review URL: http://codereview.chromium.org/459014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=29149
Review URL: http://codereview.chromium.org/460005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20915
Review URL: http://codereview.chromium.org/458002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
no longer needed and prompts the scary warning on the install dialog.
BUG=None
TEST=I ran the browser tests that test the feed parsing and tested the
extension on a news site with a feed. No issues found.
Review URL: http://codereview.chromium.org/453018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28850
TEST=NONE
Review URL: http://codereview.chromium.org/449064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/29081
Review URL: http://codereview.chromium.org/453013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/29079
Review URL: http://codereview.chromium.org/449062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=29041
Review URL: http://codereview.chromium.org/449041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
so it's not needed anymore.
BUG=28992
Review URL: http://codereview.chromium.org/449028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28808
TEST=None
Review URL: http://codereview.chromium.org/457012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/29020
Review URL: http://codereview.chromium.org/450015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/384062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/454004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=pawel
Review URL: http://codereview.chromium.org/453007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/454004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now each Profile has a BlacklistManager that maintains a compiled Blacklist for that Profile.
The system does not yet pause user-initiated web requests until the blacklist system is ready. However, the code is not supposed to be ready, and is hidden behind a --enable-privacy-blacklists command-line flag.
TEST=Covered by browser_test.
BUG=21541
Review URL: http://codereview.chromium.org/371063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
running script we need to call v8::Debug::DebugBreak() on a thread different from the Render thread which may be busy with JS execution.
BUG=28892
TEST=DevToolsSanityTest.TestPauseWhenScriptIsRunning
Review URL: http://codereview.chromium.org/444017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=28968
TEST=none
TBR=nsylvain
Review URL: http://codereview.chromium.org/448009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
library with upstream source code from the new vendor branch patterns
in third_party\jemalloc and third_party\tcmalloc.
BUG=27911
TEST=none
Review URL: http://codereview.chromium.org/435040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33208 0039d316-1c4b-4281-b951-d872f2087c98
|