| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Page options button pref has been removed. Remove the test.
Review URL: http://codereview.chromium.org/2810036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=39365
TEST=yes
Review URL: http://codereview.chromium.org/2879003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also, use command_line_string() from base/command_line.h which is
cross-platform now.
Review URL: http://codereview.chromium.org/2800029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44699
TEST=Go to about:about, and see if About page loads. Check if links work.
Review URL: http://codereview.chromium.org/2845027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
attempt caused some flakiness on the new tab warm startup test. The
only difference between this and the last is that I'm leaving some
suspcious code in TabStripModel::InsertTabContents and
Browser::AddTabWithURL. I'll try to isolate why those changes caused
flakiness after I land the rest.
Here's the description:
Moves Browser::AddTypes to TabStripModel. This patch is primarily
cleanup before I fix 29933, but has a couple of interesting bits
beyond the enum change:
. AddTabContents now supports adding pinned.
. Converted InsertTabContents call in extensionstabmodule to pass in
nothing (Rafael said old code was wrong).
BUG=29933
TEST=none
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/2866024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=See unit tests as part of this CL.
Review URL: http://codereview.chromium.org/2804010
TBR=rogerta@google.com
Review URL: http://codereview.chromium.org/2835022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=See unit tests as part of this CL.
Review URL: http://codereview.chromium.org/2804010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a new page, about:about (or chrome://about/about)
continued from http://codereview.chromium.org/2799038/show fixed typo that screwed up ChromeOS compiling
BUG=44699
TEST=Go to about:about, and see if About page loads. Check if links work.
TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/2861028
TBR=hinoka@chromium.org
Review URL: http://codereview.chromium.org/2814035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a new page, about:about (or chrome://about/about)
continued from http://codereview.chromium.org/2799038/show fixed typo that screwed up ChromeOS compiling
BUG=44699
TEST=Go to about:about, and see if About page loads. Check if links work.
TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/2861028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
As working on change committed in rev50132, instead of yet adding another project to the dependency list of libxml, I decided to abstract the dependency in the metrics helper.
BUG=0
TEST=None
Review URL: http://codereview.chromium.org/2753010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
continued from http://codereview.chromium.org/2754002/show
changelist disappeared after machine swap.
Added a new page, about:about (or chrome://about/about)
Includes a list of most of the about:* pages (eg. Left out about:inducebrowsercrashforrealz)
Page is constructed within browser_about_handler.cc
BUG=44699
TEST=Go to about:about, and see if About page loads. Check if links work.
Review URL: http://codereview.chromium.org/2799038
TBR=hinoka@chromium.org
Review URL: http://codereview.chromium.org/2813037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
continued from http://codereview.chromium.org/2754002/show
changelist disappeared after machine swap.
Added a new page, about:about (or chrome://about/about)
Includes a list of most of the about:* pages (eg. Left out about:inducebrowsercrashforrealz)
Page is constructed within browser_about_handler.cc
BUG=44699
TEST=Go to about:about, and see if About page loads. Check if links work.
Review URL: http://codereview.chromium.org/2799038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Remove 2 redundant lines.
Review URL: http://codereview.chromium.org/2810032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45734
TEST=make sure the new wrench menu works! Make sure and exer
Review URL: http://codereview.chromium.org/2845022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move some string literals into chrome/common/chrome_switches.
There are still many uses in places that cannot depend on chrome/common.
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/2824008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=checkperms.py passes
Review URL: http://codereview.chromium.org/2850030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=tony@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=tony@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Subsequent changes will:
* Allow URLPatterns to specify * for scheme, so that http/https doesn't need to be repeated for each host.
* Fix the overlap detection.
Suggested review order:
- test files
- url_pattern*
- extension_extent*
- extension*
- everything else
BUG=46633
Review URL: http://codereview.chromium.org/2876007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
items.""
This reverts r50828 as the error is already suppressed r50793.
TBR=asargent
Review URL: http://codereview.chromium.org/2844028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=asargent@chromium.org
TEST=Tree goes green
Review URL: http://codereview.chromium.org/2812025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=ericu, michaeln
Review URL: http://codereview.chromium.org/2863025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=arv@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
by one of the tests, but it is needed by more than one of them.
Review URL: http://codereview.chromium.org/2853007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BookmarkModelVerifier::Create() is called by LiveBookmarksSyncTest::SetupClients() and LiveBookmarksSyncTest::SetupSync(). This results in a duplicate bookmarks bar in the verifier profile, causing some tests to fail.
LiveSyncTest::SetupSync() polymorphically calls LiveBookmarksSyncTest::SetupClients(). Therefore, the correct fix is to remove the override method LiveBookmarksSyncTest::SetupSync(), since there is no need to do anything additional there.
BUG=47451
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/2851024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=39365
TEST=yes
Review URL: http://codereview.chromium.org/2822007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
content.ContentTest.testThreeWindows fails on linux. Disabling for now.
BUG=47457
Review URL: http://codereview.chromium.org/2808025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I didn't want to mix these in with other changes that are due
to real expectations changes.
BUG=46769 (related work)
TEST=sync_unit_tests
Review URL: http://codereview.chromium.org/2811031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also updating another trace sig to SUBSTRING so that it matches a second relevant trace.
BUG=47439
Review URL: http://codereview.chromium.org/2870024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix a bug in extension icon caching where we weren't keeping track of
potential resizing done by ImageLoadingTracker before setting the cached
SkBitmap.
BUG=39494
TEST=Install an extension that includes an icon and uses the experimental
context menu API. You should see the extension's icon in the context menu
next to its top-level item.
Review URL: http://codereview.chromium.org/2867008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cleanup before I fix 29933, but has a couple of interesting bits
beyond the enum change:
. AddTabContents now supports adding pinned.
. Nuked duplicate code in Browser::addTabWithURL that invoked
wasHidden on the TabContents. This code is already in TabStripModel.
. Moved code for setting visibility of tabcontents from
TabStripModel::AddTabContents to InsertTabContentsAt. Since everything
ends up in InsertTabContentsAt it should be there.
. Converted InsertTabContents call in extensionstabmodule to pass in
nothing (Rafael said old code was wrong).
BUG=29933
TEST=none
Review URL: http://codereview.chromium.org/2863021
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/2849025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cleanup before I fix 29933, but has a couple of interesting bits
beyond the enum change:
. AddTabContents now supports adding pinned.
. Nuked duplicate code in Browser::addTabWithURL that invoked
wasHidden on the TabContents. This code is already in TabStripModel.
. Moved code for setting visibility of tabcontents from
TabStripModel::AddTabContents to InsertTabContentsAt. Since everything
ends up in InsertTabContentsAt it should be there.
. Converted InsertTabContents call in extensionstabmodule to pass in
nothing (Rafael said old code was wrong).
BUG=29933
TEST=none
Review URL: http://codereview.chromium.org/2863021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The bookmark sync tests were not waiting for the BookmarkModel object in each Profile to load before running tests. Adding a call to ui_test_utils::WaitForBookmarkModelToLoad() to LiveBookmarksSyncTest::SetupClients().
Also including fixes for a couple of lint errors.
BUG=47361
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/2802019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=47180
Review URL: http://codereview.chromium.org/2809034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=29900
TEST=ported.
Review URL: http://codereview.chromium.org/2849019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=47367
Review URL: http://codereview.chromium.org/2802020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Bug=47367
Review URL: http://codereview.chromium.org/2817027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36184
TEST=Run PyAuto's content.py and make sure it passes.
Review URL: http://codereview.chromium.org/2861019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
just stdout.
Review URL: http://codereview.chromium.org/2826014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=643
TEST=none
Review URL: http://codereview.chromium.org/2799029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
installed.
Review URL: http://codereview.chromium.org/2831020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Attempting to resubmit this change. It looks like the reason for the build break on linux was a missing dependency (nss) in the interactive_ui_test target.
BUG=32410
TEST=unittests
Review URL: http://codereview.chromium.org/2828021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the test plugins. (TTF)
BUG=29900
TEST=none
Review URL: http://codereview.chromium.org/2864019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=this is it
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=DevToolsSanityTest.TestHeapProfiler
BUG=none
Review URL: http://codereview.chromium.org/2846019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=41515
TEST=none
Review URL: http://codereview.chromium.org/2864017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32410
TEST=start two browsers with --enable-sync-passwords, verify that passwords do get synced between the two
Review URL: http://codereview.chromium.org/2302001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50538 0039d316-1c4b-4281-b951-d872f2087c98
|