| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
the renderer.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Note that at this time the parameters to the message
are still tentative. The call goes as a sync call from
renderer to the browser. From then onwards it happens
async and no return value is available yet.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
notifications before and some of them were very unclear and misused
(STATE_CHANGED). This one, and PRUNED were called unnecessarily in some cases
as well.
I replaced STATE_CHANGED and INDEX_CHANGED with ENTRY_COMMITTED which is more
clear and covers (I think!) all the cases that the callers care about.
I added a simple notification testing helper class, and used in the navigation
controller unit tests to make sure we get the proper notifications. I had to
change NotificationSource/Details to have a = and copy constructor so I can
track them easily in my helper. I don't see why this would be bad.
As part of this, I got very frustrated recompiling the world whenever
navigation_types.h changed. So I removed this dependency from the notification
service which everybody includes. Most of the changed files are adding
notification_types.h in the .cc file where it's needed.
BUG=1325636,1321376,1325779
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
changelist model).
Description was:
Conditionally include personalization/ code by surrounding
the hooks into this module with #ifdef CHROME_PERSONALIZATION
in various .h/.cc files.
Building with the module requires adding this macro as a preprocessor
definition in build/internal/essential.vsprops, and adding it to the
VCResourceCompiler tool's command line (using /d). We will try and
make this easier in the future.
TBR=darin
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- Slightly reduce the size of the generated .lib files ~3%.
- Reduce the number of implicit and explicit atl and windows includes. hooray!
- Help incremental build by reducing the number of unnecessary included files.
- Split some template class in two, one base class for the common code and the specialization that inherits from the base class.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MessageLoop. A MessageLoop now has a MessagePump.
This will make it possible to port the MessagePump interface to other platforms
as well as to use an IO completion port for our worker threads on Windows.
Currently, there is only MessagePumpWin, which attempts to preserve the
pre-existing behavior of the MessageLoop.
API changes to MessageLoop:
1. MessageLoop::Quit means return from Run when the MessageLoop would
otherwise wait for more work.
2. MessageLoop::Quit can no longer be called outside the context of an active Run
call. So, things like this:
MessageLoop::current()->Quit();
MessageLoop::current()->Run();
are now:
MessageLoop::current()->RunAllPending();
3. MessageLoop::Quit can no longer be called from other threads. This means that
PostTask(..., new MessageLoop::QuitTask()) must be used explicitly to Quit across
thread boundaries.
4. No protection is made to deal with nested MessageLoops involving watched
objects or APCs. In fact, an assertion is added to flag such cases. This is a
temporary measure until object watching and APC facilities are removed in favor
of a MessagePump designed around an IO completion port.
As part of this CL, I also changed the automation system to use an
IPC::ChannelProxy instead of an IPC::Channel. This moves the automation IPC
onto Chrome's IO thread where it belongs. I also fixed some abuses of
RefCounted in the AutomationProvider class. It was deleting itself in some
cases! This led to having to fix the ownership model for AutomationProvider,
which explains the changes to AutomationProviderList and so on.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
registered. There are still a ton of tests to add as listed in the TODO, but I
figured it would be good to get this reviewed first before delving too far into
figuring out how to deal with beforeunload dialogs.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
The Chrome debugger tests use mjsunit.js from the V8 test framework. In the transition to a new structure for V8 on code.google.com the location of this file will change. A local copy is added temporaly to the debugger tests directory which can be removed when Chrome starts to use V8 from code.google.com.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
shell sample.
Removed the v8_shell project from the Chrome solution and added
v8_shell_sample instead.
Changed the Chrome JavaScript debugger tests to use v8_shell_sample instead
of v8_shell.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
to avoid the rietveld 1mb diff limit.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
output target of .exe files on Windows. Change all the callers to
only pass in the basename of the target (e.g., 'base_unittests').
The only exception is chrome.exe which uses chrome_exe.pdb.
This lets us remove a "if env['PLATFORM'] == 'win32'" condition from
base/SConscript and these other files going forward.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=1324185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=evanm
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=1323423
TEST=this is some tests.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
with a test.
BUG=none
TEST=none; just make sure context menu for bookmark bar still works
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Adds a timeout in waiting for a tab to be restored.
2. Adds a bunch of printfs that will hopefully let me figure out where
the test is failing.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
and browser_views.lib(65 source files, 30 megs).
This will hopefully improve link time (well, not as much as I'd like) and will definitely help non-IB compilation parallelization.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
distributed tests. The goal is to make a test run of all combinations of 4 (as opposed to 5 now) for a total of 34^4 commands (as opposed to 17^5) and see what comes out of it. We won't be running any random keypresses in this run (except in the Dialog fuzzers), only explicit actions.
There were also some discrepancies in how we were using the HTML elements, which I have fixed (Import is now ImportSettings, EditKeywords is now EditSearchEngines and ClearBrowserData is now ClearBrowsingData). I also reordered some functions to match .h file (alphabetical order).
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
there's still a TabStrip available for it.
B=1145714
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR: bradnelson
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mal
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
blocking calls. This replaces my previous CL that was somehow duplicating some of these functionalities.
BUG=None
TEST=Run the unit tests.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
reduce TabSelectedAt crashes.
B=1145714
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
bar view. These are disabled until we straighten out the buildbot that
is always logged in.
BUG=1318922
TEST=this is just a bunch of tests.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ChangeEncoding, DuplicateTab, Home, RestoreTab, ShowBookmarksBar, ViewSource.
These new commands are not used for the distributed tests/build bot tests, but hopefully that will change at some point.
I also fixed an issue where we were trying to avoid hitting Enter or Space as the first thing as the dialog opens (but were instead always hitting Enter first).
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
AM chrome/browser/tabs/tab_dragging_test.cc
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
project. I renamed a few functions for clarity, reordered the functions in both the .cc and .h file alphabetically to see at a glance what commands are missing and did the same with the loop in DoAction that parses the input. That change actually flushed out two duplications (ie. "options" had two cases in the switch).
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
with FindInPage open) is trashing the Esc handler and causing a crash.
I originally tried an automated_ui test, but was unable to get it to work since Focus changes are involved.
BUG=1303709
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
on windows 2000.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
ipc_message_utils.h.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR: mbelshe
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
causes intermittent chrome crashes. But, checking in an intermediate step so
that others can play with it too.
Basic concept is to have a pre-loaded replay cache with interesting data. This
test then drives chrome through automation, simulating a sequence of pages in
each tab
in a way that a user might also do so; this allows us to
get per-tab caching of data similar to what the user would see.
Includes a logged in gmail session, a few pages that exercise some javascript,
several languages, and pages
from many mainstream sites.
Lots more can be done with this test going forward; for now the goal is to just
measure and track memory.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I had to revert because it was somehow causing regressions on the page cycler and start-up tests.
(I suspect because I did add an IPC message not at the end of the message list)
TBR=beng
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=beng
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The new dialog command fires up a dialog (chosen randomly) and exercises it.
BUG=None
TEST=Run the automated_ui_test
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
suffixes when linking with the libraries we build, replacing the lists of explicitly-suffixed "source files" with library base names in the environment LIBS variables. This requires having ChromeStaticLibrary() install .lib files in a $BUILD_TYPE/Libs directory, and adding that directory to $LIBPATH.
R=evanm,bradnelson
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
everywhere into the base Windows environment.
TBR: evanm,bradnelson
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR: evanm,bradnelson
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Also conveniently fixes accessibility test 'failures' introduced by the last distributor logo change.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add base\object{,_watcher}.cc.
* Add chrome\browser\bookmark_{codec,storage}.cc.
* Add chrome\views\frame\browser_window_factory.cc.
* Split of app\main.cc into app\chrome_{dll,exe}_main.cc, with added CPPDEFINES for {BROWSER,RENDERER,PLUGIN}_DLL.
* Move $CSCRIPT, $PLATFORMSDK* and $VISUAL_STUDIO variables to the win32-specific construction environment.
* Remove unnecessary comments.
TBR: bradnelson
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261 0039d316-1c4b-4281-b951-d872f2087c98
|