summaryrefslogtreecommitdiffstats
path: root/chrome/test
Commit message (Collapse)AuthorAgeFilesLines
* Revert of Add missing runtime dependencies to *_run targets. (patchset #1 ↵maruel2015-09-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:40001 of https://codereview.chromium.org/1255653003/ ) Reason for revert: Broke iOS Device builder again. It fetched by accident osmesa again. Will have to investigate which target does this. Ref: http://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/19013 Original issue's description: > Add missing runtime dependencies to *_run targets. > > A follow up CL removes dynamic libraries that would be fetched automatically via > implicit dependencies. The target hierarchy needs to be there in the first > place for this to work. > > This is a redo of d7b8df80cd5ce2a882bbf35482dc21cee34934f9 but with a fix for > iOS and update to BUILD.gn files. > > TBR=jam@chromium.org,dpranke@chromium.org > BUG=98637 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/ac2496af24009df795fe0dc33d419e8a4971a8ec > Cr-Commit-Position: refs/heads/master@{#346705} TBR=jam@chromium.org,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=98637 Review URL: https://codereview.chromium.org/1314313003 Cr-Commit-Position: refs/heads/master@{#346713}
* Add missing runtime dependencies to *_run targets.maruel2015-09-011-1/+1
| | | | | | | | | | | | | | | | | A follow up CL removes dynamic libraries that would be fetched automatically via implicit dependencies. The target hierarchy needs to be there in the first place for this to work. This is a redo of d7b8df80cd5ce2a882bbf35482dc21cee34934f9 but with a fix for iOS and update to BUILD.gn files. TBR=jam@chromium.org,dpranke@chromium.org BUG=98637 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1255653003 Cr-Commit-Position: refs/heads/master@{#346705}
* Make UrlRequestContextBuilder take scoped_ptr's when it takes ownershippauljensen2015-09-011-3/+3
| | | | | | | | | | | | | | | | | | UrlRequestContextBuilder was already taking ownership in most cases, so it should be taking scoped_ptr's instead of raw pointers. This change should help enforce proper ownership and has already identified two ownership bugs. I'm fixing the ownership bugs (a double-free of ProxyConfigService in Cronet and of NetLog in AwURLRequestContextGetter) in this change also. I'm changing UrlRequestContextBuilder to not take ownership of NetLog however as this conflicts with some other uses of NetLog, like how it's exposed via ContentBrowserClient. BUG=508553 TBR=jam Review URL: https://codereview.chromium.org/1303493002 Cr-Commit-Position: refs/heads/master@{#346637}
* Revert of Browser tests for the ChromeOS chromecast system tray item. ↵jdufault2015-09-012-34/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #4 id:80001 of https://codereview.chromium.org/1309753007/ ) Reason for revert: Broke ASAN bots (https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/4293) Original issue's description: > Browser tests for the ChromeOS chromecast system tray item. > > This was first reviewed in https://codereview.chromium.org/1231593002/. > > It was later reviewed in https://codereview.chromium.org/1287023010/. > > This CL fixes the revert https://codereview.chromium.org/1307863004/; the patch was originally applied from https://codereview.chromium.org/1287023010/. > > BUG=497343, 514952 > > Committed: https://crrev.com/2c1297f68066ff7fb20a98eb5a932fa81069ace9 > Cr-Commit-Position: refs/heads/master@{#346517} TBR=stevenjb@chromium.org,achuith@chromium.org,oshima@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=497343, 514952 Review URL: https://codereview.chromium.org/1323903002 Cr-Commit-Position: refs/heads/master@{#346542}
* Switch callers to use pollForUIThreadCriteria where applicable.tedchoc2015-09-012-15/+3
| | | | | | | | | | | This gets rid of a bunch of boiler plate ThreadUtils.runOn... code in a lot of tests. BUG= Review URL: https://codereview.chromium.org/1310553012 Cr-Commit-Position: refs/heads/master@{#346538}
* Browser tests for the ChromeOS chromecast system tray item.jdufault2015-08-312-43/+34
| | | | | | | | | | | | | | This was first reviewed in https://codereview.chromium.org/1231593002/. It was later reviewed in https://codereview.chromium.org/1287023010/. This CL fixes the revert https://codereview.chromium.org/1307863004/; the patch was originally applied from https://codereview.chromium.org/1287023010/. BUG=497343, 514952 Review URL: https://codereview.chromium.org/1309753007 Cr-Commit-Position: refs/heads/master@{#346517}
* Fix omnibox suggestion alignment when switching RTL <-> LTRtedchoc2015-08-311-16/+27
| | | | | | | | | | | | | This also changes the alignment behavior to always align all suggestions on the same side (regardless if they are a mixture of LTR and RTL). The trigger for the alignment will be the location of the text in the omnibox. BUG=516327 Review URL: https://codereview.chromium.org/1321863002 Cr-Commit-Position: refs/heads/master@{#346495}
* Annotate GN executables and shared_libraries with sanitizer deps.brettw2015-08-311-0/+1
| | | | | | | | | | | | | | | | | These are needed to link in asan/lsan/etc. mode. GYP injects these automatically but GN doesn't have automatic dependency injection. All tests and components (which cover the vast majority of such targets in actual use) are templates which add these dependencies already, so most of the time it never comes up. Only a few of these changes are actually necessary to link all tests run on the asan bot (which is also what engineers will typically build, since almost nobody will build all in asan mode). But to reduce confusion from linker errors in asan mode, I annotated all executables and shared libraries I could find with the sanitizer dependency. I moved a config out of a target in yasm, and sorted a fews deps on other targets. TBR=xhwang@chromium.org (widevine) TBR=achuith@chromium.org (tools/perf, tools/telemetry) Review URL: https://codereview.chromium.org/1318343003 Cr-Commit-Position: refs/heads/master@{#346490}
* [Media Router tests] Add defaultRequest.onsessionconnect test.imcheng2015-08-312-8/+28
| | | | | | | | | | | Add test to make sure defaultRequest.onsessionconnect is getting called. Add an assertion in the Basic test. BUG=464227 Review URL: https://codereview.chromium.org/1313793009 Cr-Commit-Position: refs/heads/master@{#346483}
* Add multi-threat and metadata parsing for SafeBrowsingApiHandler.nparker2015-08-311-13/+6
| | | | | | | | | | | | | | | This moves some of the code upstream so we can add unit tests for it. It'll eventually all be moved upstream. (Tests should live here per jbudorick and yfriedman). I've also enabled a few existing unit tests for safe_browsing==3 mode. This is paired with downstream change https://chrome-internal-review.googlesource.com/228368, which I'll submit after this. BUG=514743 Review URL: https://codereview.chromium.org/1316363002 Cr-Commit-Position: refs/heads/master@{#346415}
* Fix crash when accessing automation node from stale AX treedmazzoni2015-08-311-4/+9
| | | | | | | | | | | | | | | The problem is that the root node of a stale AX tree computes its id dynamically, but if that AX tree doesn't exist anymore it was returning undefined, and then passing undefined to any of the native bindinds was a fatal error. The solution is just to return -1 instead of undefined as the id. BUG=526255 Review URL: https://codereview.chromium.org/1308813008 Cr-Commit-Position: refs/heads/master@{#346394}
* platformKeys.selectClientCertificates: Respect the clientCerts argument.pneubeck2015-08-311-0/+14
| | | | | | | | BUG=526142 Review URL: https://codereview.chromium.org/1318273002 Cr-Commit-Position: refs/heads/master@{#346375}
* Componentize proxy code from chrome/browser/netabhishek.a212015-08-311-1/+1
| | | | | | | | | | | | | | | . Moved preferences from pref_names to proxy_prefs . Using base::ThreadChecker and base::SingleThreadedTaskRunner to remove BrowserThread dependency. . Removed unused notification inclusions. TBR=thakis BUG=516714 Review URL: https://codereview.chromium.org/1296663003 Cr-Commit-Position: refs/heads/master@{#346369}
* PDF: Prevent JS error when PDF filename contains invalid characterstsergeant2015-08-311-0/+8
| | | | | | | | | | | | When a PDF filename contains invalid percent-encoded characters, fall-back to displaying the encoded filename rather than attempting to decode it. BUG=525838 Review URL: https://codereview.chromium.org/1315503004 Cr-Commit-Position: refs/heads/master@{#346338}
* Build PPAPI NaCl Newlib tests with GNphosek2015-08-281-0/+2
| | | | | | | | | | | This change enables the build of PPAPI NaCl tests, currently only for native Clang/Newlib toolchain. BUG=462791 Review URL: https://codereview.chromium.org/1316963003 Cr-Commit-Position: refs/heads/master@{#346250}
* Move loader stub libraries out of //build/config/linuxdpranke2015-08-281-2/+2
| | | | | | | | | | | | | | | | | | The //build/config/linux library defined a number of targets built through the generate_library_loader target. All of these are fairly chrome-specific, so having them defined in the //build/config/linux file made it harder to reuse that file in non-chrome GN builds (like native_client). This CL moves the targets out to a new //build/linux directory and updates the callers accordingly. R=brettw@chromium.org BUG= Review URL: https://codereview.chromium.org/1314163005 Cr-Commit-Position: refs/heads/master@{#346242}
* Add tests for braille routing commands, fix chromevox and reenable ↵plundblad2015-08-281-0/+16
| | | | | | | | | | | | | | | | | background tests. This adds a new mockFeedback class that can handle both speech and braille output. This class superseeds MockTts. Existing cvox2 background tests that had bit-rotted because they were disabled were fixed and reenabled. Braille output was added where it makes sense. A new end-to-end test for braille routing was added. BUG=451362,491242 Review URL: https://codereview.chromium.org/1302763002 Cr-Commit-Position: refs/heads/master@{#346229}
* Prevent BrowserPolicyConnector creation in test shutdowns.pneubeck2015-08-282-9/+12
| | | | | | | | | | TestingBrowserProcess lazily creates BrowserPolicyConnector. This can lead to multiple constructions of a BrowserPolicyConnector during test. This change ensures that in a single test only one BrowserPolicyConnector is created. Review URL: https://codereview.chromium.org/1300683004 Cr-Commit-Position: refs/heads/master@{#346226}
* [chromedriver] Remove references to Chrome Shell.samuong2015-08-282-20/+0
| | | | | | | | BUG=523496 Review URL: https://codereview.chromium.org/1315683003 Cr-Commit-Position: refs/heads/master@{#346199}
* Check the tab ID before delivering an extension message.kalman2015-08-285-149/+176
| | | | | | | | | | | | | | | | | | | | | r335753 changed extension messaging to use RenderFrames, which had the side-effect of delivering messages to every RenderFrame in a process, which may include other tabs. This patch fixes that by sending the target tab ID along with the message. A more principled fix would have been to track RenderFrames on the browser and send to precisely the right ones, but this would need to be part of a more comprehensive refactor. I also fixed up ExtensionApiTest.Connect and re-enabled, which was disabled years ago due to flakiness. Hopefully my test JS changes will fix that. BUG=520303 R=rdevlin.cronin@chromium.org, dcheng@chromium.org Review URL: https://codereview.chromium.org/1318153002 Cr-Commit-Position: refs/heads/master@{#346176}
* Revise ui::DomKey to unify character and non-character codes.kpschoedel2015-08-282-5/+7
| | | | | | | | | | | | | | | | | | | | | | | DomKey becomes a single integer value corresponding to the DOM UI Events KeyboardEvent.key string; it can represent either a Unicode code point or one of the defined non-printable values from <https://w3c.github.io/DOM-Level-3-Events-key/>. In the previous representation, ui::DomKey enumerated only the non- printable values and had a sentinel to indicated that a character value was held separately. Much of this CL therefore merely replaces |key, character| pairs with a single |key| value. The most substantial changes are to ui/events/keycodes/dom/dom_key.h ui/events/keycodes/dom/keycode_converter.h ui/events/event.h and associated implementations. BUG=227231 Review URL: https://codereview.chromium.org/1284433002 Cr-Commit-Position: refs/heads/master@{#346152}
* Fix NaCl IRT build with GNphosek2015-08-281-1/+1
| | | | | | | | | | | | The current IRT target produces a NEXE with an incorrect name and location (different from what is hardcoded in the plugin). This change copies the built NEXE into the correct location. BUG=462791 Review URL: https://codereview.chromium.org/1313733010 Cr-Commit-Position: refs/heads/master@{#346114}
* Add remaining GN targets for the Linux gpu tests.dpranke2015-08-281-3/+54
| | | | | | | | | | | | | | | | | | | This patch adds support for the telemetry-based gpu tests to the GN build, adds a stubbed out target for angle_end2end_tests (full support depends on angle GN fixes), and adds a dummy 'chromium_swarm_tests' build target. With these fixes, it should be possible to flip the linux_chromium_rel_ng bot to GN and still have everything run. R=kbr@chromium.org, brettw@chromium.org BUG=519778 Review URL: https://codereview.chromium.org/1311913004 Cr-Commit-Position: refs/heads/master@{#346067}
* [chromedriver] Release ChromeDriver 2.19.samuong2015-08-281-1/+1
| | | | | | | | | BUG= TBR=stgao@chromium.org Review URL: https://codereview.chromium.org/1307743007 Cr-Commit-Position: refs/heads/master@{#346063}
* [chromedriver] Reenable tests.samuong2015-08-272-6/+0
| | | | | | | | | BUG=chromedriver:1167 TBR=stgao@chromium.org Review URL: https://codereview.chromium.org/1322583002 Cr-Commit-Position: refs/heads/master@{#346012}
* [chromedriver] Don't apply device metrics overrides to app and extension pages.samuong2015-08-271-3/+15
| | | | | | | | | | | | | This prevents a renderer crash, and fixes MobileEmulationCapabilityTest.testDeviceMetricsWithStandardWidth, which is currently failing on the Win7 and Mac bots. BUG=chromedriver:1205 TBR=stgao@chromium.org Review URL: https://codereview.chromium.org/1317153002 Cr-Commit-Position: refs/heads/master@{#345988}
* Improve error handling for js2gtest C++ generation.plundblad2015-08-272-41/+85
| | | | | | | | | | | | | | | Previously, an error in a javascript file would cause the error to be written to the -gen.cc file and fed to the C++ compiler (rarely accepts such output as valid C++). This change causes the generation build action to fail and the error to be output to the stderr of the ninja process instead. Also, stack traces are improved by annotating eval'd files with sourceURL comments when running the generator. BUG=None Review URL: https://codereview.chromium.org/1299893002 Cr-Commit-Position: refs/heads/master@{#345964}
* [chromedriver] Re-disable multi-tab tests on ChromeDriver WebView Shell.samuong2015-08-271-0/+4
| | | | | | | | | | | | | ChromeDriver WebView Shell used to inherit the negative test filter from Chrome Shell, but as of crrev.com/345698 this was deleted. Re-disabling these tests, as ChromeDriver WebView Shell doesn't support multiple tabs. BUG=523496 TBR=stgao@chromium.org Review URL: https://codereview.chromium.org/1319033002 Cr-Commit-Position: refs/heads/master@{#345933}
* A flag enable-password-change-support is removed.dvadym2015-08-272-46/+11
| | | | | | | | | | | | The flag is removed since change password feature was approved for launch. Small UI improvement of update bubble: distance between combobox and buttons was increased twice. BUG=359315 Review URL: https://codereview.chromium.org/1304233002 Cr-Commit-Position: refs/heads/master@{#345882}
* Update a test to use PushSubscription.getKey()peter2015-08-271-1/+1
| | | | | | | | | | | | | | | | | The PushSubscription.curve25519dh property is now exposed through a getKey() method that takes the curve type as the first and only argument. Update the test to use this instead. This CL is part of a three-sided patch: [1] https://codereview.chromium.org/1309723004/ [2] This CL. [3] https://codereview.chromium.org/1316693002/ BUG=486040 Review URL: https://codereview.chromium.org/1314893002 Cr-Commit-Position: refs/heads/master@{#345863}
* PDF: Use PDF metadata for the title instead of the last path element.sammc2015-08-273-0/+28
| | | | | | Review URL: https://codereview.chromium.org/1303103003 Cr-Commit-Position: refs/heads/master@{#345838}
* Material PDF: Style audit and cleanuptsergeant2015-08-271-2/+2
| | | | | | | | | | | | This CL modifies styles across the PDF viewer to make them match the design mocks more closely, and cleans up and simplifies styles wherever possible. BUG=439114 TBR=estade@chromium.org Review URL: https://codereview.chromium.org/1312373002 Cr-Commit-Position: refs/heads/master@{#345800}
* Show debugger extension api infobar for every tab in every browser.dgozman2015-08-271-7/+15
| | | | | | | | | | | | | | Since debugger extension api exposes information about the whole browser, it's infobar should be visible on every tab to warn users. This is implemented using GlobalConfirmInfoBar, which listens to all tabs in all browsers and displays an infobar in each of them. BUG=521686 Review URL: https://codereview.chromium.org/1295493005 Cr-Commit-Position: refs/heads/master@{#345771}
* Me2Me Telemetry Integration test.kelvinp2015-08-271-10/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As we rely more and more on our session state changes data to determine the reliability of our connections. It is important to ensure we don't have any regressions on the telemetry events generated for a given connection. This CL implements a few integration tests for our top 7 Me2Me connection scenarios: 1. Connection Succeeded 2. Connection Failed - Signal Strategy 3. HostOffline - reconnect succeeded 4. HostOffline - reconnect failed 5. HostOffline - Jid refresh failed 6. Connection Canceled 7. Reconnect button Summary of changes: 1. Moves the creation logic of modal dialogs into a factory class so that it can be injected in test code. 2. Moves the creation of DesktopConnectedView into a factory function so that it can be overwritten in test code. 3. MockConnection injects the MockClientPlugin and the MockSignalStrategy into the ClientSessionFactory. 4. Me2MeTestDriver injects the MockConnection, MockModalDialogFactory, MockHostList and other mock objects into Me2MeActivity. BUG=521782 Review URL: https://codereview.chromium.org/1301373002 Cr-Commit-Position: refs/heads/master@{#345744}
* [Password Manager] Support <input> elements not in a <form> elementgcasto2015-08-261-0/+25
| | | | | | | | | | | BUG=451644 Committed: https://crrev.com/2f3f266efe6e18df27705fb2530489bcb42269d3 Cr-Commit-Position: refs/heads/master@{#334010} Review URL: https://codereview.chromium.org/1117983003 Cr-Commit-Position: refs/heads/master@{#345712}
* Add SIM state to DeviceStatePropertiesstevenjb2015-08-261-1/+1
| | | | | | | | | | | | On an actual device, no Shill network exists for Cellular networks with a locked SIM, so we need to provide the SIM state in the DeviceStateProperties. BUG=516367 Review URL: https://codereview.chromium.org/1304413004 Cr-Commit-Position: refs/heads/master@{#345702}
* [chromedriver] Remove chrome_shell from buildbot scripts.samuong2015-08-261-9/+1
| | | | | | | | BUG=523496 Review URL: https://codereview.chromium.org/1312303002 Cr-Commit-Position: refs/heads/master@{#345698}
* [Sync] Remove the Context from ProfileSyncService on Android.maxbogue2015-08-261-5/+5
| | | | | | | | | | The context value is never used. BUG=497518 Review URL: https://codereview.chromium.org/1316503002 Cr-Commit-Position: refs/heads/master@{#345671}
* [tracing] Add memory dump config to TraceConfigssid2015-08-261-3/+3
| | | | | | | | | | | | | | | Currently memory-infra creates dump at fixed rate. The rate and level of detail should be configurable for telemetry and slow-reports. This CL introduces memory dump config in TraceConfig, to be able to control the periodic interval and dump type. See design doc https://goo.gl/5Hj3o0. BUG=513692 TBR=dsinclair@chromium.org, jhawkins@chromium.org Review URL: https://codereview.chromium.org/1306753005 Cr-Commit-Position: refs/heads/master@{#345651}
* Remove NaCl weak_ref deps from irt_manifest_file test.jvoung2015-08-261-2/+0
| | | | | | | | | | | | | | The old pm_manifest tests relied on weak_ref, but this does not (pm_manifest tests deleted here https://codereview.chromium.org/535223002/diff/60001/chrome/test/data/nacl/manifest_file/pm_manifest_file_test.cc) Remove deps so that we can delete the weak_ref library. E.g.,: https://codereview.chromium.org/1317853002/ BUG=none Review URL: https://codereview.chromium.org/1309313003 Cr-Commit-Position: refs/heads/master@{#345646}
* Show title instead of message in Media Router issue-banner.apacible2015-08-261-9/+7
| | | | | | | | BUG=501452 Review URL: https://codereview.chromium.org/1308603003 Cr-Commit-Position: refs/heads/master@{#345505}
* Sync GN tests with GYP.brettw2015-08-251-1/+1
| | | | | | | | | | This syncs the remaining test binaries in the GN build to their GYP counterparts. Some NaCl dependent tests are still remaining. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Review URL: https://codereview.chromium.org/1302373004 Cr-Commit-Position: refs/heads/master@{#345487}
* [Extensions Toolbar] Cleanup ToolbarActionsModel and relatedrdevlin.cronin2015-08-252-0/+5
| | | | | | | | | | | | | Cleanup a few parts of the ToolbarActionsModel and friends. - Add a ToolbarActionsBar getter to the browser windows; this allows us to get rid of the very un-observer-y methods like ShowToolbarActionPopup(). - Remove unused ToolbarActionsModel::EnsureVisibility() method. - Remove ToolbarActionViewController::CanDrag() method, since it always returned true now. Review URL: https://codereview.chromium.org/1311253003 Cr-Commit-Position: refs/heads/master@{#345471}
* Remove arbitrary references to ChromeShell in comments.newt2015-08-251-1/+0
| | | | | | | | | | | | | | | Since ChromeShell is going away, we shouldn't reference it in examples in comments. This updates those comments to use something else as an example. Also, removing these references makes it easier to grep for the real remaining uses of ChromeShell in the codebase. BUG=510220 Review URL: https://codereview.chromium.org/1310733002 Cr-Commit-Position: refs/heads/master@{#345452}
* Clean up extensionview permissions for browser tests.apacible2015-08-254-13/+13
| | | | | | | | | | This whitelists specific extensions used in tests so that the primary permission for ExtensionView usage is WebUI. This also adds a key to the relevant manifest.json files for a stable ID. BUG=515284 Review URL: https://codereview.chromium.org/1290683002 Cr-Commit-Position: refs/heads/master@{#345400}
* [Script Injection] Allow whitelisted extensions to inject scripts everywhererdevlin.cronin2015-08-256-21/+19
| | | | | | | | | | | Fix a regression where whitelisted extensions couldn't inject content scripts on other extension pages. BUG=517370 Review URL: https://codereview.chromium.org/1294393003 Cr-Commit-Position: refs/heads/master@{#345382}
* [chromedriver] Fix broken ChromeDriverTest.testTabCrash.samuong2015-08-251-10/+11
| | | | | | | | | BUG= TBR=stgao@chromium.org Review URL: https://codereview.chromium.org/1310553007 Cr-Commit-Position: refs/heads/master@{#345380}
* [chromedriver] Remove obsolete test filters.samuong2015-08-251-12/+0
| | | | | | | | BUG=chromedriver:954 Review URL: https://codereview.chromium.org/1305163004 Cr-Commit-Position: refs/heads/master@{#345372}
* [chromedriver] Ignore response of Runtime.evaluate(1) if target closed or ↵samuong2015-08-251-5/+11
| | | | | | | | | | | | | crashed. This reduces flakiness that has been seen recently with WindowSwitchingTest.testCanCallGetWindowHandlesAfterClosingAWindow. BUG=524079 TBR=stgao@chromium.org Review URL: https://codereview.chromium.org/1315473003 Cr-Commit-Position: refs/heads/master@{#345275}
* PDF: Fix issue allowing PDF title to be spoofedtsergeant2015-08-251-0/+24
| | | | | | | | | | | | | The getFilenameFromURL allowed a fragment to be crafted which would modify the title displayed in Material PDF. This CL modifies to function to ignore the URL fragment and query string, preventing this from happening. BUG=524007 Review URL: https://codereview.chromium.org/1311333002 Cr-Commit-Position: refs/heads/master@{#345269}
generated by cgit v1.1 at 2025-03-14 20:55:32 +0000