summaryrefslogtreecommitdiffstats
path: root/chrome/tools/crash_service
Commit message (Collapse)AuthorAgeFilesLines
* Move directory creation functions to base namespace.brettw@chromium.org2013-12-031-1/+1
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/100573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238446 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more file utils to the base namespace.brettw@chromium.org2013-12-021-1/+1
| | | | | | | | | This also swaps the order of the parameters to GetShmemTempDir so the out parameter is last, and enhances some documentation. Review URL: https://codereview.chromium.org/93263002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238144 0039d316-1c4b-4281-b951-d872f2087c98
* Move CrashService class to breakpad componentjochen@chromium.org2013-10-183-630/+14
| | | | | | | | | BUG=247431 R=rsesek@chromium.org Review URL: https://codereview.chromium.org/26688006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229279 0039d316-1c4b-4281-b951-d872f2087c98
* Don't check the result of new for NULL.thakis@chromium.org2013-10-171-4/+0
| | | | | | | | | | | | | | | new throws on allocation error. We build with exceptions disabled, but we use an allocator that crashes the process when memory allocation fails, so this check isn't necessary. Fixes some issues reported by PVS-Studio: http://www.viva64.com/en/b/0205/ BUG=271530 NOTRY=true Review URL: https://codereview.chromium.org/23441026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229058 0039d316-1c4b-4281-b951-d872f2087c98
* Embed compatibility manifest into all *.exe filesYukawa@chromium.org2013-07-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | This CL introduces an automated and centralized way to embed compatibility manifest into all *.exe files. With this CL, a potential risk of behavioural inconsistency between production binaries and unit test binaries is resolved by enforcing the same compatibility context. This CL uses 'target_conditions' feature of gyp to inject manifest settings into each executable target. One tricky part is that some executables such as setup.exe and mini_installer.exe require external manifest file instead of embedded one when component build is enabled. See http://crbug.com/127233 for this. You can override the gyp variable 'win_exe_compatibility_manifest' locally for a given executable target to embed a custom compatibility manifest. BUG=260692 Review URL: https://chromiumcodereview.appspot.com/19275010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214427 0039d316-1c4b-4281-b951-d872f2087c98
* Strip CRs from *.exe.manifest that have themhidehiko@chromium.org2013-07-171-11/+11
| | | | | | | | | | | | | | | | | As previously reported in http://crbug.com/128744, our commit queue cannot deal with files ending with CR/LF. This CL strips CRs from some *.exe.manifest so that https://codereview.chromium.org/18477012/ can be committed via commit queue. BUG=259228 R=jochen@chromium.org Review URL: https://codereview.chromium.org/19587002 Patch from Yohei Yukawa <Yukawa@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212029 0039d316-1c4b-4281-b951-d872f2087c98
* Move PathExists to base namespace.brettw@chromium.org2013-07-111-1/+1
| | | | | | | | | BUG= TBR=jam@chromium.org Review URL: https://codereview.chromium.org/18286004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211147 0039d316-1c4b-4281-b951-d872f2087c98
* Move DeleteAfterReboot, Move, and ReplaceFile to base namespacebrettw@chromium.org2013-07-011-1/+1
| | | | | | | | | | | | Rename ReplaceFileAndGetError (only used once) to ReplaceFile (used 5 times) and have each of those callers specify NULL for the output error if they don't care. Remove InsertBeforeExtension from file_util.cc which seems to be unused. BUG= Review URL: https://codereview.chromium.org/18383003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209532 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r206949 - "Start moving breakpad integration to a component."jochen@chromium.org2013-06-291-2/+1
| | | | | | | | | | | | | | | | I'll use a different approach to move breakpad to a component. > Step 1: move the DIR_CRASH_DUMPS symbol to the component > > BUG=247431 > > Review URL: https://chromiumcodereview.appspot.com/16924012 TBR=thestig@chromium.org Review URL: https://chromiumcodereview.appspot.com/18277002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209356 0039d316-1c4b-4281-b951-d872f2087c98
* Define a LoggingSettings struct to use for InitLogging()akalin@chromium.org2013-06-211-6/+4
| | | | | | | | | | | | | | | | | | Update all callers of InitLogging() to use LoggingSettings, only setting fields that need a non-default value. Turn LoggingDestination enum into a bit field and define add LOG_DEFAULT and LOG_ALL constants. Fix erroneous comment saying that the default was to not lock the log file. BUG=247594 TBR=brettw@chromium.org, cpu@chromium.org, gene@chromium.org, jam@chromium.org, rch@chromium.org, scherkus@chromium.org, sergeyu@chromium.org, sky@chromium.org, tkent@chromium.org, yfriedman@chromium.org, zea@chromium.org Review URL: https://codereview.chromium.org/16519003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207920 0039d316-1c4b-4281-b951-d872f2087c98
* Start moving breakpad integration to a component.jochen@chromium.org2013-06-181-1/+2
| | | | | | | | | | Step 1: move the DIR_CRASH_DUMPS symbol to the component BUG=247431 Review URL: https://chromiumcodereview.appspot.com/16924012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206949 0039d316-1c4b-4281-b951-d872f2087c98
* Pass crash dump directory through ClientInfochrisphan@chromium.org2013-03-152-27/+16
| | | | | | | | Previous method of using process id to determind which crash dumps belong to which browser window didn't work because crash service only got the child process. Here, we pass the crash dump directory through ClientInfo. Review URL: https://chromiumcodereview.appspot.com/12636003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188428 0039d316-1c4b-4281-b951-d872f2087c98
* Move file_path.h to base/files.brettw@chromium.org2013-02-241-1/+1
| | | | | | TBR=sky git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184344 0039d316-1c4b-4281-b951-d872f2087c98
* Rename FilePath to base::FilePath and use new location of ↵brettw@chromium.org2013-02-083-13/+13
| | | | | | | | string_number_conversions in some chrome subdirectories. Review URL: https://codereview.chromium.org/12218065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181564 0039d316-1c4b-4281-b951-d872f2087c98
* Breakpad: Enable more logging in crash_service to debug flaky failures on ↵mseaborn@chromium.org2013-01-161-2/+4
| | | | | | | | | | | | | | | | | | | | | | | Windows Two things are needed to get crash_service's VLOG(1) messages sent to stderr: * Pass --v=1 * Enable "SYSTEM_DEBUG_LOG" in InitLogging() Without these steps, only higher verbosity messages get sent to stderr. Note that crash_service's stderr works if stderr is a pipe but not if it's a Windows console. On a Buildbot slave, though, stderr is a pipe. BUG=169394 TEST=run_breakpad_browser_process_crash_test in nacl_integration Review URL: https://codereview.chromium.org/11881043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177271 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for running multiple browser instances with reliability tests. chrisphan@chromium.org2012-11-132-6/+30
| | | | | | | | | | | | | | | | Originally, crash_service.exe dumps all encountered crash dump files into a single directory. But if multiple browser instances are running, we want to identify which crash belongs to which browser instance. - Add a flag to crash service to archive the generated crash dumps under directory by the browser process id. - Add a flag to page_load_tests to look for crashes under the directory by the process id. For example: %USERPROFILE%\AppData\Local\Google\CrashReports\pid\3f4233fhs.dmp NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11361205 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167429 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 165702 - Add support for running multiple browser instances with ↵vandebo@chromium.org2012-11-022-30/+6
| | | | | | | | | | | | | | | | | | | | | reliability tests. Originally, crash_service.exe dumps all encountered crash dump files into a single directory. But if multiple browser instances are running, we want to identify which crash belongs to which browser instance. - Add a flag to crash service to archive the generated crash dumps under directory by the browser process id. - Add a flag to page_load_tests to look for crashes under the directory by the process id. For example: %USERPROFILE%\AppData\Local\Google\CrashReports\pid\3f4233fhs.dmp NOTRY=true Review URL: https://chromiumcodereview.appspot.com/10836347 TBR=chrisphan@chromium.org Review URL: https://codereview.chromium.org/11359042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165708 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for running multiple browser instances with reliability tests. chrisphan@chromium.org2012-11-022-6/+30
| | | | | | | | | | | | | | | | Originally, crash_service.exe dumps all encountered crash dump files into a single directory. But if multiple browser instances are running, we want to identify which crash belongs to which browser instance. - Add a flag to crash service to archive the generated crash dumps under directory by the browser process id. - Add a flag to page_load_tests to look for crashes under the directory by the process id. For example: %USERPROFILE%\AppData\Local\Google\CrashReports\pid\3f4233fhs.dmp NOTRY=true Review URL: https://chromiumcodereview.appspot.com/10836347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165702 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the rest of #pragma once in one big CL.ajwong@chromium.org2012-07-111-1/+0
| | | | | | | | | For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
* Roll Breakpad to @970.alexeypa@chromium.org2012-06-141-1/+2
| | | | | | | | | | | | Add two NULL parameters to CrashGenerationServer ctor to match the new prototype (changed in r952) Add the files appeared in r945 to breakpad.gyp BUG=127776,132164 TEST=remoting_unittests.BreakpadWinDeathTest.* Review URL: https://chromiumcodereview.appspot.com/10544121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142200 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 136762 - Bump Breakpad revision to r963glider@chromium.org2012-05-141-3/+1
| | | | | | | | | | | | | Reason: symupload got broken BUG=127776 TBR=mark Review URL: https://chromiumcodereview.appspot.com/10377108 TBR=glider@chromium.org Review URL: https://chromiumcodereview.appspot.com/10398022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136925 0039d316-1c4b-4281-b951-d872f2087c98
* Bump Breakpad revision to r963glider@chromium.org2012-05-121-1/+3
| | | | | | | | | | | Add two NULL parameters to CrashGenerationServer ctor to match the new prototype (changed in r952) Add the files appeared in r945 to breakpad.gyp BUG=127776 TBR=mark Review URL: https://chromiumcodereview.appspot.com/10377108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136762 0039d316-1c4b-4281-b951-d872f2087c98
* Update Breakpad to r891, to pick up r891. r891 is a speculative backout ofmark@chromium.org2011-11-282-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Breakpad r883. Along with that, a partial backout of Chrome r110931 is needed to account for an API change. Breakpad log: ------------------------------------------------------------------------ r891 | mark@chromium.org | 2011-11-28 14:17:41 -0500 (Mon, 28 Nov 2011) | 2 lines Speculative back-out of r883, which may have broken Windows crash reporting. ------------------------------------------------------------------------ r890 | jimblandy | 2011-11-23 18:03:30 -0500 (Wed, 23 Nov 2011) | 5 lines Fix some comments and parameter names. Trivial changes; committing for post-facto review. ------------------------------------------------------------------------ r889 | qsr@chromium.org | 2011-11-23 11:14:35 -0500 (Wed, 23 Nov 2011) | 4 lines Create a static library to use Breakpad on iOS. This obliged me to move BreakpadDefines.h to src/client/apple/Framework/BreakpadDefines.h Review URL: http://breakpad.appspot.com/329001 ------------------------------------------------------------------------ Review URL: http://codereview.chromium.org/8664008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111783 0039d316-1c4b-4281-b951-d872f2087c98
* Update breakpad to rev: 886.qsr@chromium.org2011-11-212-1/+5
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/8595014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110931 0039d316-1c4b-4281-b951-d872f2087c98
* Fix check_perms failure from r105190.thestig@chromium.org2011-10-121-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105208 0039d316-1c4b-4281-b951-d872f2087c98
* x86-64 Breakpad: Append "-x64" to the pipe name for 64-bit processesmseaborn@chromium.org2011-10-121-0/+4
| | | | | | | | | | | | | | | | | | | | | | The protocol for connecting to the out-of-process Breakpad crash reporter is different for x86-32 and x86-64 (the message sizes are different because the message struct contains a pointer), so we use different pipe names for the two crash reporters. Appending "-x64" is the simplest way of doing this. It allows two crash handlers to coexist even when using the env var CHROME_BREAKPAD_PIPE_NAME for testing. Google Update (Omaha) does not yet launch an x86-64 crash handler for this to connect to -- that is a work-in-progress. BUG=89730 TEST=compile-tested; will be covered by nacl_integration later Review URL: http://codereview.chromium.org/8231036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105190 0039d316-1c4b-4281-b951-d872f2087c98
* Windows Breakpad: Allow the crash dump dir and pipe name to be overriddenmseaborn@chromium.org2011-08-062-8/+25
| | | | | | | | | | | | | | | | | | | | | | Change crash_service.exe so that the named pipe it listens on (normally global) and the directory it writes to (normally per-user) can both be overridden via command line options. Similarly, add an environment variable to Chromium for connecting to crash_service.exe via a non-default named pipe. This will allow automated tests of Chromium's Breakpad crash reporting to be more robust. A test runner can use a temp dir for crashes and a temporary named pipe, so that it does not have to worry about pre-existing instances of crash_service.exe or pre-existing dump files. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2006 TEST=inbrowser_crash_test in the NaCl tree, with the change http://codereview.chromium.org/7569002 Review URL: http://codereview.chromium.org/7538036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95714 0039d316-1c4b-4281-b951-d872f2087c98
* Change other usages of .size() to .empty() when applicable.erg@google.com2011-03-041-1/+1
| | | | | | | | | BUG=carnitas TEST=compiles Review URL: http://codereview.chromium.org/6609008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76962 0039d316-1c4b-4281-b951-d872f2087c98
* FilePath: Remove much of ToWStringHack, adding a LossyDisplayName()evan@chromium.org2011-02-041-1/+1
| | | | | | | | | | | | | | | The reason we don't want a free conversion between FilePaths and Unicode is that it can be lossy. But when displaying a string to the user, we're ok if it's lossy when we have no other option. This change introduces a LossyDisplayName() method that returns a string16, and converts many of the users of ToWStringHack to use it. BUG=69467 Review URL: http://codereview.chromium.org/6246036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73840 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete base/lock.h and fix up callers to use the new header file andbrettw@chromium.org2011-01-212-5/+5
| | | | | | | | | | | the base namespace. Fix several files including lock.h unnecessarily. BUG=none TEST=none Original review=http://codereview.chromium.org/6142009/ Patch by leviw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-111-2/+6
| | | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70920 Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70977 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70920 - Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-101-6/+2
| | | | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Review URL: http://codereview.chromium.org/6070006 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/6099012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70923 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-101-2/+6
| | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70920 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70782 - Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-071-6/+2
| | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Review URL: http://codereview.chromium.org/6070006 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/6100007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70783 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-071-2/+6
| | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70782 0039d316-1c4b-4281-b951-d872f2087c98
* windows: remove PathService::Get() that uses wstringsevan@chromium.org2010-11-302-15/+13
| | | | | | | | | | This just required fixing the remaining callers. BUG=24672 Review URL: http://codereview.chromium.org/5356008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67783 0039d316-1c4b-4281-b951-d872f2087c98
* Convert LOG(INFO) to VLOG(1) - chrome/tools/.pkasting@chromium.org2010-10-202-23/+23
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3942001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63259 0039d316-1c4b-4281-b951-d872f2087c98
* Move windows version-related stuff out of base/win_util and into ↵brettw@chromium.org2010-10-151-2/+2
| | | | | | | | | | | | | | base/win/windows_version. Many files now only need to include this instead of all of win_util. Remove a bunch of unused code from base/win_util. There was a surprising amount. Replace the AppUserModel property key with the one from the SDK now that we use the Win7 SDK. Move GetLogonSessionOnlyDACL from win_util to ipc since it's only used in that one place. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62694 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS for Breakpad r692:r697, try 3.thestig@chromium.org2010-09-231-5/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3432019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60320 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 60146 - Breakpad DEPS roll 692:697erikwright@chromium.org2010-09-221-1/+0
| | | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3386017 TBR=erikwright@chromium.org Review URL: http://codereview.chromium.org/3455013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60148 0039d316-1c4b-4281-b951-d872f2087c98
* Breakpad DEPS roll 692:697erikwright@chromium.org2010-09-221-0/+1
| | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3386017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60146 0039d316-1c4b-4281-b951-d872f2087c98
* Remove GetSwitchValue() from chrome/* where easy.evan@chromium.org2010-08-061-2/+2
| | | | | | Review URL: http://codereview.chromium.org/3057033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55176 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Remove GetSwitchValue() from chrome/* where easy."evan@chromium.org2010-08-041-2/+2
| | | | | | | | This reverts commit r54966. Meant to try it, not commit it, sorry everyone. :( git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54969 0039d316-1c4b-4281-b951-d872f2087c98
* Remove GetSwitchValue() from chrome/* where easy.evan@chromium.org2010-08-041-2/+2
| | | | | | Review URL: http://codereview.chromium.org/3057033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54966 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Remove <iostream> where possible.erg@google.com2010-07-201-1/+0
| | | | | | | | | | | | | <iostream> creates a static initializer. Most people don't need <iostream> anyway--they really need <ostream> for operator<< overloads. <iostream> should *never* be included in a header file; <iosfwd> exists for that purpose. BUG=none TEST=none Review URL: http://codereview.chromium.org/3014015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53083 0039d316-1c4b-4281-b951-d872f2087c98
* Use DISALLOW_COPY_AND_ASSIGN instead of DISALLOW_EVIL_CONSTRUCTORS in chrome ↵tfarina@chromium.org2010-06-061-2/+2
| | | | | | | | | | | directory. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/2657003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49024 0039d316-1c4b-4281-b951-d872f2087c98
* Update breakpad (432->452)gregoryd@google.com2009-12-181-1/+1
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/503052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34916 0039d316-1c4b-4281-b951-d872f2087c98
* Allow low integrity processes to connect to the chrome crash server pipe. ↵ananta@chromium.org2009-12-072-1/+60
| | | | | | | | | | | | | | | This allows us to send crash dumps for chrome frame reliability test runs. TBR'ing this based on a discussion with nsylvain Bug=29451 TBR=nsylvain Review URL: http://codereview.chromium.org/464048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33974 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes almost all of the rest of lint errors in the chrome/ directory (minus ↵erg@google.com2009-11-131-5/+5
| | | | | | | | the really hard ones which will need actual review instead of rubber-stamping.) Review URL: http://codereview.chromium.org/386026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98