| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/13429002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
For this, copied metrics.js library from file manager.
BUG=164227
TEST=Open chrome://user-actions, and then click at notifications' body, buttons or dismiss it. Observe that corresponding events get printed on the page. Check for both component and non-component extensions. Wait for several days and check that the data appears at the dashboard.
Review URL: https://chromiumcodereview.appspot.com/13180002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=It prints the browser_options.html in the error when run without
the CL https://codereview.chromium.org/12340123/ applied.
R=isherman
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/12319158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=169199
Review URL: https://codereview.chromium.org/11828039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=143999, 148870
Review URL: https://chromiumcodereview.appspot.com/11358057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Assigns values to the promo handler enum to keep the values
in sync with histograms.xml.
* Removes an action that is never triggered and doesn't appear
in the logs.
BUG=5484529
TBR=thakis,estade
Review URL: https://chromiumcodereview.appspot.com/11361076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are actions that are pulled from a different repo and aren't normally
crawled by the extract_actions.py script. Manually add them to extract_actions.py.
TBR=jam@chromium.org
BUG=136984
Review URL: https://chromiumcodereview.appspot.com/11044027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes all prefs UI classes inherit from a common ancestor,
consolidating previously copy-and-pasted code. As an additional cleanup,
support for checkboxes controlling a non-Boolean pref is retired as no
such checkboxes exist in Chrome's code.
BUG=104955
Review URL: https://chromiumcodereview.appspot.com/10908061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=143999
Review URL: https://chromiumcodereview.appspot.com/10855260
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=138498
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10805035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Shift+Alt+Tab, Ctrl+t, or Search.
Along with the fix, remove deprecated code in external_metrics.cc and extract_actions.py.
BUG=137771
TEST=manual
TEST=ran './chrome/tools/extract_actions.py | grep Accel_' and confirmed that the actions added to chrome__shell_delegate.cc are correctly recognized by the python script.
Review URL: https://chromiumcodereview.appspot.com/10799006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The original CL failed on Mac Debug.
Add a policy to disable proceeding through the Safe Browsing interstitials.
BUG=119184
TEST=browser_tests:SafeBrowsingBlockingPageTest.*, Safe Browsing warning pages don't have a "proceed" link when opening malware sites (e.g. ianfette.org) and the policy is set
Review URL: https://chromiumcodereview.appspot.com/10690102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
interstitials.
BUG=119184
TEST=browser_tests:SafeBrowsingBlockingPageTest.*, Safe Browsing warning pages don't have a "proceed" link when opening malware sites (e.g. ianfette.org) and the policy is set
Review URL: https://chromiumcodereview.appspot.com/10694037
TBR=joaodasilva@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10694107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=119184
TEST=browser_tests:SafeBrowsingBlockingPageTest.*, Safe Browsing warning pages don't have a "proceed" link when opening malware sites (e.g. ianfette.org) and the policy is set
Review URL: https://chromiumcodereview.appspot.com/10694037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=davemoore@chromium.org
BUG=98716
Review URL: http://codereview.chromium.org/8919017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to support http://codereview.chromium.org/8819013/
BUG=chromium-os:23750
TEST=
Review URL: http://codereview.chromium.org/8822013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure that:
- shebang is only present for executable files
- shebang is #!/usr/bin/env python
- __main__ is only present for executable files
- file's executable bit is coherent
Also fix EOF LF to be only one.
Minor python style fixes.
TBR=nirnimesh@chromium.org
BUG=105108
TEST=
Review URL: http://codereview.chromium.org/8680018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added UMA user action implemented in http://codereview.chromium.org/8490014/
to extract_actions.py, updated chromeactions.txt.
Note: when I ran extract_actions.py --hash I saw a number of new actions show up
in chromeactions.txt. Someone has probably forgot to update it.
I am only adding the one line related to my action in this patch.
BUG=chromium-os:22860
TEST=
Review URL: http://codereview.chromium.org/8537008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
after http://crrev.com/101826.
BUG=87335
TEST=chrome/tools/extract_actions.py works
Review URL: http://codereview.chromium.org/7971010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Included "Cryptohome.PKCS11InitFail" to list of valid actions, and ran
extract_actions.py in order to update hashes in chromeactions.txt.
BUG=chromium-os:19536
TEST=None
Review URL: http://codereview.chromium.org/7961001
Patch from Bruno Rocha <bpontes@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Included "Updater.ServerCertificateChanged" and
"Updater.ServerCertificateFailed" to list of valid actions, and ran
extract_actions.py in order to update hashes in chromeactions.txt.
BUG=chromium-os:19842
TEST=None
Review URL: http://codereview.chromium.org/7925011
Patch from Bruno Rocha <bpontes@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=92440
TEST=none
Review URL: http://codereview.chromium.org/7637010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=92170
TEST=none
Review URL: http://codereview.chromium.org/7558024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Update extract_actions.py to scan for metrics specified in the WebUI code. A common pattern is <input pref="blah" metric="Options_Blah" type="checkbox">.
* Clean up almost all of the existing warnings thrown by extract_actions.py. There is one remaining use of RecordComputedAction that is a bit too subtle for me to lump into this patch.
* Add a new warning to extract_actions.py that scans for uses of UserMetricsAction with a non-literal string. Any such uses are going to be missed by the script, and hence should use RecordComputedAction instead.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7314020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7492022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6904083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6489023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=ian
Review URL: http://codereview.chromium.org/6354019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
to view it with Adobe Reader if it's installed. If it's not, ask them if they want to launch the url to install it. If it's installed and out of date, show an interstitial.
BUG=65339
Review URL: http://codereview.chromium.org/6259008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes us (almost) just forward through user actions that
we receive from other programs rather than having them listed
in Chrome's source. Note that new actions that aren't
present in Chrome still need to be added to
chrome/tools/extract_actions.py, which needs to be rerun to
generate new hashes.
I say "almost" above because metrics still need to be added
to external_metrics.cc due to http://crosbug.com/11095. Once
it's fixed, that requirement can be easily removed.
I also cleaned up some earlier additions that I made to
extract_actions.py and re-ran it to pick up missing actions.
BUG=chromium-os:10403
TEST=built it. checked that i see no errors in chrome's log when using the window manager to report a valid user action, but that i still see an error when running "metrics_client -u BogusMetric"
Review URL: http://codereview.chromium.org/6266011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:8,chromium-os:10403
TEST=none
Review URL: http://codereview.chromium.org/6050017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=ran it with a relative path from a few directories and with an absolute path
Review URL: http://codereview.chromium.org/6133002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/5560005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4910001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/4900003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
o Update user_metrics.h to be more explicit about how to add metrics.
o Update the some BookmarkBar metrics to fit on one line as is required by the script.
BUG=59606
TEST=none
Review URL: http://codereview.chromium.org/3815011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
On other platforms, spell check dictionary is configured from "Under the hood" options,
but on Chrome OS, we integrate this setting with "Languages and Input" options.
BUG=chromium-os:6292
TEST=Confirmed that spellcheck.dictionary was updated in Preferences file. Ran out/Release/unit_tests --gtest_filter='*LanguageOptionsHandlerTest*'
Review URL: http://codereview.chromium.org/3549008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Record metrics with associated input method IDs, and language codes,
to make the metrics data more useful.
Update chromeactions.txt as follows:
% cd chrome/tools
% PYTHONPATH=../../tools/python python extract_actions.py --hash
BUG=chromium-os:2637
TEST=manually.
Review URL: http://codereview.chromium.org/3330021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=safe_browsing_blocking_page_unittest.cc
Review URL: http://codereview.chromium.org/2737005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added the created file
as well, so that dashboard code can pick up the file out of the repository.
BUG=28849
TEST=run the extract_actions.py script. No automated tests required
Patch by Frank Mantek <fmantek@google.com>
Review URL: http://codereview.chromium.org/1518026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
That way it is easier to keep track of those constants in reporting tools.
TEST=Covered with standard ui tests
Patch by Frank Mantek <fmantek@google.com>.
Review URL: http://codereview.chromium.org/811005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28291
Review URL: http://codereview.chromium.org/507067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15 0039d316-1c4b-4281-b951-d872f2087c98
|