| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=138542
TBR=thakis@chromium.org
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1548153002
Cr-Commit-Position: refs/heads/master@{#366893}
|
|
|
|
|
|
|
|
| |
BUG=561693
Review URL: https://codereview.chromium.org/1496003003
Cr-Commit-Position: refs/heads/master@{#363539}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removes most unnecessary base:: qualifications from string_util.
Updates ReplaceStringPlaceholders implementation to use C++11 features for the loop iterators.
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/1227413007
Cr-Commit-Position: refs/heads/master@{#338826}
|
|
|
|
|
|
|
|
| |
Also fix passing by non-const reference in chromedriver.
Review URL: https://codereview.chromium.org/635623003
Cr-Commit-Position: refs/heads/master@{#300629}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/486843004
Cr-Commit-Position: refs/heads/master@{#291880}
|
|
|
|
|
|
|
|
|
| |
BUG=401588
Review URL: https://codereview.chromium.org/450053003
Cr-Commit-Position: refs/heads/master@{#289213}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=355516
TEST=
0. Reboot your computer. Alternately, kill the "tccd" process, e.g. via Activity Monitor.
1. In the Terminal app, run "tccutil reset AddressBook"
2. Navigate to https://accounts.google.com/SignUp
3. Double-click in the first name field.
4. The OS will show a prompt requesting to access contacts.
This prompt should have an explanation for why Chrome wants access.
R=mark@chromium.org
Review URL: https://codereview.chromium.org/214103002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=sky@chromium.org
BUG=329295
Review URL: https://codereview.chromium.org/94013004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=170723
NOTRY=true
Review URL: https://codereview.chromium.org/59903025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15798024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
EnsureEndsWithSeparator used to check whether the file existed. This seems bad and unnecessary so I removed it.
I removed file_util::ContainsPath and used the existing file_util::IsParent instead. The functions descriptions are the same but the implementations do slightly different things, which is worrying. The only non-test use of this function to worry about is content/browser/storage_partition_impl_map.cc. As far as I see, the requirements for this seem OK, but I'm not very familiar with this.
After some discussion with akalin, I changed sync/internal_api/sync_manager_impl.cc to be a DCHECK that the path is absolute rather than make it absolute. The old code relied on the behavior of the old function that the argument would be unchanged if the file didn't exist, and this (possibly relative) path would be used later. This behavior doesn't make a lot of sense, and it looks like now that the path is always absolute, so I replaced this call with a DCHECK.
BUG=
Review URL: https://codereview.chromium.org/13196006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
string_piece.h was moved into base/strings/ in r191206 -
https://chromiumcodereview.appspot.com/12982018/
TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/13247007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=sky
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
string_number_conversions in some chrome subdirectories.
Review URL: https://codereview.chromium.org/12218065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Possibly the change of
http://src.chromium.org/viewvc/chrome?view=rev&revision=175642
Broke the mac plist string generation
BUG=168890
TEST=mac bot not red
TBR=thakis
Review URL: https://codereview.chromium.org/11829014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Android, renderer sandboxing prevents us from opening files and so
ResourceBundle is initialized with file descriptors passed in at process
creation. This change adds methods to DataPack and ResourceBundle to
support loading/initializing from PlatformFile in addition to the
current FilePath.
Also, the current methods are renamed so that the naming is consistent
between these two files.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10686005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
requested scale factor."
Relanding original CL 137734, http://codereview.chromium.org/10387010/.
TBR=aa,abodenha,ben,sail,tony
BUG=123611
TEST=All try bots pass and aura runs without errors.
Review URL: https://chromiumcodereview.appspot.com/10412004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
scale factor.
Return the best match for a requested scale factor when fetching raw image data from ResourceBundle.
TBR=aa,abodenha
BUG=123611
TEST=ResourceBundle.LoadImageResourceBytes
Review URL: https://chromiumcodereview.appspot.com/10387010
TBR=flackr@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Return the best match for a requested scale factor when fetching raw image data from ResourceBundle.
TBR=aa,abodenha
BUG=123611
TEST=ResourceBundle.LoadImageResourceBytes
Review URL: https://chromiumcodereview.appspot.com/10387010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL sets the image scale factor for data packs.
This will be used by the DOM UI code to look up encoded PNG data for images with a specific scale factor.
BUG=114311
TEST=
Review URL: http://codereview.chromium.org/10151025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Inserted a new field in the header that specifies which encoding is to be used for the text resources.
I also upped file format to version 4.
BUG=76281
TEST=unit_tests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100973
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101213
Review URL: http://codereview.chromium.org/7744017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Only C++ part and trivial HTML/CSS files.
BUG=chromium-os:15632
TEST=Manual. Navigated to chrome://oobe.
Review URL: http://codereview.chromium.org/7076014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
raw_scoped_refptr_mismatch_checker.h
ref_counted.cc
ref_counted.h
ref_counted_memory.cc
ref_counted_memory.h
ref_counted_unittest.cc
scoped_callback_factory.h
scoped_comptr_win.h
scoped_handle.h
scoped_native_library.cc
scoped_native_library.h
scoped_native_library_unittest.cc
scoped_nsobject.h
scoped_open_process.h
scoped_ptr.h
scoped_ptr_unittest.cc
scoped_temp_dir.cc
scoped_temp_dir.h
scoped_temp_dir_unittest.cc
scoped_vector.h
singleton.h
singleton_objc.h
singleton_unittest.cc
linked_ptr.h
linked_ptr_unittest.cc
weak_ptr.cc
weak_ptr.h
weak_ptr_unittest.cc
BUG=None
TEST=Compile
Review URL: http://codereview.chromium.org/6714032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/6263008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/5992006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Move scoped_aedesc from base to base/mac
Use namespace and proper Google-style class naming.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3828009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
No more symbolic links in the .app. Except for the ones that codesign adds.
The en_US.lproj directory should not exist, there should be only en.lproj.
Formerly, there was a symbolic link from en.lproj to en_US.lproj.
BUG=25578, 19165
TEST= - find C.app -name en_US.lproj should return nothing.
- find C.app -name en.lproj should show en.lproj in C.app,
C F.framework, and C H.app.
- find C.app -type l should return nothing, however, on a signed build,
it will still show symbolic links for CodeResources.
- Say "What" again. Say "What" again. I dare you. I double-dare you.
- With English or U.S. English as the top or only choices in the
International (10.5) or Language & Text (10.6) system preference
pane's Language tab, the localized language should be English.
- In this configuration, the Accept-Language header field should be
"en-US,en;q=0.8". See http://whatsmyuseragent.com/ and look for
HTTP_ACCEPT_LANGUAGE.
Review URL: http://codereview.chromium.org/345057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(This is in preparation for a very large reworking of BrowserThemeProvider).
BUG=http://crbug.com/21121
Review URL: http://codereview.chromium.org/338027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
with the StringPiece class in icu4.2, which is a problem
when trying to use the system version of icu.
Review URL: http://codereview.chromium.org/193072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
lproj folders with '-' instead of '_', Cocoa fails to load things at runtime from within them.
Map the names when writing lproj folders to use underscore.
Put an option on the helper script to control dash/underscore mapping since we need support for both.
TEST=try chinese and traditional chinese, they work now.
BUG=20441
Review URL: http://codereview.chromium.org/187011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/173274
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
folder.
Added a string for the products short name, this is current mac only, and is used for the application menu title via the infoplist.strings file.
Added source for a tool to build InfoPlist.strings files based on the values within the GRD files.
Run the InfoPlist.strings generation tool during the build.
Added a script to take a string and list of locale and generate all the versions of the string.
Wired up the string locale tool so GYP knows about all the inputs/outputs from the InfoPlist.strings generation tool.
Stop setting some of the Info.plist keys that are now covered by the InfoPlist.strings files.
Update the mac links script to stop creating a resources link.
Add a shim to nuke the helper's resource link so it can get a real folder.
Helper in in chrome_paths_mac to find the main app's bundle (that the helper lives in).
At startup, if not the browser, set the main bundle to be the parent of this bundle.
Fix up the breakpad init to use the mac_util helper for main bundle.
TEST=when runnining in the supported languages, Finder Get Info should show a localized copyright. The process names in activity monitor should also be correct and show localized names once the TC work is done.
BUG=19019
Review URL: http://codereview.chromium.org/171040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24104 0039d316-1c4b-4281-b951-d872f2087c98
|