| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
disable pyauto (for windows) and performance_ui_tests (all).
BUG=236217
Review URL: https://codereview.chromium.org/14564006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
OnMouseRange function from the instrumentation.
I don't want to land this CL now, but I'd like to have it ready so I can land it as soon as the bug is fixed.
NOTRY=True
BUG=145293
Review URL: https://chromiumcodereview.appspot.com/13982013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/13940013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Added cloud_print_service.exe.
Review URL: https://chromiumcodereview.appspot.com/13983012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
NOTRY=True
BUG=145293
Review URL: https://chromiumcodereview.appspot.com/14195017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This causes PDBs to be output with more detailed OMAP data, which in turn gives
us cleaner stack traces.
BUG=
Review URL: https://chromiumcodereview.appspot.com/14189005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=232402
Review URL: https://chromiumcodereview.appspot.com/14200036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now query whether GPO is present and read directly from the corresponding
PReg files. The registry is used only as a fallback source for policy values.
To accomplish this, PolicyLoaderWin now works in two steps: It first converts
the GPO input into base::Value representation and then maps that to proper
policy values. This also unifies the handling for Chrome policy and 3rd-party
policy.
BUG=
TEST=unit tests
TBR=grt@chromium.org, cpu@chromium.org, ben@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193649
Review URL: https://codereview.chromium.org/13619014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
EnsureEndsWithSeparator used to check whether the file existed. This seems bad and unnecessary so I removed it.
I removed file_util::ContainsPath and used the existing file_util::IsParent instead. The functions descriptions are the same but the implementations do slightly different things, which is worrying. The only non-test use of this function to worry about is content/browser/storage_partition_impl_map.cc. As far as I see, the requirements for this seem OK, but I'm not very familiar with this.
After some discussion with akalin, I changed sync/internal_api/sync_manager_impl.cc to be a DCHECK that the path is absolute rather than make it absolute. The old code relied on the behavior of the old function that the argument would be unchanged if the file didn't exist, and this (possibly relative) path would be used later. This behavior doesn't make a lot of sense, and it looks like now that the path is always absolute, so I replaced this call with a DCHECK.
BUG=
Review URL: https://codereview.chromium.org/13196006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Caused lots of unit_tests to fail on XP, such as:
PolicyProviderWinTest/ConfigurationPolicyProviderTest.StringListValue
PolicyProviderWinTest/ConfigurationPolicyProviderTest.IntegerValue
> Change PolicyLoaderWin to load PReg files if possible.
>
> We now query whether GPO is present and read directly from the corresponding
> PReg files. The registry is used only as a fallback source for policy values.
> To accomplish this, PolicyLoaderWin now works in two steps: It first converts
> the GPO input into base::Value representation and then maps that to proper
> policy values. This also unifies the handling for Chrome policy and 3rd-party
> policy.
>
> BUG=chromium:186445
> TEST=unit tests
> TBR=grt@chromium.org, cpu@chromium.org, ben@chromium.org
>
> Review URL: https://codereview.chromium.org/13619014
TBR=mnissler@chromium.org
Review URL: https://codereview.chromium.org/14087006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As it turns out, the PDB finding code assumes that the PDB was
build in the current build and lives at the exact path given
in the PE file. Presumably, the same will apply for source
indexing.
R= grt@chromium.org, mmoss@chromium.org
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/13880011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now query whether GPO is present and read directly from the corresponding
PReg files. The registry is used only as a fallback source for policy values.
To accomplish this, PolicyLoaderWin now works in two steps: It first converts
the GPO input into base::Value representation and then maps that to proper
policy values. This also unifies the handling for Chrome policy and 3rd-party
policy.
BUG=chromium:186445
TEST=unit tests
TBR=grt@chromium.org, cpu@chromium.org, ben@chromium.org
Review URL: https://codereview.chromium.org/13619014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R= mmoss@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14076002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R= chrisha@chromium.org, kerz@chromium.org, mmoss@chromium.org
Review URL: https://chromiumcodereview.appspot.com/13686015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit e59558b78e8c6a1b0bd916a724724b638c3c91b6.
Revert "Fix build after r193020."
This reverts commit 558a35897f6b3ffbcaefde927c1f150b815d140a.
Revert "Really fix build after r193020."
This reverts commit e3748a79b523a8d365d4a33ef986eebb4186fa78.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/13466012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The cloud policy protobuf is generated by a python script from the policy
templates file; a helper function that converts those protobufs to base::Values
is also generated. This change skips the protobuf and code generation for
policies that are not supported on the target platform.
It also filters policies that have a limited 'supported_on' version for the
matching platform; currently this only affects the HideWebStorePromo policy.
Changes in a linux chromeos=1 Release build:
- CloudPolicySettings goes from 216 to 172 fields
- cloud_policy_generated.cc goes from 4337 to 3193 lines
- chrome binary size decreases 45KB, of a total of 48MB
BUG=141368
Review URL: https://chromiumcodereview.appspot.com/12987009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/13429002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This has been replaced with the more complex/fancy script at
https://code.google.com/p/chromium/codesearch#chromium/src/tools/metrics/histograms/extract_histograms.py
BUG=none
Review URL: https://chromiumcodereview.appspot.com/13430002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
For this, copied metrics.js library from file manager.
BUG=164227
TEST=Open chrome://user-actions, and then click at notifications' body, buttons or dismiss it. Observe that corresponding events get printed on the page. Check for both component and non-component extensions. Wait for several days and check that the data appears at the dashboard.
Review URL: https://chromiumcodereview.appspot.com/13180002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
string_piece.h was moved into base/strings/ in r191206 -
https://chromiumcodereview.appspot.com/12982018/
TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/13247007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This moves includes from using base/sys_string_conversions.h to the new location in base/strings/sys_string_conversions.h
BUG=196305
Review URL: https://codereview.chromium.org/13042020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=jhawkins@chromium.org
BUG=none
Review URL: https://chromiumcodereview.appspot.com/12703006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This uses Syzygy's new filtering feature to avoid instrumenting functions with known and deferred bugs.
BUG=
Review URL: https://chromiumcodereview.appspot.com/12655008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Previous method of using process id to determind which crash dumps belong to which browser window didn't work because crash service only got the child process. Here, we pass the crash dump directory through ClientInfo.
Review URL: https://chromiumcodereview.appspot.com/12636003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=178525
TEST=With InstantExtended enabled, open chrome://user-actions
in another window and click on a Most Visited tile on the NTP.
Check that InstantExtended.MostVisitedClicked gets added to
chrome://user-actions.
Review URL: https://chromiumcodereview.appspot.com/12802002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the chrome/browser/policy/proto directory and move the contents
to chrome/browser/policy/cloud/proto and
chrome/browser/chromeos/policy/proto, respectively. Split the gyp rules
to reflect that structure so unneeded protos are not compiled on
configurations that don't need them.
BUG=None
TEST=Compiles and passes tests.
Review URL: https://codereview.chromium.org/12231003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/12387035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=178525
TEST=Go to chrome://user-actions and check that the new
actions appear as you switch tabs or windows.
Review URL: https://chromiumcodereview.appspot.com/12599007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most autofill strings are used there since components/autofill came into
existence.
BUG=none
TEST=script no longer erroneously lists autofill strings as unused
TBR=estade
Review URL: https://codereview.chromium.org/12408024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chromeactions.txt also picked up some hashes for other actions
that were added but didn't update the file.
BUG=178525
TEST=Click on a clickable doodle or search through
the omnibox and check that the new UMA action is
shown on chrome://user-actions.
Review URL: https://chromiumcodereview.appspot.com/12546011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a followup CL to: https://codereview.chromium.org/12588004/
R=gab@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12627003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=gab@chromium.org
BUG=180996
Review URL: https://codereview.chromium.org/12588004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=IDS_BLUETOOTH_DEVICE_* strings disappear from the output of this script
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/12395013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=178525
TEST=monitor chrome://user-actions/ to see the new/updated actions
being triggered as you interact with the BMB
Review URL: https://chromiumcodereview.appspot.com/12388024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=176639
Review URL: https://codereview.chromium.org/12377036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=175186
TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12378016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=It prints the browser_options.html in the error when run without
the CL https://codereview.chromium.org/12340123/ applied.
R=isherman
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/12319158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This got ommitted from https://chromiumcodereview.appspot.com/12342040/.
Apparently, a number of other actions didn't get added to chromeactions.txt,
as the script added those as well.
BUG=178525
Review URL: https://chromiumcodereview.appspot.com/12319156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/12316160
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the debug/release mode regardless of x86/x64 platform
and also pick up the right CRT DLLs
BUG=166496
Review URL: https://chromiumcodereview.appspot.com/12326117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=178257
Review URL: https://codereview.chromium.org/12342002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
src/chrome/tools/build/OWNERS specifies that kerz+mmoss are there mainly for */FILES.cfg
However after creating src/chrome/tools/build/win/OWNERS, we get most of the FILES.cfg requests although the intent was that we would own the scripts in that directory; most of us have no experience with FILES.cfg and it's probably better that kerz+mmoss keep owning these.
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/12328058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Add utf_string_conversions to base namespace.
>
> This adds "using"s for all functions so those can be fixed in a separate pass.
>
> This converts the "Wide" versions of the functions in the Chrome directory as a first pass on the changeover.
>
> BUG=
>
> Review URL: https://codereview.chromium.org/12314090
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/12315071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds "using"s for all functions so those can be fixed in a separate pass.
This converts the "Wide" versions of the functions in the Chrome directory as a first pass on the changeover.
BUG=
Review URL: https://codereview.chromium.org/12314090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=sky
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL combines entry points for four different kinds of Chromoting processes into a single shared entry point routine. The "--type" command line parameter is used to determine the type of the processes to be launched.
This effectively makes all the executabes interchangable, reducing the number of EXE binaries to two: remoting_host.exe and remoting_desktop.exe. The latter is needed because of level="requireAdministrator" and uiAccess="true" settings in its manifest.
Collateral changes:
- Added a debug only remoting_console.exe binary that can run in the console.
- dpiAware=true is set via the manifest instead of calling SetProcessDPIAware().
- A cross-platform define REMOTING_ENABLE_BREAKPAD is now used to enable Breakpad integration code.
- The "--host-config" command line switch is not passed to the network process by the multi-process daemon.
- The "--elevate" and "--version" command line switches are processed by the shared entry point now.
- The usage message has been updated.
BUG=170200
Review URL: https://chromiumcodereview.appspot.com/12328040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
of Unidrv, which usually has extension gpd.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/12335028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184180 0039d316-1c4b-4281-b951-d872f2087c98
|