summaryrefslogtreecommitdiffstats
path: root/chrome/utility
Commit message (Collapse)AuthorAgeFilesLines
* Collect statistics from the importer on empty usernames and passwords from ↵vasilii2014-10-221-0/+11
| | | | | | | | | | | | other browsers. Also revert https://codereview.chromium.org/579813002 BUG=404012 Review URL: https://codereview.chromium.org/665113002 Cr-Commit-Position: refs/heads/master@{#300656}
* Cleanup: Better constify some strings in chrome.thestig2014-10-227-23/+22
| | | | | | | | Also fix passing by non-const reference in chromedriver. Review URL: https://codereview.chromium.org/635623003 Cr-Commit-Position: refs/heads/master@{#300629}
* Standardize usage of virtual/override/final in chrome/dcheng2014-10-2115-83/+70
| | | | | | | | | | | | This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/653773004 Cr-Commit-Position: refs/heads/master@{#300465}
* Convert ARRAYSIZE_UNSAFE -> arraysize in chrome/, outside of chrome/browser/.viettrungluu2014-10-162-3/+3
| | | | | | | | | R=thestig@chromium.org BUG=423134 Review URL: https://codereview.chromium.org/641363003 Cr-Commit-Position: refs/heads/master@{#299856}
* Make ARRAYSIZE_UNSAFE() just use arraysize().viettrungluu2014-10-141-4/+7
| | | | | | | | | | | For every two problems that C++11 causes, it fixes at least one. R=thestig@chromium.org,tsepez@chromium.org BUG=423134 Review URL: https://codereview.chromium.org/647753003 Cr-Commit-Position: refs/heads/master@{#299419}
* Change PDF scaling factor from double to float.pkasting2014-10-092-11/+13
| | | | | | | | | | | | | | | | This ultimate consumers of this want a float anyway, so changing to be a float all the way through is less misleading. This also avoids some "value possibly truncated" warnings (currently disabled) on MSVC. This also removes a couple of scale-related functions in metafile_skia_wrapper.* that seem to be entirely unused. BUG=none TEST=none Review URL: https://codereview.chromium.org/641923002 Cr-Commit-Position: refs/heads/master@{#298980}
* Add mkwst@chromium.org to IPC OWNERS files.mkwst2014-10-092-0/+2
| | | | | | | | | NOTRY=true TBR=darin@chromium.org Review URL: https://codereview.chromium.org/636203003 Cr-Commit-Position: refs/heads/master@{#298800}
* Replace FINAL and OVERRIDE with their C++11 counterparts in chrome/utilitymohan.reddy2014-10-0921-56/+56
| | | | | | | | | | | This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Review URL: https://codereview.chromium.org/638863002 Cr-Commit-Position: refs/heads/master@{#298788}
* Rewrite line endings from CRLF to LF for a bunch of files.Daniel Cheng2014-10-071-87/+87
| | | | | | | | | | | | | There's a lot of other files with CRLF line endings in test data, third_party, and tools. Out of caution, those files have been left unchanged, in case anything depends on the CRLF being present. BUG=420796 TBR=darin@chromium.org, rsleevi@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/630333002 Cr-Commit-Position: refs/heads/master@{#298348}
* Media Galleries API: Update OWNERS files to reflect team changes.tommycli2014-09-301-2/+1
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/618753003 Cr-Commit-Position: refs/heads/master@{#297507}
* Importer - Change const char* foo to const char foo[]n.bansal2014-09-291-28/+34
| | | | | | | | | | | | Cleanup patch to address below mentioned issue - [*] Change const char* foo to const char foo[] BUG=416468 Review URL: https://codereview.chromium.org/587403002 Cr-Commit-Position: refs/heads/master@{#297282}
* Handle large wallpaper decoding in utility process:glevin2014-09-264-10/+135
| | | | | | | | | | | | | | Images over 32M pixels exceed IPC message limit size. In ChromeContentUtilityClient::DecodeImage(), cut image dimensions in half to minimize quality loss and allow decoded image to be returned via IPC message. BUG=366825 TEST=ChromeContentUtilityClientTest.DecodeImageSizeLimit; Set ChromeOS wallpaper using JPGs attached to bug Committed: https://crrev.com/d9d0e601c4c45ec8f2fb1d148e68458d9baa4e24 Cr-Commit-Position: refs/heads/master@{#296407} Review URL: https://codereview.chromium.org/482163002 Cr-Commit-Position: refs/heads/master@{#296939}
* [Mac] Use raw disks (/dev/rdisk#) in image_writer_mac.jackhou2014-09-262-1/+8
| | | | | | | | | | | | | | | | | | | | | For some USB drives, writes on Mac are much slower than using the old image creator. This is most likely because the implementation in Chrome uses /dev/disk# whereas the old implementation used /dev/rdisk# whenever possible. The main requirement is that writes are in multiples of the block size, but since ImageWriter::WriteChunk always writes in multiples of kMemoryAlignment (4096), it should be fine to always use the raw disk. My brief tests using a Lexar JumpDrive 16GB and a 1.6GB image: before: ~6.5 minutes to write, same to verify after: ~5 minutes to write, ~1.5 minutes to verify BUG=415891 Review URL: https://codereview.chromium.org/599853002 Cr-Commit-Position: refs/heads/master@{#296875}
* Remove implicit HANDLE conversions from chrome.rvargas2014-09-252-3/+5
| | | | | | | | | BUG=416722 R=thestig@chromium.org Review URL: https://codereview.chromium.org/606473002 Cr-Commit-Position: refs/heads/master@{#296613}
* Move SafeManifestParser to //extensionsrockot2014-09-242-10/+12
| | | | | | | | | | | | | This moves SafeManifestParser to extensions_browser. Also creates a new ExtensionUtility IPC message class in which to define extensions utility process messages. The relevant manifest parsing messages have been moved into this class. BUG=398671 Review URL: https://codereview.chromium.org/464613002 Cr-Commit-Position: refs/heads/master@{#296508}
* Revert of Large wallpaper decoding in utility process (patchset #5 id:190001 ↵jiayl2014-09-244-122/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/482163002/) Reason for revert: Speculative revert for unit_tests failures: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/31845/steps/unit_tests/logs/DecodeImageSizeLimit Original issue's description: > Handle large wallpaper decoding in utility process: > Images over 32M pixels exceed IPC message limit size. In ChromeContentUtilityClient::DecodeImage(), cut image dimensions in half to minimize quality loss and allow decoded image to be returned via IPC message. > > BUG=366825 > TEST=ChromeContentUtilityClientTest.DecodeImageSizeLimit; Set ChromeOS wallpaper using JPGs attached to bug > > Committed: https://crrev.com/d9d0e601c4c45ec8f2fb1d148e68458d9baa4e24 > Cr-Commit-Position: refs/heads/master@{#296407} TBR=dcheng@chromium.org,bshe@chromium.org,skuhne@chromium.org,sky@chromium.org,tsepez@chromium.org,yoz@chromium.org,glevin@chromium.org NOTREECHECKS=true NOTRY=true BUG=366825 Review URL: https://codereview.chromium.org/600913002 Cr-Commit-Position: refs/heads/master@{#296457}
* Handle large wallpaper decoding in utility process:glevin2014-09-244-10/+122
| | | | | | | | | | | Images over 32M pixels exceed IPC message limit size. In ChromeContentUtilityClient::DecodeImage(), cut image dimensions in half to minimize quality loss and allow decoded image to be returned via IPC message. BUG=366825 TEST=ChromeContentUtilityClientTest.DecodeImageSizeLimit; Set ChromeOS wallpaper using JPGs attached to bug Review URL: https://codereview.chromium.org/482163002 Cr-Commit-Position: refs/heads/master@{#296407}
* Replace forward_dependent_configs with public_depsBrett Wilson2014-09-231-1/+2
| | | | | | | | | | | | This is the new name. It has the same meaning but additionally with a "you can use the headers" permission. Rename direct_dependent_configs to public_configs. This is the new name with identical meaning. TBR=jamesr Review URL: https://codereview.chromium.org/595073002 Cr-Commit-Position: refs/heads/master@{#296302}
* Remove implicit conversions from scoped_refptr to T* in chrome/dcheng2014-09-201-1/+1
| | | | | | | | | | | This patch was generated by running the rewrite_scoped_refptr clang tool on a Mac build. BUG=110610 Review URL: https://codereview.chromium.org/591493002 Cr-Commit-Position: refs/heads/master@{#295854}
* Importer -- Use IPC_STRUCT_TRAITS macros.tsepez2014-09-171-1/+2
| | | | | | | | | | | | | | | | | This is a continuation of https://codereview.chromium.org/573503002/ The patch replaces hand-written code in the importer module with IPC macros. The patch is complicated by the need to share param traits between test-only and chrome code, which introduces the new profile_import_process_param_traits_macros.h file. patch from issue 573503002 BUG= Review URL: https://codereview.chromium.org/583433002 Cr-Commit-Position: refs/heads/master@{#295364}
* Use file handles to interact with utility process.vitalybuka2014-09-172-109/+93
| | | | | | | | | | | Spool pages as they returned from conversion instead of waiting for entire document. Service process loads each PDFs once per print job, instead of once per page. BUG=408184 Review URL: https://codereview.chromium.org/566693002 Cr-Commit-Position: refs/heads/master@{#295360}
* GN: Get //chrome/* mostly working on androidJames Robinson2014-09-171-1/+1
| | | | | | | | | | | | | This gets the //chrome subtree down to a fairly small number of build errors on Android. Most of the changes are making features not enabled on android like extensions and plugins properly guarded. This also adds a few jni targets and fixes up some bitrotted bits. R=brettw@chromium.org, cjhopman@chromium.org Review URL: https://codereview.chromium.org/571863002 Cr-Commit-Position: refs/heads/master@{#295231}
* PrintingHandler in utility process is required for Windows even without full ↵vitalybuka2014-09-093-6/+15
| | | | | | | | | | | | printing. Makes possible to print from windows with printing_enabled=2. BUG=374321 Review URL: https://codereview.chromium.org/549423002 Cr-Commit-Position: refs/heads/master@{#293984}
* Add wfh@chromium.org to ipc OWNERS filesWill Harris2014-09-082-0/+2
| | | | | | | | | BUG=None R=thestig@chromium.org Review URL: https://codereview.chromium.org/550503003 Cr-Commit-Position: refs/heads/master@{#293783}
* Add in a missing call to propagate the extension choices to the Save As dialog.erikwright2014-09-081-0/+1
| | | | | | | | BUG=407972 Review URL: https://codereview.chromium.org/544123003 Cr-Commit-Position: refs/heads/master@{#293715}
* Remove noamsml@ from OWNERSnoamsml2014-09-051-1/+0
| | | | | | | | | | Remove noamsml@ from all OWNERS files. NOTRY=true Review URL: https://codereview.chromium.org/541943002 Cr-Commit-Position: refs/heads/master@{#293470}
* Implement "Autofill form data" import for Firefoxn.bansal2014-09-054-1/+73
| | | | | | | | | | | | | | | | | | This patches adds support to import autofill form data from Firefox. Firefox stores form data in formhistory.sqlite file and currently Chrome's firefox importer doesn't import data from it. With this patch, "Autofill form data" option is available in import menu and allows user to import form data from Firefox. The imported form data is stored in autofill table and is then used in forms for autocomplete. BUG=59087 Review URL: https://codereview.chromium.org/480953002 Cr-Commit-Position: refs/heads/master@{#293381}
* Pass credentials for WifiManager in Windows.noamsml2014-08-293-17/+6
| | | | | | | | BUG=370071 Review URL: https://codereview.chromium.org/343053002 Cr-Commit-Position: refs/heads/master@{#292700}
* Media gallery fixups for scoped_refptr<T> operator T* removal.dcheng2014-08-292-11/+18
| | | | | | | | BUG=110610 Review URL: https://codereview.chromium.org/518743002 Cr-Commit-Position: refs/heads/master@{#292664}
* Remove cevans@ from OWNERS files.thestig2014-08-292-2/+0
| | | | | | | | NOTRY=true Review URL: https://codereview.chromium.org/524433003 Cr-Commit-Position: refs/heads/master@{#292549}
* Removed print_web_view_helper_win.ccvitalybuka2014-08-282-10/+10
| | | | | | | | | | | | Removed win_pdf_metafile_for_printing gyp option. Removed WIN_PDF_METAFILE_FOR_PRINTING define. BUG=170859 TBR=yzshen Review URL: https://codereview.chromium.org/516823002 Cr-Commit-Position: refs/heads/master@{#292501}
* Remove implicit conversions from scoped_refptr to T* in chrome/dcheng2014-08-261-3/+3
| | | | | | | | | | | This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Review URL: https://codereview.chromium.org/511473002 Cr-Commit-Position: refs/heads/master@{#292012}
* Work on GN build of Chrome.Brett Wilson2014-08-261-3/+6
| | | | | | | | | | | Fixes the rest of the non-rtc and non-vpx linker errors for the chrome target. BUG= R=ajwong@chromium.org Review URL: https://codereview.chromium.org/505853003 Cr-Commit-Position: refs/heads/master@{#291952}
* Change base/file_utils.h includes to base/files/file_utils.h in chrome/thestig2014-08-2614-15/+15
| | | | | | Review URL: https://codereview.chromium.org/486843004 Cr-Commit-Position: refs/heads/master@{#291880}
* Experimentally isolate GetSaveFileName in a utility process.erikwright@chromium.org2014-08-222-0/+36
| | | | | | | | | | | Shell operations may cause 3rd-party shell extensions to be loaded into the calling process. Isolating them in a utility process protects the browser process from potential instability. BUG=73098 Review URL: https://codereview.chromium.org/487453002 Cr-Commit-Position: refs/heads/master@{#291416} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291416 0039d316-1c4b-4281-b951-d872f2087c98
* Experimentally isolate OpenItemViaShell in a utility process.erikwright@chromium.org2014-08-212-0/+8
| | | | | | | | | | | Shell operations may cause 3rd-party shell extensions to be loaded into the calling process. Isolating them in a utility process protects the browser process from potential instability. BUG=73098 Review URL: https://codereview.chromium.org/431343002 Cr-Commit-Position: refs/heads/master@{#291128} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291128 0039d316-1c4b-4281-b951-d872f2087c98
* This patch parses search-metadata.json that is used to storen.bansal@samsung.com2014-08-191-0/+28
| | | | | | | | | | | | | | keywords for search engines in Firefox. GetSearchEnginesXMLDataFromJSON() is modified to parse search-metadata.json also and include keyword information in xml string. BUG=52344 Review URL: https://codereview.chromium.org/426653002 Cr-Commit-Position: refs/heads/master@{#290518} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290518 0039d316-1c4b-4281-b951-d872f2087c98
* Experimentally isolate GetOpenFileName in a utility process.erikwright@chromium.org2014-08-143-0/+106
| | | | | | | | | | | GetOpenFileName can cause 3rd-party shell extensions to be loaded into the caller's process. By putting it in a separate process we protect the browser process from potential instability. BUG=73098 Review URL: https://codereview.chromium.org/419523006 Cr-Commit-Position: refs/heads/master@{#289625} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289625 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 289312 "Move StringToUpperASCII and LowerCaseEqualsASCII ..."brettw@chromium.org2014-08-132-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace > > Convert LowerCaseEqualsASCII to take StringPiece. In the current patch this is > generally a NOP but will allow me to delete the other 4 variants in a followup > (wanted to do that separately since that will require more review, since > callsites will be changed in nontrivial ways). > > In some cases, LowerCaseEqualsASCII is called with a WebString, which no > longer is implicitly converted. I added base::string16(...) around such > calls to force the right conversion. It happened in these files: > window_container_type.cc > savable_resources.cc > render_view_impl.cc > blink_ax_tree_source.cc > password_form_conversion_utils.cc > translate_helper.cc > chrome_render_view_observer.cc > dom_serializer_browsertest.cc > > R=jamesr@chromium.org > > Review URL: https://codereview.chromium.org/448143008 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/474483002 Cr-Commit-Position: refs/heads/master@{#289320} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289320 0039d316-1c4b-4281-b951-d872f2087c98
* Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespacebrettw@chromium.org2014-08-132-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | Convert LowerCaseEqualsASCII to take StringPiece. In the current patch this is generally a NOP but will allow me to delete the other 4 variants in a followup (wanted to do that separately since that will require more review, since callsites will be changed in nontrivial ways). In some cases, LowerCaseEqualsASCII is called with a WebString, which no longer is implicitly converted. I added base::string16(...) around such calls to force the right conversion. It happened in these files: window_container_type.cc savable_resources.cc render_view_impl.cc blink_ax_tree_source.cc password_form_conversion_utils.cc translate_helper.cc chrome_render_view_observer.cc dom_serializer_browsertest.cc R=jamesr@chromium.org Review URL: https://codereview.chromium.org/448143008 Cr-Commit-Position: refs/heads/master@{#289312} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289312 0039d316-1c4b-4281-b951-d872f2087c98
* Use a qualified path for grit includes in various chrome/ directories.thestig@chromium.org2014-08-137-12/+9
| | | | | | | | | BUG=401588 Review URL: https://codereview.chromium.org/450053003 Cr-Commit-Position: refs/heads/master@{#289213} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289213 0039d316-1c4b-4281-b951-d872f2087c98
* Move ini_parser from base to chrome/commonbrettw@chromium.org2014-08-111-2/+2
| | | | | | | | | | This was moved to base apparently thinking it could be shared with a media gallery thing that seems not to have panned out. Review URL: https://codereview.chromium.org/453703002 Cr-Commit-Position: refs/heads/master@{#288814} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288814 0039d316-1c4b-4281-b951-d872f2087c98
* Allow drag-and-drop of zipped extensions on chrome://extensionselijahtaylor@chromium.org2014-08-092-0/+18
| | | | | | | | | | TEST=drag zip file extension to chrome://extensions BUG=395311 Review URL: https://codereview.chromium.org/406713002 Cr-Commit-Position: refs/heads/master@{#288545} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288545 0039d316-1c4b-4281-b951-d872f2087c98
* Move UpdateManifest to //extensionsrockot@chromium.org2014-08-081-1/+1
| | | | | | | | | | | | | | | This just moves update_manifest.h/cc into the extensions_common target. Precursor to moving manifest parsing code and ultimately the rest of the download/install/update code. BUG=398671 TBR=dcheng@chromium.org for IPC messages (header move only) Review URL: https://codereview.chromium.org/454873005 Cr-Commit-Position: refs/heads/master@{#288430} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288430 0039d316-1c4b-4281-b951-d872f2087c98
* Separate CryptoVerifyImpl into its own file.stevenjb@chromium.org2014-08-081-2/+2
| | | | | | | | | | | | | | This eliminates some dependencies from NetworkingPrivateServiceClient that will allow it to be moved to src/extensions. It also changes NetworkingPrivatCrypto from a class to a namespace since that is how we use it. BUG=363776 Review URL: https://codereview.chromium.org/442073003 Cr-Commit-Position: refs/heads/master@{#288396} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288396 0039d316-1c4b-4281-b951-d872f2087c98
* Fix accidental octal literal in pwg_encoder.ccnoamsml@chromium.org2014-08-081-1/+1
| | | | | | | | | | | | Remove leading zero to fix literal that was not meant to be octal in pwg_encoder.cc. BUG=401714 Review URL: https://codereview.chromium.org/447233004 Cr-Commit-Position: refs/heads/master@{#288264} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288264 0039d316-1c4b-4281-b951-d872f2087c98
* Created helper class for parsing Apple style XML dictionaries.krb@chromium.org2014-08-074-212/+266
| | | | | | | | | Converted iTunes and iPhotos parser to use it. BUG=302745 Review URL: https://codereview.chromium.org/436293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287940 0039d316-1c4b-4281-b951-d872f2087c98
* Fix invalid array access in OnRobustJPEGDecodeImage().tnagel@chromium.org2014-08-061-1/+2
| | | | | | | | | | | | | This doesn't seem to be a problem for release builds, but in debug builds the invalid array access causes STL errors: error: attempt to subscript container with out-of-bounds index 0, but container only holds 0 elements. BUG=401161 Review URL: https://codereview.chromium.org/446853002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287884 0039d316-1c4b-4281-b951-d872f2087c98
* Fix various bits of error-handling in NSSDecryptor.davidben@chromium.org2014-08-062-2/+13
| | | | | | | | | | String may be empty. Base64-decode may fail. BUG=none Review URL: https://codereview.chromium.org/427303004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287851 0039d316-1c4b-4281-b951-d872f2087c98
* Componentize component_updater: Decouple in-process DeltaUpdateOp from ↵tommycli@chromium.org2014-08-051-10/+4
| | | | | | | | | | | | | | out-of-process version. The in-process DeltaUpdateOps don't require content/ and can be eventually used on iOS, whereas the out-of-process version needs to stay in chrome/. Part 1d in design doc here: https://docs.google.com/document/d/1F76yNZCnPnGzgNXhI-sCFKlXulwx_s_OKTGbJS5NhbA/edit?usp=sharing BUG=371463 Review URL: https://codereview.chromium.org/420503002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287484 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-14 12:17:35 +0000