summaryrefslogtreecommitdiffstats
path: root/chrome/views/base_button.cc
Commit message (Collapse)AuthorAgeFilesLines
* Don't focus unfocusable things.pkasting@chromium.org2009-02-131-2/+1
| | | | | | Review URL: http://codereview.chromium.org/20348 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9765 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 4830: We navigate back after closing the Save As dialog.finnur@google.com2008-12-231-2/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | If you use Alt-Shift-T and the arrow keys to go to the Page menu and then launch the Save Page As dialog, we would navigate back after saving the page. This is because once we close the Save As dialog with Enter, focus goes to the Back button (which arguable is also wrong, see issue 5750) and it receives a KeyRelease(Enter), which causes us to navigate back right after saving the page. In Windows, pressing Enter while a button has focus clicks the button on KeyPressed, whereas we currently click the button on KeyRelease. This patch makes Chrome mimic native Windows behavior. We retain the current behavior for Space, however, which clicks on KeyReleased in both Chrome and Windows. BUG=4830 TEST=Native Chrome buttons should click buttons on KeyPress when using Enter and on KeyRelease when using Space. Review URL: http://codereview.chromium.org/16202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7406 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in showing context menu for buttons. In particular becausesky@google.com2008-11-121-0/+11
| | | | | | | | | | | | we weren't resetting state before showing the context menu it was possible for the button to stay in a HOT state even though it isn't. BUG=2620 TEST=see bug Review URL: http://codereview.chromium.org/10835 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5300 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeViews namespace to viewsben@chromium.org2008-10-161-18/+11
| | | | | | http://crbug.com/2188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3495 0039d316-1c4b-4281-b951-d872f2087c98
* Convert HitTest/GetViewForPoint to use gfx::Pointben@chromium.org2008-10-141-4/+4
| | | | | | | http://crbug.com/2186 Review URL: http://codereview.chromium.org/7331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3384 0039d316-1c4b-4281-b951-d872f2087c98
* Rename legacy methods that were in CamelCase to unix_hacker.erg@google.com2008-09-171-4/+4
| | | | | | | | | Required going through and modifying some of the code to solve name clashes. Review URL: http://codereview.chromium.org/2945 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2337 0039d316-1c4b-4281-b951-d872f2087c98
* Extends the toolbar keyboard support. Adds skipping of unavailable elements ↵klink@google.com2008-08-261-2/+2
| | | | | | of the toolbar, to accomodate for quicker keyboard traversal. Fixes tooltip display on initial focusing of the toolbar. Also fixes the support for VK_SPACE and VK_ENTER. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1388 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Large patch set (159 files total) to cleanup the includes.maruel@google.com2008-08-151-7/+5
| | | | | | | | | | - Slightly reduce the size of the generated .lib files ~3%. - Reduce the number of implicit and explicit atl and windows includes. hooray! - Help incremental build by reducing the number of unnecessary included files. - Split some template class in two, one base class for the common code and the specialization that inherits from the base class. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@937 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome to the repository.initial.commit2008-07-261-0/+333
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-10 17:10:58 +0000