summaryrefslogtreecommitdiffstats
path: root/chrome/views/chrome_menu.cc
Commit message (Collapse)AuthorAgeFilesLines
* Rename Container->Widgetben@chromium.org2008-11-211-9/+9
| | | | | | | | | R=erg review url = http://codereview.chromium.org/11348/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5849 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash when showing modal dialog from context menu. With thissky@google.com2008-11-191-23/+33
| | | | | | | | | | | | | | | | | | | | | sequence ContainerWin remains on the stack while the modal dialog is showing. Prior to this fix we would delete the ContainerWin, so that when the modal dialog closed control would return to a deleted object. The fix is to effectively delay deleting of the ConatinerWins used by menus. BUG=4580 TEST=This is the sequence that triggered the crash: open a folder on the bookmark bar, right child on a child folder that has more than 15 descendant URLs, click open all, a dialog should appear asking if you really want to open all, click cancel and make sure it doesn't crash. This is a subtle change to bookmark menus though, would be good to thoroughly exercise the menus in as many permutations as you can think of. Review URL: http://codereview.chromium.org/11289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5724 0039d316-1c4b-4281-b951-d872f2087c98
* Make border and background setting and getting non-virtual and use the ↵brettw@google.com2008-11-141-3/+3
| | | | | | | | correct style. I was debugging in here and this was annoying me, since there is no reason for these functions to be virtual. Review URL: http://codereview.chromium.org/10638 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5445 0039d316-1c4b-4281-b951-d872f2087c98
* Three menu bugs:sky@google.com2008-11-131-4/+7
| | | | | | | | | | | | | | | | | | . If a context menu was shown from a menu, then hidden we did not keep mouse capture and bad things happened (menu wouldn't go away when clicking else where, crash ...). . We only update menu sizes on first show of a menu. That way if a context menu doesn't have icons things don't shift around. . If nothing was selected in the menu pressing the context menu showed the context menu for the root. It doesn't make sense for the root menu to have a context menu. BUG=4364 TEST=see bug Review URL: http://codereview.chromium.org/10706 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5397 0039d316-1c4b-4281-b951-d872f2087c98
* Puts chrome menus on a slimfast diet: they are no longer chubby. Isky@google.com2008-11-131-14/+52
| | | | | | | | | | | | | | | added an option such that menus can be rendered in two ways, chubby or skinny. The only places that uses the taller menus is the bookmark bar. I also made the menus use the right font. BUG=1074332 TEST=none Review URL: http://codereview.chromium.org/10865 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5367 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two menu bugs:sky@google.com2008-11-121-1/+20
| | | | | | | | | | | | | | | | | | | . Pressing shift-F10 would make context menu appear then immediately disappear. This is because MenuController was hiding on a WM_SYSKEYUP. I've changed MenuController to do nothing on WM_SYSKEYUP. If a sys key is pressed again, we'll get a WM_SYSKEYDOWN and hide there. . MenuController needed to handle WM_CONTEXTMENU and not dispatch it, otheriwse we could end up with stacked menus. BUG=3685 TEST=bring up bookmark manager, select a row in the table on the right. Press shift-F10 and make sure the context menu appears and stays up. Review URL: http://codereview.chromium.org/10635 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5299 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in menu code. If after dropping you quickly rightsky@google.com2008-11-041-0/+7
| | | | | | | | | | | click the mouse we would crash. This is the same fix as you first saw, I couldn't repro interactive ui test anymore. BUG=4047 TEST=see bug git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4671 0039d316-1c4b-4281-b951-d872f2087c98
* My last fix breaks an interative ui test. I'm going to back out until I ↵sky@google.com2008-11-041-7/+0
| | | | | | | | | | figure out why. TBR=ben Review URL: http://codereview.chromium.org/9353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4656 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in menu code. If after dropping you quickly rightsky@google.com2008-11-041-0/+7
| | | | | | | | | | | click the mouse we would crash. BUG=4047 TEST=see bug Review URL: http://codereview.chromium.org/9346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4647 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for autoscrolling on drag to bookmark tree/table.sky@google.com2008-11-041-6/+3
| | | | | | | | | BUG=674 TEST=none Review URL: http://codereview.chromium.org/9042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4625 0039d316-1c4b-4281-b951-d872f2087c98
* Move Time, TimeDelta and TimeTicks into namespace base.dsh@google.com2008-10-271-1/+3
| | | | | | Review URL: http://codereview.chromium.org/7995 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4022 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeViews namespace to viewsben@chromium.org2008-10-161-4/+4
| | | | | | http://crbug.com/2188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3495 0039d316-1c4b-4281-b951-d872f2087c98
* Make View::SetBounds take a const gfx::Rect& instead of a const CRect&ben@chromium.org2008-10-161-2/+4
| | | | | | | | | | Make View::DidChangeBounds call Layout by default, eliminating this function from most places. http://crbug.com/2186 Review URL: http://codereview.chromium.org/7429 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3471 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ViewContainer to Container and HWNDViewContainer to ContainerWin.ben@chromium.org2008-10-161-7/+7
| | | | | | | http://crbug.com/3430 Review URL: http://codereview.chromium.org/7376 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3441 0039d316-1c4b-4281-b951-d872f2087c98
* Convert GetPreferredSize from:beng@google.com2008-10-151-71/+60
| | | | | | | | | | | | | | | | | void GetPreferredSize(CSize* out); to: gfx::Size GetPreferredSize(); .. and update some other places to use gfx::Size as well. http://crbug.com/2186 Review URL: http://codereview.chromium.org/7344 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3400 0039d316-1c4b-4281-b951-d872f2087c98
* Convert HitTest/GetViewForPoint to use gfx::Pointben@chromium.org2008-10-141-3/+3
| | | | | | | http://crbug.com/2186 Review URL: http://codereview.chromium.org/7331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3384 0039d316-1c4b-4281-b951-d872f2087c98
* Change all ConvertPointTo* methods to use gfx::Point instead of CPoint.ben@chromium.org2008-10-141-40/+41
| | | | | | | | http://crbug.com/2186 Review URL: http://codereview.chromium.org/7317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3365 0039d316-1c4b-4281-b951-d872f2087c98
* Replace View::GetBounds(CRect* bounds) const; with gfx::Rect bounds() const. ben@chromium.org2008-10-141-3/+1
| | | | | | | | http://crbug.com/2186 Review URL: http://codereview.chromium.org/7136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3348 0039d316-1c4b-4281-b951-d872f2087c98
* I'm going to try and land this again. This is exactly the same change as you ↵sky@google.com2008-09-221-6/+22
| | | | | | | | | | | | | | | | reviewed earlier. Fixes mnemonic bug in chrome menus. After this change you can indicate whether menus have mnemonics. Mnemonics are shown if the menus have mnemonics, and the OS says we should show them. BUG=1355952 TEST=add a bookmark and change the title to &foo. Move the bookmark to a folder, click on the folder and make sure the title shows the &. Review URL: http://codereview.chromium.org/4021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2458 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts fix for 2554.sky@google.com2008-09-221-22/+6
| | | | | | Review URL: http://codereview.chromium.org/4017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2445 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes mnemonic bug in chrome menus. After this change you can indicatesky@google.com2008-09-221-6/+22
| | | | | | | | | | | | | whether menus have mnemonics. Mnemonics are shown if the menus have mnemonics, and the OS says we should show them. BUG=1355952 TEST=add a bookmark and change the title to &foo. Move the bookmark to a folder, click on the folder and make sure the title shows the &. Review URL: http://codereview.chromium.org/4002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2442 0039d316-1c4b-4281-b951-d872f2087c98
* Rename legacy methods that were in CamelCase to unix_hacker.erg@google.com2008-09-171-59/+59
| | | | | | | | | Required going through and modifying some of the code to solve name clashes. Review URL: http://codereview.chromium.org/2945 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2337 0039d316-1c4b-4281-b951-d872f2087c98
* This patch is from Andrew Brampton <me@bramp.net>.sky@google.com2008-09-081-3/+8
| | | | | | | | | | | | | | This patches allows menu items in PopUpMenus to be clicked with the right mouse button. menu.cc controls the web content popup menus, and some others chrome_menu{.cc,.h} controls popup menu on the chrome, for example right clicking on a tab. BUG=718 TEST=Bring up any menu (wrench/document) and right click on one of the items. This should select the item. Try the same with any of the bookmark menus. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1838 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup to OneShotTimer and RepeatingTimer: moves more of the member ↵darin@google.com2008-09-031-54/+31
| | | | | | | | | | | variables into the Task subclass. Also included in this change: deprecate MessageLoop::timer_manager(), and change consumers over to use OneShotTimer or RepeatingTimer. R=beng BUG=1346553 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1684 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome changes corresponding to my message_loop_type CL.darin@google.com2008-08-261-6/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1363 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Large patch set (159 files total) to cleanup the includes.maruel@google.com2008-08-151-0/+1
| | | | | | | | | | - Slightly reduce the size of the generated .lib files ~3%. - Reduce the number of implicit and explicit atl and windows includes. hooray! - Help incremental build by reducing the number of unnecessary included files. - Split some template class in two, one base class for the common code and the specialization that inherits from the base class. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@937 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup of RootView. Removes unused double_buffered field fromsky@google.com2008-08-121-1/+1
| | | | | | | | | | | RootView, as well as renaming RootView::ProcessPendingPaint to PaintNow. BUG=1255929 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@750 0039d316-1c4b-4281-b951-d872f2087c98
* A set of tests to exercise chrome menus as well as parts of bookmarksky@google.com2008-08-111-1/+12
| | | | | | | | | | | | bar view. These are disabled until we straighten out the buildbot that is always logged in. BUG=1318922 TEST=this is just a bunch of tests. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@654 0039d316-1c4b-4281-b951-d872f2087c98
* Make tabs affected by context menu actions pulse. The effect is somewhat ↵beng@google.com2008-08-071-0/+3
| | | | | | | | | | subtle since I'm re-using the selection animation. Added support to the Menu Delegate for notifications of when selection moves within the menu. B=1313339 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@523 0039d316-1c4b-4281-b951-d872f2087c98
* Make HWNDViewContainer set up its contents view separately from its Init method.beng@google.com2008-07-301-1/+2
| | | | | | | | | This is needed as a first step in further adjustments I'm going to be making to Window, ClientView, etc. B=1280060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome to the repository.initial.commit2008-07-261-0/+2743
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-20 17:02:34 +0000