summaryrefslogtreecommitdiffstats
path: root/chrome/views/dialog_client_view.cc
Commit message (Collapse)AuthorAgeFilesLines
* Move windowing related objects into chrome/views/window subdir.ben@chromium.org2009-03-171-434/+0
| | | | | | | | TBR=sky Review URL: http://codereview.chromium.org/42272 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11819 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Window->WindowWinben@chromium.org2009-03-141-4/+4
| | | | | | | | | Pull basic Window interface out of WindowWin into new interface, Window. Convert code to use it. Review URL: http://codereview.chromium.org/46079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11699 0039d316-1c4b-4281-b951-d872f2087c98
* rollback againben@chromium.org2009-03-141-4/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11696 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Window->WindowWinben@chromium.org2009-03-141-4/+4
| | | | | | | | | Pull basic Window interface out of WindowWin into new interface, Window. Convert code to use it. Review URL: http://codereview.chromium.org/42201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11695 0039d316-1c4b-4281-b951-d872f2087c98
* revertben@chromium.org2009-03-131-4/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11671 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Window->WindowWinben@chromium.org2009-03-131-4/+4
| | | | | | | | | Pull basic Window interface out of WindowWin into new interface, Window. Convert code to use it. Review URL: http://codereview.chromium.org/42169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11668 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGEdeanm@chromium.org2009-03-101-1/+0
| | | | | | | | | Normalize end of file newlines in chrome/. All files end in a single newline. Review URL: http://codereview.chromium.org/42015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
* Test to see if we can reduce some crashes by deferring delegate destruction ↵ben@chromium.org2009-03-061-5/+0
| | | | | | | | until WM_NCDESTROY. This involves adding a specific method to allow delegates to destroy themselves to WindowDelegate, and moving all delete this calls into implementations of that method (to allow delegates to still respond to WM_DESTROY which is legit). Review URL: http://codereview.chromium.org/40192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11132 0039d316-1c4b-4281-b951-d872f2087c98
* I meant to say !ben@chromium.org2009-03-061-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11070 0039d316-1c4b-4281-b951-d872f2087c98
* Guard against a crash that can impact Dialog boxes ... this one seems to ↵ben@chromium.org2009-03-051-0/+5
| | | | | | | | | have already impacted Window itself, but a NULL check was already inserted in that code. http://crbug.com/4355 Review URL: http://codereview.chromium.org/40183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11047 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 8200: Pressing Esc should cancel dialogs, not commit.finnur@chromium.org2009-02-271-3/+3
| | | | | | | | | | | | | | | | | | | | | When we create the OK & Cancel dialog buttons in DialogClientView, we were registering OK as a handler for Escape, even though the dialog had a Cancel button. This is because we register for Esc if the member variable |cancel_ button_| is NULL. Problem is, that member isn't created until later on in that function. We should be checking the |buttons| flags instead. TEST=Open the Clear Browsing Data dialog, press Tab twice, press Esc and make sure that the dialog closes and nothing is cleared (from whatever checkbox was selected). BUG=8200 Review URL: http://codereview.chromium.org/28267 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10631 0039d316-1c4b-4281-b951-d872f2087c98
* Update include paths for grit files. Go ahead and resorttc@google.com2009-02-221-1/+1
| | | | | | | | the headers too. Review URL: http://codereview.chromium.org/21472 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10167 0039d316-1c4b-4281-b951-d872f2087c98
* Adding more space between dialog contents and the buttons. For XP Classic themeben@chromium.org2008-12-021-1/+1
| | | | | | | | | | | | | | there was close to no space between the tab control and the buttons. The space is aligned with default Windows look for dialogs. BUG=4402 TEST=Verify that all dialogs look good in any XP/Vista theme w.r. to space from dialog contents to buttons. Change by Sverrir Á. Berg <sverrir@google.com>, committing on his behalf. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6240 0039d316-1c4b-4281-b951-d872f2087c98
* In dialogs, when the focus moves to a button, that button should become the ↵jcampan@chromium.org2008-11-081-10/+63
| | | | | | | | | | | | | | default button. When the focus is not a button, then the default button should be the one the delegate specifies. BUG=4132 TEST=Open the option dialog. OK should be the default and focused button. Move the focus around by pressing tab. When a button is selected, it should be the default button. Review URL: http://codereview.chromium.org/10230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5056 0039d316-1c4b-4281-b951-d872f2087c98
* The "extra view" used by the DialogClientView must not be retrieved before ↵ben@chromium.org2008-10-291-8/+14
| | | | | | | | | the contents view has been attached to the view hierarchy. http://crbug.com/2751 Review URL: http://codereview.chromium.org/8681 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4116 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeViews namespace to viewsben@chromium.org2008-10-161-6/+6
| | | | | | http://crbug.com/2188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3495 0039d316-1c4b-4281-b951-d872f2087c98
* Make View::SetBounds take a const gfx::Rect& instead of a const CRect&ben@chromium.org2008-10-161-39/+25
| | | | | | | | | | Make View::DidChangeBounds call Layout by default, eliminating this function from most places. http://crbug.com/2186 Review URL: http://codereview.chromium.org/7429 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3471 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ViewContainer to Container and HWNDViewContainer to ContainerWin.ben@chromium.org2008-10-161-1/+1
| | | | | | | http://crbug.com/3430 Review URL: http://codereview.chromium.org/7376 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3441 0039d316-1c4b-4281-b951-d872f2087c98
* Convert GetPreferredSize from:beng@google.com2008-10-151-15/+12
| | | | | | | | | | | | | | | | | void GetPreferredSize(CSize* out); to: gfx::Size GetPreferredSize(); .. and update some other places to use gfx::Size as well. http://crbug.com/2186 Review URL: http://codereview.chromium.org/7344 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3400 0039d316-1c4b-4281-b951-d872f2087c98
* Rename legacy methods that were in CamelCase to unix_hacker.erg@google.com2008-09-171-7/+7
| | | | | | | | | Required going through and modifying some of the code to solve name clashes. Review URL: http://codereview.chromium.org/2945 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2337 0039d316-1c4b-4281-b951-d872f2087c98
* fix build bustagebeng@google.com2008-09-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2170 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash that occurred because DialogClientView::AcceptWindow wassky@google.com2008-09-051-0/+5
| | | | | | | | | | | | | | | | | getting invoked twice. It appears that because we hide the window then destroy the window after a delay, it is possible for messages to get dispatched after the hide. Dispatching messages after the window was closed made it possible for two enters to be dispatched, which triggered a crash. I've modified the FocusManager to only dispatch key messages if the window is visible. BUG=1361863 TEST=See bug, but also make sure there are no weird focus traversal/accelerator issues in our dialogs. Review URL: http://codereview.chromium.org/251 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1802 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in DialogClientView caused by recursion of Close calls. When ↵beng@google.com2008-08-011-6/+8
| | | | | | | | migrating from Window to DialogClientView, I neglected to insert the check into this function to see if the dialog had already been accepted by the user before trying to abort. B=1304032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244 0039d316-1c4b-4281-b951-d872f2087c98
* Move dialog-specific aspects of ClientView into a new subclass DialogClientView.beng@google.com2008-07-311-0/+410
ClientView becomes a generic representation of the View that occupies the "client area" of a window. All Windows now require a Client View (though they can use the default). Adjust WindowDelegate to provide a method for constructing the ClientView for a Window. The DialogDelegate overrides this to construct the DialogClientView. In the future, other specialized delegates will construct ClientViews specific to them, e.g. WizardDelegate would construct WizardClientView. Adjust the Window Init method to set up this new required Client View, and make some tweaks to CustomFrameWindow to make all this work. Remove all traces of dialog specific handling in Window into DialogClientView. B=1280060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-04-01 01:55:20 +0000