summaryrefslogtreecommitdiffstats
path: root/chrome/views
Commit message (Collapse)AuthorAgeFilesLines
* Revert "revert r8217 until memory tests are fixed." This re-applies r8217.tc@google.com2009-01-202-5/+34
| | | | | | | | | | | This reverts commit r8245. TBR=ben Review URL: http://codereview.chromium.org/18410 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8292 0039d316-1c4b-4281-b951-d872f2087c98
* Generate all chrome .vcproj files:sgk@google.com2009-01-171-19/+145
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Path name translation (/ to \) of various MSVSTool attributes. * Explicit keyword= arguments to MSVSProject. This will likely go away eventually in favor of uniform behavior. * Add a relative_path_substitutions array that can be used to substitute in Visual Studio variable like $(OutDir). * Add a local_directory_prefix that can be set to './' to only affect files in the current directory. * Additional Keyword ordering in Tool attributes to continue to match the default order Visual Studio generates. * Add a Derived() proxy class that can wrap a File node to tell the .vcproj generation that we want the derived file, not its source(s), in the file list. * In the individual *.scons files, add the necessary files (mostly .h files) to file lists, and update MSVSProject() calls with the additional necessary information. Result is identical .vcproj files modulo the following differences: * Four locales .vcproj files (da, en-US, he and zh-TW) with source file orders that don't match the other locale .vcproj files have re-ordered file lists to match the rest. * Cosmetic XML changes (white space, ending tags) in: chrome/app/chrome_dll.vcproj chrome/app/generated_resources.vcproj net/build/net_resources.vcproj * Removal or addition of ./ prefixes from various files that don't match the other file specifications within their individual .vcproj files: chrome/installer/util/util.vcproj net/build/net.vcproj net/build/net_unittests.vcproj * Add missing empty sections (<ToolFiles>, <References>, <Globals>) for consistency with other .vcproj files: chrome/tools/test/image_diff/image_diff.vcproj third_party/libpng/libpng.vcproj third_party/zlib/zlib.vcproj * Add missing RootNameSpace attribute: chrome/test/automation/automation.vcproj testing/gtest.vcproj * Use && instead of \r\n as a command separator, to sidestep XML-generation problems: chrome/app/chrome_exe.vcproj * Remove unnecessary (?) duplicate files in the file list: chrome/browser/views/browser_views.vcproj (event_utils.cc and event_utils.h were duplicated) Review URL: http://codereview.chromium.org/17603 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8253 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add #ifdefs to the views/ code and move windows specific codeerg@google.com2009-01-1713-387/+171
| | | | | | | | | | into their own files to get some files compiling." Conflicts with something that went in in the interim... Review URL: http://codereview.chromium.org/18187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8251 0039d316-1c4b-4281-b951-d872f2087c98
* Add #ifdefs to the views/ code and move windows specific code into their own ↵erg@google.com2009-01-1713-171/+387
| | | | | | | | | files to get some files compiling. Review URL: http://codereview.chromium.org/18136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8250 0039d316-1c4b-4281-b951-d872f2087c98
* revert r8217 until memory tests are fixed.ben@chromium.org2009-01-172-34/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8245 0039d316-1c4b-4281-b951-d872f2087c98
* window.cc should not include browser_list.h ... dependent (non-browser) ↵ben@chromium.org2009-01-162-5/+34
| | | | | | | | | | windows are closed when they receive a notification rather than by being called directly from BrowserList. Also browser_list.cc should not include window.h, required for porting. TEST=Open browser. Open options dialog box. Close browser. Options dialog should close too. Review URL: http://codereview.chromium.org/18328 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8217 0039d316-1c4b-4281-b951-d872f2087c98
* Fix maximized mode drawing offscreen in Classic mode. Apparently Classic, ↵pkasting@chromium.org2009-01-151-7/+14
| | | | | | | | | | | unlike Luna, does not auto-clip maximized windows with an explicitly-set HRGN of NULL, so we have to set one. BUG=5054 TEST=On a desktop extended across multiple monitors, switch to Classic mode, open a Chrome window, and maximize it on one monitor. Make sure it doesn't draw any pixels on the other monitor. Review URL: http://codereview.chromium.org/18258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8062 0039d316-1c4b-4281-b951-d872f2087c98
* Constify the params of a couple View functions, which I'll need for an ↵pkasting@chromium.org2009-01-152-10/+20
| | | | | | | | | upcoming change to be able to call these from someone else's const member function. Also fixes a couple cases of wrong parameter wrapping/"*" binding. Review URL: http://codereview.chromium.org/18251 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8057 0039d316-1c4b-4281-b951-d872f2087c98
* Provides the infrastructure for Browser unit tests that create asky@google.com2009-01-141-1/+4
| | | | | | | | | | | | | BrowserWindow with only a TabStrip. I also converted two ui tests over to unit tests to make sure it all worked. I had to add a bunch of null checks to Browser and a couple of other places. BUG=none TEST=none Review URL: http://codereview.chromium.org/17386 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8007 0039d316-1c4b-4281-b951-d872f2087c98
* Porting in views/phajdan.jr@chromium.org2009-01-137-23/+165
| | | | | | | | | | This actually manages to compile few files on Linux. Porting some other files from views/ would be more difficult, but this view.h change unblocks porting opportunities in other areas. Review URL: http://codereview.chromium.org/17352 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7921 0039d316-1c4b-4281-b951-d872f2087c98
* Removes a bogus DCHECK. This DCHECK is bogus for two reasons:sky@google.com2009-01-081-1/+2
| | | | | | | | | | | | | | | | | | | . it's checking a field that hasn't been set yet, hence the sporadic failure. . It shouldn't check delegate either as inside this class it's possible to supply NULL. I've removed it entirely and added a comment. BUG=5914 TEST=right click on the tab strip and make sure you don't get a DCHECK. Because this relies on random data, it's too hard to write a test for this, additionally I'm sure once we run the interactive ui tests under Purify this'll be covered. Review URL: http://codereview.chromium.org/17439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7777 0039d316-1c4b-4281-b951-d872f2087c98
* Some more GRIT refactoring.tc@google.com2009-01-051-1/+1
| | | | | | | | | | | | | | | | | | Moved the grit .vsprops file from chrome/tools/build/win/ to /tools/grit/build and renamed to using_generated_resources.vsprops. Updated non-chrome projects to use the this new vsprops file. Created a new .rules file and renamed the old one. Now there are grit_resources.rules and grit_localized_resources.rules. The latter is what we use now, but I'll be adding some grd files that use the former in a follow up change. This is just vsprops reshuffling for now. I'll also add a using_generated_resources.scons in a follow up change. Review URL: http://codereview.chromium.org/14901 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7560 0039d316-1c4b-4281-b951-d872f2087c98
* Mass convert ChromeStaticLibrary -> ChromeLibrary, including pulling the ↵evanm@google.com2008-12-261-1/+1
| | | | | | | | | | | updated ICU dep that uses it as well. Add a SHARED scons command-line flag to build shared libraries. Review URL: http://codereview.chromium.org/16477 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7479 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 4830: We navigate back after closing the Save As dialog.finnur@google.com2008-12-231-2/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | If you use Alt-Shift-T and the arrow keys to go to the Page menu and then launch the Save Page As dialog, we would navigate back after saving the page. This is because once we close the Save As dialog with Enter, focus goes to the Back button (which arguable is also wrong, see issue 5750) and it receives a KeyRelease(Enter), which causes us to navigate back right after saving the page. In Windows, pressing Enter while a button has focus clicks the button on KeyPressed, whereas we currently click the button on KeyRelease. This patch makes Chrome mimic native Windows behavior. We retain the current behavior for Space, however, which clicks on KeyReleased in both Chrome and Windows. BUG=4830 TEST=Native Chrome buttons should click buttons on KeyPress when using Enter and on KeyRelease when using Space. Review URL: http://codereview.chromium.org/16202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7406 0039d316-1c4b-4281-b951-d872f2087c98
* Initial generation of native Visual Studio solution filessgk@google.com2008-12-191-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (project files still to come). To wit: * Solution file configuration is in *_sln.scons files (base\base_sln.scons, chrome\chrome_sln.scons). * Individual Project file configuration is in the the .scons file for the relevant target (base\base_unittests.scons, third_party\libxml\libxml.scons, etc.)--that is, where their file lists will live. * MSVSProject() calls are currently placeholders that establish the existence of Project Nodes (and Project dependencies) but don't yet have actual Project configuration information (file lists, .vsprops, etc.). * Configuraiton is very manual. In particular, the entries in the .sln file will be written out in exactly the order specified in the configuration(s). The current ordering is taken from our existing .sln files, so we can generate virtually the same configurations on output. * Generated solution files are nearly byte-for-byte identical with our existing .sln files, modulo: * net\dump_cache has a WebsiteProperties sections (making that configurable per project isn't important right now); * sandbox\sandbox.sln was missing a dependency of base.vcproj on on debug_message.vcproj (present in other .sln files) * webkit\webkit.sln was missing dependencies of WebCore.vcproj on libxml_config.vcproj and libxslt_config.vcproj (present in chrome.sln); * add a handful of other miscellaneous missing dependencies on various .vcproj definitions in chrome.sln (present in other .sln files). * remove stats_viewer.csproj from chrome.sln (sorry, mbelshe), which was complicating the solution configuration with unnecessary (for us) "Mixed Platform" types; * All MSVSFolder(), MSVSProject() and MSVSSolution() calls have hard-wired guid= values taken from our existing configuration, so we can: 1) verify generation of working configs; 2) minimize diffs when checking in generated .sln files. We can remove these in the future in favor of extracting them from existing .sln files if we wish. * Add ChromeMSVSFolder(), ChromeMSVSProject() and ChromeMSVSSolution() wrappers to chromium_builders.py, that gate the underlying call to the env.MSVS*() builders based on whether env.Bit('msvs') is set (i.e., we're in --mode=msvs). * Remove platform-specific gating of to-be-ported .scons files that we now need to load on any platform to generate coheren MSVS files. Move the env.Bit('windows') tests for actually building their executables into the individual .scons files. Review URL: http://codereview.chromium.org/14472 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7297 0039d316-1c4b-4281-b951-d872f2087c98
* Select the Languages tab of the fonts and languages dialog when using ↵pkasting@chromium.org2008-12-192-2/+19
| | | | | | | | spellcheck context menu commands to change spellchecking options. Patch by Mohamed Mansour, r=me,sky; see http://codereview.chromium.org/15031. Tweaked by me. BUG=5639 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7289 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the Home button to the MSAA focus order, if enabled. Also removes an ↵klink@chromium.org2008-12-181-5/+0
| | | | | | | | unnecessary check from ViewAccessibility. Review URL: http://codereview.chromium.org/15026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7239 0039d316-1c4b-4281-b951-d872f2087c98
* Changes menu's Dispatcher to translate/dispatch message beforesky@google.com2008-12-171-1/+6
| | | | | | | | | | | | | returning false. This way we don't screw up the message pump. I also needed to slightly tweak the bookmark bar test that was hitting this code path. BUG=none TEST=none Review URL: http://codereview.chromium.org/15008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7177 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two bugs resulting in bad window resize behavior:sky@google.com2008-12-171-5/+8
| | | | | | | | | | | | | | | | | . Dragging a tab out was forcing the bounds to fit on the monitor. This was a regression introduced during some refactoring. The fix is not to call Window::SetBounds, but instead SetWindowPos (which is roughly what the old code did). . When the bounds of the window change always layout. We need this for the situation where the normal bounds and maximized bounds are the same because we layout differently in the two. BUG=5540 5118 TEST=see description in 5118 Review URL: http://codereview.chromium.org/14511 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7169 0039d316-1c4b-4281-b951-d872f2087c98
* Replace some CRects with gfx::Rectagl@chromium.org2008-12-177-31/+28
| | | | | | | Review URL: http://codereview.chromium.org/14173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7126 0039d316-1c4b-4281-b951-d872f2087c98
* Switch back svn:eol-style=native for .sln, .vcproj and .vsprops files.maruel@chromium.org2008-12-161-655/+655
| | | | | | | Patch fails otherwise on non-Windows platforms. Review URL: http://codereview.chromium.org/14478 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7093 0039d316-1c4b-4281-b951-d872f2087c98
* Landing http://codereview.chromium.org/14450 for m0 (Mohamed Mansour).sky@google.com2008-12-162-14/+15
| | | | | | | | BUG=2186 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7076 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 4376: Press "Tab" key to navigate - Text focus is ↵xji@chromium.org2008-12-161-2/+4
| | | | | | | | | | | | | | | | | | | showing at wrong place in Hebrew and Arabic. when drawing focus rectangle for CheckBox,the left point of the rectangle should be mirrored for RTL text. http://crbug.com/4376 TEST: 1. Launch RTL Chome (for ex: set language as Hebrew). 2. Go to > Customize and Control Google Chrome > Options > Under the Hood or any other Tab 3. Press tab key to navigate thought text options 4. The focus is properly set on the text. (without this fix, the focus is not properly set on the text). Review URL: http://codereview.chromium.org/14452 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7067 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes info bubble painting bug. This was happening because we weresky@google.com2008-12-162-8/+41
| | | | | | | | | | | | | | | | | using layered windows incorrectly. According to the docs if you invoke SetLayeredWindowAttributes, then you shouldn't invoke UpdateLayeredWindow (unless you remove then add the WS_EX_LAYERED style bit). My approach here is to disable the backing buffer for the info bubble. I had problems toggling the WS_EX_LAYERED at the end up the animation. The text field would not paint when I did this... BUG=5351 TEST=bookmark a page. When the bubble appears press shift-tab and make sure you see a focus rect around the remove link. Review URL: http://codereview.chromium.org/14131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7063 0039d316-1c4b-4281-b951-d872f2087c98
* Rip out custom WM_GETMINMAXINFO handling entirely. I think this is a relic ↵pkasting@chromium.org2008-12-163-39/+0
| | | | | | | | | | | of the old Halo Frame. Trying to rip it out halfway results in problems, like the taskbar not un-auto-hiding when Chromium is maximized. This should result in correct handling of maximized windows on multiple monitors with different resolutions, taskbar positions, and auto-hide settings (since we're just using the native Windows code to do everything). BUG=943445 Review URL: http://codereview.chromium.org/14446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7021 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminates the dependencies between views and browser, and also does some ↵klink@chromium.org2008-12-166-443/+29
| | | | | | | | | | | other minor cleanups. The special casing for the OmniBox that used to live in the ViewAccessibility code could be removed due to the fact that the only assistive technologies depending on this case are now testing tools. The end-user tools will see no difference, and the testing tools can access the OmniBox IAccessible by directly giving it keyboard/mouse focus. BUG=2237 Review URL: http://codereview.chromium.org/14036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7020 0039d316-1c4b-4281-b951-d872f2087c98
* A new shot at the old system monitor changelist.mbelshe@google.com2008-12-131-0/+4
| | | | | | Review URL: http://codereview.chromium.org/12883 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6974 0039d316-1c4b-4281-b951-d872f2087c98
* Move skia_utils into the skia namespace.brettw@google.com2008-12-124-6/+6
| | | | | | Review URL: http://codereview.chromium.org/14079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6948 0039d316-1c4b-4281-b951-d872f2087c98
* Have GRIT generate files into a common directory.tc@google.com2008-12-121-1/+1
| | | | | | | | | | | | | | | Joi has convinced me that GRIT should generate platform specific resources files. This is easier than parsing .rc files because GRIT effectively has an .rc parser. To that end, we need to convert some existing .rc files to .grd files (e.g., net_resources.rc and webkit_resources.rc). Rather than having every grd file output to a different place and -I all the different paths, have GRIT generate all files into one directory. This directory is grit_derived_sources. Review URL: http://codereview.chromium.org/13776 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6940 0039d316-1c4b-4281-b951-d872f2087c98
* Move Image operations and convolver to the skia namespace and clean up a few ↵brettw@google.com2008-12-121-1/+1
| | | | | | | | (but not all) base types. Review URL: http://codereview.chromium.org/13726 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6921 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing reliability crash spike. The traces lead me tosky@google.com2008-12-111-1/+5
| | | | | | | | | | | | | | | | | | believe RichEdit is sending a WM_COMMAND with an id of 35000, which corresponds to IDC_STAR. Peter's changing of IDs resulted in IDC_STAR getting set to 35000. I'm hoping the WM_COMMAND sent from the rich edit has it's high bits set appropriately so that this change will result in not trying to execute IDC_STAR when we get the command. WARNING: this is all speculation from looking at the traces. I couldn't repro on my machine. BUG=5405 TEST=none Review URL: http://codereview.chromium.org/14010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6823 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a handful of related bookmark manager bugs/requests:sky@google.com2008-12-112-2/+6
| | | | | | | | | | | | | | | . Adds a search field before the text field. . When the search node is selected and there are no results or no search text, a descriptive label is drawn on top of the table telling the user what's happening. . In the bookmark menus Edit... is now Rename... for folders. BUG=5272 5319 5273 4165 TEST=see individual bugs Review URL: http://codereview.chromium.org/13724 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6777 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where context menu for table/tree in rtl was showing up onsky@google.com2008-12-102-0/+4
| | | | | | | | | | | the wrong side. BUG=5067 TEST=see bug Review URL: http://codereview.chromium.org/13353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6734 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 6709,6708,6706.brettw@google.com2008-12-101-1/+1
| | | | | | Review URL: http://codereview.chromium.org/13345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6710 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base dependency from image_operations and associated unittests. I ↵brettw@google.com2008-12-101-1/+1
| | | | | | | | | also renamed the namespace from "gfx" to "skia". This also adds back the image_operations_unittest to a project (this had gotten lost in my move). Review URL: http://codereview.chromium.org/13143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6706 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing 4687: Enter in FirstRun UI starts import when Customize link is focued.finnur@google.com2008-12-102-10/+7
| | | | | | | We now properly handle Enter when links are focused. I also made it so that links navigate on KeyDown (when you press Enter or Space) instead of on KeyUp. This matches WebKit and native Windows behavior. Review URL: http://codereview.chromium.org/13321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6670 0039d316-1c4b-4281-b951-d872f2087c98
* Changes DefaultNonClientView to show the min/max buttons if thesky@google.com2008-12-091-0/+2
| | | | | | | | | | | delegate says it can be minimized. BUG=4083 TEST=none Review URL: http://codereview.chromium.org/13683 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6649 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at landing tree node iterator. I needed an includesky@google.com2008-12-094-1/+121
| | | | | | | | in tree_node_model. Review URL: http://codereview.chromium.org/13274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6588 0039d316-1c4b-4281-b951-d872f2087c98
* Backs out tree node iterator until I figure out why release build doesn'tsky@google.com2008-12-083-119/+0
| | | | | | | | | | like me. BUG=none TEST=none Review URL: http://codereview.chromium.org/13267 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6554 0039d316-1c4b-4281-b951-d872f2087c98
* Adds an iterator over tree nodes.sky@google.com2008-12-083-0/+119
| | | | | | | | | BUG=4065 TEST=none Review URL: http://codereview.chromium.org/13264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6552 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup, part 1.pkasting@chromium.org2008-12-081-15/+15
| | | | | | | | | | | | | | * Consistently use underscores between words in identifiers (IDC_NEWTAB -> IDC_NEW_TAB) * Make some identifiers clearer or more up-to-date (IDC_DUPLICATE -> IDC_DUPLICATE_TAB, IDC_GOOFFTHERECORD -> IDC_NEW_INCOGNITO_WINDOW, IDC_NEWPROFILEWINDOW -> IDC_PROFILE_MENU) * Try and make string identifiers (IDS_xxx) match their corresponding IDC_xxx commands. Tony tells me this will not cause any need for retranslation. * As much as possible (without modifying automated UI test XML files), use "Bookmark Bar", not "Bookmarks Bar" (this seemed to be prevailing usage in the code) * Fix 80-column issues This patch touches move files than any subsequent patches, but should be the most rubber-stampable. Review URL: http://codereview.chromium.org/13633 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6535 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash on 64-bit systems when an external message hook is installed. Thebrettw@google.com2008-12-051-1/+3
| | | | | | | | | | proxying for CB_GETCOMBOXINFO is wrong and will crash. Instead, call GetComboBoxInfo. BUG=49 Review URL: http://codereview.chromium.org/13156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6420 0039d316-1c4b-4281-b951-d872f2087c98
* Changed svn:eol-style of all .sln and .vcproj files to CRLFscherkus@chromium.org2008-12-041-659/+659
| | | | | | Review URL: http://codereview.chromium.org/13133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6372 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium-MultiProfile-Prototypemunjal@chromium.org2008-12-034-8/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Summary ======= Implement a prototype of multiple profiles in Chrome by utilizing the functionality of user-data-dir command line flag that already exists. A profile in this case is an umbrella for all user data including cookies, history, bookmarks, settings, etc. Each profile gives the user a separation of all these data elements. User Interface ============== - Wrench > "New window in profile" menu item, with sub-menu items. This new menu item has sub menu items for each existing profile, for up to 9 profiles, and one more sub menu item to launch a window in a new profile. The 9 sub-menu items also have the accelerators like CTRL + SHIFT + 1, CTRL + SHIFT + 2, etc. If there are more than 9 profiles, we will also show an extra sub-menu item, "Other...". - New Profile dialog box This dialog box is shown to the use when (s)he clicks Wrench > New window in profile > <New Profile>. It lets the user specify a profile name, and also shows a checkbox to create a desktop shortcut to launch Chrome in that profile. - Choose profile dialog box This dialog box lets the user select a profile from a drop down to open a new window in. It also has an item <New Profile> in the drop down, selecting which will show the new profile dialog box mentioned above. CTRL + M shortcut also launches this dialog box. Code Organization ================= chrome\browser\user_data_dir_profile_manager.h/.cc: This class provides an abstraction of profiles on top of the user data dir command line flag. chrome\browser\views\user_data_dir_new_profile_dialog.h/.cc New profile dialog box code. chrome\browser\views\user_data_dir_profiles_dialog.h/.cc Choose profile dialog box code. Review URL: http://codereview.chromium.org/12895 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6333 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/gfx/skia_util to skia/ext/skia_util_win.brettw@google.com2008-12-036-6/+6
| | | | | | | In a later pass, I will separate off the cross-platform part of this file into skia/ext/skia_util (only one function). Review URL: http://codereview.chromium.org/13101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6306 0039d316-1c4b-4281-b951-d872f2087c98
* Move convolver and image_operations from base/gfx to skia/ext. This is justbrettw@google.com2008-12-031-1/+1
| | | | | | | | like my previous change except does no namespace renaming and doesn't touch skia_utils. Review URL: http://codereview.chromium.org/13080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6290 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back this change.ben@chromium.org2008-12-032-12/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6279 0039d316-1c4b-4281-b951-d872f2087c98
* RootView should be destroyed in WM_NCDESTROY not after it.ben@chromium.org2008-12-032-1/+12
| | | | | | Review URL: http://codereview.chromium.org/12632 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6277 0039d316-1c4b-4281-b951-d872f2087c98
* Revert my skia file moves because of layout test failures.brettw@google.com2008-12-037-12/+15
| | | | | | Review URL: http://codereview.chromium.org/12892 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6266 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes context menu behavior of table view. In particular when runningsky@google.com2008-12-022-18/+43
| | | | | | | | | | | | | | in an RTL locale and right clicking on the icon some times the scrollbar context menu would appear. I've fixed it by subclassing the context menu handling and getting the location from the position of the mouse. BUG=4752 TEST=see bug, but also make sure this doesn't regress 4750 Review URL: http://codereview.chromium.org/13055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6252 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-19 11:44:23 +0000