summaryrefslogtreecommitdiffstats
path: root/chrome/views
Commit message (Collapse)AuthorAgeFilesLines
* Move focus related files into a new chrome/views/focus subdirben@chromium.org2009-03-1715-56/+60
| | | | | | | | TBR=sky Review URL: http://codereview.chromium.org/48056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11837 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustage - linux build edit flubben@chromium.org2009-03-171-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11832 0039d316-1c4b-4281-b951-d872f2087c98
* bustage fix - file movedben@chromium.org2009-03-171-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11824 0039d316-1c4b-4281-b951-d872f2087c98
* Move windowing related objects into chrome/views/window subdir.ben@chromium.org2009-03-1732-203/+215
| | | | | | | | TBR=sky Review URL: http://codereview.chromium.org/42272 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11819 0039d316-1c4b-4281-b951-d872f2087c98
* fix linux bustageben@chromium.org2009-03-171-4/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11815 0039d316-1c4b-4281-b951-d872f2087c98
* Move widget related files into views/widgetben@chromium.org2009-03-1739-139/+273
| | | | | | | TBR=sky git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11811 0039d316-1c4b-4281-b951-d872f2087c98
* Rework the Button API to be saner in preparation for NativeControl ↵ben@chromium.org2009-03-1618-765/+674
| | | | | | | | rejiggering.BaseButton->Button, CustomButtonButton->ImageButtonToggleButton->ToggleImageButtonRemoving SetListener (buttons take listener through ctor)Tidy up source files. No functionality changes, just naming and organization.Look at the button classes first, then everything else. Review URL: http://codereview.chromium.org/46096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11799 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable building views under Linux.erg@google.com2009-03-161-17/+20
| | | | | | | Review URL: http://codereview.chromium.org/48028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11780 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Window->WindowWinben@chromium.org2009-03-1416-492/+585
| | | | | | | | | Pull basic Window interface out of WindowWin into new interface, Window. Convert code to use it. Review URL: http://codereview.chromium.org/46079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11699 0039d316-1c4b-4281-b951-d872f2087c98
* rollback againben@chromium.org2009-03-1416-585/+492
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11696 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Window->WindowWinben@chromium.org2009-03-1416-492/+585
| | | | | | | | | Pull basic Window interface out of WindowWin into new interface, Window. Convert code to use it. Review URL: http://codereview.chromium.org/42201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11695 0039d316-1c4b-4281-b951-d872f2087c98
* Disallows dragging from the bookmark bar when the bookmark bar issky@google.com2009-03-131-2/+6
| | | | | | | | | | | | closed or animating. This fixes a case where clicking on a bookmark bar, then hitting control-b triggers a drag. BUG=8674 TEST=see bug Review URL: http://codereview.chromium.org/46066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11687 0039d316-1c4b-4281-b951-d872f2087c98
* this should have been reinstated in the revertben@chromium.org2009-03-131-0/+1194
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11673 0039d316-1c4b-4281-b951-d872f2087c98
* revertben@chromium.org2009-03-1316-1625/+338
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11671 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Window->WindowWinben@chromium.org2009-03-1316-492/+585
| | | | | | | | | Pull basic Window interface out of WindowWin into new interface, Window. Convert code to use it. Review URL: http://codereview.chromium.org/42169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11668 0039d316-1c4b-4281-b951-d872f2087c98
* Makes drops above the tabstrip work again. This stopped workingsky@google.com2009-03-131-1/+1
| | | | | | | | | | | because of changes to the view hiearchy. BUG=8669 TEST=see bug Review URL: http://codereview.chromium.org/42176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11666 0039d316-1c4b-4281-b951-d872f2087c98
* Removed unneeded includes of base/scoped_ptr.h. Reduce usage from ~800 files ↵thestig@chromium.org2009-03-133-1/+2
| | | | | | | | to ~400. Review URL: http://codereview.chromium.org/46039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11651 0039d316-1c4b-4281-b951-d872f2087c98
* Remove logging.h from cc files that don't use it.thestig@chromium.org2009-03-122-2/+0
| | | | | | Review URL: http://codereview.chromium.org/42155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11593 0039d316-1c4b-4281-b951-d872f2087c98
* Make Widget return a gfx::NativeView instead of a HWND.ben@chromium.org2009-03-1221-120/+116
| | | | | | Review URL: http://codereview.chromium.org/43124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11562 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors code for showing bookmarks menus into a standalone classsky@google.com2009-03-121-0/+1
| | | | | | | | | | | | | | | that isn't tied to the bookmark bar. Removes some dead code from the bookmark bar, and fixes a UMR in chrome_menu that I found when running under purify. There isn't any behavior change in this patch. BUG=none TEST=this is a large refactoring of how bookmark menus are shown. Please thoroughly test menus on the bookmark bar to make sure I didn't screw anything up. Review URL: http://codereview.chromium.org/42128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11558 0039d316-1c4b-4281-b951-d872f2087c98
* Moving the storing/restoring of the focus from TabContents to ↵jcampan@chromium.org2009-03-122-24/+4
| | | | | | | | | | | | WebContentsView. This makes TabContents less dependent on views. This requires few contortions with DOMUIs (NTP, history and downloads tab) as they still need to set the initial focus specifically. BUG=None TEST=Run the interactive tests. Review URL: http://codereview.chromium.org/39269 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11501 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the distributor logo placement on the glass frame.ben@chromium.org2009-03-114-6/+37
| | | | | | | | | | The window's control bounds can change independently of window sizing messages (WM_SIZE), and so we need to make sure that we always call Layout on the frame view and the client view, even if the bounds of the window don't change so that we are more likely to update the layout of the distributor logo. http://crbug.com/8511 Review URL: http://codereview.chromium.org/42061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11424 0039d316-1c4b-4281-b951-d872f2087c98
* Fix black titlebar rendering when toggling DWM when the window is maximized:ben@chromium.org2009-03-104-3/+34
| | | | | | | | | | | - restore window after hiding it, since our hide hack only works for non-maximized windows - handle WM_WINDOWPOSCHANGING in this case to make sure the window isn't made visible by the restore action http://crbug.com/8526 Review URL: http://codereview.chromium.org/43052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11401 0039d316-1c4b-4281-b951-d872f2087c98
* This changes the base clipboard class, as accomplishing paste requires that ↵avi@chromium.org2009-03-101-1/+1
| | | | | | | | Clipboard::FormatType be IPC-able. The lowest-common denominator of unsigned int, NSString*, and GdkAtom is string, so string it is. (Linux changes by estade.) Review URL: http://codereview.chromium.org/41012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11383 0039d316-1c4b-4281-b951-d872f2087c98
* Unrevert 11294.mpcomplete@google.com2009-03-101-1/+2
| | | | | | | | | - include stub fix so that linux/mac still build. - fix DCHECK in views code. - fix unit test. Review URL: http://codereview.chromium.org/41020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11360 0039d316-1c4b-4281-b951-d872f2087c98
* Make Chromium windows not hide auto-hide taskbars, take 2.pkasting@chromium.org2009-03-101-17/+38
| | | | | | | | | | This is very similar to r10845, but also includes a regression fix for issue 8410, where locking and unlocking the screen would cause mispositioning of child content. BUG=20,8410 Review URL: http://codereview.chromium.org/42027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11355 0039d316-1c4b-4281-b951-d872f2087c98
* Slight code change to make some global variables const.maruel@google.com2009-03-1014-64/+106
| | | | | | | Fix >80 cols lines. Review URL: http://codereview.chromium.org/42013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11342 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGEdeanm@chromium.org2009-03-1085-87/+0
| | | | | | | | | Normalize end of file newlines in chrome/. All files end in a single newline. Review URL: http://codereview.chromium.org/42015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in ResizeCorner. ResizeCorner was caching the BrowserViewsky@google.com2009-03-092-0/+12
| | | | | | | | | | | | | | that created it, but if a tab contained a download shelf and was dragged to a new window the ResizeCorner would be referencing the wrong BrowserView. I've changed the code to look up the ancestor BrowserView as necessary. BUG=8477 TEST=see bug Review URL: http://codereview.chromium.org/41010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11285 0039d316-1c4b-4281-b951-d872f2087c98
* Back out r10845 because it caused too many other regressions.pkasting@chromium.org2009-03-091-29/+16
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11284 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression in menus. Specifically selecting by way of press,sky@google.com2009-03-091-2/+3
| | | | | | | | | | | | drag then release was broken. It appears that TPM_RIGHTBUTTON disallows this behavior. BUG=8560 TEST=see bug Review URL: http://codereview.chromium.org/41006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11280 0039d316-1c4b-4281-b951-d872f2087c98
* Allow clicks to windows disabled by modal dialogs to bring the entire modal ↵ben@chromium.org2009-03-071-0/+13
| | | | | | | | | | stack to the front. Apparently you need to let DefWindowProc handle WM_SETCURSOR unless you want clicks to background disabled windows to get lost. http://crbug.com/8437 Review URL: http://codereview.chromium.org/39308 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11198 0039d316-1c4b-4281-b951-d872f2087c98
* Fix about box truncation (and truncation of probably every other box on ↵ben@chromium.org2009-03-071-1/+2
| | | | | | | | | | | | glass frames). Our windows don't have WS_CAPTION. It's remarkable to me that we've made it this far without noticing this glaring oversight. I guess I fixed a bug with my frame changes earlier in the week that resulted in AdjustWindowRectEx getting called correctly for the first time, and it was not providing correct offsets because of the absence of this flag. http://crbug.com/8445 Review URL: http://codereview.chromium.org/39300 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11195 0039d316-1c4b-4281-b951-d872f2087c98
* Test to see if we can reduce some crashes by deferring delegate destruction ↵ben@chromium.org2009-03-064-10/+16
| | | | | | | | until WM_NCDESTROY. This involves adding a specific method to allow delegates to destroy themselves to WindowDelegate, and moving all delete this calls into implementations of that method (to allow delegates to still respond to WM_DESTROY which is legit). Review URL: http://codereview.chromium.org/40192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11132 0039d316-1c4b-4281-b951-d872f2087c98
* I meant to say !ben@chromium.org2009-03-061-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11070 0039d316-1c4b-4281-b951-d872f2087c98
* Guard against a crash that can impact Dialog boxes ... this one seems to ↵ben@chromium.org2009-03-051-0/+5
| | | | | | | | | have already impacted Window itself, but a NULL check was already inserted in that code. http://crbug.com/4355 Review URL: http://codereview.chromium.org/40183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11047 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes CRLF and trailing white spaces.maruel@chromium.org2009-03-0518-26/+26
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10982 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r9953 since it caused regressions like: ben@chromium.org2009-03-046-56/+20
| | | | | | | | | http://crbug.com/8287 Eyeballing the code in RootView, this change seems wrong. Review URL: http://codereview.chromium.org/40124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10929 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 at moving SupportsWindowFeature from BrowserViewtc@google.com2009-03-041-10/+11
| | | | | | | | | | | | | | | | | | to Browser. Turns out the test regression was actually caused by r10806 which removed an anonymous namespace causing the TestView class to collide with the same class in render_widget_host_unittest.cc. For now, fix by adding the TestView in the view unittest to the anon namespace. shess is going to try to re-add the namespace to render_widget_host_unittest.cc too. TBR=pkasting Review URL: http://codereview.chromium.org/40058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10873 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression where the window caption buttons weren't clickable when ↵ben@chromium.org2009-03-042-1/+37
| | | | | | | | | | | | maximized. This is because of the nonclient frameview/clientview hierarchy changes. Make sure that the frame gets a chance to respond to GetViewForPoint before the client view if the client view does not visually overlap. http://crbug.com/8312 Review URL: http://codereview.chromium.org/40062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10857 0039d316-1c4b-4281-b951-d872f2087c98
* Fix other release bustage. Gahpkasting@chromium.org2009-03-041-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10850 0039d316-1c4b-4281-b951-d872f2087c98
* Make Chromium windows not hide auto-hide taskbars.pkasting@chromium.org2009-03-041-16/+29
| | | | | | | | | | | | | | | There are a few caveats here: * On Aero glass, if the auto-hide taskbar is at the top of the screen, we get one row of nonclient pixels along the bottom of the screen (not too noticeable for light-colored pages, looks a bit odd with a dark page). I can't find a way around this. * Switching between fullscreen and normal mode can leave things a bit confused until you click another app and then reactivate Chromium. This seems to happen with other applications too (e.g. Firefox fullscreen mode) so I'm not too worried. * Chromium does not deal well with toggling the taskbar's auto-hide setting (or, I think, its position?) unless you restore and remaximize the window. I tried to fix this via modified handling of WM_SETTINGCHANGE but only made things worse and so gave up. BUG=20 Review URL: http://codereview.chromium.org/28338 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10845 0039d316-1c4b-4281-b951-d872f2087c98
* Nonfunctional cleanup change:pkasting@chromium.org2009-03-032-13/+10
| | | | | | | | * Fix two violations of 80-column lines * Use MSG_WM_SETTINGCHANGE instead of MESSAGE_RANGE_HANDLER_EX in order to simplify a function declaration/code. Review URL: http://codereview.chromium.org/27358 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10823 0039d316-1c4b-4281-b951-d872f2087c98
* disable test since it doesn't compiletc@google.com2009-03-031-2/+2
| | | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/39040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10812 0039d316-1c4b-4281-b951-d872f2087c98
* disable failing tests while I debugtc@google.com2009-03-031-9/+9
| | | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/40033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10811 0039d316-1c4b-4281-b951-d872f2087c98
* When you launch Chrome from a desktop shortcut, the window wasn't getting ↵ben@chromium.org2009-03-031-2/+12
| | | | | | activated because I removed code to explicitly activate the window in my change earlier today git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10780 0039d316-1c4b-4281-b951-d872f2087c98
* Fix interactive ui tests. There was a bug in the ↵ben@chromium.org2009-03-032-4/+3
| | | | | | NonClientView::GetPreferredSize method... it was returning the preferred size of the client area not the non-client area! git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10778 0039d316-1c4b-4281-b951-d872f2087c98
* Make it so that dropdown selects don't deactivate the main frame when opened ↵ben@chromium.org2009-03-031-0/+3
| | | | | | http://crbug.com/8247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10777 0039d316-1c4b-4281-b951-d872f2087c98
* Support DWM switching.ben@chromium.org2009-03-0318-910/+639
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This completes the collapsing of window types and browser frames around a single class: views::Window. CustomFrameWindow is removed with this change. The Browser window is represented by a single views::Window subclass: BrowserFrame, which replaces both AeroGlassFrame and OpaqueFrame. NonClientView is now a container of two sibling classes - the Window's ClientView (in the Browser's case, BrowserView), and a NonClientFrameView subclass, which provides the rendering for the non-client portions of the window. These Views are siblings rather than the ClientView a child of the NonClientFrameView because when the DWM is toggled, the ClientView would have to be re-parented. Many Views make the assumption they are only inserted into a View hierarchy once, and so this is problematic. By having the views be siblings, this is avoided. With this in mind, all of the former NonClientViews now become NonClientFrameView subclasses: DefaultNonClientView -> CustomFrameView (non-existent, NonClientView) -> NativeFrameView AeroGlassNonClientView -> GlassBrowserFrameView OpaqueNonClientView -> OpaqueBrowserFrameView The latter two derive from NonClientFrameView via BrowserNonClientFrameView, which adds some extras. I also had to modify the TabRenderer class to know how to drop its cache of tab background images when the theme changes since it uses different ones for Glass and non-Glass. This change also fixes a few non-client flicker issues relating to window non-client activation by using more ScopedRedrawLocks. (Touches info_bubble.cc, window.cc) Bugs fixed: http://crbug.com/153 http://crbug.com/747 http://crbug.com/2371 http://crbug.com/3264 http://crbug.com/8234 Plumbing for http://crbug.com/8247 Design docs: http://dev.chromium.org/developers/design-documents/views-windowing http://dev.chromium.org/developers/design-documents/browser-window Review URL: http://codereview.chromium.org/27317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10757 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bookmark and menu drag images by making a halo around them. This makesbrettw@chromium.org2009-03-029-28/+55
| | | | | | | | | | | | | the ClearType composited on the correct color to fix the semitransparent pixels into 1-bit transparency pixels. Remove some unnecessary header file dependencies on ChromeCanvas I noticed when compiling this patch. BUG=8258 Review URL: http://codereview.chromium.org/27321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10732 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 06:09:11 +0000