summaryrefslogtreecommitdiffstats
path: root/chrome/views
Commit message (Collapse)AuthorAgeFilesLines
* Fix UI test regression, there's a better way to refactor this anyway.pkasting@chromium.org2009-02-101-5/+2
| | | | | | | TBR=glen Review URL: http://codereview.chromium.org/24007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9443 0039d316-1c4b-4281-b951-d872f2087c98
* Make aero glass code look more like other nonclient views in hopes of easing ↵pkasting@chromium.org2009-02-093-25/+21
| | | | | | | | | refactoring. More cleanup. Change tabstrip layout to match opaque frame. BUG=5054 Review URL: http://codereview.chromium.org/20161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9433 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 9408.brettw@chromium.org2009-02-093-0/+69
| | | | | | Review URL: http://codereview.chromium.org/20190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9414 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new resizer corner.mad@chromium.org2009-02-093-69/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To display a resize bitmap and handle the mouse interactions as requested in http://code.google.com/p/chromium/issues/detail?id=458. BUG=458 There are unfortunately two cases to handle and they must be handled separately. The first one is when there are no bottom shelf like the download bar, and the case where there is one. For the case without, we must draw on top of what we receive from WebKit, so we intercept the bitmap in RenderWidgetHostViewWin::OnPaint() so that we can draw the resize corner bitmap on top of it (taking into account whether we are in a right to left language or not). For the case where we have a bottom shelf, we use a dedicated view that we properly layout on top of the bottom shelf view (which takes care of handling the RTL language case for us). Same split for the mouse interactions. Without the bottom shelf, we must deal with it in RenderWidgetHostViewWin::OnMouseEvent() by sending the root window a WM_NCLBUTTONDOWN message with either HTBOTTOMRIGHT or HTBOTTOMLEFT (based on the RTL setting) and let the OS take care of the resizing. IF we have a bottom shelf, we must deal with the mouse interaction in BrowserView::NonClientHitTest() to either return HTBOTTOMRIGHT or HTBOTTOMLEFT (again, based on the RTL setting) and, again, let the OS take care of the resizing. More details here: http://code.google.com/p/chromium/wiki/BrowserViewResizer git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9408 0039d316-1c4b-4281-b951-d872f2087c98
* Support custom border widths. Allow user to resize the window (instead of ↵pkasting@chromium.org2009-02-061-26/+27
| | | | | | | | | doing nothing) when over our client edge graphics. Make resize corner behavior on XP more native. More cleanup. BUG=5054 Review URL: http://codereview.chromium.org/21116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9315 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup forward declared classes that are not needed in chrome/renderer, ↵thestig@chromium.org2009-02-069-36/+17
| | | | | | | | chrome/test/, and chrome/views. Also fix some lint issues while I'm at it. Review URL: http://codereview.chromium.org/20112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9289 0039d316-1c4b-4281-b951-d872f2087c98
* Add debugging info to hopefully catch what's causing 6316erg@google.com2009-02-051-0/+2
| | | | | | | BUG=6316 Review URL: http://codereview.chromium.org/21105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9281 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the dependency checker tool. Rules for a directory did modify their ↵stoyan@chromium.org2009-02-051-0/+9
| | | | | | | | | | directory parent rules. Using copy.copy() solves the problem.Additional fix when "allow-current-directory" rules was not applied if DEPS file is missing. Updated few DEPS file with reasonable rules. To prevent tree closing other dependencies are added. These need to be either legitimated or dependency removed. Review URL: http://codereview.chromium.org/21025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9221 0039d316-1c4b-4281-b951-d872f2087c98
* Paper over a crash that I think is due to the way we shut down the view ↵ben@chromium.org2009-02-041-0/+7
| | | | | | | | | | hierarchy in a window. http://crbug.com/6260 Review URL: http://codereview.chromium.org/20051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9165 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds macro used to track the creation and destructionjcampan@chromium.org2009-02-043-9/+31
| | | | | | | | | | | of HWNDs, in an attempt to detect potential double-delete. A double-delete of a HWND might be responsible for the crasher http://crbug.com/4714 Note: this CL was previously committed and reverted because it broke the sandbox integration module. Review URL: http://codereview.chromium.org/21032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9161 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 9109.ojan@google.com2009-02-033-31/+9
| | | | | | | Broke the build. Review URL: http://codereview.chromium.org/20029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9110 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds macro used to track the creation and destructionjcampan@chromium.org2009-02-033-9/+31
| | | | | | | | | | | | of HWNDs, in an attempt to detect potential double-delete. A double-delete of a HWND might be responsible for the crasher http://crbug.com/4714 Review URL: http://codereview.chromium.org/21018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9109 0039d316-1c4b-4281-b951-d872f2087c98
* Bail saving window placement if the function is called after WM_DESTROY ↵ben@chromium.org2009-02-031-0/+7
| | | | | | | | | | (window_delegate_ is NULL). http://crbug.com/6376 Review URL: http://codereview.chromium.org/21004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9099 0039d316-1c4b-4281-b951-d872f2087c98
* Porting unit tests.phajdan.jr@chromium.org2009-02-031-3/+3
| | | | | | Review URL: http://codereview.chromium.org/19723 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9079 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fix issue 7253 -- tooltip of pure English tab title has wrong ↵xji@chromium.org2009-02-031-0/+3
| | | | | | | | | | | | | | | | | | | | directionality. (http://crbug.com/7253) Fix: LTR tooltip text need to be marked with LRE-PDF to be displayed correctly in RTL locales. Test steps: 1. Open Chrome in RTL locales. 2. Open page http://mail.yahoo.com, whose title is "Yahoo! Mail: the best web-based mail!" 3. Mouse over to the tab title to show the completed page title. Without the fix, tooltip text is: "!Yahoo! Mail: the best web-based mail" (with wrong placement of the ending punctuation). With the fix, tooltip text is: "Yahoo! Mail: the best web-based mail!" Review URL: http://codereview.chromium.org/21003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9064 0039d316-1c4b-4281-b951-d872f2087c98
* More bustage fixesbrettw@chromium.org2009-02-011-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9029 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most header file dependencies on the notification type list. It isbrettw@chromium.org2009-02-0110-32/+45
| | | | | | | | | | | really painful to add more types, since lots of headers include the notification service to derive from the notification observer. This splits that out, so much less of the project should end up including notification_types.h ---Paths modified but not in any changelist: Review URL: http://codereview.chromium.org/19744 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9020 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Aero Basic (i.e. non-glass) maximized mode drawing. This old hack was ↵pkasting@chromium.org2009-01-311-46/+0
| | | | | | | | | interfering with my new code that should do things at least somewhat more correctly. BUG=5054 Review URL: http://codereview.chromium.org/19728 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9009 0039d316-1c4b-4281-b951-d872f2087c98
* Lands fix for 6878 from Yong Shin.sky@google.com2009-01-301-1/+5
| | | | | | | | | BUG=6878 TEST=see bug Review URL: http://codereview.chromium.org/19516 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8985 0039d316-1c4b-4281-b951-d872f2087c98
* Fix various problems with constrained windows and/or custom frame windows:pkasting@chromium.org2009-01-301-77/+183
| | | | | | | | | | | | | | | | | * Wrong titlebar height * Titlebars not handling custom font size properly * Drawing errors in maximized mode * One-pixel overlap glitch on bottom corners of client edges * Borders not handling custom border sizes correctly * Unnecessarily small top resize area (unlike in the main window, there's no competition here between resizing and window dragging in the same small strip) * Wrong icon sizing (only a problem in theory, no one uses this code ATM) These files are now very much like simplified versions of the opaque_non_client_view.cc code (which was the goal); eventually all these should be refactorable. BUG=5054 Review URL: http://codereview.chromium.org/19484 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8947 0039d316-1c4b-4281-b951-d872f2087c98
* Reorganize DefaultNonClientView and ConstrainedWindowNonClientView to match ↵pkasting@chromium.org2009-01-291-164/+117
| | | | | | | | | | | changes in OpaqueNonClientView in preparation for fixing similar problems in them, and then refactoring everyone to a common base implementation. This change should have no visible effect; it merely adds functions, reorganizes code, renames variables, and modifies spacing/style to match OpaqueNonClientView as closely as possible. The subsequent set of functional changes should thus hopefully be easier to review, as should the eventual refactoring changes. This does away with some useless code since both these views are used for windows which always have titles, and, in ConstrainedWindowNonClientView's case, never have icons. (Technically, DefaultNonClientView never has an icon right now either, but there's some commented-out code in the bookmark manager that speaks of having one one day.) Review URL: http://codereview.chromium.org/19684 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8927 0039d316-1c4b-4281-b951-d872f2087c98
* Per Glen, remove the bottom border of maximized windows. I went ahead and ↵pkasting@chromium.org2009-01-293-10/+8
| | | | | | | | also removed support for window frame sizes with unequal widths vs. heights; Windows' UI doesn't actually let you do this and it was making the code more complex than it needed to be. Review URL: http://codereview.chromium.org/19477 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8916 0039d316-1c4b-4281-b951-d872f2087c98
* Move kClientEdgeThickness from BrowserView to NonClientView (which makes ↵pkasting@chromium.org2009-01-292-0/+6
| | | | | | | | | more sense anyway) so I'll be able to use it in custom_frame_window.cc. Also eliminate an unnecessarily-repeated set of resource IDs from the opaque nonclient view, and move a comment to match what I ended up doing (but haven't yet sent up for review) in other places. Seems I couldn't make up my mind on that one. Review URL: http://codereview.chromium.org/19458 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8891 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in adding a menu item. As far as I can tellsky@google.com2009-01-281-0/+9
| | | | | | | | | | | | | | | l10n_util::GetString(IDS_TASK_MANAGER) is returning "". Tony, myself and Rahul don't think this should be possible, yet we have crashes indicating otherwise. If IDS_TASK_MANAGER returns an emtpy string then menu derefs NULL and we crash. BUG=6206 TEST=no way to directly test this, instead just make sure menus still work. Review URL: http://codereview.chromium.org/19434 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8829 0039d316-1c4b-4281-b951-d872f2087c98
* Add NOTREACHED() in switch default part which should never be reached.phajdan.jr@chromium.org2009-01-271-0/+1
| | | | | | Review URL: http://codereview.chromium.org/18850 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8730 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux build breakage.maruel@chromium.org2009-01-271-0/+3
| | | | | | Review URL: http://codereview.chromium.org/19020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8720 0039d316-1c4b-4281-b951-d872f2087c98
* Porting in chrome/views/phajdan.jr@chromium.org2009-01-277-47/+39
| | | | | | | | Some highlights: label, throbber. And others. Review URL: http://codereview.chromium.org/18757 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8715 0039d316-1c4b-4281-b951-d872f2087c98
* This change should have few user-visible effects. I think I slightly ↵pkasting@chromium.org2009-01-263-27/+25
| | | | | | | | | | | | | | | | | | | modified the window layout (by a pixel or so) in the popup window case, which I haven't tried to make pixel-perfect yet anyway. Otherwise it's all reorg. Clean up logic of nonclient view to be more consistent and coherent. Most things are now based on a small set of core functions that return various frame/nonclient thicknesses. This allows a noticeable reduction in the number of hardcoded constants, makes the code make more sense (even though a few places are longer than before), and makes it much easier to do things in the future like resizing various borders or handling system metrics better. Rename and update comments for all constants to be more descriptive and less redundant. Rename helper functions and variables for consistency, now that they've changed. Remove an unused variant of TileImageInt(). Add a new one that takes an offset into the source image. This is used to rewrite the maximized bottom border tiling call in a way that doesn't rely on someone else clipping out or painting over the overdraw from tiling "too large" a source image. Probably no visible effect. Make resize border hittest helper function able to handle borders of varying widths, and try to make parameter names more meaningful. Technically, we don't need the extra flexibility, since our bottom and side borders are the same thickness, but since there are different functions calculating that thickness on the caller side, it didn't hurt to not rely on that for the future. BUG=5054 Review URL: http://codereview.chromium.org/18804 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8658 0039d316-1c4b-4281-b951-d872f2087c98
* Some cleanups I've had sitting around for a while that are getting in my way ↵pkasting@chromium.org2009-01-261-139/+93
| | | | | | | | | now. Fixes some >80-column lines, simplifies LayoutWindowControls() and makes it more similar to the version in OpaqueNonClientView (with the goal of eventually merging these), etc. Review URL: http://codereview.chromium.org/18579 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8638 0039d316-1c4b-4281-b951-d872f2087c98
* Two of the three places that set a window mask had it wrong. Fix it.pkasting@chromium.org2009-01-261-1/+4
| | | | | | Review URL: http://codereview.chromium.org/18580 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8637 0039d316-1c4b-4281-b951-d872f2087c98
* Fix warning which breaks compile with gcc 4.3.xmaruel@chromium.org2009-01-261-2/+2
| | | | | | | | | since warnings are treated as errors. Patch contributed by Craig Schlenter <craig.schlenter@gmail.com> git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8635 0039d316-1c4b-4281-b951-d872f2087c98
* Small porting in chrome/phajdan.jr@chromium.org2009-01-262-2/+12
| | | | | | | | | This is actually http://codereview.chromium.org/18446 without process_watcher changes. Review URL: http://codereview.chromium.org/18724 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8622 0039d316-1c4b-4281-b951-d872f2087c98
* Create a dialog box for the about:network view and kill the tab type.brettw@chromium.org2009-01-242-1/+18
| | | | | | | | | This adds an AppendText method to the text field view. The job tracker stuff is just copied from the old network status file. Review URL: http://codereview.chromium.org/18728 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8604 0039d316-1c4b-4281-b951-d872f2087c98
* ===================================================xji@chromium.org2009-01-233-1/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change list fixes the following 2 chrome bugs: 2821 RTL: Ellipsis appeared at right for RTL locales on "Task Manager - Google Chrome" dialog (http://crbug.com/2821) 6132: Strings in tables are displayed LTR when they should be RTL (http://crbug.com/6132) =================================================== Background: The above 2 bugs are related to Chrome task manager. Task manager is a TableView, which is a subclass of NativeControl. Currently, TableView window is created by using WS_EX_LAYOUTRTL | WS_EX_RTLREADING flag, which is wrong. WS_EX_LAYOUTRTL | WS_EX_RTLREADING renders a RTL alignment but LTR reading order. Please see the following blog for detail: http://blogs.msdn.com/michkap/archive/2007/03/11/1857043.aspx We need to replace the above flag with WS_EX_LAYOUTRTL only. Consequently, we need to make sure that the various implementations of TableModel::GetText adjust the returned text appropriately if need be. For example, if the text in an URL, then the returned text should be explicitly marked as LTR text. Please note: there are several other places where we create RTL window using WS_EX_LAYOUTRTL | WS_EX_RTLREADING flag, such as AutoCompleteEditView (omnibox), MenuHostWindow, TextField (for example, text in bookmark dialog), and other NativeControl (including checkbox, combobox, native_button, radio_button, separator, tabbed_pane, and tree view). They all need to be fixed. And the following bug is filed for tracking. http://crbug.com/6573 =================================================== The fix is based on Idan's comments on bug 6132 1.create the table view with WS_EX_LAYOUTRTL (rather than WS_EX_LAYOUTRTL | WS_EX_RTLREADING) 2 Make sure that the various implementations of TableModel::GetText adjust the returned text appropriately if need be. If the text in an URL, then the returned text is explicitly marked as LTR text. Otherwise, the returned text is marked with LTR if it is RTL environment and there is no strong RTL character in the text. This is to avoid the wrong placement of (or wrong mirrored) ending-punctuation. =================================================== Since we have quite a few places creating window using WS_EX_LAYOUTRTL | WS_EX_RTLREADING style. We decided to migrate to the right style step to step. This is the first step, and there is unnecessary function introduced by this change list. 1. I am using l10n_util::GetExtendedTooltipStyles() for the right style for now. And I marked a TODO there to obsolete this function name, replace with GetExtendedStyles eventually. (the l10n_util.h is no longer in the change list since I've checked it in with another CL). 2. I introduced native_control::GetAdditionalRTLStyle() which should replace GetAdditionalExStyle() eventually. =================================================== When wrapping text with LTR format in GetText(), ideally, we should parse the text to check whether this is a n URL or not (for example, a webpage title could be an URL, or user could add URL as search engine's name or keyword). I did not do that and only added a TODO there because I think that might be rare case and parsing the text might cause performance degradation. Review URL: http://codereview.chromium.org/18076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8593 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r8560 due to broken interactive_ui_testsmark@chromium.org2009-01-232-12/+2
| | | | | | Review URL: http://codereview.chromium.org/18722 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8570 0039d316-1c4b-4281-b951-d872f2087c98
* Porting in chrome/phajdan.jr@chromium.org2009-01-232-2/+12
| | | | | | Review URL: http://codereview.chromium.org/18446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8560 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage.brettw@chromium.org2009-01-221-1/+1
| | | | | | Review URL: http://codereview.chromium.org/18513 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8480 0039d316-1c4b-4281-b951-d872f2087c98
* use a registrar to safely remove observertc@google.com2009-01-212-6/+5
| | | | | | | | TBR=evan Review URL: http://codereview.chromium.org/18442 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8359 0039d316-1c4b-4281-b951-d872f2087c98
* Fix BrowserTest.WindowsSessionEnd by moving a virtual calltc@google.com2009-01-211-4/+5
| | | | | | | | | | | | | from the constructor to the Init() function(). The virtual call in the constructor of the base class doesn't get dispatched to the child class since we haven't started to construct it yet. Instead, defer the call until after we've finished creating the object. Review URL: http://codereview.chromium.org/18601 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8354 0039d316-1c4b-4281-b951-d872f2087c98
* Make CommandLine into a normal object, with some statics for getting at the ↵evan@chromium.org2009-01-211-1/+1
| | | | | | | | | | | current process's command line. One explicit goal of this change is to *not* deal with the string/wstring issues at the API on POSIX; the functions are the same as before, which means they remain as broken as before. (I did try to fix the internals, though, so migrating the callers is now possible by adding platform-appropriate hooks.) Review URL: http://codereview.chromium.org/18248 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8347 0039d316-1c4b-4281-b951-d872f2087c98
* Rework the command updater to not be dependent on views::Button (needed for ↵ben@chromium.org2009-01-202-10/+2
| | | | | | | | | porting). TEST=make sure back/forward buttons still enable/disable correctly depending on the length of the back/forward navigation list. Review URL: http://codereview.chromium.org/18343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8332 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the broken commit in r8250. The problem was that basictypes.herg@google.com2009-01-2013-172/+389
| | | | | | | | | wasn't getting included before a defined(OS_WIN) check. Review URL: http://codereview.chromium.org/18414 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8308 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "revert r8217 until memory tests are fixed." This re-applies r8217.tc@google.com2009-01-202-5/+34
| | | | | | | | | | | This reverts commit r8245. TBR=ben Review URL: http://codereview.chromium.org/18410 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8292 0039d316-1c4b-4281-b951-d872f2087c98
* Generate all chrome .vcproj files:sgk@google.com2009-01-171-19/+145
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Path name translation (/ to \) of various MSVSTool attributes. * Explicit keyword= arguments to MSVSProject. This will likely go away eventually in favor of uniform behavior. * Add a relative_path_substitutions array that can be used to substitute in Visual Studio variable like $(OutDir). * Add a local_directory_prefix that can be set to './' to only affect files in the current directory. * Additional Keyword ordering in Tool attributes to continue to match the default order Visual Studio generates. * Add a Derived() proxy class that can wrap a File node to tell the .vcproj generation that we want the derived file, not its source(s), in the file list. * In the individual *.scons files, add the necessary files (mostly .h files) to file lists, and update MSVSProject() calls with the additional necessary information. Result is identical .vcproj files modulo the following differences: * Four locales .vcproj files (da, en-US, he and zh-TW) with source file orders that don't match the other locale .vcproj files have re-ordered file lists to match the rest. * Cosmetic XML changes (white space, ending tags) in: chrome/app/chrome_dll.vcproj chrome/app/generated_resources.vcproj net/build/net_resources.vcproj * Removal or addition of ./ prefixes from various files that don't match the other file specifications within their individual .vcproj files: chrome/installer/util/util.vcproj net/build/net.vcproj net/build/net_unittests.vcproj * Add missing empty sections (<ToolFiles>, <References>, <Globals>) for consistency with other .vcproj files: chrome/tools/test/image_diff/image_diff.vcproj third_party/libpng/libpng.vcproj third_party/zlib/zlib.vcproj * Add missing RootNameSpace attribute: chrome/test/automation/automation.vcproj testing/gtest.vcproj * Use && instead of \r\n as a command separator, to sidestep XML-generation problems: chrome/app/chrome_exe.vcproj * Remove unnecessary (?) duplicate files in the file list: chrome/browser/views/browser_views.vcproj (event_utils.cc and event_utils.h were duplicated) Review URL: http://codereview.chromium.org/17603 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8253 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add #ifdefs to the views/ code and move windows specific codeerg@google.com2009-01-1713-387/+171
| | | | | | | | | | into their own files to get some files compiling." Conflicts with something that went in in the interim... Review URL: http://codereview.chromium.org/18187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8251 0039d316-1c4b-4281-b951-d872f2087c98
* Add #ifdefs to the views/ code and move windows specific code into their own ↵erg@google.com2009-01-1713-171/+387
| | | | | | | | | files to get some files compiling. Review URL: http://codereview.chromium.org/18136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8250 0039d316-1c4b-4281-b951-d872f2087c98
* revert r8217 until memory tests are fixed.ben@chromium.org2009-01-172-34/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8245 0039d316-1c4b-4281-b951-d872f2087c98
* window.cc should not include browser_list.h ... dependent (non-browser) ↵ben@chromium.org2009-01-162-5/+34
| | | | | | | | | | windows are closed when they receive a notification rather than by being called directly from BrowserList. Also browser_list.cc should not include window.h, required for porting. TEST=Open browser. Open options dialog box. Close browser. Options dialog should close too. Review URL: http://codereview.chromium.org/18328 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8217 0039d316-1c4b-4281-b951-d872f2087c98
* Fix maximized mode drawing offscreen in Classic mode. Apparently Classic, ↵pkasting@chromium.org2009-01-151-7/+14
| | | | | | | | | | | unlike Luna, does not auto-clip maximized windows with an explicitly-set HRGN of NULL, so we have to set one. BUG=5054 TEST=On a desktop extended across multiple monitors, switch to Classic mode, open a Chrome window, and maximize it on one monitor. Make sure it doesn't draw any pixels on the other monitor. Review URL: http://codereview.chromium.org/18258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8062 0039d316-1c4b-4281-b951-d872f2087c98
* Constify the params of a couple View functions, which I'll need for an ↵pkasting@chromium.org2009-01-152-10/+20
| | | | | | | | | upcoming change to be able to call these from someone else's const member function. Also fixes a couple cases of wrong parameter wrapping/"*" binding. Review URL: http://codereview.chromium.org/18251 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8057 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-18 07:41:50 +0000