summaryrefslogtreecommitdiffstats
path: root/chrome/views
Commit message (Collapse)AuthorAgeFilesLines
* Large patch set (159 files total) to cleanup the includes.maruel@google.com2008-08-1546-193/+323
| | | | | | | | | | - Slightly reduce the size of the generated .lib files ~3%. - Reduce the number of implicit and explicit atl and windows includes. hooray! - Help incremental build by reducing the number of unnecessary included files. - Split some template class in two, one base class for the common code and the specialization that inherits from the base class. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@937 0039d316-1c4b-4281-b951-d872f2087c98
* Make theme change notifications for the renderer originate from the ↵beng@google.com2008-08-152-0/+8
| | | | | | | | | RenderWidgetHostHWND, not the frame. B=1326392 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@918 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up the system menu in new frames.erg@google.com2008-08-144-0/+18
| | | | | | BUG=1319684 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@908 0039d316-1c4b-4281-b951-d872f2087c98
* If a Window is created with specified bounds, make sure its sized to them!beng@google.com2008-08-141-1/+8
| | | | | | B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@900 0039d316-1c4b-4281-b951-d872f2087c98
* Set the svn:eol-style to LF on all SConscript filestc@google.com2008-08-131-117/+117
| | | | | | TBR=evanm git-svn-id: svn://svn.chromium.org/chrome/trunk/src@823 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup of RootView. Removes unused double_buffered field fromsky@google.com2008-08-124-27/+18
| | | | | | | | | | | RootView, as well as renaming RootView::ProcessPendingPaint to PaintNow. BUG=1255929 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@750 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup a few files, reduce the number of includes.maruel@google.com2008-08-123-5/+8
| | | | | | | | Applied glint. No code change, just moving around. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@713 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the ChromeViews' Menu to wrap the Windows system menu and insert items ↵beng@google.com2008-08-112-35/+136
| | | | | | | | | | | | into it. Basically adds an alternate ctor for Menu that takes an existing HMENU, and then provides variants of most of the APIs that allow insertion of an item at a specified index. I will use this in the new frames to add the task manager and app frame menu items. B=1293995 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@661 0039d316-1c4b-4281-b951-d872f2087c98
* Another Frame Grab-Bagbeng@google.com2008-08-111-0/+2
| | | | | | | | | | | | | | | - makes more stuff in Browser object only happen if you're using the old frames- rename BrowserWindow::Update to BrowserWindow::UpdateToolbar since that's what it does - add window position save/restore handling to Browser- remove BrowserWindow::BrowserDidPaint - relic from HaloFrame days- remove BrowserWindow::GetRootView - unused and exposes impl details- remove BrowserWindow::DetachFromBrowser - unused - store BrowserView2* on HWND's property list so infobubbles can access it later- both frames (Opaque and AeroGlass) notify the BrowserView2 when they're moved so BrowserView2 can reposition the status bubble and close the autocomplete popup - remove BrowserView2::ShowTabContents - no longer used - remove BrowserView2::ShelfVisibilityChanged - no longer used - remove BrowserView2::SetWindowTitle - never used - remove BrowserView2::ProfileChanged - now called from TabSelectedAt- properly unhook infobars etc when a tab is detached B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@660 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for ChromeViews::Windows to disable inactive rendering. This is ↵beng@google.com2008-08-115-14/+67
| | | | | | | | | for the new frames to make it so when infobubbles are activated the window frame isn't deactivated. B=1318343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@659 0039d316-1c4b-4281-b951-d872f2087c98
* A set of tests to exercise chrome menus as well as parts of bookmarksky@google.com2008-08-113-3/+18
| | | | | | | | | | | | bar view. These are disabled until we straighten out the buildbot that is always logged in. BUG=1318922 TEST=this is just a bunch of tests. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@654 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the window icon to be shown in the task bar, Alt+Tab etc.beng@google.com2008-08-094-0/+23
| | | | | | | B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@614 0039d316-1c4b-4281-b951-d872f2087c98
* Even more tweaks.beng@google.com2008-08-091-0/+2
| | | | | | | | | | - make window icon and title work on app windows - make window title updating sync with the task bar - make Aero Glass frame respect app mode settings - move title formatting routine from TabRenderer into Browser (a more central location) - appearance adjustments for app windows with info bars git-svn-id: svn://svn.chromium.org/chrome/trunk/src@612 0039d316-1c4b-4281-b951-d872f2087c98
* More improvements to the frames. Consolidate some of the optional bar ↵beng@google.com2008-08-071-1/+7
| | | | | | | | | (bookmark, info, download) showing/layout, add a notion of supported window features, hook up some accelerator handling goop etc. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@529 0039d316-1c4b-4281-b951-d872f2087c98
* Make tabs affected by context menu actions pulse. The effect is somewhat ↵beng@google.com2008-08-072-0/+7
| | | | | | | | | | subtle since I'm re-using the selection animation. Added support to the Menu Delegate for notifications of when selection moves within the menu. B=1313339 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@523 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 1303709: Crash: Switching between tabs with a Find box open on both tabs ↵finnur@google.com2008-08-061-6/+7
| | | | | | | | | | | | | | | | | | nulls the Esc handler This is a temporary fix until we fix this properly: http://b/issue?id=1307173 This change makes sure that when we Register as the Esc handler, we store who was registered at the time the Find box was opened for the first time (as opposed to always restoring to what RegisterAccelerator tells us was registered before us). Also, if we have already been unregistered, we don't restore the old value. This prevents us from restoring to another tab's handler when the tab registering gets focus notification before the tab *un*registering receives blur notification (through FocusWillChange). BUG=1303709 TEST=Manually perform the steps listed in the bug and make sure it doesn't crash. Also make sure that the browser's Esc handler still works after closing the Find box. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@421 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing an issue where BiDi text in window titles was not displayed correctly ↵idana@google.com2008-08-051-0/+7
| | | | | | | | on Vista with aero. BUG=1306227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@385 0039d316-1c4b-4281-b951-d872f2087c98
* Copy WM_GETOBJECT handler impl from XPFrame to HWNDViewContainer. This will ↵beng@google.com2008-08-052-1/+63
| | | | | | | | | | be used for the new frames. Also provide virtual stub handlers for WM_ENDSESSION and WM_POWERBROADCAST B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@378 0039d316-1c4b-4281-b951-d872f2087c98
* Add the AeroGlassFrame and AeroGlassNonClientView for Vista.beng@google.com2008-08-054-12/+29
| | | | | | | | Note that AeroGlassFrame needs a NonClientView as well - even though Windows draws most of the frame and its borders, we do some custom rendering in the non-client area, such as the distributor logo, the client edge and toolbar backgrounds. This necessitated allowing Window to support an optional NonClientView. I just jimmied this in for now... can clean up that API later if desired. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@352 0039d316-1c4b-4281-b951-d872f2087c98
* Bring up the new frame (opaque version for XP only, for now).beng@google.com2008-08-042-6/+15
| | | | | | | | | | | | I've hidden this frame behind a command line switch (--magic_browzR) so as not to destabilize the main browser UI any further. Note that running with this switch is likely buggy, incomplete, crashy, etc. In order to make this work without disrupting a lot of existing code, I've had to make another BrowserView class (temporary) - BrowserView2. This also has to be a BrowserWindow implementor since that's the interface Browser uses to communicate with the UI. BrowserView2 and OpaqueNonClientView are the major new files in this CL, but BrowserView2 is pretty similar to BrowserView. OpaqueNonClientView is the view that renders the titlebar/borders/etc. It's layout/painting routines are a bit simpler than XPFrame's! B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@329 0039d316-1c4b-4281-b951-d872f2087c98
* Convert chrome SConscript files to psuedo-builder calls.sgk@google.com2008-08-031-1/+1
| | | | | | | | TBR: evanm,bradnelson git-svn-id: svn://svn.chromium.org/chrome/trunk/src@306 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in DialogClientView caused by recursion of Close calls. When ↵beng@google.com2008-08-011-6/+8
| | | | | | | | migrating from Window to DialogClientView, I neglected to insert the check into this function to see if the dialog had already been accepted by the user before trying to abort. B=1304032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SCons breakage, plus latest updates:sgk@google.com2008-07-311-0/+1
| | | | | | | | | | | | | * Update src/DEPS to latest icu38 rev. * Add new browser/views/frame/*.cc files. * Add new browser/debugger/debugger_contents.cc file. * Add new views/dialog_client_view.cc file. * Build new browser/debugger/resources/debugger_resources.rc file. * Add a new ChromeVersionRC() builder to the environment to provide a simpler, abstract interface for the four *version.rc files we build, with fixed definitions of $VERSION_BAT and $CHROME_SRC_DIR. * Fix the definition of $HTML_INLINE. R=deanm,bradnelson git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196 0039d316-1c4b-4281-b951-d872f2087c98
* Initial cleanups en route to coalescing the get-it-built cut-and-paste from ↵sgk@google.com2008-07-311-11/+2
| | | | | | | | | | | | | | | | | | various SConscripts into readable and maintainable shape. To wit: * Put the near-universal settings of /DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS, /DWIN32_LEAN_AND_MEAN, /wd4503 and /wd4819 in the base construction environment. * Sort various unsorted source file lists. * Fix indentation and quoting for consistency in a couple SConscript files that escaped previous dragnets. * Eliminate two left-over uses of Split() for input file lists. * Give the devenv invocation to build v8_shell.exe the full path to the relevant .vcproj file. * Add /nologo to the base LINKFLAGS setting. * Remove various CPPPATH and other settings that have been hanging around commented out from the Visual Studio build (in case we needed them, which we evidently don't). * Get rid of unnecessary env.File() and env.Dir() calls in various settings (esp. CPPPATH) and source file lists. * Add copyright notice to an overlooked SConscript file. * Clean up version.bat invocation. TBR: bradnelson git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174 0039d316-1c4b-4281-b951-d872f2087c98
* rollback these changesbeng@google.com2008-07-313-20/+11
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustage, not sure why this didn't break on my machinebeng@google.com2008-07-311-0/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169 0039d316-1c4b-4281-b951-d872f2087c98
* Should not be able to construct a CustomFrameWindow directly. Should use ↵beng@google.com2008-07-312-11/+17
| | | | | | | | | | CreateChromeWindow instead. Move CustomFrameWindow's two constructors to the protected section. They should be called by subclasses only. B=1293984 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167 0039d316-1c4b-4281-b951-d872f2087c98
* Move some methods from public to protected, since only subclasses should be ↵beng@google.com2008-07-313-82/+79
| | | | | | | | | | calling them. Move some data members from protected to private and provide a protected setter, per C++ style guidelines. B=1293984 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157 0039d316-1c4b-4281-b951-d872f2087c98
* forgot these filesbeng@google.com2008-07-314-460/+75
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154 0039d316-1c4b-4281-b951-d872f2087c98
* Move dialog-specific aspects of ClientView into a new subclass DialogClientView.beng@google.com2008-07-318-166/+674
| | | | | | | | | | | | | | ClientView becomes a generic representation of the View that occupies the "client area" of a window. All Windows now require a Client View (though they can use the default). Adjust WindowDelegate to provide a method for constructing the ClientView for a Window. The DialogDelegate overrides this to construct the DialogClientView. In the future, other specialized delegates will construct ClientViews specific to them, e.g. WizardDelegate would construct WizardClientView. Adjust the Window Init method to set up this new required Client View, and make some tweaks to CustomFrameWindow to make all this work. Remove all traces of dialog specific handling in Window into DialogClientView. B=1280060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153 0039d316-1c4b-4281-b951-d872f2087c98
* Add views\non_client_view.cc to the SCons build.sgk@google.com2008-07-301-0/+1
| | | | | | TBR: beng git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147 0039d316-1c4b-4281-b951-d872f2087c98
* Make NonClientView an interface independent of CustomFrameWindow (i.e. move ↵beng@google.com2008-07-305-91/+212
| | | | | | | | | | | | it into its own file). Rename NonClientView's HitTest method to NonClientHitTest, so it doesn't collide with View's HitTest method. Also, consolidate some duplicated code between CustomFrameWindow and ConstrainedWindow's non-client view impl. B=1300864 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141 0039d316-1c4b-4281-b951-d872f2087c98
* Made changes to display tooltip window when user navigates through the icons ↵stanguturi@google.com2008-07-303-8/+109
| | | | | | | | in the toolbar using keyboard arrow keys. I have already fixed this issue. (Issue:801). I have got LGTM also. But, I have checked in the code when tree was closed. So, all my changes were reverted. So, this new issue is created to upload the same changes. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139 0039d316-1c4b-4281-b951-d872f2087c98
* build bustagebeng@google.com2008-07-302-2/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106 0039d316-1c4b-4281-b951-d872f2087c98
* Make HWNDViewContainer set up its contents view separately from its Init method.beng@google.com2008-07-307-26/+33
| | | | | | | | | This is needed as a first step in further adjustments I'm going to be making to Window, ClientView, etc. B=1280060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105 0039d316-1c4b-4281-b951-d872f2087c98
* roll back this part of the fix since it has unintended side effects when ↵beng@google.com2008-07-301-1/+2
| | | | | | calling virtual overrides git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104 0039d316-1c4b-4281-b951-d872f2087c98
* Move the initial sizing of a Window into a separate function ↵beng@google.com2008-07-302-76/+81
| | | | | | | | (SetInitialBounds) to tidy up the Init method a bit. Move SetInitialFocus into private section since it's not used by subclasses. B=1293984 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99 0039d316-1c4b-4281-b951-d872f2087c98
* Window Delegate Improvements:beng@google.com2008-07-308-149/+133
| | | | | | | | | | | | | | | | | | | | | | - Windows now must have a Delegate. Just construct the default WindowDelegate if you don't want to have to write one in testing. - Windows now obtain their contents view by asking the delegate via WindowDelegate::GetContentsView. - Contents views no longer need to manually store a pointer to the Window that contains them, WindowDelegate does this automatically via its window() accessor. Reviewer notes: - review window_delegate.h first, then - window.h/cc - custom frame window.h/cc - constrained_window_impl.h/cc - then everything else (just updating all call sites) B=1280060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96 0039d316-1c4b-4281-b951-d872f2087c98
* Revert revision 73 because it was checked in when the tree was closed.nsylvain@google.com2008-07-293-109/+8
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74 0039d316-1c4b-4281-b951-d872f2087c98
* Made changes to display the tooltip window when user navigates through the ↵stanguturi@google.com2008-07-293-8/+109
| | | | | | icons in the toolbar using keyboard arrow keys. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a few incorrect #endif's in include guards.deanm@google.com2008-07-281-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36 0039d316-1c4b-4281-b951-d872f2087c98
* Try to cut down on some unnecessary dependencies. Remove any unused ↵deanm@google.com2008-07-281-1/+0
| | | | | | includes of gurl.h in header files, and forward declare GURL where possible. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome to the repository.initial.commit2008-07-26122-0/+37679
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-22 07:01:17 +0000