summaryrefslogtreecommitdiffstats
path: root/chrome/views
Commit message (Collapse)AuthorAgeFilesLines
* Don't reserve space for an auto-hide taskbar that's not always-on-top. ↵pkasting@chromium.org2009-04-141-4/+4
| | | | | | | | | Windows native behavior is to cover these. BUG=9976 Review URL: http://codereview.chromium.org/66055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13683 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo. Original patch by Shinichiro Hamaji (see ↵pkasting@chromium.org2009-04-142-10/+10
| | | | | | http://codereview.chromium.org/67123 ), r=me. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13669 0039d316-1c4b-4281-b951-d872f2087c98
* Add a comment to the hwnd view about proper usage. I was using it incorrectlybrettw@chromium.org2009-04-131-0/+3
| | | | | | | | | in when trying to do some ui demos. Add a hook for the frame window test I'm doing. Review URL: http://codereview.chromium.org/58013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13605 0039d316-1c4b-4281-b951-d872f2087c98
* Fix various problems with work area change notifications so that we now ↵pkasting@chromium.org2009-04-102-46/+115
| | | | | | | | | (hopefully) move/resize correctly whenever the work area changes, no matter why. BUG=8873 Review URL: http://codereview.chromium.org/67023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13533 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure one cannot cut or copy from a passwordjcampan@chromium.org2009-04-103-3/+126
| | | | | | | | | | | text-field. And assorted unit-tests. BUG=9425 TEST=Visit a page with basic auth (ex: http://prism.library.cornell.edu/control/authBasic/authTest/). Type some text in the password field. Select the text and try to cut/copy with CTRL-X, CTRL-V and right click menu. You should not be able to cut/copy the text. Review URL: http://codereview.chromium.org/63053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13520 0039d316-1c4b-4281-b951-d872f2087c98
* Adds some ifdefs so that test_shell can be compiled on linuxsky@chromium.org2009-04-101-3/+3
| | | | | | | | | | | | | without GTK. I had to recreate this patch as my workspace for various resonds. UGH! BUG=none TEST=none Review URL: http://codereview.chromium.org/67024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13503 0039d316-1c4b-4281-b951-d872f2087c98
* When the Find bar has focus it eats keypresses such as PageUp, PageDown and ↵finnur@chromium.org2009-04-082-7/+15
| | | | | | | | | | | | | | | Up and Down arrow keys. It doesn't need to - instead the page should scroll even if focus is on the Find bar. This patch forwards those selected keypresses to the page for its perusal. Known issues: Just like Firefox, the page doesn't scroll if it has frames. SONG=I like to fixit fixit. I like to fixit fixit. BUG=7079 TEST=Open FindInPage on a webpage that has a vertical scrollbar. Press Down, Up, PageDown and PageUp and the page should scroll accordingly. Make sure no ding is heard while doing so. Also make sure this works if focus is on a textfield/textarea when you press Ctrl+F. Review URL: http://codereview.chromium.org/62129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13389 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor AppModalDialogQueue and move JS Alert boxes into a MVC.tc@google.com2009-04-072-28/+0
| | | | | | | | | | | | JavascriptMessageBoxHandler (handles alert, confirm, prompt, and onbeforeunload) was a views class. This change converts it into an MVC so we can port to linux/mac. AppModalDialog is the model+controller, JavascriptMessageBoxDialog is the windows specific view. The onbeforeunload dialog (JavascriptBeforeUnloadHandler) was a subclass of JavascriptMessageBoxHandler that had a different title and button text. I merged this class into JavascriptMessageBoxHandler by passing a bool to handle the custom button text. Review URL: http://codereview.chromium.org/63033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13276 0039d316-1c4b-4281-b951-d872f2087c98
* Pasting successfully into a TextField should always triggerfinnur@chromium.org2009-04-061-3/+6
| | | | | | | | | | | | | | OnContentsChanged on the controller. BUG=None TEST= 1) Navigate to google.com, copy the contents of the OmniBox (the URL) and paste it back into the OmniBox. The dropdown should appear. 2) Navigate to google.com, copy the word Privacy into the clipboard. Open the Find box, Paste into the Find bar. It should search. Close the Find bar. Reopen the Find bar. Paste again. It should search. Review URL: http://codereview.chromium.org/63014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13187 0039d316-1c4b-4281-b951-d872f2087c98
* Commits bug issuereview 62043 (http://codereview.chromium.org/62043)sky@chromium.org2009-04-061-3/+3
| | | | | | | | | | | from m0. BUG-9393 TEST=see bug Review URL: http://codereview.chromium.org/62067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13177 0039d316-1c4b-4281-b951-d872f2087c98
* Lands fix for 9659 from tedoc. See http://codereview.chromium.org/60059 for ↵sky@chromium.org2009-04-031-3/+20
| | | | | | | | | | | review. BUG=9659 TEST=none Review URL: http://codereview.chromium.org/60106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13121 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the checked-in scons configuration files.sgk@google.com2009-04-011-315/+0
| | | | | | Review URL: http://codereview.chromium.org/53121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12982 0039d316-1c4b-4281-b951-d872f2087c98
* Fix distributor logo placement on glass frame when window is restored from ↵ben@chromium.org2009-04-012-9/+18
| | | | | | | | | | | | fullscreen. Force a layout in WM_NCCALCSIZE since NC metrics can change as a result of handling this message. http://crbug.com/8511 Review URL: http://codereview.chromium.org/56086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12930 0039d316-1c4b-4281-b951-d872f2087c98
* Update non-browser windows to handle maximized mode layout changes. This ↵pkasting@chromium.org2009-03-311-8/+8
| | | | | | | | | should have been part of my changes in r11355, I overlooked it. BUG=8372 Review URL: http://codereview.chromium.org/56121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12900 0039d316-1c4b-4281-b951-d872f2087c98
* Use Webkit::WebInputEvent and remove webkit/glue/webinputevent.darin@chromium.org2009-03-271-5/+6
| | | | | | | | | | This change adds a temporary dependency on src/KeyIdentifier.{h,cpp} which I am going to remove after this CL. I didn't want to grow this CL any larger. R=dglazkov Review URL: http://codereview.chromium.org/53099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12728 0039d316-1c4b-4281-b951-d872f2087c98
* Move message flags into a separate header that can be usedtc@google.com2009-03-272-33/+3
| | | | | | | | | outside the views system. Mac will need this as well when implementing message boxes. Review URL: http://codereview.chromium.org/56026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12722 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clipping by using the correct window styles for native buttons.ben@chromium.org2009-03-275-39/+40
| | | | | | | | | | Also ensure unhandled messages get handled by DefWindowProc of the containing WidgetWin. http://crbug.com/9216 Review URL: http://codereview.chromium.org/42629 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12671 0039d316-1c4b-4281-b951-d872f2087c98
* Default native button were not activated anymore when enter was pressed.jcampan@chromium.org2009-03-275-30/+160
| | | | | | | | | | | | The DialogDefaultButtonTest unit-test now tests for the behavior when enter is pressed. Also changed check-box (and radio-buttons) not to respond to enter key press as if they were clicked. BUG=9384 TEST=Bring up the option dialog. Move the focus to a link press Enter. The dialog should be closed (as OK was the default button). Review URL: http://codereview.chromium.org/42683 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12666 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fix issue 5724 - RTL: Windows context menu with Alt+Space Bar should ↵xji@chromium.org2009-03-272-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | be displayed on right side of the window. (http://crbug.com/5724) and issue 5738 - RTL: App drop-down menu should be displayed below the favicon (http://crbug.com/5738) In RTL UI, the x-axis of the system menu was computed as the MirroredXCoordinateInsideView(x-axis in LTR UI); Also, the menu was right-aligned relative to the x-axis. It fixes the system menu position in the following 3 situations: 1. press alt+space (such as in application short-cut, in chrome browser, in pop-up dialog such as option/clear browsing data), the system menu appears on the right side of the window (instead of left side, without the fix). 2. click favicon of application shortcut, the system menu appears on the right side of the window (instead of left side, without the fix). 3. right click on chrome browser tab, system menu appears at left side of the click (instead of right side of the click). Please be noted that: System menu itself is not yet mirrored. This CL only fixes its display position. Review URL: http://codereview.chromium.org/53120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12631 0039d316-1c4b-4281-b951-d872f2087c98
* Issue 21268: The RemakeSee http://codereview.chromium.org/21268 for the ↵idanan@chromium.org2009-03-267-25/+73
| | | | | | | | original issue which was partially reverted due to a possible regression. Issue 8819 was created to track the part of the original fix which was reverted.A double-click come as an event which follows a single-click. The core of this change is to makesure that a double-click arrives at the object which handled the single-click which preceeded it.If it does not, then the double-click is transformed into a single-click at the dispatch level.The tricky part is that a single-click and the double-click which follows it may not both be clientor non-client. So, all double-clicks (client or non-client) are now centrally handled and replacedwhen needed by second single-clicks.Note that the behavior which was reverted was to discard a double-click rather than reducing it toa single-click. The bug filed as a regression involved using a double-middle-click as two single-clicks when destroying compressed tabs sequentially.BUG=8819 Review URL: http://codereview.chromium.org/50017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12590 0039d316-1c4b-4281-b951-d872f2087c98
* In an effort to make the FocusManager class platform independent, moving ↵jcampan@chromium.org2009-03-262-7/+11
| | | | | | | | | | some Windows specific code around. BUG=9117 TEST=None Review URL: http://codereview.chromium.org/42621 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12571 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding since it was breaking the Release build (because of missing includes).jcampan@chromium.org2009-03-256-115/+171
| | | | | | | | | | | | | | | | | | Moving the mouse-wheel message rerouting code out of the focus manager. This is part of the effort of making the focus manager not window specific. BUG=None TEST=Make sure mouse-wheel scrolls the Chrome window under the cursor (try with a Chrome window, the option window, the task manager table) when it is active and when it is inactive. Also try using the mouse-wheel on a plugin with a scroll-view (for example http://java.sun.com/products/plugin/1.4/demos/plugin/jfc/SwingSet2/SwingSet2.html) when the browser window is not active, the plugin should scroll. TBR=ben Review URL: http://codereview.chromium.org/42624 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12517 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 12498.jcampan@chromium.org2009-03-256-167/+115
| | | | | | Review URL: http://codereview.chromium.org/53073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12500 0039d316-1c4b-4281-b951-d872f2087c98
* Moving the mouse-wheel message rerouting code out of the focus manager.jcampan@chromium.org2009-03-256-115/+167
| | | | | | | | | | This is part of the effort of making the focus manager not window specific. BUG=None TEST=Make sure mouse-wheel scrolls the Chrome window under the cursor (try with a Chrome window, the option window, the task manager table) when it is active and when it is inactive. Also try using the mouse-wheel on a plugin with a scroll-view (for example http://java.sun.com/products/plugin/1.4/demos/plugin/jfc/SwingSet2/SwingSet2.html) when the browser window is not active, the plugin should scroll. Review URL: http://codereview.chromium.org/53037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12498 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash that occurred because we weren't correctly disposing of thesky@google.com2009-03-251-0/+8
| | | | | | | | | | | native HWND for buttons. BUG=9301 TEST=see bug Review URL: http://codereview.chromium.org/42609 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12481 0039d316-1c4b-4281-b951-d872f2087c98
* When a native button was getting focused we were calling the View::Focus() ↵jcampan@chromium.org2009-03-251-1/+3
| | | | | | | | | | | | method which would focus the RootView HWND confusing the button and the click would not trigger WM_COMMAND. When the button was already focused, we were not setting the focus and the WM_COMMAND was sent correctly. BUG=9273 TEST=Open the option dialog, click the Manage button in the "Default search" section. This should bring up the dialog. Close the dialog, the focus should be on the Manage button. Review URL: http://codereview.chromium.org/42616 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12480 0039d316-1c4b-4281-b951-d872f2087c98
* The native button's visible and enabled state were not working.jcampan@chromium.org2009-03-255-0/+17
| | | | | | | | BUG=9261 TEST=See bug. Review URL: http://codereview.chromium.org/42582 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12473 0039d316-1c4b-4281-b951-d872f2087c98
* Focusing a native button through a RequestFocus call would not result in the ↵jcampan@chromium.org2009-03-255-3/+29
| | | | | | | | | | | | | | actual button showing as focused. This is because the NativeButton is the one getting focused not the NativeControl wrapper. This CL adds forwarding the focus to the NativeControl so the HWND really gets focused. It also associates the NativeButton view with the NativeControl, so that when the HWND is focused (through a click for example), the focus manager has the NativeButton as the focused view (not the NativeControl wrapper). BUG=9253 TEST=Open the option panel. Press tab several times. The focus should move as expected to the different buttons and views in the page. Review URL: http://codereview.chromium.org/45042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12420 0039d316-1c4b-4281-b951-d872f2087c98
* Redone http://codereview.chromium.org/42571idanan@chromium.org2009-03-242-2/+14
| | | | | | | | | | | Issue 6477: Support modifier clicks on UI elements Mouse event flags transformed to WindoOpenDisposition so that browser commands can all inteterpert event modifiers. Implemented home, forward and backwards middle-click andshift middle click. Previously working on issue 358 which was market a duplicate and concerned with the home and tabstrip subset of this behavior: Can't open a new tab by middle-clicking home button. No functionality has been lost or altered, only the use ofmodifiers give access to increased functionality. BUG=6477 TBR=maruel Review URL: http://codereview.chromium.org/53020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12403 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r12383, caused a build breakage on all platforms.maruel@chromium.org2009-03-242-14/+2
| | | | | | | TBR=idanan Review URL: http://codereview.chromium.org/42571 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12385 0039d316-1c4b-4281-b951-d872f2087c98
* Issue 6477: Support modifier clicks on UI elementsidanan@chromium.org2009-03-242-2/+14
| | | | | | | | | | | | | | | | | | | Mouse event flags transformed to WindoOpenDisposition so that browser commands can all inteterpert event modifiers. Implemented home, forward and backwards middle-click andshift middle click. Previously working on issue 358 which was market a duplicate and concerned with the home and tabstrip subset of this behavior: Can't open a new tab by middle-clicking home button. No functionality has been lost or altered, only the use ofmodifiers give access to increased functionality. BUG=6477 TBR=ben@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12383 0039d316-1c4b-4281-b951-d872f2087c98
* Fix first run/installer test by NULL checking.ben@chromium.org2009-03-241-1/+2
| | | | | | | | TBR=jcampan Review URL: http://codereview.chromium.org/52032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12328 0039d316-1c4b-4281-b951-d872f2087c98
* Fix UI test:ben@chromium.org2009-03-231-0/+3
| | | | | | | | | | NULL check the wrapper since this can be called when we're not in a view hierarchy. TBR=jcampan Review URL: http://codereview.chromium.org/42539 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12321 0039d316-1c4b-4281-b951-d872f2087c98
* The death knell for the old native buttons, checkboxes and radio buttons.ben@chromium.org2009-03-2325-1311/+493
| | | | | | | | Replace with renamed NativeButton2, Checkbox2, RadioButton2. Review URL: http://codereview.chromium.org/50083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12317 0039d316-1c4b-4281-b951-d872f2087c98
* Fix broken build.erg@google.com2009-03-231-0/+2
| | | | | | | Review URL: http://codereview.chromium.org/42528 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12306 0039d316-1c4b-4281-b951-d872f2087c98
* Deliver events and notifications to the RootView.erg@google.com2009-03-2310-93/+254
| | | | | | | Review URL: http://codereview.chromium.org/42519 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12305 0039d316-1c4b-4281-b951-d872f2087c98
* forgot thisben@chromium.org2009-03-211-0/+8
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12236 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for radio buttons. The code implementing checked/group was ↵ben@chromium.org2009-03-214-5/+149
| | | | | | | | copied from the old radio button. Review URL: http://codereview.chromium.org/50080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12235 0039d316-1c4b-4281-b951-d872f2087c98
* More button modificationsben@chromium.org2009-03-206-19/+144
| | | | | | Review URL: http://codereview.chromium.org/50047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12233 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a bookmark menu. This is experimental. To turn on you needsky@google.com2009-03-201-0/+4
| | | | | | | | | | | | --bookmark-menu. BUG=3206 TEST=Turn on the bookmark menu via --bookmark-menu and make sure it works. Also make sure I didn't break anything on the bookmark bar. Review URL: http://codereview.chromium.org/42460 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12217 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: remove extra "typedef" from an enum.agl@chromium.org2009-03-201-1/+1
| | | | | | | | | (reported by t3d0). TBR=erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12182 0039d316-1c4b-4281-b951-d872f2087c98
* Now have a TextButton rendering (sort of; doesn't respond to mouse events soerg@google.com2009-03-199-44/+53
| | | | | | | | | | | I don't know if it'll draw the border correctly). Now with fixes to compile under Windows. Review URL: http://codereview.chromium.org/42427 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12172 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Now have a TextButton rendering." Broke Windows.erg@google.com2009-03-198-48/+34
| | | | | | | | | TBR=beng Review URL: http://codereview.chromium.org/50035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12163 0039d316-1c4b-4281-b951-d872f2087c98
* Now have a TextButton rendering (sort of; doesn't respond to mouse events so ↵erg@google.com2009-03-198-34/+48
| | | | | | | | | I don't know if it'll draw the border correctly). Review URL: http://codereview.chromium.org/42414 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12162 0039d316-1c4b-4281-b951-d872f2087c98
* Create cross-platform NativeButton2 class that wraps a NativeButtonWin.Once ↵ben@chromium.org2009-03-1915-213/+515
| | | | | | | | I get this to work I'll rename it NativeButton and remove the old one. Review URL: http://codereview.chromium.org/48117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12160 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/43009 .sky@google.com2009-03-191-2/+4
| | | | | | | | BUG=7259 TEST=see bug git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12153 0039d316-1c4b-4281-b951-d872f2087c98
* Render into a ChromeCanvasPaint object in a RootView under Linux.erg@google.com2009-03-1914-107/+544
| | | | | | | Review URL: http://codereview.chromium.org/45014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12097 0039d316-1c4b-4281-b951-d872f2087c98
* Deletes the now unused AccessibleWrapper (replaced in previous CL by ↵klink@chromium.org2009-03-192-133/+0
| | | | | | | | ViewAccessibilityWrapper). Review URL: http://codereview.chromium.org/48170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12064 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when double clicking a menu button.ben@chromium.org2009-03-191-1/+4
| | | | | | Review URL: http://codereview.chromium.org/42376 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12063 0039d316-1c4b-4281-b951-d872f2087c98
* New native control helpers. Built but not run by anyone just yet. See design docben@chromium.org2009-03-187-0/+794
| | | | | | | | http://dev.chromium.org/developers/design-documents/native-controls Review URL: http://codereview.chromium.org/48094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12008 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-09 01:29:26 +0000