summaryrefslogtreecommitdiffstats
path: root/chrome/views
Commit message (Collapse)AuthorAgeFilesLines
* Changed svn:eol-style of all .sln and .vcproj files to CRLFscherkus@chromium.org2008-12-041-659/+659
| | | | | | Review URL: http://codereview.chromium.org/13133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6372 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium-MultiProfile-Prototypemunjal@chromium.org2008-12-034-8/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Summary ======= Implement a prototype of multiple profiles in Chrome by utilizing the functionality of user-data-dir command line flag that already exists. A profile in this case is an umbrella for all user data including cookies, history, bookmarks, settings, etc. Each profile gives the user a separation of all these data elements. User Interface ============== - Wrench > "New window in profile" menu item, with sub-menu items. This new menu item has sub menu items for each existing profile, for up to 9 profiles, and one more sub menu item to launch a window in a new profile. The 9 sub-menu items also have the accelerators like CTRL + SHIFT + 1, CTRL + SHIFT + 2, etc. If there are more than 9 profiles, we will also show an extra sub-menu item, "Other...". - New Profile dialog box This dialog box is shown to the use when (s)he clicks Wrench > New window in profile > <New Profile>. It lets the user specify a profile name, and also shows a checkbox to create a desktop shortcut to launch Chrome in that profile. - Choose profile dialog box This dialog box lets the user select a profile from a drop down to open a new window in. It also has an item <New Profile> in the drop down, selecting which will show the new profile dialog box mentioned above. CTRL + M shortcut also launches this dialog box. Code Organization ================= chrome\browser\user_data_dir_profile_manager.h/.cc: This class provides an abstraction of profiles on top of the user data dir command line flag. chrome\browser\views\user_data_dir_new_profile_dialog.h/.cc New profile dialog box code. chrome\browser\views\user_data_dir_profiles_dialog.h/.cc Choose profile dialog box code. Review URL: http://codereview.chromium.org/12895 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6333 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/gfx/skia_util to skia/ext/skia_util_win.brettw@google.com2008-12-036-6/+6
| | | | | | | In a later pass, I will separate off the cross-platform part of this file into skia/ext/skia_util (only one function). Review URL: http://codereview.chromium.org/13101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6306 0039d316-1c4b-4281-b951-d872f2087c98
* Move convolver and image_operations from base/gfx to skia/ext. This is justbrettw@google.com2008-12-031-1/+1
| | | | | | | | like my previous change except does no namespace renaming and doesn't touch skia_utils. Review URL: http://codereview.chromium.org/13080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6290 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back this change.ben@chromium.org2008-12-032-12/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6279 0039d316-1c4b-4281-b951-d872f2087c98
* RootView should be destroyed in WM_NCDESTROY not after it.ben@chromium.org2008-12-032-1/+12
| | | | | | Review URL: http://codereview.chromium.org/12632 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6277 0039d316-1c4b-4281-b951-d872f2087c98
* Revert my skia file moves because of layout test failures.brettw@google.com2008-12-037-12/+15
| | | | | | Review URL: http://codereview.chromium.org/12892 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6266 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes context menu behavior of table view. In particular when runningsky@google.com2008-12-022-18/+43
| | | | | | | | | | | | | | in an RTL locale and right clicking on the icon some times the scrollbar context menu would appear. I've fixed it by subclassing the context menu handling and getting the location from the position of the mouse. BUG=4752 TEST=see bug, but also make sure this doesn't regress 4750 Review URL: http://codereview.chromium.org/13055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6252 0039d316-1c4b-4281-b951-d872f2087c98
* Move convolver, image_operations, and skia_utils from base/gfx to skia/ext.brettw@google.com2008-12-027-15/+12
| | | | | | | | | | | This changes the namespace in those files from "gfx" to "skia". I split skia_utils into two parts, the Windows specific part is now in a separate file called skia_utils_win. There were several obsolete includes of these headers which I removed. I also removed img_resize_perftest which isn't used and has bitrotted. Review URL: http://codereview.chromium.org/12842 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6248 0039d316-1c4b-4281-b951-d872f2087c98
* Adding more space between dialog contents and the buttons. For XP Classic themeben@chromium.org2008-12-021-1/+1
| | | | | | | | | | | | | | there was close to no space between the tab control and the buttons. The space is aligned with default Windows look for dialogs. BUG=4402 TEST=Verify that all dialogs look good in any XP/Vista theme w.r. to space from dialog contents to buttons. Change by Sverrir Á. Berg <sverrir@google.com>, committing on his behalf. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6240 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when hiding the find bar due to a NULL window_delegate_.ben@chromium.org2008-12-021-1/+3
| | | | | | Review URL: http://codereview.chromium.org/12854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6197 0039d316-1c4b-4281-b951-d872f2087c98
* Add F1 as an accelerator for "Help". Original patch by Alex Mendes da ↵pkasting@chromium.org2008-12-011-0/+3
| | | | | | | | Costa, r=ben, see http://codereview.chromium.org/10796 . BUG=851 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6158 0039d316-1c4b-4281-b951-d872f2087c98
* Rollbackmbelshe@google.com2008-12-011-4/+0
| | | | | | Review URL: http://codereview.chromium.org/13009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6127 0039d316-1c4b-4281-b951-d872f2087c98
* A new copy of the old system monitor changelist.mbelshe@google.com2008-11-301-0/+4
| | | | | | Review URL: http://codereview.chromium.org/12817 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6126 0039d316-1c4b-4281-b951-d872f2087c98
* Fix black flash when doing fast animations - our fix was previously ↵glen@chromium.org2008-11-261-6/+5
| | | | | | | | | | Vista-only, but now we have cross platform goodness. BUG=3676 Review URL: http://codereview.chromium.org/12670 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6033 0039d316-1c4b-4281-b951-d872f2087c98
* Changes keyword editor to map all input in the keyword field to lowersky@google.com2008-11-262-7/+16
| | | | | | | | | | | | case. BUG=4520 TEST=bring up the keyword editor, type some text and make sure it gets mapped to lower case. Review URL: http://codereview.chromium.org/12452 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6018 0039d316-1c4b-4281-b951-d872f2087c98
* Changes table_view to get position for context menu from the currentsky@google.com2008-11-252-0/+18
| | | | | | | | | | | | | | position of the mose. I've no idea why, but it seems when RTL the position passed to OnContextMenu is wrong in weird inconsistent ways. I thought it was interted, but that isn't always the case. I'm also changing the anchor position to top_right when RTL. BUG=4750 TEST=see bug Review URL: http://codereview.chromium.org/12447 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5996 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/12434jcampan@chromium.org2008-11-251-2/+27
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5990 0039d316-1c4b-4281-b951-d872f2087c98
* container_win.cc => widget_win.cc in the SCons build.sgk@google.com2008-11-221-1/+1
| | | | | | Review URL: http://codereview.chromium.org/11373 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5884 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Container->Widgetben@chromium.org2008-11-2140-506/+477
| | | | | | | | | R=erg review url = http://codereview.chromium.org/11348/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5849 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where tooltips would get stuck. This was happening becausesky@google.com2008-11-204-1/+10
| | | | | | | | | | | | | | | | | | on Vista we manage showing/hiding tooltips ourself. It would appear when managing our own tooltips like this we need to explicitly hide the tooltip. If you rapidly moved the mouse we wouldn't get a mouse move and the tooltip would stick. The fix is to have ContainerWin forward mouse leave and have the tooltip manager close the tooltip on mouse leave. BUG=2717 TEST=on vista do the following. Add a bookmark to the bookmark bar and hover the mouse over it. Then hit control-b so the bookmark bar disappears. Make sure the tooltip disappears too. Review URL: http://codereview.chromium.org/11540 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5798 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash when showing modal dialog from context menu. With thissky@google.com2008-11-192-38/+47
| | | | | | | | | | | | | | | | | | | | | sequence ContainerWin remains on the stack while the modal dialog is showing. Prior to this fix we would delete the ContainerWin, so that when the modal dialog closed control would return to a deleted object. The fix is to effectively delay deleting of the ConatinerWins used by menus. BUG=4580 TEST=This is the sequence that triggered the crash: open a folder on the bookmark bar, right child on a child folder that has more than 15 descendant URLs, click open all, a dialog should appear asking if you really want to open all, click cancel and make sure it doesn't crash. This is a subtle change to bookmark menus though, would be good to thoroughly exercise the menus in as many permutations as you can think of. Review URL: http://codereview.chromium.org/11289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5724 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes trees on Hebrew locales. The current code was problematicsky@google.com2008-11-191-2/+26
| | | | | | | | | | | | because SetWorldTransform and a graphics mode of COMPATIBLE don't work together. Instead we must use SetViewportOrgEx. BUG=4515 TEST=see bug Review URL: http://codereview.chromium.org/11253 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5654 0039d316-1c4b-4281-b951-d872f2087c98
* Fix erase method usage on STL containers in Chrome. Invoking erase on the ↵ananta@chromium.org2008-11-151-1/+2
| | | | | | | | | | iterator renders it invalid. We were continuing to use this iterator. R=darin Review URL: http://codereview.chromium.org/10925 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5531 0039d316-1c4b-4281-b951-d872f2087c98
* Fix broken size restoration for bookmark manager. Initializing a rect ↵ben@chromium.org2008-11-143-3/+16
| | | | | | | | | incorrectly, and clobbering the maximized state during initial sizing. http://crbug.com/4437 Review URL: http://codereview.chromium.org/10758 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5512 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/10958mbelshe@google.com2008-11-141-4/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5509 0039d316-1c4b-4281-b951-d872f2087c98
* Make the bookmark manager blue.glen@chromium.org2008-11-142-9/+7
| | | | | | Review URL: http://codereview.chromium.org/11006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5506 0039d316-1c4b-4281-b951-d872f2087c98
* Change to integrate SystemMonitor changes into chrome.mbelshe@google.com2008-11-141-0/+4
| | | | | | | | | | | | This enables the dynamic detection of battery status changes so that we can turn on/off the hi-res timer. Review URL: http://codereview.chromium.org/10264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5489 0039d316-1c4b-4281-b951-d872f2087c98
* Port some files in chrome/browser/agl@chromium.org2008-11-144-76/+102
| | | | | | | | | | | | | | | #ifdef out windows-specific portion of chrome/common/l10n_util.h, which allows me to port some other files. I also extracted parts of chrome/views/tree_view.h to tree_model.h, so that ATL/WTL-specific parts stay in tree_view.h, but tree_model.h is platform-independent and can be included in files using it as base class. Review URL: http://codereview.chromium.org/8618 Patch from Paweł Hajdan jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5483 0039d316-1c4b-4281-b951-d872f2087c98
* Make border and background setting and getting non-virtual and use the ↵brettw@google.com2008-11-149-80/+51
| | | | | | | | correct style. I was debugging in here and this was annoying me, since there is no reason for these functions to be virtual. Review URL: http://codereview.chromium.org/10638 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5445 0039d316-1c4b-4281-b951-d872f2087c98
* Re-do the way browser windows are shown:ben@chromium.org2008-11-144-114/+134
| | | | | | | | | | | | | | | | | | | | | | | | | | | - Remove the path from WinMain to the Browser object passing the show_command. For the Browser object, this is a problem since this value isn't portable. For the code in general it involves a lot of ugly wiring. It's completely unnecessary since the value is obtainable via GetStartupInfo. - Remove show_command plumbing from all over the place (session restore, web app launcher, etc) Change the way browser windows are constructed: - The browser constructor now takes just a type and a profile, and simply initializes the object. - Some configuration that used to be part of the constructor that was only used in one or two use cases (initial bounds, maximized state, web app name) are split into separate setters. - Window creation is split out into a separate step to be called post configuration. - Assorted static helper functions added to Browser to make construction of common types easy. - Remove Browser::Show in favor of BrowserWindow::Show - Adjust all callers to use the new helpers. Change the way ChromeViews restores window placement: - Split restored size determination from restored maximized determination. They are needed by the code at different times. Size restoration happens when the window is constructed and Window::SetInitialBounds is called. Maximized state restoration happens when the window is shown for the first time and SW_SHOWMAXIMIZED or SW_SHOWNORMAL is needed. Thus, replace WindowDelegate::RestoreWindowPosition with WindowDelegate::RestoreWindowBounds and WindowDelegate::RestoreMaximizedState. - Window::SetInitialBounds calls WindowDelegate::RestoreWindowBounds - Window::Show calls WindowDelegate::RestoreMaximizedState - Adjusts all WindowDelegate implementations that override RestoreWindowPosition to implement these new methods instead. - Move "playback/record" mode window size setting from browser_init to Browser::RestoreWindowBounds. - Provide a virtual function on Window called GetShowState that determines the default show state to be used when Window::Show is called. For most windows and dialogs this is SW_SHOWNORMAL. AeroGlassFrame/OpaqueFrame (the browser window frames) override this since they're the app's main windows to return the value provided by GetStartupInfo which gives the value from the app shortcut. http://crbug.com/3557 Review URL: http://codereview.chromium.org/10896 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5417 0039d316-1c4b-4281-b951-d872f2087c98
* Three menu bugs:sky@google.com2008-11-132-6/+8
| | | | | | | | | | | | | | | | | | . If a context menu was shown from a menu, then hidden we did not keep mouse capture and bad things happened (menu wouldn't go away when clicking else where, crash ...). . We only update menu sizes on first show of a menu. That way if a context menu doesn't have icons things don't shift around. . If nothing was selected in the menu pressing the context menu showed the context menu for the root. It doesn't make sense for the root menu to have a context menu. BUG=4364 TEST=see bug Review URL: http://codereview.chromium.org/10706 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5397 0039d316-1c4b-4281-b951-d872f2087c98
* Puts chrome menus on a slimfast diet: they are no longer chubby. Isky@google.com2008-11-132-14/+64
| | | | | | | | | | | | | | | added an option such that menus can be rendered in two ways, chubby or skinny. The only places that uses the taller menus is the bookmark bar. I also made the menus use the right font. BUG=1074332 TEST=none Review URL: http://codereview.chromium.org/10865 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5367 0039d316-1c4b-4281-b951-d872f2087c98
* Some speculative fixes for UI test flakiness.beng@google.com2008-11-132-5/+8
| | | | | | | | | | - make the window update locking use window visibility instead of WM_SETREDRAW. I believe WM_SETREDRAW is causing the window to become visible during tests. - potential crashes caused by NULL TabcontentsDelegates. TBR=sky Review URL: http://codereview.chromium.org/10674 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5335 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the 0x0 canvas used for computing text sizes. Creating this is not ↵brettw@google.com2008-11-131-2/+1
| | | | | | | | | necessary since the text can be sized using the desktop DC, which should be faster. I made this function static, and moved the functions it used into file-local functions since they didn't depend on the class either. This is trying to fix bug 49. This code is very close to the crash, and a 0x0 canvas seems like it might cause problems. However, it is unclear whether this will have any effect (other than performance). Review URL: http://codereview.chromium.org/10409 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5328 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes text field background when disabled/read-only to better matchsky@google.com2008-11-122-23/+44
| | | | | | | | | | | | | | | how Windows looks. This also changes SetEnabled not to adjust read_only_ state. That SetEnabled invoked SetReadOnly is just wrong, the two don't have to be the same. BUG=1218491 TEST=bring up the keyword editor and double click on one of the default search engines, make sure the background of the text field looks disabled. Review URL: http://codereview.chromium.org/10662 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5317 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in showing context menu for buttons. In particular becausesky@google.com2008-11-124-15/+25
| | | | | | | | | | | | we weren't resetting state before showing the context menu it was possible for the button to stay in a HOT state even though it isn't. BUG=2620 TEST=see bug Review URL: http://codereview.chromium.org/10835 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5300 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two menu bugs:sky@google.com2008-11-121-1/+20
| | | | | | | | | | | | | | | | | | | . Pressing shift-F10 would make context menu appear then immediately disappear. This is because MenuController was hiding on a WM_SYSKEYUP. I've changed MenuController to do nothing on WM_SYSKEYUP. If a sys key is pressed again, we'll get a WM_SYSKEYDOWN and hide there. . MenuController needed to handle WM_CONTEXTMENU and not dispatch it, otheriwse we could end up with stacked menus. BUG=3685 TEST=bring up bookmark manager, select a row in the table on the right. Press shift-F10 and make sure the context menu appears and stays up. Review URL: http://codereview.chromium.org/10635 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5299 0039d316-1c4b-4281-b951-d872f2087c98
* Uncomment out these two lines I commented out a few weeks ago so that the ↵ben@chromium.org2008-11-121-4/+0
| | | | | | | | | trunk is usable again. TBR=sky Review URL: http://codereview.chromium.org/10655 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5294 0039d316-1c4b-4281-b951-d872f2087c98
* Changes TableView to have its own mouse handling code so that we cansky@google.com2008-11-124-8/+154
| | | | | | | | | | | start a drag when user clicks anywhere on a row. BUG=4306 TEST=thoroughly test drag and drop of bookmark manager table. Review URL: http://codereview.chromium.org/9776 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5233 0039d316-1c4b-4281-b951-d872f2087c98
* Changes tree/table to pass in an appropriate location when the contextsky@google.com2008-11-108-47/+95
| | | | | | | | | | | | | menu is invoked from the keyboard. BUG=4029 TEST=In the bookmark manager bring up the context menu of the tree/table via the menu key and make sure the menu appears at a reasonable location. Review URL: http://codereview.chromium.org/10256 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5125 0039d316-1c4b-4281-b951-d872f2087c98
* Minor layout changes that make the bookmark manager and popup blocker look ↵glen@chromium.org2008-11-101-1/+1
| | | | | | | | | | better. BUG=4271 Review URL: http://codereview.chromium.org/10262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5121 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes Issue 3096 in chromium "[Find in page] responds each IME composition, ↵hbono@chromium.org2008-11-101-3/+74
| | | | | | | | | | | | making "not found" noises or jumping within the page." This issue is caued by the TextField::Edit class which start searching a page with a string retrieved with the GetWindowText() function every time when a user presses a key. A string retrived with the GetWindowText() function contains a composition string, a string being composed by an IME. This string changes too often and users do not like to start searching a page with the string. To fix this issue, this change removes a composition string from a search string to emulate Firefox. BUG=3096 "Issue 3096: [Find in page] responds each IME composition, making "not found" noises or jumping within the page." Review URL: http://codereview.chromium.org/9634 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5096 0039d316-1c4b-4281-b951-d872f2087c98
* In dialogs, when the focus moves to a button, that button should become the ↵jcampan@chromium.org2008-11-0812-13/+241
| | | | | | | | | | | | | | default button. When the focus is not a button, then the default button should be the one the delegate specifies. BUG=4132 TEST=Open the option dialog. OK should be the default and focused button. Move the focus around by pressing tab. When a button is selected, it should be the default button. Review URL: http://codereview.chromium.org/10230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5056 0039d316-1c4b-4281-b951-d872f2087c98
* Turns back on tree's double buffering when RTL. For some reason asky@google.com2008-11-071-14/+11
| | | | | | | | | | | | | graphics mode of a ADVANCED doesn't work with a RTL layout for this code. BUG=4175 TEST=bring up the bookmark manager in the hebrew locale, make sure the text isn't mirrored. Review URL: http://codereview.chromium.org/10216 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5017 0039d316-1c4b-4281-b951-d872f2087c98
* Adds cut/copy/paste support to the bookmark manager tree/table andsky@google.com2008-11-072-0/+11
| | | | | | | | | | | | context menus. BUG=4186 TEST=try cut/copy/paste from table/tree in the bookmark manager as well as context menus in bookmark manager. Review URL: http://codereview.chromium.org/9481 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4993 0039d316-1c4b-4281-b951-d872f2087c98
* Adds import/export of bookmarks to bookmarks.html file.sky@google.com2008-11-072-16/+16
| | | | | | | | | | | | BUG=1649 TEST=bring up bookmark manager and try out import/export from the tools menu. Note that import ALWAYS creates a new folder under the 'Other bookmarks folder' with the name of Imported (x). This is by design. Review URL: http://codereview.chromium.org/9471 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4968 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the double buffering in TreeView when the locale is RTL. This means ↵idana@google.com2008-11-061-0/+16
| | | | | | | | | that the tree still flicker during a resize on RTL locales but not on LTR. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4917 0039d316-1c4b-4281-b951-d872f2087c98
* Add a function for eliding filenames to a set pixel width while preserving ↵glen@chromium.org2008-11-062-2/+2
| | | | | | | | the display of the extension. This touches a lot of files because it renames url_elider to text_elider (as it already contained a bunch of text ellision functions), and so requires header file reference changes. BUG=1208 Review URL: http://codereview.chromium.org/9613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4912 0039d316-1c4b-4281-b951-d872f2087c98
* A reported crasher seems to indicate the ViewStorage can be NULL. I don't ↵jcampan@chromium.org2008-11-061-1/+17
| | | | | | | | | | | | see how it could happen. Just bullet-proofing the code so we don't crash. BUG=981648 Review URL: http://codereview.chromium.org/9190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4857 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-09 01:55:12 +0000