summaryrefslogtreecommitdiffstats
path: root/chrome/views
Commit message (Collapse)AuthorAgeFilesLines
* Accumulated SCons changes for Windows chrome build, round II:sgk@google.com2008-10-301-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Includes other recent additions, and doesn't fix everything, but gets significant pieces back on track: * New/additional library dependencies in various test executables (too many to be worth listing). * Portability: put library base names in $LIBS instead of explicitly listing .lib files. * Have interactive_ui re-use various object files from test/ui instead of (re-)listing the .cc files. * Add new files: chrome\browser\bookmarks\bookmark_drag_data.cc chrome\browser\bookmarks\bookmark_drag_utils.cc chrome\browser\bookmarks\bookmark_table_model.cc chrome\browser\browser_trial.cc chrome\browser\download\download_request_manager_unittest.cc chrome\browser\greasmonkey_master.cc chrome\browser\spellcheck_unittest.cc chrome\browser\views\find_bar_view.cc chrome\browser\views\find_bar_win.cc chrome\renderer\greasemonkey_slave.cc * Remove old files: chrome\browser\find_in_page_controller.cc chrome\browser\find_in_page_view.cc chrome\renderer\spellcheck_unittest.cc * Remove relative reference to ../../app/google_update_settings$OBJSUFFIX. * Get rid of by-hand /IMPLIB and /MAP flags. * Prefix / suffix portability in the jscre library. * Rename $LIBXML_DIR/scons => $LIBXML_DIR/DerivedSources. * Add $CHROME_DIR/app/resources to CPPPATH. * Add icu38 directories to CPPPATH for building chrome/views files. Review URL: http://codereview.chromium.org/8742 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4215 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Issue 2918 in chromium: Chrome dialog displayed in large size with ↵hbono@chromium.org2008-10-302-2/+2
| | | | | | | | Meiryo font.This issue is caused by a font whose text metric |tmAveCharWidth| is not precise as noted in Microsoft Knowledge Base 145994 (*1) To handle this case, this change uses the ChromeFont::horizontal_dlus_to_pixels() function instead of the ChromeFont::ave_char_width() function.(*1) http://support.microsoft.com/kb/145994BUG=2918 Review URL: http://codereview.chromium.org/8051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4213 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r4205 to track down buildbot unit_tests failure.sgk@google.com2008-10-301-2/+0
| | | | | | Review URL: http://codereview.chromium.org/8730 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4206 0039d316-1c4b-4281-b951-d872f2087c98
* Accumulated SCons changes for Windows chrome build and othersgk@google.com2008-10-301-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | recent additions (doesn't fix everything, but gets significant pieces back on track). * New/additional library dependencies in various test executables (too many to be worth listing). * Portability: put library base names in $LIBS instead of explicitly listing .lib files. * Have interactive_ui re-use various object files from test/ui instead of (re-)listing the .cc files. * Add new files: chrome\browser\bookmarks\bookmark_drag_data.cc chrome\browser\bookmarks\bookmark_drag_utils.cc chrome\browser\bookmarks\bookmark_table_model.cc chrome\browser\browser_trial.cc chrome\browser\download\download_request_manager_unittest.cc chrome\browser\greasmonkey_master.cc chrome\browser\spellcheck_unittest.cc chrome\browser\views\find_bar_view.cc chrome\browser\views\find_bar_win.cc chrome\renderer\greasemonkey_slave.cc * Remove old files: chrome\browser\find_in_page_controller.cc chrome\browser\find_in_page_view.cc chrome\renderer\spellcheck_unittest.cc * Remove relative reference to ../../app/google_update_settings$OBJSUFFIX. * Get rid of by-hand /IMPLIB and /MAP flags. * Prefix / suffix portability in the jscre library. * Rename $LIBXML_DIR/scons => $LIBXML_DIR/DerivedSources. * Add $CHROME_DIR/app/resources to CPPPATH. * Add icu38 directories to CPPPATH for building chrome/views files. Review URL: http://codereview.chromium.org/8725 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4205 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes resizing of single split view for RTL case.sky@google.com2008-10-301-2/+1
| | | | | | | | | BUG=674 TEST=none Review URL: http://codereview.chromium.org/8210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4193 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at the bookmark manager. There are still a fair number ofsky@google.com2008-10-292-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | | rough edges, but I'm at a good point where I want to land what I have. Here's what is left: . Flicker on show, likely the result of restoring window placement. . tree flickers when dragging splitter. . table/tree need to autoscroll when drop cursor held at bottom of view. . prompts for deleting. . When you move an item the table snaps to the top, this is because I'm sending out model changed. need a better notification. . Operations in menu to add need to change selection. . Remember split location. I would have preferred to split this up into a couple of reviews, but everything is intertwined now. Sorry. BUG=674 TEST=don't test the bookmark manager yet, but make sure bookmark bar still works. Review URL: http://codereview.chromium.org/8197 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4191 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing some windows scons build breaks.bradnelson@chromium.org2008-10-291-2/+1
| | | | | | Review URL: http://codereview.chromium.org/8723 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4186 0039d316-1c4b-4281-b951-d872f2087c98
* The "extra view" used by the DialogClientView must not be retrieved before ↵ben@chromium.org2008-10-292-8/+17
| | | | | | | | | the contents view has been attached to the view hierarchy. http://crbug.com/2751 Review URL: http://codereview.chromium.org/8681 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4116 0039d316-1c4b-4281-b951-d872f2087c98
* Makes tree double duffered so that it doesn't flicker during resize.sky@google.com2008-10-281-0/+14
| | | | | | | | | BUG=3784 TEST=none Review URL: http://codereview.chromium.org/8819 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4054 0039d316-1c4b-4281-b951-d872f2087c98
* Move Time, TimeDelta and TimeTicks into namespace base.dsh@google.com2008-10-275-2/+11
| | | | | | Review URL: http://codereview.chromium.org/7995 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4022 0039d316-1c4b-4281-b951-d872f2087c98
* Handful of changes to NativeControl, TreeView and TableView I'm goingsky@google.com2008-10-248-31/+149
| | | | | | | | | | | | | | | | | | | | to need for the bookmark manager. Specifically: . NativeController now delegates OnContextMenu to the ContextMenuController. . TableView allows a NULL model. . TableView::SetColumns was buggy. . Added a method that TableView invokes after painting. . Added methods to TreeView for getting various state information. BUG=674 TEST=make sure the various places in the UI we uses trees and table work fine: cookies table, passwords table, task manager, bookmark editor, search engines. Review URL: http://codereview.chromium.org/8145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3956 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a horizontal split view.sky@google.com2008-10-244-1/+185
| | | | | | | | | BUG=674 TEST=none Review URL: http://codereview.chromium.org/7930 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3897 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in FillLayout. It should use the size of the root view. I'msky@google.com2008-10-231-3/+1
| | | | | | | | | | | | not actually going to need FillLayout, but I'm fixing the bug in case someone else bumps into it. BUG=none TEST=none Review URL: http://codereview.chromium.org/8202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3839 0039d316-1c4b-4281-b951-d872f2087c98
* test something else to fix dist crashesben@chromium.org2008-10-231-0/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3835 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in TextField::SetEnabled. The code was invoking SetReadOnlysky@google.com2008-10-231-1/+1
| | | | | | | | | | | with the enabled parameter, when it should be !enabled. BUG=none TEST=none Review URL: http://codereview.chromium.org/8108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3820 0039d316-1c4b-4281-b951-d872f2087c98
* Adds models needed by the bookmark manager. Specifically asky@google.com2008-10-231-1/+2
| | | | | | | | | | | | | BookmarkTableModel, which will be used to show one of the following: the children of a folder, recently bookmarked or the results of a search. And the tree model implementation that shows the folders. BUG=674 TEST=covered by unit tests Review URL: http://codereview.chromium.org/8063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3814 0039d316-1c4b-4281-b951-d872f2087c98
* try to fix dist crashesben@chromium.org2008-10-221-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3755 0039d316-1c4b-4281-b951-d872f2087c98
* Using $CHROME_SRC_DIR in place of hash/..bradnelson@google.com2008-10-221-1/+1
| | | | | | | | This will facilitate changing where the main sconstruct lives. Review URL: http://codereview.chromium.org/7847 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3725 0039d316-1c4b-4281-b951-d872f2087c98
* forgot these filesben@chromium.org2008-10-222-30/+93
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3723 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the bug with the minimize/restore buttons getting stuck hot when the ↵ben@chromium.org2008-10-222-6/+14
| | | | | | | | | | | window is restored. Turns out the messages we receive prior to becoming restored/minimized etc are not sufficient to restore the button to its appropriate state. Since this is specific to the implementation of these controls, I have provided a solution specific to them. http://crbug.com/3559 Review URL: http://codereview.chromium.org/7803 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3721 0039d316-1c4b-4281-b951-d872f2087c98
* try rolling this back to see if it helpsben@chromium.org2008-10-212-85/+30
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3645 0039d316-1c4b-4281-b951-d872f2087c98
* More Windows-is-a-crack-baby mitigation.beng@google.com2008-10-202-30/+85
| | | | | | | | | | | | | | | | | I think I've finally fixed this. Knock on wood. Turns out that these two additional places do non-client rendering: - DefWindowProc for WM_NCLBUTTONDOWN - the function EnableMenuItem (called from CustomFrameWindow::OnInitMenu) For the first case, we also need to unlock updating when we begin to receive mouse move events during modal size/move loops, otherwise the feedback won't be visually continuous. http://crbug.com/3264 Review URL: http://codereview.chromium.org/7662 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3620 0039d316-1c4b-4281-b951-d872f2087c98
* Allow middle click on the only tab with one window open.ben@chromium.org2008-10-174-10/+53
| | | | | | | http://crbug.com/3466 Review URL: http://codereview.chromium.org/7506 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3580 0039d316-1c4b-4281-b951-d872f2087c98
* Support shortcut show styles for "run maximized", "run minimized" etc.ben@chromium.org2008-10-172-2/+7
| | | | | | | http://crbug.com/3278 Review URL: http://codereview.chromium.org/7504 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3579 0039d316-1c4b-4281-b951-d872f2087c98
* more bustage fixesben@chromium.org2008-10-171-4/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3557 0039d316-1c4b-4281-b951-d872f2087c98
* fix release bustage :-(ben@chromium.org2008-10-171-1/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3555 0039d316-1c4b-4281-b951-d872f2087c98
* attempt at fixing release bustageben@chromium.org2008-10-171-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3554 0039d316-1c4b-4281-b951-d872f2087c98
* Convert SchedulePaint and a few other methods to use gfx types.ben@chromium.org2008-10-1710-82/+61
| | | | | | | http://crbug.com/2186 Review URL: http://codereview.chromium.org/7468 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3550 0039d316-1c4b-4281-b951-d872f2087c98
* testing something elseben@chromium.org2008-10-171-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3544 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the anti-carpet bombing dialog. More specifically a newsky@google.com2008-10-171-2/+3
| | | | | | | | | | | | | | | | | EventHandler now exists between the buffered event handler and download event handler. This new event handler asks the DownloadRequestManager whether the download is allowed. This may prompt the user and then the download continues or is canceled. The DownloadRequestManager receives the request on the IO thread, forwards to the UI thread, makes the decision, then notifies back on the IO thread. BUG=3422 TEST=make sure you don't see any problems downloading content. Review URL: http://codereview.chromium.org/7479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3543 0039d316-1c4b-4281-b951-d872f2087c98
* Removes an unneeded override.sky@google.com2008-10-172-7/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7398 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3526 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeViews namespace to viewsben@chromium.org2008-10-16123-513/+509
| | | | | | http://crbug.com/2188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3495 0039d316-1c4b-4281-b951-d872f2087c98
* Fix weird NC painting in classic mode by removing an apparently unnecessary ↵ben@chromium.org2008-10-161-4/+1
| | | | | | | | | window style. http://crbug.com/3264 Review URL: http://codereview.chromium.org/7442 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3494 0039d316-1c4b-4281-b951-d872f2087c98
* fix unittestben@chromium.org2008-10-161-2/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3475 0039d316-1c4b-4281-b951-d872f2087c98
* Make View::SetBounds take a const gfx::Rect& instead of a const CRect&ben@chromium.org2008-10-1632-278/+170
| | | | | | | | | | Make View::DidChangeBounds call Layout by default, eliminating this function from most places. http://crbug.com/2186 Review URL: http://codereview.chromium.org/7429 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3471 0039d316-1c4b-4281-b951-d872f2087c98
* revert the testbeng@google.com2008-10-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3454 0039d316-1c4b-4281-b951-d872f2087c98
* a quick testbeng@google.com2008-10-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3451 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ViewContainer to Container and HWNDViewContainer to ContainerWin.ben@chromium.org2008-10-1641-359/+344
| | | | | | | http://crbug.com/3430 Review URL: http://codereview.chromium.org/7376 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3441 0039d316-1c4b-4281-b951-d872f2087c98
* Convert GetPreferredSize from:beng@google.com2008-10-1552-466/+434
| | | | | | | | | | | | | | | | | void GetPreferredSize(CSize* out); to: gfx::Size GetPreferredSize(); .. and update some other places to use gfx::Size as well. http://crbug.com/2186 Review URL: http://codereview.chromium.org/7344 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3400 0039d316-1c4b-4281-b951-d872f2087c98
* Label::SizeToFit was not setting the width properly.jcampan@chromium.org2008-10-151-1/+1
| | | | | | | | BUG=3432 TEST=See bug. Review URL: http://codereview.chromium.org/7337 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3390 0039d316-1c4b-4281-b951-d872f2087c98
* Convert HitTest/GetViewForPoint to use gfx::Pointben@chromium.org2008-10-1412-40/+44
| | | | | | | http://crbug.com/2186 Review URL: http://codereview.chromium.org/7331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3384 0039d316-1c4b-4281-b951-d872f2087c98
* Actually handle WM_SETICON and provide a virtual base that CustomFrameWindow ↵ben@chromium.org2008-10-141-0/+5
| | | | | | | | can override... Review URL: http://codereview.chromium.org/7321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3383 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some places I missed the renaming changes.brettw@google.com2008-10-141-1/+1
| | | | | | Review URL: http://codereview.chromium.org/7332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3382 0039d316-1c4b-4281-b951-d872f2087c98
* Change all ConvertPointTo* methods to use gfx::Point instead of CPoint.ben@chromium.org2008-10-1417-167/+148
| | | | | | | | http://crbug.com/2186 Review URL: http://codereview.chromium.org/7317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3365 0039d316-1c4b-4281-b951-d872f2087c98
* Replace View::GetBounds(CRect* bounds) const; with gfx::Rect bounds() const. ben@chromium.org2008-10-1412-130/+103
| | | | | | | | http://crbug.com/2186 Review URL: http://codereview.chromium.org/7136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3348 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issues with mouseleave messages not getting sent due to some sort of ↵ben@chromium.org2008-10-132-4/+5
| | | | | | | | | | issue with the message cracking macros in hwnd_view_container.h http://crbug.com/3375 Review URL: http://codereview.chromium.org/7126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3326 0039d316-1c4b-4281-b951-d872f2087c98
* Use system title bar font for app windows, detached popups, constrained popups.ben@chromium.org2008-10-131-2/+10
| | | | | | | | http://crbug.com/3376 Review URL: http://codereview.chromium.org/7274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3307 0039d316-1c4b-4281-b951-d872f2087c98
* Assorted improvements to window maximization and flicker on Windows Vista ↵ben@chromium.org2008-10-132-8/+95
| | | | | | | | | with aero-glass disabled. http://crbug.com/2488 Review URL: http://codereview.chromium.org/7262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3292 0039d316-1c4b-4281-b951-d872f2087c98
* Fix RTL issues with opaque frame. ben@chromium.org2008-10-102-1/+2
| | | | | | | | http://crbug.com/3247 Review URL: http://codereview.chromium.org/7240 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3256 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds prompting for dangerous types of files (executable) when they ↵jcampan@chromium.org2008-10-102-10/+23
| | | | | | | | | | | | | | | | are automatically downloaded. The file is saved with a temporary name (dangerous_download_xxxx.download) in the download directory and the user is presented (in the download shelf and the download tab if opened) with a warning message and buttons to save/discard the download. If discarded the download is removed (and its file deleted). If saved, download goes as usual. Dangerous downloads not confirmed by the user are deleted on shutdown. TEST=Download a small exe file, try using the save/discard button from the download shelf and from the download tab (the intent is that the file has been entirely downloaded by the time you take action). Try again with a slow/big download (that time the download is expected not to be finished when approved/discarded). Review URL: http://codereview.chromium.org/6043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3228 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 04:58:48 +0000