summaryrefslogtreecommitdiffstats
path: root/chrome/views
Commit message (Collapse)AuthorAgeFilesLines
* This change should have few user-visible effects. I think I slightly ↵pkasting@chromium.org2009-01-263-27/+25
| | | | | | | | | | | | | | | | | | | modified the window layout (by a pixel or so) in the popup window case, which I haven't tried to make pixel-perfect yet anyway. Otherwise it's all reorg. Clean up logic of nonclient view to be more consistent and coherent. Most things are now based on a small set of core functions that return various frame/nonclient thicknesses. This allows a noticeable reduction in the number of hardcoded constants, makes the code make more sense (even though a few places are longer than before), and makes it much easier to do things in the future like resizing various borders or handling system metrics better. Rename and update comments for all constants to be more descriptive and less redundant. Rename helper functions and variables for consistency, now that they've changed. Remove an unused variant of TileImageInt(). Add a new one that takes an offset into the source image. This is used to rewrite the maximized bottom border tiling call in a way that doesn't rely on someone else clipping out or painting over the overdraw from tiling "too large" a source image. Probably no visible effect. Make resize border hittest helper function able to handle borders of varying widths, and try to make parameter names more meaningful. Technically, we don't need the extra flexibility, since our bottom and side borders are the same thickness, but since there are different functions calculating that thickness on the caller side, it didn't hurt to not rely on that for the future. BUG=5054 Review URL: http://codereview.chromium.org/18804 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8658 0039d316-1c4b-4281-b951-d872f2087c98
* Some cleanups I've had sitting around for a while that are getting in my way ↵pkasting@chromium.org2009-01-261-139/+93
| | | | | | | | | now. Fixes some >80-column lines, simplifies LayoutWindowControls() and makes it more similar to the version in OpaqueNonClientView (with the goal of eventually merging these), etc. Review URL: http://codereview.chromium.org/18579 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8638 0039d316-1c4b-4281-b951-d872f2087c98
* Two of the three places that set a window mask had it wrong. Fix it.pkasting@chromium.org2009-01-261-1/+4
| | | | | | Review URL: http://codereview.chromium.org/18580 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8637 0039d316-1c4b-4281-b951-d872f2087c98
* Fix warning which breaks compile with gcc 4.3.xmaruel@chromium.org2009-01-261-2/+2
| | | | | | | | | since warnings are treated as errors. Patch contributed by Craig Schlenter <craig.schlenter@gmail.com> git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8635 0039d316-1c4b-4281-b951-d872f2087c98
* Small porting in chrome/phajdan.jr@chromium.org2009-01-262-2/+12
| | | | | | | | | This is actually http://codereview.chromium.org/18446 without process_watcher changes. Review URL: http://codereview.chromium.org/18724 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8622 0039d316-1c4b-4281-b951-d872f2087c98
* Create a dialog box for the about:network view and kill the tab type.brettw@chromium.org2009-01-242-1/+18
| | | | | | | | | This adds an AppendText method to the text field view. The job tracker stuff is just copied from the old network status file. Review URL: http://codereview.chromium.org/18728 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8604 0039d316-1c4b-4281-b951-d872f2087c98
* ===================================================xji@chromium.org2009-01-233-1/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change list fixes the following 2 chrome bugs: 2821 RTL: Ellipsis appeared at right for RTL locales on "Task Manager - Google Chrome" dialog (http://crbug.com/2821) 6132: Strings in tables are displayed LTR when they should be RTL (http://crbug.com/6132) =================================================== Background: The above 2 bugs are related to Chrome task manager. Task manager is a TableView, which is a subclass of NativeControl. Currently, TableView window is created by using WS_EX_LAYOUTRTL | WS_EX_RTLREADING flag, which is wrong. WS_EX_LAYOUTRTL | WS_EX_RTLREADING renders a RTL alignment but LTR reading order. Please see the following blog for detail: http://blogs.msdn.com/michkap/archive/2007/03/11/1857043.aspx We need to replace the above flag with WS_EX_LAYOUTRTL only. Consequently, we need to make sure that the various implementations of TableModel::GetText adjust the returned text appropriately if need be. For example, if the text in an URL, then the returned text should be explicitly marked as LTR text. Please note: there are several other places where we create RTL window using WS_EX_LAYOUTRTL | WS_EX_RTLREADING flag, such as AutoCompleteEditView (omnibox), MenuHostWindow, TextField (for example, text in bookmark dialog), and other NativeControl (including checkbox, combobox, native_button, radio_button, separator, tabbed_pane, and tree view). They all need to be fixed. And the following bug is filed for tracking. http://crbug.com/6573 =================================================== The fix is based on Idan's comments on bug 6132 1.create the table view with WS_EX_LAYOUTRTL (rather than WS_EX_LAYOUTRTL | WS_EX_RTLREADING) 2 Make sure that the various implementations of TableModel::GetText adjust the returned text appropriately if need be. If the text in an URL, then the returned text is explicitly marked as LTR text. Otherwise, the returned text is marked with LTR if it is RTL environment and there is no strong RTL character in the text. This is to avoid the wrong placement of (or wrong mirrored) ending-punctuation. =================================================== Since we have quite a few places creating window using WS_EX_LAYOUTRTL | WS_EX_RTLREADING style. We decided to migrate to the right style step to step. This is the first step, and there is unnecessary function introduced by this change list. 1. I am using l10n_util::GetExtendedTooltipStyles() for the right style for now. And I marked a TODO there to obsolete this function name, replace with GetExtendedStyles eventually. (the l10n_util.h is no longer in the change list since I've checked it in with another CL). 2. I introduced native_control::GetAdditionalRTLStyle() which should replace GetAdditionalExStyle() eventually. =================================================== When wrapping text with LTR format in GetText(), ideally, we should parse the text to check whether this is a n URL or not (for example, a webpage title could be an URL, or user could add URL as search engine's name or keyword). I did not do that and only added a TODO there because I think that might be rare case and parsing the text might cause performance degradation. Review URL: http://codereview.chromium.org/18076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8593 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r8560 due to broken interactive_ui_testsmark@chromium.org2009-01-232-12/+2
| | | | | | Review URL: http://codereview.chromium.org/18722 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8570 0039d316-1c4b-4281-b951-d872f2087c98
* Porting in chrome/phajdan.jr@chromium.org2009-01-232-2/+12
| | | | | | Review URL: http://codereview.chromium.org/18446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8560 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage.brettw@chromium.org2009-01-221-1/+1
| | | | | | Review URL: http://codereview.chromium.org/18513 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8480 0039d316-1c4b-4281-b951-d872f2087c98
* use a registrar to safely remove observertc@google.com2009-01-212-6/+5
| | | | | | | | TBR=evan Review URL: http://codereview.chromium.org/18442 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8359 0039d316-1c4b-4281-b951-d872f2087c98
* Fix BrowserTest.WindowsSessionEnd by moving a virtual calltc@google.com2009-01-211-4/+5
| | | | | | | | | | | | | from the constructor to the Init() function(). The virtual call in the constructor of the base class doesn't get dispatched to the child class since we haven't started to construct it yet. Instead, defer the call until after we've finished creating the object. Review URL: http://codereview.chromium.org/18601 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8354 0039d316-1c4b-4281-b951-d872f2087c98
* Make CommandLine into a normal object, with some statics for getting at the ↵evan@chromium.org2009-01-211-1/+1
| | | | | | | | | | | current process's command line. One explicit goal of this change is to *not* deal with the string/wstring issues at the API on POSIX; the functions are the same as before, which means they remain as broken as before. (I did try to fix the internals, though, so migrating the callers is now possible by adding platform-appropriate hooks.) Review URL: http://codereview.chromium.org/18248 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8347 0039d316-1c4b-4281-b951-d872f2087c98
* Rework the command updater to not be dependent on views::Button (needed for ↵ben@chromium.org2009-01-202-10/+2
| | | | | | | | | porting). TEST=make sure back/forward buttons still enable/disable correctly depending on the length of the back/forward navigation list. Review URL: http://codereview.chromium.org/18343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8332 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the broken commit in r8250. The problem was that basictypes.herg@google.com2009-01-2013-172/+389
| | | | | | | | | wasn't getting included before a defined(OS_WIN) check. Review URL: http://codereview.chromium.org/18414 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8308 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "revert r8217 until memory tests are fixed." This re-applies r8217.tc@google.com2009-01-202-5/+34
| | | | | | | | | | | This reverts commit r8245. TBR=ben Review URL: http://codereview.chromium.org/18410 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8292 0039d316-1c4b-4281-b951-d872f2087c98
* Generate all chrome .vcproj files:sgk@google.com2009-01-171-19/+145
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Path name translation (/ to \) of various MSVSTool attributes. * Explicit keyword= arguments to MSVSProject. This will likely go away eventually in favor of uniform behavior. * Add a relative_path_substitutions array that can be used to substitute in Visual Studio variable like $(OutDir). * Add a local_directory_prefix that can be set to './' to only affect files in the current directory. * Additional Keyword ordering in Tool attributes to continue to match the default order Visual Studio generates. * Add a Derived() proxy class that can wrap a File node to tell the .vcproj generation that we want the derived file, not its source(s), in the file list. * In the individual *.scons files, add the necessary files (mostly .h files) to file lists, and update MSVSProject() calls with the additional necessary information. Result is identical .vcproj files modulo the following differences: * Four locales .vcproj files (da, en-US, he and zh-TW) with source file orders that don't match the other locale .vcproj files have re-ordered file lists to match the rest. * Cosmetic XML changes (white space, ending tags) in: chrome/app/chrome_dll.vcproj chrome/app/generated_resources.vcproj net/build/net_resources.vcproj * Removal or addition of ./ prefixes from various files that don't match the other file specifications within their individual .vcproj files: chrome/installer/util/util.vcproj net/build/net.vcproj net/build/net_unittests.vcproj * Add missing empty sections (<ToolFiles>, <References>, <Globals>) for consistency with other .vcproj files: chrome/tools/test/image_diff/image_diff.vcproj third_party/libpng/libpng.vcproj third_party/zlib/zlib.vcproj * Add missing RootNameSpace attribute: chrome/test/automation/automation.vcproj testing/gtest.vcproj * Use && instead of \r\n as a command separator, to sidestep XML-generation problems: chrome/app/chrome_exe.vcproj * Remove unnecessary (?) duplicate files in the file list: chrome/browser/views/browser_views.vcproj (event_utils.cc and event_utils.h were duplicated) Review URL: http://codereview.chromium.org/17603 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8253 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add #ifdefs to the views/ code and move windows specific codeerg@google.com2009-01-1713-387/+171
| | | | | | | | | | into their own files to get some files compiling." Conflicts with something that went in in the interim... Review URL: http://codereview.chromium.org/18187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8251 0039d316-1c4b-4281-b951-d872f2087c98
* Add #ifdefs to the views/ code and move windows specific code into their own ↵erg@google.com2009-01-1713-171/+387
| | | | | | | | | files to get some files compiling. Review URL: http://codereview.chromium.org/18136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8250 0039d316-1c4b-4281-b951-d872f2087c98
* revert r8217 until memory tests are fixed.ben@chromium.org2009-01-172-34/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8245 0039d316-1c4b-4281-b951-d872f2087c98
* window.cc should not include browser_list.h ... dependent (non-browser) ↵ben@chromium.org2009-01-162-5/+34
| | | | | | | | | | windows are closed when they receive a notification rather than by being called directly from BrowserList. Also browser_list.cc should not include window.h, required for porting. TEST=Open browser. Open options dialog box. Close browser. Options dialog should close too. Review URL: http://codereview.chromium.org/18328 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8217 0039d316-1c4b-4281-b951-d872f2087c98
* Fix maximized mode drawing offscreen in Classic mode. Apparently Classic, ↵pkasting@chromium.org2009-01-151-7/+14
| | | | | | | | | | | unlike Luna, does not auto-clip maximized windows with an explicitly-set HRGN of NULL, so we have to set one. BUG=5054 TEST=On a desktop extended across multiple monitors, switch to Classic mode, open a Chrome window, and maximize it on one monitor. Make sure it doesn't draw any pixels on the other monitor. Review URL: http://codereview.chromium.org/18258 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8062 0039d316-1c4b-4281-b951-d872f2087c98
* Constify the params of a couple View functions, which I'll need for an ↵pkasting@chromium.org2009-01-152-10/+20
| | | | | | | | | upcoming change to be able to call these from someone else's const member function. Also fixes a couple cases of wrong parameter wrapping/"*" binding. Review URL: http://codereview.chromium.org/18251 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8057 0039d316-1c4b-4281-b951-d872f2087c98
* Provides the infrastructure for Browser unit tests that create asky@google.com2009-01-141-1/+4
| | | | | | | | | | | | | BrowserWindow with only a TabStrip. I also converted two ui tests over to unit tests to make sure it all worked. I had to add a bunch of null checks to Browser and a couple of other places. BUG=none TEST=none Review URL: http://codereview.chromium.org/17386 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8007 0039d316-1c4b-4281-b951-d872f2087c98
* Porting in views/phajdan.jr@chromium.org2009-01-137-23/+165
| | | | | | | | | | This actually manages to compile few files on Linux. Porting some other files from views/ would be more difficult, but this view.h change unblocks porting opportunities in other areas. Review URL: http://codereview.chromium.org/17352 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7921 0039d316-1c4b-4281-b951-d872f2087c98
* Removes a bogus DCHECK. This DCHECK is bogus for two reasons:sky@google.com2009-01-081-1/+2
| | | | | | | | | | | | | | | | | | | . it's checking a field that hasn't been set yet, hence the sporadic failure. . It shouldn't check delegate either as inside this class it's possible to supply NULL. I've removed it entirely and added a comment. BUG=5914 TEST=right click on the tab strip and make sure you don't get a DCHECK. Because this relies on random data, it's too hard to write a test for this, additionally I'm sure once we run the interactive ui tests under Purify this'll be covered. Review URL: http://codereview.chromium.org/17439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7777 0039d316-1c4b-4281-b951-d872f2087c98
* Some more GRIT refactoring.tc@google.com2009-01-051-1/+1
| | | | | | | | | | | | | | | | | | Moved the grit .vsprops file from chrome/tools/build/win/ to /tools/grit/build and renamed to using_generated_resources.vsprops. Updated non-chrome projects to use the this new vsprops file. Created a new .rules file and renamed the old one. Now there are grit_resources.rules and grit_localized_resources.rules. The latter is what we use now, but I'll be adding some grd files that use the former in a follow up change. This is just vsprops reshuffling for now. I'll also add a using_generated_resources.scons in a follow up change. Review URL: http://codereview.chromium.org/14901 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7560 0039d316-1c4b-4281-b951-d872f2087c98
* Mass convert ChromeStaticLibrary -> ChromeLibrary, including pulling the ↵evanm@google.com2008-12-261-1/+1
| | | | | | | | | | | updated ICU dep that uses it as well. Add a SHARED scons command-line flag to build shared libraries. Review URL: http://codereview.chromium.org/16477 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7479 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 4830: We navigate back after closing the Save As dialog.finnur@google.com2008-12-231-2/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | If you use Alt-Shift-T and the arrow keys to go to the Page menu and then launch the Save Page As dialog, we would navigate back after saving the page. This is because once we close the Save As dialog with Enter, focus goes to the Back button (which arguable is also wrong, see issue 5750) and it receives a KeyRelease(Enter), which causes us to navigate back right after saving the page. In Windows, pressing Enter while a button has focus clicks the button on KeyPressed, whereas we currently click the button on KeyRelease. This patch makes Chrome mimic native Windows behavior. We retain the current behavior for Space, however, which clicks on KeyReleased in both Chrome and Windows. BUG=4830 TEST=Native Chrome buttons should click buttons on KeyPress when using Enter and on KeyRelease when using Space. Review URL: http://codereview.chromium.org/16202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7406 0039d316-1c4b-4281-b951-d872f2087c98
* Initial generation of native Visual Studio solution filessgk@google.com2008-12-191-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (project files still to come). To wit: * Solution file configuration is in *_sln.scons files (base\base_sln.scons, chrome\chrome_sln.scons). * Individual Project file configuration is in the the .scons file for the relevant target (base\base_unittests.scons, third_party\libxml\libxml.scons, etc.)--that is, where their file lists will live. * MSVSProject() calls are currently placeholders that establish the existence of Project Nodes (and Project dependencies) but don't yet have actual Project configuration information (file lists, .vsprops, etc.). * Configuraiton is very manual. In particular, the entries in the .sln file will be written out in exactly the order specified in the configuration(s). The current ordering is taken from our existing .sln files, so we can generate virtually the same configurations on output. * Generated solution files are nearly byte-for-byte identical with our existing .sln files, modulo: * net\dump_cache has a WebsiteProperties sections (making that configurable per project isn't important right now); * sandbox\sandbox.sln was missing a dependency of base.vcproj on on debug_message.vcproj (present in other .sln files) * webkit\webkit.sln was missing dependencies of WebCore.vcproj on libxml_config.vcproj and libxslt_config.vcproj (present in chrome.sln); * add a handful of other miscellaneous missing dependencies on various .vcproj definitions in chrome.sln (present in other .sln files). * remove stats_viewer.csproj from chrome.sln (sorry, mbelshe), which was complicating the solution configuration with unnecessary (for us) "Mixed Platform" types; * All MSVSFolder(), MSVSProject() and MSVSSolution() calls have hard-wired guid= values taken from our existing configuration, so we can: 1) verify generation of working configs; 2) minimize diffs when checking in generated .sln files. We can remove these in the future in favor of extracting them from existing .sln files if we wish. * Add ChromeMSVSFolder(), ChromeMSVSProject() and ChromeMSVSSolution() wrappers to chromium_builders.py, that gate the underlying call to the env.MSVS*() builders based on whether env.Bit('msvs') is set (i.e., we're in --mode=msvs). * Remove platform-specific gating of to-be-ported .scons files that we now need to load on any platform to generate coheren MSVS files. Move the env.Bit('windows') tests for actually building their executables into the individual .scons files. Review URL: http://codereview.chromium.org/14472 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7297 0039d316-1c4b-4281-b951-d872f2087c98
* Select the Languages tab of the fonts and languages dialog when using ↵pkasting@chromium.org2008-12-192-2/+19
| | | | | | | | spellcheck context menu commands to change spellchecking options. Patch by Mohamed Mansour, r=me,sky; see http://codereview.chromium.org/15031. Tweaked by me. BUG=5639 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7289 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the Home button to the MSAA focus order, if enabled. Also removes an ↵klink@chromium.org2008-12-181-5/+0
| | | | | | | | unnecessary check from ViewAccessibility. Review URL: http://codereview.chromium.org/15026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7239 0039d316-1c4b-4281-b951-d872f2087c98
* Changes menu's Dispatcher to translate/dispatch message beforesky@google.com2008-12-171-1/+6
| | | | | | | | | | | | | returning false. This way we don't screw up the message pump. I also needed to slightly tweak the bookmark bar test that was hitting this code path. BUG=none TEST=none Review URL: http://codereview.chromium.org/15008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7177 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two bugs resulting in bad window resize behavior:sky@google.com2008-12-171-5/+8
| | | | | | | | | | | | | | | | | . Dragging a tab out was forcing the bounds to fit on the monitor. This was a regression introduced during some refactoring. The fix is not to call Window::SetBounds, but instead SetWindowPos (which is roughly what the old code did). . When the bounds of the window change always layout. We need this for the situation where the normal bounds and maximized bounds are the same because we layout differently in the two. BUG=5540 5118 TEST=see description in 5118 Review URL: http://codereview.chromium.org/14511 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7169 0039d316-1c4b-4281-b951-d872f2087c98
* Replace some CRects with gfx::Rectagl@chromium.org2008-12-177-31/+28
| | | | | | | Review URL: http://codereview.chromium.org/14173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7126 0039d316-1c4b-4281-b951-d872f2087c98
* Switch back svn:eol-style=native for .sln, .vcproj and .vsprops files.maruel@chromium.org2008-12-161-655/+655
| | | | | | | Patch fails otherwise on non-Windows platforms. Review URL: http://codereview.chromium.org/14478 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7093 0039d316-1c4b-4281-b951-d872f2087c98
* Landing http://codereview.chromium.org/14450 for m0 (Mohamed Mansour).sky@google.com2008-12-162-14/+15
| | | | | | | | BUG=2186 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7076 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes issue 4376: Press "Tab" key to navigate - Text focus is ↵xji@chromium.org2008-12-161-2/+4
| | | | | | | | | | | | | | | | | | | showing at wrong place in Hebrew and Arabic. when drawing focus rectangle for CheckBox,the left point of the rectangle should be mirrored for RTL text. http://crbug.com/4376 TEST: 1. Launch RTL Chome (for ex: set language as Hebrew). 2. Go to > Customize and Control Google Chrome > Options > Under the Hood or any other Tab 3. Press tab key to navigate thought text options 4. The focus is properly set on the text. (without this fix, the focus is not properly set on the text). Review URL: http://codereview.chromium.org/14452 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7067 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes info bubble painting bug. This was happening because we weresky@google.com2008-12-162-8/+41
| | | | | | | | | | | | | | | | | using layered windows incorrectly. According to the docs if you invoke SetLayeredWindowAttributes, then you shouldn't invoke UpdateLayeredWindow (unless you remove then add the WS_EX_LAYERED style bit). My approach here is to disable the backing buffer for the info bubble. I had problems toggling the WS_EX_LAYERED at the end up the animation. The text field would not paint when I did this... BUG=5351 TEST=bookmark a page. When the bubble appears press shift-tab and make sure you see a focus rect around the remove link. Review URL: http://codereview.chromium.org/14131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7063 0039d316-1c4b-4281-b951-d872f2087c98
* Rip out custom WM_GETMINMAXINFO handling entirely. I think this is a relic ↵pkasting@chromium.org2008-12-163-39/+0
| | | | | | | | | | | of the old Halo Frame. Trying to rip it out halfway results in problems, like the taskbar not un-auto-hiding when Chromium is maximized. This should result in correct handling of maximized windows on multiple monitors with different resolutions, taskbar positions, and auto-hide settings (since we're just using the native Windows code to do everything). BUG=943445 Review URL: http://codereview.chromium.org/14446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7021 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminates the dependencies between views and browser, and also does some ↵klink@chromium.org2008-12-166-443/+29
| | | | | | | | | | | other minor cleanups. The special casing for the OmniBox that used to live in the ViewAccessibility code could be removed due to the fact that the only assistive technologies depending on this case are now testing tools. The end-user tools will see no difference, and the testing tools can access the OmniBox IAccessible by directly giving it keyboard/mouse focus. BUG=2237 Review URL: http://codereview.chromium.org/14036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7020 0039d316-1c4b-4281-b951-d872f2087c98
* A new shot at the old system monitor changelist.mbelshe@google.com2008-12-131-0/+4
| | | | | | Review URL: http://codereview.chromium.org/12883 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6974 0039d316-1c4b-4281-b951-d872f2087c98
* Move skia_utils into the skia namespace.brettw@google.com2008-12-124-6/+6
| | | | | | Review URL: http://codereview.chromium.org/14079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6948 0039d316-1c4b-4281-b951-d872f2087c98
* Have GRIT generate files into a common directory.tc@google.com2008-12-121-1/+1
| | | | | | | | | | | | | | | Joi has convinced me that GRIT should generate platform specific resources files. This is easier than parsing .rc files because GRIT effectively has an .rc parser. To that end, we need to convert some existing .rc files to .grd files (e.g., net_resources.rc and webkit_resources.rc). Rather than having every grd file output to a different place and -I all the different paths, have GRIT generate all files into one directory. This directory is grit_derived_sources. Review URL: http://codereview.chromium.org/13776 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6940 0039d316-1c4b-4281-b951-d872f2087c98
* Move Image operations and convolver to the skia namespace and clean up a few ↵brettw@google.com2008-12-121-1/+1
| | | | | | | | (but not all) base types. Review URL: http://codereview.chromium.org/13726 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6921 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing reliability crash spike. The traces lead me tosky@google.com2008-12-111-1/+5
| | | | | | | | | | | | | | | | | | believe RichEdit is sending a WM_COMMAND with an id of 35000, which corresponds to IDC_STAR. Peter's changing of IDs resulted in IDC_STAR getting set to 35000. I'm hoping the WM_COMMAND sent from the rich edit has it's high bits set appropriately so that this change will result in not trying to execute IDC_STAR when we get the command. WARNING: this is all speculation from looking at the traces. I couldn't repro on my machine. BUG=5405 TEST=none Review URL: http://codereview.chromium.org/14010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6823 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a handful of related bookmark manager bugs/requests:sky@google.com2008-12-112-2/+6
| | | | | | | | | | | | | | | . Adds a search field before the text field. . When the search node is selected and there are no results or no search text, a descriptive label is drawn on top of the table telling the user what's happening. . In the bookmark menus Edit... is now Rename... for folders. BUG=5272 5319 5273 4165 TEST=see individual bugs Review URL: http://codereview.chromium.org/13724 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6777 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where context menu for table/tree in rtl was showing up onsky@google.com2008-12-102-0/+4
| | | | | | | | | | | the wrong side. BUG=5067 TEST=see bug Review URL: http://codereview.chromium.org/13353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6734 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 6709,6708,6706.brettw@google.com2008-12-101-1/+1
| | | | | | Review URL: http://codereview.chromium.org/13345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6710 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base dependency from image_operations and associated unittests. I ↵brettw@google.com2008-12-101-1/+1
| | | | | | | | | also renamed the namespace from "gfx" to "skia". This also adds back the image_operations_unittest to a project (this had gotten lost in my move). Review URL: http://codereview.chromium.org/13143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6706 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 19:09:14 +0000