summaryrefslogtreecommitdiffstats
path: root/chrome/views
Commit message (Collapse)AuthorAgeFilesLines
* fix unittestben@chromium.org2008-10-161-2/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3475 0039d316-1c4b-4281-b951-d872f2087c98
* Make View::SetBounds take a const gfx::Rect& instead of a const CRect&ben@chromium.org2008-10-1632-278/+170
| | | | | | | | | | Make View::DidChangeBounds call Layout by default, eliminating this function from most places. http://crbug.com/2186 Review URL: http://codereview.chromium.org/7429 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3471 0039d316-1c4b-4281-b951-d872f2087c98
* revert the testbeng@google.com2008-10-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3454 0039d316-1c4b-4281-b951-d872f2087c98
* a quick testbeng@google.com2008-10-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3451 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ViewContainer to Container and HWNDViewContainer to ContainerWin.ben@chromium.org2008-10-1641-359/+344
| | | | | | | http://crbug.com/3430 Review URL: http://codereview.chromium.org/7376 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3441 0039d316-1c4b-4281-b951-d872f2087c98
* Convert GetPreferredSize from:beng@google.com2008-10-1552-466/+434
| | | | | | | | | | | | | | | | | void GetPreferredSize(CSize* out); to: gfx::Size GetPreferredSize(); .. and update some other places to use gfx::Size as well. http://crbug.com/2186 Review URL: http://codereview.chromium.org/7344 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3400 0039d316-1c4b-4281-b951-d872f2087c98
* Label::SizeToFit was not setting the width properly.jcampan@chromium.org2008-10-151-1/+1
| | | | | | | | BUG=3432 TEST=See bug. Review URL: http://codereview.chromium.org/7337 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3390 0039d316-1c4b-4281-b951-d872f2087c98
* Convert HitTest/GetViewForPoint to use gfx::Pointben@chromium.org2008-10-1412-40/+44
| | | | | | | http://crbug.com/2186 Review URL: http://codereview.chromium.org/7331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3384 0039d316-1c4b-4281-b951-d872f2087c98
* Actually handle WM_SETICON and provide a virtual base that CustomFrameWindow ↵ben@chromium.org2008-10-141-0/+5
| | | | | | | | can override... Review URL: http://codereview.chromium.org/7321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3383 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some places I missed the renaming changes.brettw@google.com2008-10-141-1/+1
| | | | | | Review URL: http://codereview.chromium.org/7332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3382 0039d316-1c4b-4281-b951-d872f2087c98
* Change all ConvertPointTo* methods to use gfx::Point instead of CPoint.ben@chromium.org2008-10-1417-167/+148
| | | | | | | | http://crbug.com/2186 Review URL: http://codereview.chromium.org/7317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3365 0039d316-1c4b-4281-b951-d872f2087c98
* Replace View::GetBounds(CRect* bounds) const; with gfx::Rect bounds() const. ben@chromium.org2008-10-1412-130/+103
| | | | | | | | http://crbug.com/2186 Review URL: http://codereview.chromium.org/7136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3348 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issues with mouseleave messages not getting sent due to some sort of ↵ben@chromium.org2008-10-132-4/+5
| | | | | | | | | | issue with the message cracking macros in hwnd_view_container.h http://crbug.com/3375 Review URL: http://codereview.chromium.org/7126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3326 0039d316-1c4b-4281-b951-d872f2087c98
* Use system title bar font for app windows, detached popups, constrained popups.ben@chromium.org2008-10-131-2/+10
| | | | | | | | http://crbug.com/3376 Review URL: http://codereview.chromium.org/7274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3307 0039d316-1c4b-4281-b951-d872f2087c98
* Assorted improvements to window maximization and flicker on Windows Vista ↵ben@chromium.org2008-10-132-8/+95
| | | | | | | | | with aero-glass disabled. http://crbug.com/2488 Review URL: http://codereview.chromium.org/7262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3292 0039d316-1c4b-4281-b951-d872f2087c98
* Fix RTL issues with opaque frame. ben@chromium.org2008-10-102-1/+2
| | | | | | | | http://crbug.com/3247 Review URL: http://codereview.chromium.org/7240 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3256 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds prompting for dangerous types of files (executable) when they ↵jcampan@chromium.org2008-10-102-10/+23
| | | | | | | | | | | | | | | | are automatically downloaded. The file is saved with a temporary name (dangerous_download_xxxx.download) in the download directory and the user is presented (in the download shelf and the download tab if opened) with a warning message and buttons to save/discard the download. If discarded the download is removed (and its file deleted). If saved, download goes as usual. Dangerous downloads not confirmed by the user are deleted on shutdown. TEST=Download a small exe file, try using the save/discard button from the download shelf and from the download tab (the intent is that the file has been entirely downloaded by the time you take action). Try again with a slow/big download (that time the download is expected not to be finished when approved/discarded). Review URL: http://codereview.chromium.org/6043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3228 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back trial from last nightben@chromium.org2008-10-103-22/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3217 0039d316-1c4b-4281-b951-d872f2087c98
* Another attempt at fixing non-client flicker. Let's see how well this works.ben@chromium.org2008-10-101-9/+9
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3169 0039d316-1c4b-4281-b951-d872f2087c98
* Put this file back into its original state when I first landed this change ↵ben@chromium.org2008-10-092-0/+11
| | | | | | | | | earlier today. http://crbug.com/3264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3154 0039d316-1c4b-4281-b951-d872f2087c98
* Put back WM_ENTERIDLE handler and remove WM_INITMENU and WM_INITMENUPOPUP ↵ben@chromium.org2008-10-092-11/+7
| | | | | | | | | | handlers. http://crbug.com/3264 Review URL: http://codereview.chromium.org/6605 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3143 0039d316-1c4b-4281-b951-d872f2087c98
* The window class now set the initial focus after the window is made visible. ↵jcampan@chromium.org2008-10-091-13/+2
| | | | | | | | | | The SetInitialFocus method needs to be changed to still work. BUG=2519 TEST=Open Chrome, the location bar has focus, type something the drop down menu shows. Press ESC, the drop down menu should go. Review URL: http://codereview.chromium.org/7030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3130 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back this section of the previous change to see if it is necessary.ben@chromium.org2008-10-092-7/+0
| | | | | | | http://crbug.com/3264 Review URL: http://codereview.chromium.org/6394 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3126 0039d316-1c4b-4281-b951-d872f2087c98
* Another attempt at fixing standard non-client area overpainting.ben@chromium.org2008-10-093-8/+20
| | | | | | | | http://crbug.com/3264 Review URL: http://codereview.chromium.org/7022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3115 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land this earlier change. Will deal with dist crashes as they arise.ben@chromium.org2008-10-091-0/+3
| | | | | | | | | | | | | | Make sure the frame is set to the foreground when: - opening from a shortcut when an existing frame is already open - pressing Ctrl+T from an app window http://crbug.com/2477 R=jcampan git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3103 0039d316-1c4b-4281-b951-d872f2087c98
* Fix weird painting of elements of the non-client area.ben@chromium.org2008-10-093-24/+54
| | | | | | | | http://crbug.com/3264 Review URL: http://codereview.chromium.org/7007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3100 0039d316-1c4b-4281-b951-d872f2087c98
* Move window_resources.h to chrome/views to remove bad dependency of ↵ben@chromium.org2008-10-083-1/+33
| | | | | | | | | | chrome/views on chrome/browser http://crbug.com/2395 Review URL: http://codereview.chromium.org/7002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3076 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the window icon is set to at least the app icon as the window is ↵ben@chromium.org2008-10-081-8/+5
| | | | | | | | | created, so it shows up in places like Alt+Tab, etc. http://crbug.com/3100 Review URL: http://codereview.chromium.org/6358 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3066 0039d316-1c4b-4281-b951-d872f2087c98
* Enables sorting of the tables in the password editor and the URLsky@google.com2008-10-082-11/+19
| | | | | | | | | | | | picker dialog. BUG=2949 TEST=Try sorting in the password manager dialog table as well as when adding a URL to the list of URLs to open on startup. Review URL: http://codereview.chromium.org/6053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3010 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate non-client flicker of the standard windows title bar when handling ↵beng@google.com2008-10-084-29/+79
| | | | | | | | | | | | WM_SETTEXT. Make sure mouse leave messages are sent for controls within the non-client areas of the window too. http://crbug.com/2689 http://crbug.com/2710 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2992 0039d316-1c4b-4281-b951-d872f2087c98
* Merge the chrome_webkit_merge_branch back on to trunk. This brings ustc@google.com2008-10-011-1/+2
| | | | | | | up to webkit@36102. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2778 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some issues found looking at the code.maruel@google.com2008-09-302-0/+4
| | | | | | | | | | Patch from Gaetano Mendola <mendola@gmail.com> Original review: http://codereview.chromium.org/4273 I added some additions on my part and two unit test fix due to the added DCHECK. Reduced atl header inclusion. Review URL: http://codereview.chromium.org/5009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2730 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 3011: Accessibility crash on teardown of HWNDViewContainerfinnur@google.com2008-09-301-0/+7
| | | | | | | | | | http://code.google.com/p/chromium/issues/detail?id=3011 Looks like we are trying to access the HWND of a window during teardown of the window. Review URL: http://codereview.chromium.org/6015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2723 0039d316-1c4b-4281-b951-d872f2087c98
* Catch up SCons Windows build with recent file shuffling and other changes:sgk@google.com2008-09-261-2/+0
| | | | | | | | | | | | | * New browser\download\ subdirectory. * New browser\importer\ subdirectory. * New browser\views\old_frames subdirectory. * Add common/notification_registrar.cc. * Remove title_chomper{,_unittest}.cc. * Link against sdch where empirically necessary. * No libevent.lib on Windows, comment out until Linux hits the .dll logic. Review URL: http://codereview.chromium.org/4310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2655 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability to sort TableView. Contrary to what we spoke aboutsky@google.com2008-09-266-152/+952
| | | | | | | | | | | | | | | | | | | | | | | the other day I ended up doing the sorting in tableview. This makes it a heck of lot easier than having every model have to deal with it. As part of this I removed the optional non-caching logic from TableView, which was never used. Sadly though, this means there are coordinate transformations. I've only enabled sorting in the keyword editor, I have to make sure all the other places that use TableView can deal with it. For example, task manager can't deal with it currently as it expects the getters to be called only once where as when sorting they may be called multiple times. BUG=2790 TEST=This enables sorting ONLY in the keyword editor. Make sure there aren't any problems in adding/removing/changing entries in the keyword editor after this. Review URL: http://codereview.chromium.org/4276 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2631 0039d316-1c4b-4281-b951-d872f2087c98
* I'm going to try and land this again. This is exactly the same change as you ↵sky@google.com2008-09-222-11/+29
| | | | | | | | | | | | | | | | reviewed earlier. Fixes mnemonic bug in chrome menus. After this change you can indicate whether menus have mnemonics. Mnemonics are shown if the menus have mnemonics, and the OS says we should show them. BUG=1355952 TEST=add a bookmark and change the title to &foo. Move the bookmark to a folder, click on the folder and make sure the title shows the &. Review URL: http://codereview.chromium.org/4021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2458 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts fix for 2554.sky@google.com2008-09-222-29/+11
| | | | | | Review URL: http://codereview.chromium.org/4017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2445 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes mnemonic bug in chrome menus. After this change you can indicatesky@google.com2008-09-222-11/+29
| | | | | | | | | | | | | whether menus have mnemonics. Mnemonics are shown if the menus have mnemonics, and the OS says we should show them. BUG=1355952 TEST=add a bookmark and change the title to &foo. Move the bookmark to a folder, click on the folder and make sure the title shows the &. Review URL: http://codereview.chromium.org/4002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2442 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in tooltip manager. Mouse coordinates for NC events are insky@google.com2008-09-192-4/+12
| | | | | | | | | | | screen coordinates and need to be converted. BUG=2523 TEST=see bug Review URL: http://codereview.chromium.org/3160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2406 0039d316-1c4b-4281-b951-d872f2087c98
* roll backbeng@google.com2008-09-191-3/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2402 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the frame is set to the foreground when:ben@chromium.org2008-09-191-0/+3
| | | | | | | | | | | - opening from a shortcut when an existing frame is already open - pressing Ctrl+T from an app window http://crbug.com/2477 Review URL: http://codereview.chromium.org/3134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2399 0039d316-1c4b-4281-b951-d872f2087c98
* Fix painting of the title bar when the window is maximized and then deactivated.ben@chromium.org2008-09-181-1/+1
| | | | | | | | http://crbug.com/2456 Review URL: http://codereview.chromium.org/2953 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2350 0039d316-1c4b-4281-b951-d872f2087c98
* Fix GDI leak in Window object (leak of HICONs)ben@chromium.org2008-09-171-4/+12
| | | | | | | | http://crbug.com/2322 Review URL: http://codereview.chromium.org/3120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2341 0039d316-1c4b-4281-b951-d872f2087c98
* Rename legacy methods that were in CamelCase to unix_hacker.erg@google.com2008-09-1740-445/+442
| | | | | | | | | Required going through and modifying some of the code to solve name clashes. Review URL: http://codereview.chromium.org/2945 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2337 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak in the view unit tests.ben@chromium.org2008-09-171-2/+2
| | | | | | Review URL: http://codereview.chromium.org/3115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2328 0039d316-1c4b-4281-b951-d872f2087c98
* Don't load the font for the window title if we're not going to be painting a ↵beng@google.com2008-09-171-23/+10
| | | | | | | | | | text title bar... ie. don't load the font for the title bar for the main browser window since we won't use it - it's only used for app windows. http://crbug.com/2369 Review URL: http://codereview.chromium.org/2919 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2299 0039d316-1c4b-4281-b951-d872f2087c98
* Touchpad support for laptopsjoshia@google.com2008-09-161-1/+2
| | | | | | | | | | | | | | | | | | | | | | | This fix is a workaround to receive mouse wheel and scroll messages from synaptics touchpad driver used in majority of laptops. Removed fake scroll bars in RenderWidgetHostHwnd so that it can now receive mouse wheel messages from synaptics drivers for Dell, Toshiba laptops. Added fake scroll bars to WebContents so that it can receive scroll messages. WebContents then reflects scroll messages to the view to give it a chance to handle them. BUG=4 TEST=Touchpad scrolling and zooming (control + scroll) on various laptops. Review URL: http://codereview.chromium.org/2878 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2266 0039d316-1c4b-4281-b951-d872f2087c98
* Allow Views to support an optional hit-test mask. Make hittest use this.beng@google.com2008-09-163-14/+113
| | | | | | | | | | | Make GetViewForPoint call HitTest instead of rolling its own crude hit testing. Update custom-shaped views to use this framework instead of overriding hittest themselves. B=2273 Review URL: http://codereview.chromium.org/3051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2255 0039d316-1c4b-4281-b951-d872f2087c98
* fix build bustagebeng@google.com2008-09-132-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2170 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent window caption flashing in the magic frames by handling undocumented ↵beng@google.com2008-09-123-0/+45
| | | | | | | | | | windows messages that get sent to caption'ed windows. B=1031854 Review URL: http://codereview.chromium.org/1965 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2105 0039d316-1c4b-4281-b951-d872f2087c98