summaryrefslogtreecommitdiffstats
path: root/chrome/views
Commit message (Collapse)AuthorAgeFilesLines
* Changes line endings from CRLF to LF and add svn:eol-style to LF.hbono@chromium.org2009-02-191-422/+422
| | | | | | | No code changes. This change just changes the CRLF line endings found by your change to make your change work on Mac and Linux trybots. Review URL: http://codereview.chromium.org/21445 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10001 0039d316-1c4b-4281-b951-d872f2087c98
* Make interstitial_page.cc compile on Posix.jhawkins@chromium.org2009-02-181-1/+1
| | | | | | Review URL: http://codereview.chromium.org/21467 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9971 0039d316-1c4b-4281-b951-d872f2087c98
* Solved 2 bugs which caused Chrome to maximize itself whendouble clicking, ↵idanan@chromium.org2009-02-187-36/+54
| | | | | | | | either on the new tab button, on the closetab button or on a single tab.BUG=2827BUG=3787The problem comes from the Windows event sequence upon adouble-click (simplified here):1 - hit-test2 - mouse-down4 - mouse-up/click5 - hit-test6 - mouse down7 - mouse up/double-clickThe 1st hit-test is always performed correctly, returningclient for tabs and non-client for the tab-strip (background).The 2nd hit test is not performed correctly to avoid crashesin Chromebot from events being processed while tabs are animating.Since we have no record of these crashes, Ben prefers we keepthis special-case, even though we are responding incorrectlyto the windows hit-test. So, when the tabs are animating wereturn a HTNOWHERE hit which the caller translates into anHTCAPTION hit. This even though a tab-control (new-tab/close-tab)may have been hit.The problem is that having returned HTCAPTION to Windows defaultmessage handling, we get a NON-CLIENT double-click event insteadof a standard one.To keep the behavior of the second hit-test AND prevent theChrome window from maximizing, this change simply declaresthe non-client double-click as handled when the tabs areanimating.Another trick we pulled in the hit-test is to return HTCAPTIONwhen a single tab is present. This allows the entire window to be dragged but causes the context menu to be wrong and the windowto maximize when double clicking on the single tab.The solution here is to correct return a client hit for a singletab and, upon handling a client single-click, delegate to thenon-client single-click default handler. Review URL: http://codereview.chromium.org/21268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9953 0039d316-1c4b-4281-b951-d872f2087c98
* Don't pass out pointers that belong to other processes.tommi@chromium.org2009-02-181-7/+13
| | | | | | Review URL: http://codereview.chromium.org/20385 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9931 0039d316-1c4b-4281-b951-d872f2087c98
* HtmlDialogs had focus problems.jcampan@chromium.org2009-02-185-3/+9
| | | | | | | | | | | | | | | | | | They would not be focused when shown and tab traversal was not working. This was caused by several issues: - HWNDView was not focusing its HWND when focused through the View::RequestFocus() method (it would rely on the default view behavior which is to focus the root view HWND), so it would not be focused by default. - DOMView (parent of HtmlDialogView) was not focusable so would not get the focus when pressing tab. - DOMView was not eating tab keys events (by returning false in View::CanProcessTabKeyEvents()), so the render view would not get the tab key press messages (for focus traversal in the render view). Note: most of the file changes in this CL are just the consequence of changing the constness of the WindowDelegate::GetInitiallyFocusedView method. BUG=6859 TEST=Open a web page, from the page menu, select the "Create application shortcut..." menu. In the dialog, press the TAB key, focus should alternate between the different fields Review URL: http://codereview.chromium.org/21439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9925 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 9855.maruel@chromium.org2009-02-161-1/+1
| | | | | | | This change didn't have any description and it broke the tree Review URL: http://codereview.chromium.org/21393 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9856 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/20405yurys@google.com2009-02-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9855 0039d316-1c4b-4281-b951-d872f2087c98
* Make system menus show up at the right place for all frames, whether they're ↵pkasting@chromium.org2009-02-137-28/+42
| | | | | | | | | | | | | | | | triggered by clicking the window icon or hitting alt-space. Make clicking the icon for windows without a non-client view (e.g. the Bookmark Manager on Aero Glass) bring up the system menu. Clean up more dead code, verbose code, or unnecessary statics/members. TEST=Right-click titlebars, hit alt-space, and left-click window icons (where present), for: * Main window * Dialogs, e.g. the bookmark manager * Popups * App windows When right-clicking, a system menu should appear at the cursor. For the other cases, a system menu should appear at the system native location (roughly just below the titlebar). Review URL: http://codereview.chromium.org/20225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9766 0039d316-1c4b-4281-b951-d872f2087c98
* Don't focus unfocusable things.pkasting@chromium.org2009-02-134-8/+4
| | | | | | Review URL: http://codereview.chromium.org/20348 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9765 0039d316-1c4b-4281-b951-d872f2087c98
* A patch from external contributor Yong Shin (already in AUTHORS list). I ↵finnur@google.com2009-02-131-18/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | also removed some lint errors. This was reviewed by me and Scott TBR=sky Original changelist description (http://codereview.chromium.org/17608): Context menu for title bar doesn't appear when a tab's context menu was open. --------------------------------------------------------------------------- * About the Bug --------------------------------------------------------------------------- - What steps will reproduce the problem? 1. Open the context menu for a tab of your choice. 2. Right-click on the title bar. - What is the expected result? The application context menu should show up. - What happens instead? Nothing (The tab's context menu is correctly closed, of course). - What is the reason? The context menu for an App is displayed when WM_NCRBUTTONDOWN event is processed on the Window::OnNCRButtonDown() handler. In normal case, when the right mouse button is clicked on the NC area, this event is generated. But in the case that the context menu for a tab is being displayed, WM_NCRBUTTONDOWN is not received. Instead, WM_NCLBUTTONDOWN is generated. (This is wrong because left mouse button is never pressed.) So the right handler (Window::OnNCRButtonDown()) cannot be called. --------------------------------------------------------------------------- * About the Fix --------------------------------------------------------------------------- What is modified? Modified MenuController::RepostEvent() method. This function is called when the mouse button is pressed while the context menu for a tab is being displayed. In this function, following two steps occur in order. 1st. Determine the event type. 2nd. Post this event using PostMessage(). On the 2nd step, In the case that the determined event on the 1st step is for the client area, there's no problem. But in the case of the non-client area, it doesn't use the right event type but use the fixed event type (WM_NCLBUTTONDOWN). This is the wrong implementation. So, I modified this part so that it use the right event type. Bug=5695 http://crbug.com/5695 Review URL: http://codereview.chromium.org/21354 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9761 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an issue with HWNDView visibility where invisible (i.e. ↵pkasting@chromium.org2009-02-132-5/+3
| | | | | | | | SetVisible(false)) views would have ShowWindow() called on them, which was bogus. Review URL: http://codereview.chromium.org/21333 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9760 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some focus traversal issues:pkasting@chromium.org2009-02-131-11/+9
| | | | | | | | * When we're on the only focusable view, AdvanceFocus() should just focus us again. * When only one focusable view exists, FindLastFocusableView() should return it, not NULL. Also the code here was longer than it needed to be. Review URL: http://codereview.chromium.org/20347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9759 0039d316-1c4b-4281-b951-d872f2087c98
* Add ability to set a flag in the Label view class that tells it tomunjal@chromium.org2009-02-133-0/+22
| | | | | | | | return a preferred size of 0, 0 when the label is not visible. Review URL: http://codereview.chromium.org/21313 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9725 0039d316-1c4b-4281-b951-d872f2087c98
* Second try of landing chrome_resources project. Changes from last time:tc@google.com2009-02-128-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | - fix scons dependencies by adding a target for grit/theme_resources.h - fix mac build by adding grit to unittest include path - fix check deps by adding rules for /grit dir. Create a chrome_resources.vcproj that holds grd files that hold non-string resources. Put browser_resources.grd into this vcproj. Port theme_resources.rc/theme_resources.h to theme_resources.grd and put it in the vcproj too. I did a find/replace on the theme_resources include line. Modify grit so header files go in grit_generated_resources/grit/ so the include path can be cleaner. I'll migrate the others in follow up patches. theme_resources.rc had a conditional include of distribution_resources.rc so I had to add support for preprocessor defines to visual studio. Review URL: http://codereview.chromium.org/24011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9664 0039d316-1c4b-4281-b951-d872f2087c98
* This is an attempt at finding the reason for the page_cycler slowness caused bymad@chromium.org2009-02-123-69/+0
| | | | | | | | | | | | | | | the new resize corner. Local experiment led me to believe that it is WebKit that is slower when we specify a resize corner area. To validate this hypothesis, I always return an empty rect to WebKit, but I still compute and push the rect to the render widget and I also draw the bitmap even if this will cause it to be drawn on top of the scroll bars when there is only one. TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9654 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Create a chrome_resources.vcproj that holds grd files that hold"tc@google.com2009-02-127-6/+7
| | | | | | | | | | This reverts commit r9631. TBR=deanm Review URL: http://codereview.chromium.org/23023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9634 0039d316-1c4b-4281-b951-d872f2087c98
* Create a chrome_resources.vcproj that holds grd files that holdtc@google.com2009-02-127-7/+6
| | | | | | | | | | | | | | | | | | | | | non-string resources. Put browser_resources.grd into this vcproj. Port theme_resources.rc/theme_resources.h to theme_resources.grd and put it in the vcproj too. I did a find/replace on the theme_resources include line. Modify grit so header files go in grit_generated_resources/grit/ so the include path can be cleaner. I'll migrate the others in follow up patches. theme_resources.rc had a conditional include of distribution_resources.rc so I had to add support for preprocessor defines to visual studio. Review URL: http://codereview.chromium.org/20247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9631 0039d316-1c4b-4281-b951-d872f2087c98
* Text fields were not getting focused.jcampan@chromium.org2009-02-111-0/+1
| | | | | | | BUG= 7468 Review URL: http://codereview.chromium.org/21255 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9578 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 9493.kuchhal@chromium.org2009-02-103-0/+69
| | | | | | Review URL: http://codereview.chromium.org/21231 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9517 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding of http://codereview.chromium.org/16488.mad@chromium.org2009-02-103-69/+0
| | | | | | | | Adding proper project dependency in chrome.sln. Review URL: http://codereview.chromium.org/21188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9493 0039d316-1c4b-4281-b951-d872f2087c98
* Fix UI test regression, there's a better way to refactor this anyway.pkasting@chromium.org2009-02-101-5/+2
| | | | | | | TBR=glen Review URL: http://codereview.chromium.org/24007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9443 0039d316-1c4b-4281-b951-d872f2087c98
* Make aero glass code look more like other nonclient views in hopes of easing ↵pkasting@chromium.org2009-02-093-25/+21
| | | | | | | | | refactoring. More cleanup. Change tabstrip layout to match opaque frame. BUG=5054 Review URL: http://codereview.chromium.org/20161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9433 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 9408.brettw@chromium.org2009-02-093-0/+69
| | | | | | Review URL: http://codereview.chromium.org/20190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9414 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new resizer corner.mad@chromium.org2009-02-093-69/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To display a resize bitmap and handle the mouse interactions as requested in http://code.google.com/p/chromium/issues/detail?id=458. BUG=458 There are unfortunately two cases to handle and they must be handled separately. The first one is when there are no bottom shelf like the download bar, and the case where there is one. For the case without, we must draw on top of what we receive from WebKit, so we intercept the bitmap in RenderWidgetHostViewWin::OnPaint() so that we can draw the resize corner bitmap on top of it (taking into account whether we are in a right to left language or not). For the case where we have a bottom shelf, we use a dedicated view that we properly layout on top of the bottom shelf view (which takes care of handling the RTL language case for us). Same split for the mouse interactions. Without the bottom shelf, we must deal with it in RenderWidgetHostViewWin::OnMouseEvent() by sending the root window a WM_NCLBUTTONDOWN message with either HTBOTTOMRIGHT or HTBOTTOMLEFT (based on the RTL setting) and let the OS take care of the resizing. IF we have a bottom shelf, we must deal with the mouse interaction in BrowserView::NonClientHitTest() to either return HTBOTTOMRIGHT or HTBOTTOMLEFT (again, based on the RTL setting) and, again, let the OS take care of the resizing. More details here: http://code.google.com/p/chromium/wiki/BrowserViewResizer git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9408 0039d316-1c4b-4281-b951-d872f2087c98
* Support custom border widths. Allow user to resize the window (instead of ↵pkasting@chromium.org2009-02-061-26/+27
| | | | | | | | | doing nothing) when over our client edge graphics. Make resize corner behavior on XP more native. More cleanup. BUG=5054 Review URL: http://codereview.chromium.org/21116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9315 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup forward declared classes that are not needed in chrome/renderer, ↵thestig@chromium.org2009-02-069-36/+17
| | | | | | | | chrome/test/, and chrome/views. Also fix some lint issues while I'm at it. Review URL: http://codereview.chromium.org/20112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9289 0039d316-1c4b-4281-b951-d872f2087c98
* Add debugging info to hopefully catch what's causing 6316erg@google.com2009-02-051-0/+2
| | | | | | | BUG=6316 Review URL: http://codereview.chromium.org/21105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9281 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the dependency checker tool. Rules for a directory did modify their ↵stoyan@chromium.org2009-02-051-0/+9
| | | | | | | | | | directory parent rules. Using copy.copy() solves the problem.Additional fix when "allow-current-directory" rules was not applied if DEPS file is missing. Updated few DEPS file with reasonable rules. To prevent tree closing other dependencies are added. These need to be either legitimated or dependency removed. Review URL: http://codereview.chromium.org/21025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9221 0039d316-1c4b-4281-b951-d872f2087c98
* Paper over a crash that I think is due to the way we shut down the view ↵ben@chromium.org2009-02-041-0/+7
| | | | | | | | | | hierarchy in a window. http://crbug.com/6260 Review URL: http://codereview.chromium.org/20051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9165 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds macro used to track the creation and destructionjcampan@chromium.org2009-02-043-9/+31
| | | | | | | | | | | of HWNDs, in an attempt to detect potential double-delete. A double-delete of a HWND might be responsible for the crasher http://crbug.com/4714 Note: this CL was previously committed and reverted because it broke the sandbox integration module. Review URL: http://codereview.chromium.org/21032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9161 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 9109.ojan@google.com2009-02-033-31/+9
| | | | | | | Broke the build. Review URL: http://codereview.chromium.org/20029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9110 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds macro used to track the creation and destructionjcampan@chromium.org2009-02-033-9/+31
| | | | | | | | | | | | of HWNDs, in an attempt to detect potential double-delete. A double-delete of a HWND might be responsible for the crasher http://crbug.com/4714 Review URL: http://codereview.chromium.org/21018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9109 0039d316-1c4b-4281-b951-d872f2087c98
* Bail saving window placement if the function is called after WM_DESTROY ↵ben@chromium.org2009-02-031-0/+7
| | | | | | | | | | (window_delegate_ is NULL). http://crbug.com/6376 Review URL: http://codereview.chromium.org/21004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9099 0039d316-1c4b-4281-b951-d872f2087c98
* Porting unit tests.phajdan.jr@chromium.org2009-02-031-3/+3
| | | | | | Review URL: http://codereview.chromium.org/19723 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9079 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fix issue 7253 -- tooltip of pure English tab title has wrong ↵xji@chromium.org2009-02-031-0/+3
| | | | | | | | | | | | | | | | | | | | directionality. (http://crbug.com/7253) Fix: LTR tooltip text need to be marked with LRE-PDF to be displayed correctly in RTL locales. Test steps: 1. Open Chrome in RTL locales. 2. Open page http://mail.yahoo.com, whose title is "Yahoo! Mail: the best web-based mail!" 3. Mouse over to the tab title to show the completed page title. Without the fix, tooltip text is: "!Yahoo! Mail: the best web-based mail" (with wrong placement of the ending punctuation). With the fix, tooltip text is: "Yahoo! Mail: the best web-based mail!" Review URL: http://codereview.chromium.org/21003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9064 0039d316-1c4b-4281-b951-d872f2087c98
* More bustage fixesbrettw@chromium.org2009-02-011-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9029 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most header file dependencies on the notification type list. It isbrettw@chromium.org2009-02-0110-32/+45
| | | | | | | | | | | really painful to add more types, since lots of headers include the notification service to derive from the notification observer. This splits that out, so much less of the project should end up including notification_types.h ---Paths modified but not in any changelist: Review URL: http://codereview.chromium.org/19744 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9020 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Aero Basic (i.e. non-glass) maximized mode drawing. This old hack was ↵pkasting@chromium.org2009-01-311-46/+0
| | | | | | | | | interfering with my new code that should do things at least somewhat more correctly. BUG=5054 Review URL: http://codereview.chromium.org/19728 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9009 0039d316-1c4b-4281-b951-d872f2087c98
* Lands fix for 6878 from Yong Shin.sky@google.com2009-01-301-1/+5
| | | | | | | | | BUG=6878 TEST=see bug Review URL: http://codereview.chromium.org/19516 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8985 0039d316-1c4b-4281-b951-d872f2087c98
* Fix various problems with constrained windows and/or custom frame windows:pkasting@chromium.org2009-01-301-77/+183
| | | | | | | | | | | | | | | | | * Wrong titlebar height * Titlebars not handling custom font size properly * Drawing errors in maximized mode * One-pixel overlap glitch on bottom corners of client edges * Borders not handling custom border sizes correctly * Unnecessarily small top resize area (unlike in the main window, there's no competition here between resizing and window dragging in the same small strip) * Wrong icon sizing (only a problem in theory, no one uses this code ATM) These files are now very much like simplified versions of the opaque_non_client_view.cc code (which was the goal); eventually all these should be refactorable. BUG=5054 Review URL: http://codereview.chromium.org/19484 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8947 0039d316-1c4b-4281-b951-d872f2087c98
* Reorganize DefaultNonClientView and ConstrainedWindowNonClientView to match ↵pkasting@chromium.org2009-01-291-164/+117
| | | | | | | | | | | changes in OpaqueNonClientView in preparation for fixing similar problems in them, and then refactoring everyone to a common base implementation. This change should have no visible effect; it merely adds functions, reorganizes code, renames variables, and modifies spacing/style to match OpaqueNonClientView as closely as possible. The subsequent set of functional changes should thus hopefully be easier to review, as should the eventual refactoring changes. This does away with some useless code since both these views are used for windows which always have titles, and, in ConstrainedWindowNonClientView's case, never have icons. (Technically, DefaultNonClientView never has an icon right now either, but there's some commented-out code in the bookmark manager that speaks of having one one day.) Review URL: http://codereview.chromium.org/19684 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8927 0039d316-1c4b-4281-b951-d872f2087c98
* Per Glen, remove the bottom border of maximized windows. I went ahead and ↵pkasting@chromium.org2009-01-293-10/+8
| | | | | | | | also removed support for window frame sizes with unequal widths vs. heights; Windows' UI doesn't actually let you do this and it was making the code more complex than it needed to be. Review URL: http://codereview.chromium.org/19477 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8916 0039d316-1c4b-4281-b951-d872f2087c98
* Move kClientEdgeThickness from BrowserView to NonClientView (which makes ↵pkasting@chromium.org2009-01-292-0/+6
| | | | | | | | | more sense anyway) so I'll be able to use it in custom_frame_window.cc. Also eliminate an unnecessarily-repeated set of resource IDs from the opaque nonclient view, and move a comment to match what I ended up doing (but haven't yet sent up for review) in other places. Seems I couldn't make up my mind on that one. Review URL: http://codereview.chromium.org/19458 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8891 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in adding a menu item. As far as I can tellsky@google.com2009-01-281-0/+9
| | | | | | | | | | | | | | | l10n_util::GetString(IDS_TASK_MANAGER) is returning "". Tony, myself and Rahul don't think this should be possible, yet we have crashes indicating otherwise. If IDS_TASK_MANAGER returns an emtpy string then menu derefs NULL and we crash. BUG=6206 TEST=no way to directly test this, instead just make sure menus still work. Review URL: http://codereview.chromium.org/19434 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8829 0039d316-1c4b-4281-b951-d872f2087c98
* Add NOTREACHED() in switch default part which should never be reached.phajdan.jr@chromium.org2009-01-271-0/+1
| | | | | | Review URL: http://codereview.chromium.org/18850 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8730 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux build breakage.maruel@chromium.org2009-01-271-0/+3
| | | | | | Review URL: http://codereview.chromium.org/19020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8720 0039d316-1c4b-4281-b951-d872f2087c98
* Porting in chrome/views/phajdan.jr@chromium.org2009-01-277-47/+39
| | | | | | | | Some highlights: label, throbber. And others. Review URL: http://codereview.chromium.org/18757 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8715 0039d316-1c4b-4281-b951-d872f2087c98
* This change should have few user-visible effects. I think I slightly ↵pkasting@chromium.org2009-01-263-27/+25
| | | | | | | | | | | | | | | | | | | modified the window layout (by a pixel or so) in the popup window case, which I haven't tried to make pixel-perfect yet anyway. Otherwise it's all reorg. Clean up logic of nonclient view to be more consistent and coherent. Most things are now based on a small set of core functions that return various frame/nonclient thicknesses. This allows a noticeable reduction in the number of hardcoded constants, makes the code make more sense (even though a few places are longer than before), and makes it much easier to do things in the future like resizing various borders or handling system metrics better. Rename and update comments for all constants to be more descriptive and less redundant. Rename helper functions and variables for consistency, now that they've changed. Remove an unused variant of TileImageInt(). Add a new one that takes an offset into the source image. This is used to rewrite the maximized bottom border tiling call in a way that doesn't rely on someone else clipping out or painting over the overdraw from tiling "too large" a source image. Probably no visible effect. Make resize border hittest helper function able to handle borders of varying widths, and try to make parameter names more meaningful. Technically, we don't need the extra flexibility, since our bottom and side borders are the same thickness, but since there are different functions calculating that thickness on the caller side, it didn't hurt to not rely on that for the future. BUG=5054 Review URL: http://codereview.chromium.org/18804 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8658 0039d316-1c4b-4281-b951-d872f2087c98
* Some cleanups I've had sitting around for a while that are getting in my way ↵pkasting@chromium.org2009-01-261-139/+93
| | | | | | | | | now. Fixes some >80-column lines, simplifies LayoutWindowControls() and makes it more similar to the version in OpaqueNonClientView (with the goal of eventually merging these), etc. Review URL: http://codereview.chromium.org/18579 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8638 0039d316-1c4b-4281-b951-d872f2087c98
* Two of the three places that set a window mask had it wrong. Fix it.pkasting@chromium.org2009-01-261-1/+4
| | | | | | Review URL: http://codereview.chromium.org/18580 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8637 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-22 10:09:24 +0000