summaryrefslogtreecommitdiffstats
path: root/chrome/views
Commit message (Collapse)AuthorAgeFilesLines
* Changes TableView to have its own mouse handling code so that we cansky@google.com2008-11-124-8/+154
| | | | | | | | | | | start a drag when user clicks anywhere on a row. BUG=4306 TEST=thoroughly test drag and drop of bookmark manager table. Review URL: http://codereview.chromium.org/9776 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5233 0039d316-1c4b-4281-b951-d872f2087c98
* Changes tree/table to pass in an appropriate location when the contextsky@google.com2008-11-108-47/+95
| | | | | | | | | | | | | menu is invoked from the keyboard. BUG=4029 TEST=In the bookmark manager bring up the context menu of the tree/table via the menu key and make sure the menu appears at a reasonable location. Review URL: http://codereview.chromium.org/10256 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5125 0039d316-1c4b-4281-b951-d872f2087c98
* Minor layout changes that make the bookmark manager and popup blocker look ↵glen@chromium.org2008-11-101-1/+1
| | | | | | | | | | better. BUG=4271 Review URL: http://codereview.chromium.org/10262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5121 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes Issue 3096 in chromium "[Find in page] responds each IME composition, ↵hbono@chromium.org2008-11-101-3/+74
| | | | | | | | | | | | making "not found" noises or jumping within the page." This issue is caued by the TextField::Edit class which start searching a page with a string retrieved with the GetWindowText() function every time when a user presses a key. A string retrived with the GetWindowText() function contains a composition string, a string being composed by an IME. This string changes too often and users do not like to start searching a page with the string. To fix this issue, this change removes a composition string from a search string to emulate Firefox. BUG=3096 "Issue 3096: [Find in page] responds each IME composition, making "not found" noises or jumping within the page." Review URL: http://codereview.chromium.org/9634 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5096 0039d316-1c4b-4281-b951-d872f2087c98
* In dialogs, when the focus moves to a button, that button should become the ↵jcampan@chromium.org2008-11-0812-13/+241
| | | | | | | | | | | | | | default button. When the focus is not a button, then the default button should be the one the delegate specifies. BUG=4132 TEST=Open the option dialog. OK should be the default and focused button. Move the focus around by pressing tab. When a button is selected, it should be the default button. Review URL: http://codereview.chromium.org/10230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5056 0039d316-1c4b-4281-b951-d872f2087c98
* Turns back on tree's double buffering when RTL. For some reason asky@google.com2008-11-071-14/+11
| | | | | | | | | | | | | graphics mode of a ADVANCED doesn't work with a RTL layout for this code. BUG=4175 TEST=bring up the bookmark manager in the hebrew locale, make sure the text isn't mirrored. Review URL: http://codereview.chromium.org/10216 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5017 0039d316-1c4b-4281-b951-d872f2087c98
* Adds cut/copy/paste support to the bookmark manager tree/table andsky@google.com2008-11-072-0/+11
| | | | | | | | | | | | context menus. BUG=4186 TEST=try cut/copy/paste from table/tree in the bookmark manager as well as context menus in bookmark manager. Review URL: http://codereview.chromium.org/9481 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4993 0039d316-1c4b-4281-b951-d872f2087c98
* Adds import/export of bookmarks to bookmarks.html file.sky@google.com2008-11-072-16/+16
| | | | | | | | | | | | BUG=1649 TEST=bring up bookmark manager and try out import/export from the tools menu. Note that import ALWAYS creates a new folder under the 'Other bookmarks folder' with the name of Imported (x). This is by design. Review URL: http://codereview.chromium.org/9471 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4968 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the double buffering in TreeView when the locale is RTL. This means ↵idana@google.com2008-11-061-0/+16
| | | | | | | | | that the tree still flicker during a resize on RTL locales but not on LTR. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4917 0039d316-1c4b-4281-b951-d872f2087c98
* Add a function for eliding filenames to a set pixel width while preserving ↵glen@chromium.org2008-11-062-2/+2
| | | | | | | | the display of the extension. This touches a lot of files because it renames url_elider to text_elider (as it already contained a bunch of text ellision functions), and so requires header file reference changes. BUG=1208 Review URL: http://codereview.chromium.org/9613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4912 0039d316-1c4b-4281-b951-d872f2087c98
* A reported crasher seems to indicate the ViewStorage can be NULL. I don't ↵jcampan@chromium.org2008-11-061-1/+17
| | | | | | | | | | | | see how it could happen. Just bullet-proofing the code so we don't crash. BUG=981648 Review URL: http://codereview.chromium.org/9190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4857 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where we failed to paint infobars and other fast-moving items correctly.glen@chromium.org2008-11-051-1/+1
| | | | | | | | | BUG=4048 Review URL: http://codereview.chromium.org/9192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4810 0039d316-1c4b-4281-b951-d872f2087c98
* This is r4523, with a few changes to make things work under Vista.erg@google.com2008-11-051-2/+1
| | | | | | | | | | | | | - Explicitly set_delegate(NULL) before releasing a TabContents. (I think the order messages are getting handled is different from XP; this only seems neccessary under Vista.) - r4523 and someone elses change added entries to theme_resources.rc at roughly the same time, causing happy fun crashes. - Roll in sgk's SConscript fix. Review URL: http://codereview.chromium.org/9373 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4799 0039d316-1c4b-4281-b951-d872f2087c98
* Add to SCons build:sgk@google.com2008-11-051-0/+1
| | | | | | | | | chrome\browser\bookmarks\bookmark_drop_info.cc chrome\browser\importer\toolbar_importer.cc chrome\views\view_constants.cc Review URL: http://codereview.chromium.org/9387 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4782 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrote the clipboard API to be more concurrent. Added a helper class to ↵estade@chromium.org2008-11-051-4/+3
| | | | | | | | make it more foolproof. Updated all clients and unittests. Mac port by jeremy@chromium.org Review URL: http://codereview.chromium.org/9154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4719 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in menu code. If after dropping you quickly rightsky@google.com2008-11-041-0/+7
| | | | | | | | | | | click the mouse we would crash. This is the same fix as you first saw, I couldn't repro interactive ui test anymore. BUG=4047 TEST=see bug git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4671 0039d316-1c4b-4281-b951-d872f2087c98
* My last fix breaks an interative ui test. I'm going to back out until I ↵sky@google.com2008-11-041-7/+0
| | | | | | | | | | figure out why. TBR=ben Review URL: http://codereview.chromium.org/9353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4656 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in menu code. If after dropping you quickly rightsky@google.com2008-11-041-0/+7
| | | | | | | | | | | click the mouse we would crash. BUG=4047 TEST=see bug Review URL: http://codereview.chromium.org/9346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4647 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for autoscrolling on drag to bookmark tree/table.sky@google.com2008-11-045-11/+49
| | | | | | | | | BUG=674 TEST=none Review URL: http://codereview.chromium.org/9042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4625 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for models to provide addition icons to the tree. Updatessky@google.com2008-11-042-41/+79
| | | | | | | | | | | | the bookmarks folder tree model to return custom icons for search and recently bookmarked. BUG=674 TEST=none Review URL: http://codereview.chromium.org/9047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4556 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change r4523 because Vista doesn't like it.erg@google.com2008-11-041-1/+2
| | | | | | | TBR=nsylvain git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4539 0039d316-1c4b-4281-b951-d872f2087c98
* Redo how we block popups. Rip out the old constrained popup window cruft ↵erg@google.com2008-11-041-2/+1
| | | | | | | | (while leaving the HTTP authentication dialog support) and add a new type of constrained window which owns all blocked popups. Rip out dead unit tests. Review URL: http://codereview.chromium.org/8782 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4523 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome\views\single_split_view.cc to the SCons build.sgk@google.com2008-11-031-0/+1
| | | | | | Review URL: http://codereview.chromium.org/9241 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4451 0039d316-1c4b-4281-b951-d872f2087c98
* Make multiline labels respect the inset.levin@chromium.org2008-11-013-27/+479
| | | | | | | | Add a unittest for label.cc Review URL: http://codereview.chromium.org/8902 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4351 0039d316-1c4b-4281-b951-d872f2087c98
* Some code in MessageBoxView was focusing the first focusable element in the ↵jcampan@chromium.org2008-10-314-23/+26
| | | | | | | | | | | | | view, overidding the focus set from the DialogDelegate. We now only rely on the dialog delegate. Also changed dialog delegate so the default button is also the focused button. BUG=98 TEST=Open a javascript alert then confirm dialog. A button should be focused. Open all dialogs in Chrome. A button should be focused by default. Review URL: http://codereview.chromium.org/8786 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4334 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for keyboard-triggered (through VK_APPS and SHIFT+VK_F10) ↵klink@chromium.org2008-10-316-0/+51
| | | | | | | | right-click menu, specifically on the toolbar's back/forward buttons. Review URL: http://codereview.chromium.org/8942 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4326 0039d316-1c4b-4281-b951-d872f2087c98
* Accumulated SCons changes for Windows chrome build, round II:sgk@google.com2008-10-301-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Includes other recent additions, and doesn't fix everything, but gets significant pieces back on track: * New/additional library dependencies in various test executables (too many to be worth listing). * Portability: put library base names in $LIBS instead of explicitly listing .lib files. * Have interactive_ui re-use various object files from test/ui instead of (re-)listing the .cc files. * Add new files: chrome\browser\bookmarks\bookmark_drag_data.cc chrome\browser\bookmarks\bookmark_drag_utils.cc chrome\browser\bookmarks\bookmark_table_model.cc chrome\browser\browser_trial.cc chrome\browser\download\download_request_manager_unittest.cc chrome\browser\greasmonkey_master.cc chrome\browser\spellcheck_unittest.cc chrome\browser\views\find_bar_view.cc chrome\browser\views\find_bar_win.cc chrome\renderer\greasemonkey_slave.cc * Remove old files: chrome\browser\find_in_page_controller.cc chrome\browser\find_in_page_view.cc chrome\renderer\spellcheck_unittest.cc * Remove relative reference to ../../app/google_update_settings$OBJSUFFIX. * Get rid of by-hand /IMPLIB and /MAP flags. * Prefix / suffix portability in the jscre library. * Rename $LIBXML_DIR/scons => $LIBXML_DIR/DerivedSources. * Add $CHROME_DIR/app/resources to CPPPATH. * Add icu38 directories to CPPPATH for building chrome/views files. Review URL: http://codereview.chromium.org/8742 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4215 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Issue 2918 in chromium: Chrome dialog displayed in large size with ↵hbono@chromium.org2008-10-302-2/+2
| | | | | | | | Meiryo font.This issue is caused by a font whose text metric |tmAveCharWidth| is not precise as noted in Microsoft Knowledge Base 145994 (*1) To handle this case, this change uses the ChromeFont::horizontal_dlus_to_pixels() function instead of the ChromeFont::ave_char_width() function.(*1) http://support.microsoft.com/kb/145994BUG=2918 Review URL: http://codereview.chromium.org/8051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4213 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r4205 to track down buildbot unit_tests failure.sgk@google.com2008-10-301-2/+0
| | | | | | Review URL: http://codereview.chromium.org/8730 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4206 0039d316-1c4b-4281-b951-d872f2087c98
* Accumulated SCons changes for Windows chrome build and othersgk@google.com2008-10-301-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | recent additions (doesn't fix everything, but gets significant pieces back on track). * New/additional library dependencies in various test executables (too many to be worth listing). * Portability: put library base names in $LIBS instead of explicitly listing .lib files. * Have interactive_ui re-use various object files from test/ui instead of (re-)listing the .cc files. * Add new files: chrome\browser\bookmarks\bookmark_drag_data.cc chrome\browser\bookmarks\bookmark_drag_utils.cc chrome\browser\bookmarks\bookmark_table_model.cc chrome\browser\browser_trial.cc chrome\browser\download\download_request_manager_unittest.cc chrome\browser\greasmonkey_master.cc chrome\browser\spellcheck_unittest.cc chrome\browser\views\find_bar_view.cc chrome\browser\views\find_bar_win.cc chrome\renderer\greasemonkey_slave.cc * Remove old files: chrome\browser\find_in_page_controller.cc chrome\browser\find_in_page_view.cc chrome\renderer\spellcheck_unittest.cc * Remove relative reference to ../../app/google_update_settings$OBJSUFFIX. * Get rid of by-hand /IMPLIB and /MAP flags. * Prefix / suffix portability in the jscre library. * Rename $LIBXML_DIR/scons => $LIBXML_DIR/DerivedSources. * Add $CHROME_DIR/app/resources to CPPPATH. * Add icu38 directories to CPPPATH for building chrome/views files. Review URL: http://codereview.chromium.org/8725 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4205 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes resizing of single split view for RTL case.sky@google.com2008-10-301-2/+1
| | | | | | | | | BUG=674 TEST=none Review URL: http://codereview.chromium.org/8210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4193 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at the bookmark manager. There are still a fair number ofsky@google.com2008-10-292-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | | rough edges, but I'm at a good point where I want to land what I have. Here's what is left: . Flicker on show, likely the result of restoring window placement. . tree flickers when dragging splitter. . table/tree need to autoscroll when drop cursor held at bottom of view. . prompts for deleting. . When you move an item the table snaps to the top, this is because I'm sending out model changed. need a better notification. . Operations in menu to add need to change selection. . Remember split location. I would have preferred to split this up into a couple of reviews, but everything is intertwined now. Sorry. BUG=674 TEST=don't test the bookmark manager yet, but make sure bookmark bar still works. Review URL: http://codereview.chromium.org/8197 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4191 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing some windows scons build breaks.bradnelson@chromium.org2008-10-291-2/+1
| | | | | | Review URL: http://codereview.chromium.org/8723 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4186 0039d316-1c4b-4281-b951-d872f2087c98
* The "extra view" used by the DialogClientView must not be retrieved before ↵ben@chromium.org2008-10-292-8/+17
| | | | | | | | | the contents view has been attached to the view hierarchy. http://crbug.com/2751 Review URL: http://codereview.chromium.org/8681 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4116 0039d316-1c4b-4281-b951-d872f2087c98
* Makes tree double duffered so that it doesn't flicker during resize.sky@google.com2008-10-281-0/+14
| | | | | | | | | BUG=3784 TEST=none Review URL: http://codereview.chromium.org/8819 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4054 0039d316-1c4b-4281-b951-d872f2087c98
* Move Time, TimeDelta and TimeTicks into namespace base.dsh@google.com2008-10-275-2/+11
| | | | | | Review URL: http://codereview.chromium.org/7995 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4022 0039d316-1c4b-4281-b951-d872f2087c98
* Handful of changes to NativeControl, TreeView and TableView I'm goingsky@google.com2008-10-248-31/+149
| | | | | | | | | | | | | | | | | | | | to need for the bookmark manager. Specifically: . NativeController now delegates OnContextMenu to the ContextMenuController. . TableView allows a NULL model. . TableView::SetColumns was buggy. . Added a method that TableView invokes after painting. . Added methods to TreeView for getting various state information. BUG=674 TEST=make sure the various places in the UI we uses trees and table work fine: cookies table, passwords table, task manager, bookmark editor, search engines. Review URL: http://codereview.chromium.org/8145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3956 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a horizontal split view.sky@google.com2008-10-244-1/+185
| | | | | | | | | BUG=674 TEST=none Review URL: http://codereview.chromium.org/7930 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3897 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in FillLayout. It should use the size of the root view. I'msky@google.com2008-10-231-3/+1
| | | | | | | | | | | | not actually going to need FillLayout, but I'm fixing the bug in case someone else bumps into it. BUG=none TEST=none Review URL: http://codereview.chromium.org/8202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3839 0039d316-1c4b-4281-b951-d872f2087c98
* test something else to fix dist crashesben@chromium.org2008-10-231-0/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3835 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in TextField::SetEnabled. The code was invoking SetReadOnlysky@google.com2008-10-231-1/+1
| | | | | | | | | | | with the enabled parameter, when it should be !enabled. BUG=none TEST=none Review URL: http://codereview.chromium.org/8108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3820 0039d316-1c4b-4281-b951-d872f2087c98
* Adds models needed by the bookmark manager. Specifically asky@google.com2008-10-231-1/+2
| | | | | | | | | | | | | BookmarkTableModel, which will be used to show one of the following: the children of a folder, recently bookmarked or the results of a search. And the tree model implementation that shows the folders. BUG=674 TEST=covered by unit tests Review URL: http://codereview.chromium.org/8063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3814 0039d316-1c4b-4281-b951-d872f2087c98
* try to fix dist crashesben@chromium.org2008-10-221-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3755 0039d316-1c4b-4281-b951-d872f2087c98
* Using $CHROME_SRC_DIR in place of hash/..bradnelson@google.com2008-10-221-1/+1
| | | | | | | | This will facilitate changing where the main sconstruct lives. Review URL: http://codereview.chromium.org/7847 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3725 0039d316-1c4b-4281-b951-d872f2087c98
* forgot these filesben@chromium.org2008-10-222-30/+93
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3723 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the bug with the minimize/restore buttons getting stuck hot when the ↵ben@chromium.org2008-10-222-6/+14
| | | | | | | | | | | window is restored. Turns out the messages we receive prior to becoming restored/minimized etc are not sufficient to restore the button to its appropriate state. Since this is specific to the implementation of these controls, I have provided a solution specific to them. http://crbug.com/3559 Review URL: http://codereview.chromium.org/7803 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3721 0039d316-1c4b-4281-b951-d872f2087c98
* try rolling this back to see if it helpsben@chromium.org2008-10-212-85/+30
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3645 0039d316-1c4b-4281-b951-d872f2087c98
* More Windows-is-a-crack-baby mitigation.beng@google.com2008-10-202-30/+85
| | | | | | | | | | | | | | | | | I think I've finally fixed this. Knock on wood. Turns out that these two additional places do non-client rendering: - DefWindowProc for WM_NCLBUTTONDOWN - the function EnableMenuItem (called from CustomFrameWindow::OnInitMenu) For the first case, we also need to unlock updating when we begin to receive mouse move events during modal size/move loops, otherwise the feedback won't be visually continuous. http://crbug.com/3264 Review URL: http://codereview.chromium.org/7662 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3620 0039d316-1c4b-4281-b951-d872f2087c98
* Allow middle click on the only tab with one window open.ben@chromium.org2008-10-174-10/+53
| | | | | | | http://crbug.com/3466 Review URL: http://codereview.chromium.org/7506 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3580 0039d316-1c4b-4281-b951-d872f2087c98
* Support shortcut show styles for "run maximized", "run minimized" etc.ben@chromium.org2008-10-172-2/+7
| | | | | | | http://crbug.com/3278 Review URL: http://codereview.chromium.org/7504 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3579 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-02 16:19:45 +0000