summaryrefslogtreecommitdiffstats
path: root/chrome/views
Commit message (Collapse)AuthorAgeFilesLines
* Rename Container->Widgetben@chromium.org2008-11-2140-506/+477
| | | | | | | | | R=erg review url = http://codereview.chromium.org/11348/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5849 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where tooltips would get stuck. This was happening becausesky@google.com2008-11-204-1/+10
| | | | | | | | | | | | | | | | | | on Vista we manage showing/hiding tooltips ourself. It would appear when managing our own tooltips like this we need to explicitly hide the tooltip. If you rapidly moved the mouse we wouldn't get a mouse move and the tooltip would stick. The fix is to have ContainerWin forward mouse leave and have the tooltip manager close the tooltip on mouse leave. BUG=2717 TEST=on vista do the following. Add a bookmark to the bookmark bar and hover the mouse over it. Then hit control-b so the bookmark bar disappears. Make sure the tooltip disappears too. Review URL: http://codereview.chromium.org/11540 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5798 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash when showing modal dialog from context menu. With thissky@google.com2008-11-192-38/+47
| | | | | | | | | | | | | | | | | | | | | sequence ContainerWin remains on the stack while the modal dialog is showing. Prior to this fix we would delete the ContainerWin, so that when the modal dialog closed control would return to a deleted object. The fix is to effectively delay deleting of the ConatinerWins used by menus. BUG=4580 TEST=This is the sequence that triggered the crash: open a folder on the bookmark bar, right child on a child folder that has more than 15 descendant URLs, click open all, a dialog should appear asking if you really want to open all, click cancel and make sure it doesn't crash. This is a subtle change to bookmark menus though, would be good to thoroughly exercise the menus in as many permutations as you can think of. Review URL: http://codereview.chromium.org/11289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5724 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes trees on Hebrew locales. The current code was problematicsky@google.com2008-11-191-2/+26
| | | | | | | | | | | | because SetWorldTransform and a graphics mode of COMPATIBLE don't work together. Instead we must use SetViewportOrgEx. BUG=4515 TEST=see bug Review URL: http://codereview.chromium.org/11253 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5654 0039d316-1c4b-4281-b951-d872f2087c98
* Fix erase method usage on STL containers in Chrome. Invoking erase on the ↵ananta@chromium.org2008-11-151-1/+2
| | | | | | | | | | iterator renders it invalid. We were continuing to use this iterator. R=darin Review URL: http://codereview.chromium.org/10925 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5531 0039d316-1c4b-4281-b951-d872f2087c98
* Fix broken size restoration for bookmark manager. Initializing a rect ↵ben@chromium.org2008-11-143-3/+16
| | | | | | | | | incorrectly, and clobbering the maximized state during initial sizing. http://crbug.com/4437 Review URL: http://codereview.chromium.org/10758 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5512 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/10958mbelshe@google.com2008-11-141-4/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5509 0039d316-1c4b-4281-b951-d872f2087c98
* Make the bookmark manager blue.glen@chromium.org2008-11-142-9/+7
| | | | | | Review URL: http://codereview.chromium.org/11006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5506 0039d316-1c4b-4281-b951-d872f2087c98
* Change to integrate SystemMonitor changes into chrome.mbelshe@google.com2008-11-141-0/+4
| | | | | | | | | | | | This enables the dynamic detection of battery status changes so that we can turn on/off the hi-res timer. Review URL: http://codereview.chromium.org/10264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5489 0039d316-1c4b-4281-b951-d872f2087c98
* Port some files in chrome/browser/agl@chromium.org2008-11-144-76/+102
| | | | | | | | | | | | | | | #ifdef out windows-specific portion of chrome/common/l10n_util.h, which allows me to port some other files. I also extracted parts of chrome/views/tree_view.h to tree_model.h, so that ATL/WTL-specific parts stay in tree_view.h, but tree_model.h is platform-independent and can be included in files using it as base class. Review URL: http://codereview.chromium.org/8618 Patch from Paweł Hajdan jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5483 0039d316-1c4b-4281-b951-d872f2087c98
* Make border and background setting and getting non-virtual and use the ↵brettw@google.com2008-11-149-80/+51
| | | | | | | | correct style. I was debugging in here and this was annoying me, since there is no reason for these functions to be virtual. Review URL: http://codereview.chromium.org/10638 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5445 0039d316-1c4b-4281-b951-d872f2087c98
* Re-do the way browser windows are shown:ben@chromium.org2008-11-144-114/+134
| | | | | | | | | | | | | | | | | | | | | | | | | | | - Remove the path from WinMain to the Browser object passing the show_command. For the Browser object, this is a problem since this value isn't portable. For the code in general it involves a lot of ugly wiring. It's completely unnecessary since the value is obtainable via GetStartupInfo. - Remove show_command plumbing from all over the place (session restore, web app launcher, etc) Change the way browser windows are constructed: - The browser constructor now takes just a type and a profile, and simply initializes the object. - Some configuration that used to be part of the constructor that was only used in one or two use cases (initial bounds, maximized state, web app name) are split into separate setters. - Window creation is split out into a separate step to be called post configuration. - Assorted static helper functions added to Browser to make construction of common types easy. - Remove Browser::Show in favor of BrowserWindow::Show - Adjust all callers to use the new helpers. Change the way ChromeViews restores window placement: - Split restored size determination from restored maximized determination. They are needed by the code at different times. Size restoration happens when the window is constructed and Window::SetInitialBounds is called. Maximized state restoration happens when the window is shown for the first time and SW_SHOWMAXIMIZED or SW_SHOWNORMAL is needed. Thus, replace WindowDelegate::RestoreWindowPosition with WindowDelegate::RestoreWindowBounds and WindowDelegate::RestoreMaximizedState. - Window::SetInitialBounds calls WindowDelegate::RestoreWindowBounds - Window::Show calls WindowDelegate::RestoreMaximizedState - Adjusts all WindowDelegate implementations that override RestoreWindowPosition to implement these new methods instead. - Move "playback/record" mode window size setting from browser_init to Browser::RestoreWindowBounds. - Provide a virtual function on Window called GetShowState that determines the default show state to be used when Window::Show is called. For most windows and dialogs this is SW_SHOWNORMAL. AeroGlassFrame/OpaqueFrame (the browser window frames) override this since they're the app's main windows to return the value provided by GetStartupInfo which gives the value from the app shortcut. http://crbug.com/3557 Review URL: http://codereview.chromium.org/10896 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5417 0039d316-1c4b-4281-b951-d872f2087c98
* Three menu bugs:sky@google.com2008-11-132-6/+8
| | | | | | | | | | | | | | | | | | . If a context menu was shown from a menu, then hidden we did not keep mouse capture and bad things happened (menu wouldn't go away when clicking else where, crash ...). . We only update menu sizes on first show of a menu. That way if a context menu doesn't have icons things don't shift around. . If nothing was selected in the menu pressing the context menu showed the context menu for the root. It doesn't make sense for the root menu to have a context menu. BUG=4364 TEST=see bug Review URL: http://codereview.chromium.org/10706 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5397 0039d316-1c4b-4281-b951-d872f2087c98
* Puts chrome menus on a slimfast diet: they are no longer chubby. Isky@google.com2008-11-132-14/+64
| | | | | | | | | | | | | | | added an option such that menus can be rendered in two ways, chubby or skinny. The only places that uses the taller menus is the bookmark bar. I also made the menus use the right font. BUG=1074332 TEST=none Review URL: http://codereview.chromium.org/10865 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5367 0039d316-1c4b-4281-b951-d872f2087c98
* Some speculative fixes for UI test flakiness.beng@google.com2008-11-132-5/+8
| | | | | | | | | | - make the window update locking use window visibility instead of WM_SETREDRAW. I believe WM_SETREDRAW is causing the window to become visible during tests. - potential crashes caused by NULL TabcontentsDelegates. TBR=sky Review URL: http://codereview.chromium.org/10674 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5335 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the 0x0 canvas used for computing text sizes. Creating this is not ↵brettw@google.com2008-11-131-2/+1
| | | | | | | | | necessary since the text can be sized using the desktop DC, which should be faster. I made this function static, and moved the functions it used into file-local functions since they didn't depend on the class either. This is trying to fix bug 49. This code is very close to the crash, and a 0x0 canvas seems like it might cause problems. However, it is unclear whether this will have any effect (other than performance). Review URL: http://codereview.chromium.org/10409 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5328 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes text field background when disabled/read-only to better matchsky@google.com2008-11-122-23/+44
| | | | | | | | | | | | | | | how Windows looks. This also changes SetEnabled not to adjust read_only_ state. That SetEnabled invoked SetReadOnly is just wrong, the two don't have to be the same. BUG=1218491 TEST=bring up the keyword editor and double click on one of the default search engines, make sure the background of the text field looks disabled. Review URL: http://codereview.chromium.org/10662 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5317 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in showing context menu for buttons. In particular becausesky@google.com2008-11-124-15/+25
| | | | | | | | | | | | we weren't resetting state before showing the context menu it was possible for the button to stay in a HOT state even though it isn't. BUG=2620 TEST=see bug Review URL: http://codereview.chromium.org/10835 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5300 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two menu bugs:sky@google.com2008-11-121-1/+20
| | | | | | | | | | | | | | | | | | | . Pressing shift-F10 would make context menu appear then immediately disappear. This is because MenuController was hiding on a WM_SYSKEYUP. I've changed MenuController to do nothing on WM_SYSKEYUP. If a sys key is pressed again, we'll get a WM_SYSKEYDOWN and hide there. . MenuController needed to handle WM_CONTEXTMENU and not dispatch it, otheriwse we could end up with stacked menus. BUG=3685 TEST=bring up bookmark manager, select a row in the table on the right. Press shift-F10 and make sure the context menu appears and stays up. Review URL: http://codereview.chromium.org/10635 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5299 0039d316-1c4b-4281-b951-d872f2087c98
* Uncomment out these two lines I commented out a few weeks ago so that the ↵ben@chromium.org2008-11-121-4/+0
| | | | | | | | | trunk is usable again. TBR=sky Review URL: http://codereview.chromium.org/10655 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5294 0039d316-1c4b-4281-b951-d872f2087c98
* Changes TableView to have its own mouse handling code so that we cansky@google.com2008-11-124-8/+154
| | | | | | | | | | | start a drag when user clicks anywhere on a row. BUG=4306 TEST=thoroughly test drag and drop of bookmark manager table. Review URL: http://codereview.chromium.org/9776 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5233 0039d316-1c4b-4281-b951-d872f2087c98
* Changes tree/table to pass in an appropriate location when the contextsky@google.com2008-11-108-47/+95
| | | | | | | | | | | | | menu is invoked from the keyboard. BUG=4029 TEST=In the bookmark manager bring up the context menu of the tree/table via the menu key and make sure the menu appears at a reasonable location. Review URL: http://codereview.chromium.org/10256 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5125 0039d316-1c4b-4281-b951-d872f2087c98
* Minor layout changes that make the bookmark manager and popup blocker look ↵glen@chromium.org2008-11-101-1/+1
| | | | | | | | | | better. BUG=4271 Review URL: http://codereview.chromium.org/10262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5121 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes Issue 3096 in chromium "[Find in page] responds each IME composition, ↵hbono@chromium.org2008-11-101-3/+74
| | | | | | | | | | | | making "not found" noises or jumping within the page." This issue is caued by the TextField::Edit class which start searching a page with a string retrieved with the GetWindowText() function every time when a user presses a key. A string retrived with the GetWindowText() function contains a composition string, a string being composed by an IME. This string changes too often and users do not like to start searching a page with the string. To fix this issue, this change removes a composition string from a search string to emulate Firefox. BUG=3096 "Issue 3096: [Find in page] responds each IME composition, making "not found" noises or jumping within the page." Review URL: http://codereview.chromium.org/9634 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5096 0039d316-1c4b-4281-b951-d872f2087c98
* In dialogs, when the focus moves to a button, that button should become the ↵jcampan@chromium.org2008-11-0812-13/+241
| | | | | | | | | | | | | | default button. When the focus is not a button, then the default button should be the one the delegate specifies. BUG=4132 TEST=Open the option dialog. OK should be the default and focused button. Move the focus around by pressing tab. When a button is selected, it should be the default button. Review URL: http://codereview.chromium.org/10230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5056 0039d316-1c4b-4281-b951-d872f2087c98
* Turns back on tree's double buffering when RTL. For some reason asky@google.com2008-11-071-14/+11
| | | | | | | | | | | | | graphics mode of a ADVANCED doesn't work with a RTL layout for this code. BUG=4175 TEST=bring up the bookmark manager in the hebrew locale, make sure the text isn't mirrored. Review URL: http://codereview.chromium.org/10216 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5017 0039d316-1c4b-4281-b951-d872f2087c98
* Adds cut/copy/paste support to the bookmark manager tree/table andsky@google.com2008-11-072-0/+11
| | | | | | | | | | | | context menus. BUG=4186 TEST=try cut/copy/paste from table/tree in the bookmark manager as well as context menus in bookmark manager. Review URL: http://codereview.chromium.org/9481 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4993 0039d316-1c4b-4281-b951-d872f2087c98
* Adds import/export of bookmarks to bookmarks.html file.sky@google.com2008-11-072-16/+16
| | | | | | | | | | | | BUG=1649 TEST=bring up bookmark manager and try out import/export from the tools menu. Note that import ALWAYS creates a new folder under the 'Other bookmarks folder' with the name of Imported (x). This is by design. Review URL: http://codereview.chromium.org/9471 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4968 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the double buffering in TreeView when the locale is RTL. This means ↵idana@google.com2008-11-061-0/+16
| | | | | | | | | that the tree still flicker during a resize on RTL locales but not on LTR. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4917 0039d316-1c4b-4281-b951-d872f2087c98
* Add a function for eliding filenames to a set pixel width while preserving ↵glen@chromium.org2008-11-062-2/+2
| | | | | | | | the display of the extension. This touches a lot of files because it renames url_elider to text_elider (as it already contained a bunch of text ellision functions), and so requires header file reference changes. BUG=1208 Review URL: http://codereview.chromium.org/9613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4912 0039d316-1c4b-4281-b951-d872f2087c98
* A reported crasher seems to indicate the ViewStorage can be NULL. I don't ↵jcampan@chromium.org2008-11-061-1/+17
| | | | | | | | | | | | see how it could happen. Just bullet-proofing the code so we don't crash. BUG=981648 Review URL: http://codereview.chromium.org/9190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4857 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where we failed to paint infobars and other fast-moving items correctly.glen@chromium.org2008-11-051-1/+1
| | | | | | | | | BUG=4048 Review URL: http://codereview.chromium.org/9192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4810 0039d316-1c4b-4281-b951-d872f2087c98
* This is r4523, with a few changes to make things work under Vista.erg@google.com2008-11-051-2/+1
| | | | | | | | | | | | | - Explicitly set_delegate(NULL) before releasing a TabContents. (I think the order messages are getting handled is different from XP; this only seems neccessary under Vista.) - r4523 and someone elses change added entries to theme_resources.rc at roughly the same time, causing happy fun crashes. - Roll in sgk's SConscript fix. Review URL: http://codereview.chromium.org/9373 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4799 0039d316-1c4b-4281-b951-d872f2087c98
* Add to SCons build:sgk@google.com2008-11-051-0/+1
| | | | | | | | | chrome\browser\bookmarks\bookmark_drop_info.cc chrome\browser\importer\toolbar_importer.cc chrome\views\view_constants.cc Review URL: http://codereview.chromium.org/9387 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4782 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrote the clipboard API to be more concurrent. Added a helper class to ↵estade@chromium.org2008-11-051-4/+3
| | | | | | | | make it more foolproof. Updated all clients and unittests. Mac port by jeremy@chromium.org Review URL: http://codereview.chromium.org/9154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4719 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in menu code. If after dropping you quickly rightsky@google.com2008-11-041-0/+7
| | | | | | | | | | | click the mouse we would crash. This is the same fix as you first saw, I couldn't repro interactive ui test anymore. BUG=4047 TEST=see bug git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4671 0039d316-1c4b-4281-b951-d872f2087c98
* My last fix breaks an interative ui test. I'm going to back out until I ↵sky@google.com2008-11-041-7/+0
| | | | | | | | | | figure out why. TBR=ben Review URL: http://codereview.chromium.org/9353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4656 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in menu code. If after dropping you quickly rightsky@google.com2008-11-041-0/+7
| | | | | | | | | | | click the mouse we would crash. BUG=4047 TEST=see bug Review URL: http://codereview.chromium.org/9346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4647 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for autoscrolling on drag to bookmark tree/table.sky@google.com2008-11-045-11/+49
| | | | | | | | | BUG=674 TEST=none Review URL: http://codereview.chromium.org/9042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4625 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for models to provide addition icons to the tree. Updatessky@google.com2008-11-042-41/+79
| | | | | | | | | | | | the bookmarks folder tree model to return custom icons for search and recently bookmarked. BUG=674 TEST=none Review URL: http://codereview.chromium.org/9047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4556 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change r4523 because Vista doesn't like it.erg@google.com2008-11-041-1/+2
| | | | | | | TBR=nsylvain git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4539 0039d316-1c4b-4281-b951-d872f2087c98
* Redo how we block popups. Rip out the old constrained popup window cruft ↵erg@google.com2008-11-041-2/+1
| | | | | | | | (while leaving the HTTP authentication dialog support) and add a new type of constrained window which owns all blocked popups. Rip out dead unit tests. Review URL: http://codereview.chromium.org/8782 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4523 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome\views\single_split_view.cc to the SCons build.sgk@google.com2008-11-031-0/+1
| | | | | | Review URL: http://codereview.chromium.org/9241 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4451 0039d316-1c4b-4281-b951-d872f2087c98
* Make multiline labels respect the inset.levin@chromium.org2008-11-013-27/+479
| | | | | | | | Add a unittest for label.cc Review URL: http://codereview.chromium.org/8902 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4351 0039d316-1c4b-4281-b951-d872f2087c98
* Some code in MessageBoxView was focusing the first focusable element in the ↵jcampan@chromium.org2008-10-314-23/+26
| | | | | | | | | | | | | view, overidding the focus set from the DialogDelegate. We now only rely on the dialog delegate. Also changed dialog delegate so the default button is also the focused button. BUG=98 TEST=Open a javascript alert then confirm dialog. A button should be focused. Open all dialogs in Chrome. A button should be focused by default. Review URL: http://codereview.chromium.org/8786 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4334 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for keyboard-triggered (through VK_APPS and SHIFT+VK_F10) ↵klink@chromium.org2008-10-316-0/+51
| | | | | | | | right-click menu, specifically on the toolbar's back/forward buttons. Review URL: http://codereview.chromium.org/8942 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4326 0039d316-1c4b-4281-b951-d872f2087c98
* Accumulated SCons changes for Windows chrome build, round II:sgk@google.com2008-10-301-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Includes other recent additions, and doesn't fix everything, but gets significant pieces back on track: * New/additional library dependencies in various test executables (too many to be worth listing). * Portability: put library base names in $LIBS instead of explicitly listing .lib files. * Have interactive_ui re-use various object files from test/ui instead of (re-)listing the .cc files. * Add new files: chrome\browser\bookmarks\bookmark_drag_data.cc chrome\browser\bookmarks\bookmark_drag_utils.cc chrome\browser\bookmarks\bookmark_table_model.cc chrome\browser\browser_trial.cc chrome\browser\download\download_request_manager_unittest.cc chrome\browser\greasmonkey_master.cc chrome\browser\spellcheck_unittest.cc chrome\browser\views\find_bar_view.cc chrome\browser\views\find_bar_win.cc chrome\renderer\greasemonkey_slave.cc * Remove old files: chrome\browser\find_in_page_controller.cc chrome\browser\find_in_page_view.cc chrome\renderer\spellcheck_unittest.cc * Remove relative reference to ../../app/google_update_settings$OBJSUFFIX. * Get rid of by-hand /IMPLIB and /MAP flags. * Prefix / suffix portability in the jscre library. * Rename $LIBXML_DIR/scons => $LIBXML_DIR/DerivedSources. * Add $CHROME_DIR/app/resources to CPPPATH. * Add icu38 directories to CPPPATH for building chrome/views files. Review URL: http://codereview.chromium.org/8742 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4215 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Issue 2918 in chromium: Chrome dialog displayed in large size with ↵hbono@chromium.org2008-10-302-2/+2
| | | | | | | | Meiryo font.This issue is caused by a font whose text metric |tmAveCharWidth| is not precise as noted in Microsoft Knowledge Base 145994 (*1) To handle this case, this change uses the ChromeFont::horizontal_dlus_to_pixels() function instead of the ChromeFont::ave_char_width() function.(*1) http://support.microsoft.com/kb/145994BUG=2918 Review URL: http://codereview.chromium.org/8051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4213 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r4205 to track down buildbot unit_tests failure.sgk@google.com2008-10-301-2/+0
| | | | | | Review URL: http://codereview.chromium.org/8730 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4206 0039d316-1c4b-4281-b951-d872f2087c98
* Accumulated SCons changes for Windows chrome build and othersgk@google.com2008-10-301-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | recent additions (doesn't fix everything, but gets significant pieces back on track). * New/additional library dependencies in various test executables (too many to be worth listing). * Portability: put library base names in $LIBS instead of explicitly listing .lib files. * Have interactive_ui re-use various object files from test/ui instead of (re-)listing the .cc files. * Add new files: chrome\browser\bookmarks\bookmark_drag_data.cc chrome\browser\bookmarks\bookmark_drag_utils.cc chrome\browser\bookmarks\bookmark_table_model.cc chrome\browser\browser_trial.cc chrome\browser\download\download_request_manager_unittest.cc chrome\browser\greasmonkey_master.cc chrome\browser\spellcheck_unittest.cc chrome\browser\views\find_bar_view.cc chrome\browser\views\find_bar_win.cc chrome\renderer\greasemonkey_slave.cc * Remove old files: chrome\browser\find_in_page_controller.cc chrome\browser\find_in_page_view.cc chrome\renderer\spellcheck_unittest.cc * Remove relative reference to ../../app/google_update_settings$OBJSUFFIX. * Get rid of by-hand /IMPLIB and /MAP flags. * Prefix / suffix portability in the jscre library. * Rename $LIBXML_DIR/scons => $LIBXML_DIR/DerivedSources. * Add $CHROME_DIR/app/resources to CPPPATH. * Add icu38 directories to CPPPATH for building chrome/views files. Review URL: http://codereview.chromium.org/8725 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4205 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 13:00:24 +0000