summaryrefslogtreecommitdiffstats
path: root/chrome
Commit message (Collapse)AuthorAgeFilesLines
* Add modifier key support for window open dispositions throught the Mac UIrohitrao@chromium.org2009-08-1811-13/+113
| | | | | | | | | | | | | | | | * Add cocoa_utils.{h,mm} and a unit test for the one method it contains: event_utils::DispositionFromEventFlags(). * Add modifier key support to the history menu, bookmark menu, infobars, bookmark bar, and Omnibox. BUG=17912,17301 TEST=When using the aforementioned UI elements, Cmd should open in new foreground tab, Cmd+Shift should open in new background tab, and Shift should open in a new window. Patch by Robert Sesek. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23636 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup in AutomationProvider's navigation observer.phajdan.jr@chromium.org2009-08-185-141/+79
| | | | | | | | | | | | | | Remove unnecessary parameters. Instead of making the callers customize the return codes, just standardize on already present constants. This is a preparation needed before implementing waiting for multiple navigations. TEST=Covered by ui_tests. http://crbug.com/19395 Review URL: http://codereview.chromium.org/171064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23634 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: maruelerikkay@chromium.org2009-08-181-0/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23632 0039d316-1c4b-4281-b951-d872f2087c98
* Renames the function CreateTemporaryFilename to CreateTemporaryFile and ↵erikkay@chromium.org2009-08-1811-38/+45
| | | | | | | | | | | | | | track down all callers, also removes the deprecated function that uses std::wstring. BUG=3078 (http://crbug.com/3078) TEST=run base_unittests, installer_util_unittests, net_unittests, setup_unittests, and unit_tests. Review URL: http://codereview.chromium.org/164537 Patch from Thiago Farina. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23631 0039d316-1c4b-4281-b951-d872f2087c98
* Fix "crashed extension" infobar browser crashes.phajdan.jr@chromium.org2009-08-1814-96/+175
| | | | | | | | | | | | This is a general rework of how "crashed extension" infobar works and how the extension is actually recovered after the crash. TEST=See bug. http://crbug.com/15888 Review URL: http://codereview.chromium.org/164151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23628 0039d316-1c4b-4281-b951-d872f2087c98
* Moves GtkDndUtil into app.sky@chromium.org2009-08-1812-234/+9
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/165423 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23627 0039d316-1c4b-4281-b951-d872f2087c98
* Bugfixes and enhancements to the compact nav bar and the status area.brettw@chromium.org2009-08-185-41/+157
| | | | | | | | | | | | | | | | | This makes the compact navigation bar off by default at the request of Nicolas. It can be enabled with --compact-nav on the command line. It also adds different tab opening options when this feature is enabled. They are accessible from the app menu in the status area. The buttons now extend to the top of the screen for easier clicking. The status area is enabled whether or not the compact navigation bar is. I fixed the background so it will appear unselected when the window loses focus, and I fixed the time formatting to make the minutes always 2 digits. The Chrome button is now hooked up and just opens a tab to a placeholder page. Review URL: http://codereview.chromium.org/169001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23626 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ViewHostMsg_PluginMessage which was unused.brettw@chromium.org2009-08-183-53/+0
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/171052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23623 0039d316-1c4b-4281-b951-d872f2087c98
* Remove RenderProcessHost::size(). With Pawel's change, size() isn't necessarilybrettw@chromium.org2009-08-187-28/+40
| | | | | | | | | | | | | correct, and it was badly named and needed fixing anyway. This patch just removes it. There were a few debugging places that used it which I just removed, since I think they're old and haven't been useful lately. The non-trivial changes were in the histogram code, it now counts them slightly differently. Review URL: http://codereview.chromium.org/171051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23622 0039d316-1c4b-4281-b951-d872f2087c98
* Add more libnss files to lib32.thestig@chromium.org2009-08-181-0/+6
| | | | | | | | TEST=none BUG=19440 Review URL: http://codereview.chromium.org/172067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23618 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an unused header from proxy_service.h.ericroman@google.com2009-08-183-0/+3
| | | | | | Review URL: http://codereview.chromium.org/164545 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23615 0039d316-1c4b-4281-b951-d872f2087c98
* Use 'icu::' namespace explicitly throughout Chrome tree instead of relying ↵jshin@chromium.org2009-08-186-48/+46
| | | | | | | | | | | | | | | | | | | on 'using namespace icu'. This is Chrome's counterpart to the ICU header change that disables 'using namespace icu' (http://codereview.chromium.org/171010/show), which is required to avoid the name colission between Chrome's StringPiece (in base) and ICU's StringPiece. The webkit change (which is minor) will be dealt with in the webkit bugzilla. This can go in before the ICU change/upgrade without affecting anything. BUG=8198 TEST=All the targets are built without an error on all platforms. Review URL: http://codereview.chromium.org/171012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23613 0039d316-1c4b-4281-b951-d872f2087c98
* Reference count ProxyService.eroman@chromium.org2009-08-183-15/+22
| | | | | | | | | | | | | This is necessary since ProxyService is getting shared between chrome's url request contexts (off the record, media), and the current way it is being shared could result in free memory read/writes during shutdown. This is a step towards fixing http://crbug.com/15289. BUG=http://crbug.com/15289 TEST=The existing tests should continue to pass following this refactor. Review URL: http://codereview.chromium.org/165430 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23612 0039d316-1c4b-4281-b951-d872f2087c98
* more linux automation porting: SendKeyPressNotifyWhenDoneestade@chromium.org2009-08-189-92/+93
| | | | | | | | | | also change the interface for SimulateOSKeyPress()/SendKeyPress() to take a VKEY_ value (defined in base/keyboard_codes.h) rather than a VK_ value. BUG=19076 Review URL: http://codereview.chromium.org/171079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23611 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: make the passwords and exceptions dialog box default size larger.mdm@chromium.org2009-08-182-3/+5
| | | | | | | | | BUG=19433 TEST=obvious Review URL: http://codereview.chromium.org/171077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23608 0039d316-1c4b-4281-b951-d872f2087c98
* Add the UI thread to the list of ChromeThreads.paul@chromium.org2009-08-183-2/+31
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/171088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23605 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out views::Combobox::Model so that it can be used cross-platform.mattm@chromium.org2009-08-1816-69/+67
| | | | | | | | | | This removes the Combobox* source arg from the Model methods, which wasn't really used by anything. BUG=none TEST=none Review URL: http://codereview.chromium.org/165514 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23603 0039d316-1c4b-4281-b951-d872f2087c98
* Makes UMA log upload work on non-Windows platforms.cmasone@google.com2009-08-181-0/+1
| | | | | | | | | MemoryDetails::StartFetch() isn't implemented, thus it was never signalling that it was done fetching memory details. Now it does. BUG=15418 Review URL: http://codereview.chromium.org/172052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23602 0039d316-1c4b-4281-b951-d872f2087c98
* Call the new FilePath API to make sure the untrusted sandboxed process is notcevans@chromium.org2009-08-181-2/+12
| | | | | | | | | | | sending us paths with .. in them. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/171025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23597 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Update PRIMARY selection on omnibox copy-to-clipboard.derat@chromium.org2009-08-182-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | | This brings us in line with Firefox's behavior. Ctrl-L highlights the URL but doesn't update the PRIMARY selection, so Ctrl-C is a common* way to get the current location into PRIMARY so you can middle-click somewhere else to paste it. * I use it and a user mentioned that they do too. :-P Tested as follows: - highlight some text on the page to make it PRIMARY - hit Ctrl-L and confirm that text on page is still PRIMARY - hit Ctrl-C and confirm that location is now PRIMARY - repeat, but this time hit the right arrow key between Ctrl-L and Ctrl-C to unhighlight the text first. the text on the page should remain the PRIMARY selection BUG=18403 TESTED=see above Review URL: http://codereview.chromium.org/164539 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23596 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Theme: Draw the GTK border around the entry in GTK them mode.erg@google.com2009-08-182-13/+31
| | | | | | | | | | | Also makes the label look native. I can't get the label inside the entry, though. http://crbug.com/17962 Review URL: http://codereview.chromium.org/172069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23595 0039d316-1c4b-4281-b951-d872f2087c98
* Made the Sync UI work in the New New tab page.idana@chromium.org2009-08-177-75/+227
| | | | | | | | | | There are no significant logic changes except the addition of a link which points to the web ui. BUG=none Review URL: http://codereview.chromium.org/172007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23591 0039d316-1c4b-4281-b951-d872f2087c98
* Remove webview's dependency on webpreferences.jorlow@chromium.org2009-08-173-14/+27
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/165513 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23589 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable a failing ui test.estade@chromium.org2009-08-171-1/+2
| | | | | | | TBR=eroman git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23588 0039d316-1c4b-4281-b951-d872f2087c98
* Move interactive_ui_tests target to !mac for now.estade@chromium.org2009-08-171-125/+126
| | | | | | | | TBR=eroman Review URL: http://codereview.chromium.org/171083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23587 0039d316-1c4b-4281-b951-d872f2087c98
* Begin to port browser focus tests to linux.estade@chromium.org2009-08-172-98/+178
| | | | | | | | TEST=interactive ui tests builds and runs and BrowserFocusTest.TabInitialFocus passes Review URL: http://codereview.chromium.org/172059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23585 0039d316-1c4b-4281-b951-d872f2087c98
* cap the number of tabs in the backing store cacheerikkay@chromium.org2009-08-172-27/+50
| | | | | | | | | BUG=19353 TEST=None Review URL: http://codereview.chromium.org/165538 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23584 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaning up lines longer than 80 chars under src/chrome/browser. mark@chromium.org2009-08-1731-68/+124
| | | | | | | | | | | | | | | | | | | Command: awk '{if ( length($0) > 80 ) { print FILENAME, FNR, $0 } }' *.cc *.h # recursive find . -type f \( -name '*.cc' -o -name '*.h' \) -exec awk '{if ( length($0) > 80 ) { print FILENAME, FNR, $0 } }' {} \; Patch by Pierre-Antoine LaFayette <pierre.lafayette@gmail.com> BUG=None TEST=None Code review URL: http://codereview.chromium.org/164566 Review URL: http://codereview.chromium.org/171066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23583 0039d316-1c4b-4281-b951-d872f2087c98
* Add libnss3.so to the list of files we put in lib32.thestig@chromium.org2009-08-171-9/+10
| | | | | | | | TEST=none BUG=19440 Review URL: http://codereview.chromium.org/171069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23578 0039d316-1c4b-4281-b951-d872f2087c98
* An initial pass at structure to do end-to-end extension API tests. I'll ↵erikkay@chromium.org2009-08-1714-9/+319
| | | | | | | | work on actually fleshing out some tests in the next CL. Review URL: http://codereview.chromium.org/171032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23577 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor IDMap to support safe removing of elements during iteration.phajdan.jr@chromium.org2009-08-1717-119/+276
| | | | | | | | | TEST=Covered by unit_tests and other automated tests. http://crbug.com/19202 Review URL: http://codereview.chromium.org/164518 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23572 0039d316-1c4b-4281-b951-d872f2087c98
* Changes Live Search to Bing for en_US only. A full worldwide review is in ↵pkasting@chromium.org2009-08-171-13/+13
| | | | | | | | | | | | progress and we'll pick up the other countries eventually. Added some temporary comments on the Bing entry since the way it's coexisting with the Live entries right now makes for a few slightly unusual bits. BUG=13065 TEST=Search providers should show Bing and not Live Search, setting Bing to default should result in working Suggest and search functionality. Review URL: http://codereview.chromium.org/171065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23571 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for crash bug in PluginProcessHost::OnGetCookies - it likes like this ↵robertshield@chromium.org2009-08-171-1/+7
| | | | | | | | | | | | | can be called when we don't have a URLContext from which to return cookies. Previously we crashed, this patch just logs an error and returns an empty string instead. BUG=http://crbug.com/10706 Review URL: http://codereview.chromium.org/171050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23568 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash that could happen on shutdown if the ResourceMessageFilter tried ↵jam@chromium.org2009-08-174-23/+48
| | | | | | | | | | | to get the IO thread's message loop when it was going away. Do the same acrobatics as in BufferedResourceHandler by going to the UI thread first, and doing refcounting manually. Also fix an issue I saw by inspection in BufferedResourceHandler, where Release should be called at the end of the function. BUG=19415 Review URL: http://codereview.chromium.org/171055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23563 0039d316-1c4b-4281-b951-d872f2087c98
* Add third_party/bzip2/bzip2.gyp:bzip2 to a few targets.agl@chromium.org2009-08-171-0/+2
| | | | | | | | | | These targets include from third_party/bzip2 but list it in dependencies. This means that they don't get the direct_dependents_settings and this is breaking the Ubuntu package building with use_system_bzip2. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23556 0039d316-1c4b-4281-b951-d872f2087c98
* Make Cmd+Y the command key for opening the history UI on the Macpinkerton@chromium.org2009-08-171-1/+2
| | | | | | | | | | Per discussion: http://groups.google.com/group/chromium-dev/browse_thread/thread/b4c671403265 Patch from rsesek@chromium.org BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23552 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up download item look, part 1 of many.thakis@chromium.org2009-08-173-52/+44
| | | | | | | | | BUG=18902 TEST=items look like buttons all the time, not only on hover. icon is 16x16 :-/. spacing slightly modified (not final yet). Review URL: http://codereview.chromium.org/172030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23550 0039d316-1c4b-4281-b951-d872f2087c98
* Implement drag and drop of downloads for the Mac downloads page.paul@chromium.org2009-08-1710-14/+149
| | | | | | | | | | BUG=15776 (http://crbug.com/15776) TEST=Download an item, open the download page, drag the icon of the download to the desktop. Review URL: http://codereview.chromium.org/164459 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23548 0039d316-1c4b-4281-b951-d872f2087c98
* Stop shortening the Mac lproj directories (ie-"en-US" instead of "en").thomasvl@chromium.org2009-08-173-22/+31
| | | | | | | | | | | Add a script to make a link for "en.lproj" so we always have an english in the fall back list. Run said script as a postbuild step. TEST=Chrome should now show all 40 language when you do a get info in the finder. BUG=19165 Review URL: http://codereview.chromium.org/171043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23547 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: remove TODO on completed item.pfeldman@chromium.org2009-08-171-1/+0
| | | | | | | | | BUG=19335 TBR=aa Review URL: http://codereview.chromium.org/171036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23543 0039d316-1c4b-4281-b951-d872f2087c98
* Flip inverted logic that caused Breakpad to never initialize after r23509.mark@chromium.org2009-08-171-1/+1
| | | | | | | | | | | | | BUG=19204 TEST=When reporting is enabled, Breakpad should pick up browser and renderer process crashes; When reporting is enabled, renderer should not log messages like [mmdd/hhmmss:WARNING:/path/to/breakpad_mac.mm(57)] Breakpad disabled; When reporting is disabled, browser and renderer should both log these messages. Review URL: http://codereview.chromium.org/172037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23538 0039d316-1c4b-4281-b951-d872f2087c98
* skip ExpireHistoryTest.* in Purifyerikkay@chromium.org2009-08-161-0/+3
| | | | | | | | | | BUG=19467 TEST=none TBR=maruel Review URL: http://codereview.chromium.org/172036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23536 0039d316-1c4b-4281-b951-d872f2087c98
* Fix potential crash in Browser::OpenURLAtIndex.finnur@chromium.org2009-08-161-7/+8
| | | | | | | | | | | | | | | This is a bit of a Coverity nit, but if disposition SUPPRESS_OPEN is ever passed in to this function, it will crash because we try to call Focus on a new_contents pointer that is null. I verified this by hard coding the disposition as we open URLs. BUG=17101 TEST=No significant change. Review URL: http://codereview.chromium.org/155773 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23532 0039d316-1c4b-4281-b951-d872f2087c98
* Add some recent reliability crashes to known_crashes. Remove some ↵senorblanco@chromium.org2009-08-151-1/+4
| | | | | | | | | | | | consistently passing tests from test_expectations. Add some svn:ignore's for .scons files. BUG=18896,15217,18978,19428,19414 TEST=Green is good. TBR=pkasting Review URL: http://codereview.chromium.org/172022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23526 0039d316-1c4b-4281-b951-d872f2087c98
* Fix TOC formatting.kathyw@google.com2009-08-151-0/+4
| | | | | | | | TBR=rafaelw Review URL: http://codereview.chromium.org/171024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23525 0039d316-1c4b-4281-b951-d872f2087c98
* Fix startup tests with complex theme.mirandac@chromium.org2009-08-155-12/+127
| | | | | | | | | | BUG= http://crbug.com/18767 TEST= none Review URL: http://codereview.chromium.org/165478 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23524 0039d316-1c4b-4281-b951-d872f2087c98
* Make callstack for known crash more general, so it applies to the slight ↵eroman@chromium.org2009-08-151-1/+1
| | | | | | | | | | | variation that is showing up. BUG=http://crbug.com/19393 TBR=ananta Review URL: http://codereview.chromium.org/172021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23522 0039d316-1c4b-4281-b951-d872f2087c98
* Add themes link to left nav.aa@chromium.org2009-08-1516-15/+16
| | | | | | TBR=rafaelw@chromium.org,kathyw@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23521 0039d316-1c4b-4281-b951-d872f2087c98
* First swing at the docs homepage. Also, fix the copyright/licenseaa@chromium.org2009-08-1521-25/+68
| | | | | | | | footer. TBR=rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23520 0039d316-1c4b-4281-b951-d872f2087c98
* Add a suppression for crash in ResourceMessageFilter::OnGetPluginsOnFileThread.eroman@chromium.org2009-08-151-0/+3
| | | | | | | | | BUG=http://crbug.com/19415 TBR=jam Review URL: http://codereview.chromium.org/171022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23519 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 11:39:36 +0000