| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
action transparency.
BUG=51944
TEST=see bug. rightmost extension should not be transparent at all after resizing browser action container.
Review URL: http://codereview.chromium.org/3179011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=51834
TEST=Clicking on a selection dropdown should not cause assert failure.
Review URL: http://codereview.chromium.org/3176009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
dashboard, it has been passing consistently.
BUG=42844
Review URL: http://codereview.chromium.org/3095006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49094
TEST=none
Review URL: http://codereview.chromium.org/3171003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3106007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/2941001
Initial submit broke the chromeos build. This patch includes the original change, and fixes to compile ChromeOs properly.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2819086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See r26348, "Avoid spurious errors about NSColor*-CGColor* and NSSize-CGSize
conversions": The SDK has gotten stupider in 10.6, and has conspired with the
compiler, which now thinks that when the receiver is held in a scoped_nsobject,
NSColor and NSSize arguments should be converted to their CG cousins.
BUG=51430
TEST=10.6 SDK build (mac_sdk=10.6)
Review URL: http://codereview.chromium.org/3162008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The TwoClientLiveAutofillSyncTest.Client1HasData test fails due to bug
51956. Marking it as FAILS until the bug is fixed.
TBR=tim@chromium.org
BUG=51956
TEST=TwoClientLiveAutofillSyncTest.Client1HasData
Review URL: http://codereview.chromium.org/3146013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disable the options menu divider so we don't fire an invalid command.
the translate bar was crashing when you would use
the context menu to translate a page with an unknown language. It was trying to
instantiate an options menu model when it didn't need one, or have a language to
populate it with. This makes it so the options menu model is not instantiated
unless it needs it, and it only needs it when it actually knows the language.
BUG=47303
TEST=see bug.
Review URL: http://codereview.chromium.org/3080035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed Unnescessary code and also refactored some.
Added tests.
Added example AppleScripts.
original patch from shreyas.
BUG=none
TEST=updates some unit tests and adds some.
Review URL: http://codereview.chromium.org/3163008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
no checkboxes are checked.
BUG=49037
TEST=out/Debug/chrome --enable-tabbed-options. Go to 'Under the Hood' tab, open the
dialog, check some checkbox, the button should become enabled, uncheck all the
checkboxes, the button should become disabled.
Review URL: http://codereview.chromium.org/3155001
TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/3172012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
are crashy.
BUG=51969
TEST=MediaTest.*
Review URL: http://codereview.chromium.org/3155010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=51890
TEST=tsan ui_tests
Review URL: http://codereview.chromium.org/3158010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PrefixedSwitchString was full of encoding conversions, but there was only one
real caller, and the function is trivial.
Terminate is leftover cruft.
TEST=compiles
Review URL: http://codereview.chromium.org/3138001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42676
TEST=Hit F11 while an app panel is open. It should not be maximized
Review URL: http://codereview.chromium.org/3074033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Removed a unused header
BUG=49093
TEST=None
Review URL: http://codereview.chromium.org/3029065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will look a bit broken until the window manager changes its shadows to
match.
BUG=chromiumos:5156
TEST=Panels should have rounded corners, cleaner spacing of ui elements, and
shouldn't change when they have the focus.
Review URL: http://codereview.chromium.org/3091009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=51703
BUG=30178
BUG=25106
TEST=none
Review URL: http://codereview.chromium.org/3129003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=51969
TEST=MediaTest.VideoBearSilentTheora
Review URL: http://codereview.chromium.org/3155009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
recognize speech.
Also added a unit test for checking the callbacks fire as expected.
TEST=unit_tests --gtest_filter=SpeechRecognizerTest.*
BUG=none
Review URL: http://codereview.chromium.org/3124009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
status menu, about:networks, and options pages.
Also fixed a small issue where we should not be displaying "Other..." if wifi is disabled.
BUG=chromium-os:5570
TEST=manual
Review URL: http://codereview.chromium.org/3108011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
supports it.
BUG=none
TEST=--use-accelerated-2d-canvas, any canvas content w/images
Review URL: http://codereview.chromium.org/3125007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
for yzshen's http://codereview.chromium.org/3117011/show
BUG=50943
TEST=none
Review URL: http://codereview.chromium.org/3131014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=mpcomplete@chromium.org
BUG=49234
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed for pages to be able to deactivate the browser's or popup windows with window.blur().
BUG=51364
TEST=Open a page that calls window.blur(), it should move the browser window to the back of the Z order.
Review URL: http://codereview.chromium.org/3159007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
o Just use the provided toolbar background color as the "highlight" color in most cases and don't draw a bevel on the templated buttons.
BUG=51430
TEST=see bug. make sure no jank.
Review URL: http://codereview.chromium.org/3140009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=51411
TEST=compiles
Review URL: http://codereview.chromium.org/3174002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=51847
TEST=none
Review URL: http://codereview.chromium.org/3141010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
source id. It will assign entries with a source type of NONE their own unique negative id, which will never be displayed.
Also, the id column in the Requests tab is now right-aligned.
BUG= 48806
TEST= Run chromium while your ip address changes.
Alternatively, add the following code to
ConnectJob::LogConnectStart(), or somewhere else
that looks promising:
net_log().net_log()->AddEntry(net::NetLog::TYPE_NETWORK_IP_ADDRESSSES_CHANGED,
base::TimeTicks::Now(),
net::NetLog::Source(),
net::NetLog::PHASE_NONE,
NULL);
Review URL: http://codereview.chromium.org/2883061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=builds
Review URL: http://codereview.chromium.org/3136007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Run with --enable-resource-content-settings and --enable-click-to-play to enable.
TabSpecificContentSettings now keeps track of which resources were blocked. The content setting bubble displays those resource, and selecting the "allow radio buttons adds exceptions for these resources.
The infobar for non-sandboxed plug-ins now also shows a button to always allow the blocked plug-in on that site.
Screenshot of the plugin bubble: http://imgur.com/6npqv.png
Because we need to change the title and radio button labels depending on whether we track specific plug-ins, we copy them from the ContentSettingBubbleModel.
XIB changes: Add a text field for the blocked plug-ins to ContentBlockedPlugins.xib, hooked up to the |blockedResourcesField_| outlet.
BUG=39252,38432
TEST=manual
Review URL: http://codereview.chromium.org/2873104
TBR: bauerb@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3132007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Run with --enable-resource-content-settings and --enable-click-to-play to enable.
TabSpecificContentSettings now keeps track of which resources were blocked. The content setting bubble displays those resource, and selecting the "allow radio buttons adds exceptions for these resources.
The infobar for non-sandboxed plug-ins now also shows a button to always allow the blocked plug-in on that site.
Screenshot of the plugin bubble: http://imgur.com/6npqv.png
Because we need to change the title and radio button labels depending on whether we track specific plug-ins, we copy them from the ContentSettingBubbleModel.
XIB changes: Add a text field for the blocked plug-ins to ContentBlockedPlugins.xib, hooked up to the |blockedResourcesField_| outlet.
BUG=39252,38432
TEST=manual
Review URL: http://codereview.chromium.org/2873104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:2884
TEST=none
Review URL: http://codereview.chromium.org/3072029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
are checked.
BUG=49037
TEST=out/Debug/chrome --enable-tabbed-options. Go to 'Under the Hood' tab, open the
dialog, check some checkbox, the button should become enabled, uncheck all the
checkboxes, the button should become disabled.
Review URL: http://codereview.chromium.org/3155001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:5636
TEST=See instructions in the bug.
Review URL: http://codereview.chromium.org/3122011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm renaming the platform-specific content setting bubble classes to the uniform naming scheme content_setting_bubble_{views,gtk,cocoa}.{h,cc}
XIB changes: Rename ContentBlockedBubbleController in ContentBlocked*.xib to ContentSettingBubbleController.
BUG=none
TEST=everything compiles
Review URL: http://codereview.chromium.org/3099002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mazda: In your DOMUI html, please set the integers defined in chromeos_keyboard.h:
enum ModifierKey {
kSearchKey = 0,
kLeftControlKey,
kLeftAltKey,
kVoidKey,
kCapsLockKey,
kNumModifierKeys,
};
to the following integer prefs:
prefs::kLanguageXkbRemapSearchKeyTo
prefs::kLanguageXkbRemapControlKeyTo
prefs::kLanguageXkbRemapAltKeyTo
BUG=chromium-os:5152
TEST=manually
Review URL: http://codereview.chromium.org/3141011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- make it consistent in how to get an instance of the API classes
- remove duplicate (and obsolete) copies of the docs from .cc files, mocks etc.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3050049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
CID=12377, 12379, 12380, 12381
Review URL: http://codereview.chromium.org/3176004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=indexed_db_browsertest.cc
Review URL: http://codereview.chromium.org/3061057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch from <nhiroki@google.com>.
BUG=chromium-os:5284
TEST=manual
Review URL: http://codereview.chromium.org/3179008
Patch from Hiroki Nakagawa <nhiroki@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
When an ICU ruleset defines a dictionary value "$dictionary = [:LineBreak = Complex_Context:]", ICU expects we use this value in breaking text. On the other hand, when we do not use this value, ubrk_next() gets stuck in an infinite loop and it causes Issue 46278. To fix this issue, we define |$dictionary| only for the languages we need the value, e.g. Korean and Thai.
BUG=46278
TEST=unit_test.exe --gtest_filter=SpellcheckWordIteratorTest.RuleConsistency
Review URL: http://codereview.chromium.org/3108003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=builds
TBR=viettrungluu@chromium.org,brettw@chromium.org
Review URL: http://codereview.chromium.org/3130011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=builds on Chrome OS
TBR=viettrungluu@chromium.org,brettw@chromium.org
Review URL: http://codereview.chromium.org/3129009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3136004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
removing a langauge.
TEST=manually
BUG=chromium-os:4573
Review URL: http://codereview.chromium.org/3152005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Also do some drive-bys.)
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3165009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=lzheng@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3122010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55838 0039d316-1c4b-4281-b951-d872f2087c98
|