| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Do it fast with following shell script:
export LC_ALL=C
find chrome/browser/chromeos/ -name '*.h' -o -name '*.cc' \
| xargs grep -C1 '^#include' \
| awk -F: '$2 !~ "include" { prev=""; next } ($2 <= prev) { print $1 } { prev=$2 }' \
| uniq \
| xargs -n1 sh -c 'cat "$1" \
| awk "{ tag=((/^#include/) \"_\" (/</) \"_\" (/third.party/)); print tag \"\t\" \$0 }" \
| awk -vi=0 -F\\t "{ if (!/^1_0_/ || \$1 != prev) { ++i } } { printf \"%09d\t%s\n\",i,\$0; prev=\$1 }" \
| sort \
| sed "s/^[0-9]*\t[0-9]_[0-9]_[0-9]\t//" > "$1".fixed; mv -f "$1".fixed "$1"' xxx
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/3402010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=55380
TEST=LoginPromptTest.TestDigestAuth
TBR=thomasvl@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
noticeable when end events missing from log.
BUG=54879
TEST=manual
Review URL: http://codereview.chromium.org/3450009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
webNavigation API.
Also, rewrite the onCommitted event such that AUTO_SUBFRAME events are also registered.
The frameId and the requestId fields are still unimplemented.
Also, there occur navigation events after an error is reported.
BUG=50943
TEST=WebNavigationEvents
Review URL: http://codereview.chromium.org/3436002
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3389012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, rewrite the onCommitted event such that AUTO_SUBFRAME events are also registered.
The frameId and the requestId fields are still unimplemented.
Also, there occur navigation events after an error is reported.
BUG=50943
TEST=WebNavigationEvents
Review URL: http://codereview.chromium.org/3436002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=55380
TEST=LoginPromptTest.TestBasicAuth
TBR=thomasvl@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Per UX input from Cole, this matches the implementation in the android voice actions app.
Changes in this CL:
- Instead of the old mic icon use the recently added mic-volume-empty, mic-volume-full and mask images for the volume indicator.
- Extended the endpointer code to return the audio RMS level (copied from the original source).
- SpeechRecognizer receives the above calculated RMS level and computes a volume level in the [0.0-1.0] range.
- SpeechInputManager receives the above computed volume level and passes it to SpeechInputBubbleController for display, which passes it to SpeechInputBubble.
- SpeechInputBubbleBase creates the appropriate skia bitmap for the volume indicator and passes to the platform specific code for display.
- As part of the above SpeechInputBubbleController addition for volume level, I wrote a single function to process all calls received by it and handled in the UI thread for simplicity.
BUG=53598
TEST=updated existing tests. Also test manually, use speech input and verify the audio level changes appropriately in the UI as mic is moved near and far.
Review URL: http://codereview.chromium.org/3384005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53158
TEST=Configure wildcard blacklist pattern and check whether plugins get disabled in about:plugins.
Review URL: http://codereview.chromium.org/3435001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change the child process to synchronise with the parent (the zygote)
so that the child does not fork further children while the zygote is
trying to discover the child's real PID from the SUID helper.
Split the logic for doing METHOD_GET_CHILD_WITH_INODE into a separate
function. Add a pipe for doing the synchronisation.
Now that the child synchronises, it can close dummy_fd.
BUG=55599
TEST=Tested manually with:
cd native_client && ./tools/httpd.py &
CHROME_DEVEL_SANDBOX=/opt/google/chrome/chrome-sandbox ./out/Debug/chrome-wrapper --enable-nacl --enable-seccomp-sandbox http://localhost:5103/tests/prebuilt/srpc_hw.html
Review URL: http://codereview.chromium.org/3391003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since this mostly worked before, this is just a matter of reordering
some "if" clauses.
Before this change, --enable-seccomp-sandbox would have the side
effect of disabling the SUID sandbox. The zygote would get run
through the SUID helper, but the zygote would never send the message
to turn the SUID sandbox on.
Change this so that --enable-seccomp-sandbox does not disable the SUID
sandbox.
BUG=55599
TEST=Tested manually with:
cd native_client && ./tools/httpd.py &
CHROME_DEVEL_SANDBOX=/opt/google/chrome/chrome-sandbox ./out/Debug/chrome-wrapper --enable-nacl --enable-seccomp-sandbox http://localhost:5103/tests/prebuilt/srpc_hw.html
Review URL: http://codereview.chromium.org/3449001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added new classes WeakXmppClient and XmppConnection, which let me
simplify MediatorThreadImpl et al.
BUG=55302
TEST=new unit tests, manually
Review URL: http://codereview.chromium.org/3290025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GpuVideoDecoder now implements VideoDecodeContext. Also defined a
GpuVideoDevice that works with GpuVideoDecoder.
No implemetation in this change, just added comments to describe the work flow.
BUG=53714
TEST=Tree is green
Review URL: http://codereview.chromium.org/3295027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3423004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crosbug.com/6620
TEST=Manual
Review URL: http://codereview.chromium.org/3429007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
installs.
BUG=55363
TEST=none
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3404005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Plumb the gaia password up to the cryptographer to generate an
encryption key.
Add NIGORI to the list of active datatypes to request if
enable-sync-passwords is specified.
Also fixes behavior from bug 55501 (required adding ExtraChangeRecordData to syncapi), as well as an ADD-handling bug in ApplyChangesFromSyncModel.
Add back the call to Cryptographer::Bootstrap which was mistakenly removed in auth refactor.
This patch doesn't have necessary UI to handle secondary passphrases,
password changes, or existing user upgrades. Only unsynced profiles
can currently get password sync working.
BUG=48702,32410, 55501
TEST=ProfileSyncPasswordTest, upcoming password integration tests
Review URL: http://codereview.chromium.org/3295026
TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/3419003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Plumb the gaia password up to the cryptographer to generate an
encryption key.
Add NIGORI to the list of active datatypes to request if
enable-sync-passwords is specified.
Also fixes behavior from bug 55501 (required adding ExtraChangeRecordData to syncapi), as well as an ADD-handling bug in ApplyChangesFromSyncModel.
Add back the call to Cryptographer::Bootstrap which was mistakenly removed in auth refactor.
This patch doesn't have necessary UI to handle secondary passphrases,
password changes, or existing user upgrades. Only unsynced profiles
can currently get password sync working.
BUG=48702,32410, 55501
TEST=ProfileSyncPasswordTest, upcoming password integration tests
Review URL: http://codereview.chromium.org/3295026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/3385004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also refactored a bunch of code from chrome/browser to webkit/fileapi for reuse.
Added class hierarchy. Test shell and browser operations now inherit from
common webkit/fileapi/file_system_operation.
Review URL: http://codereview.chromium.org/3186009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
In one case, completely removed the field trial.
BUG=55634
r=mbelshe,willchan
Review URL: http://codereview.chromium.org/3449003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Note: This was a TODO for Aaron).
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3429003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:6554
TEST=kill ibus-daemon and check that candidate_window shuts down.
Review URL: http://codereview.chromium.org/3429002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Scaling would change the color of pixels, causing test failure.
BUG=51761
TEST=ExtensionApiTest.CaptureVisibleTabPng
Review URL: http://codereview.chromium.org/3395004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
installs.
BUG=55363
TEST=none
Review URL: http://codereview.chromium.org/3324017
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3406004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=55798
TEST=Go to bookmark manager
Right click the list
Mouse over and mousedown on a separator. It should not change color.
Review URL: http://codereview.chromium.org/3381007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=52291
TEST=Go to bookmark manager.
Right click a bookmark.
Right click another bookmark. This should open a new context menu
Right click "Edit...". This should start editing the item.
Review URL: http://codereview.chromium.org/3395006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=unit tests
Review URL: http://codereview.chromium.org/3440005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The dmg used need not be a valid one. Replacing the 10MB one with a 4K one.
BUG=
TEST=
Review URL: http://codereview.chromium.org/3397003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added closed_task parameter in this method. This parameter is used to
notify the caller when the stream is actually closed. Callbacks may
be called until closed_task is executed.
BUG=55755
TEST=Unittests, audio still works, doesn't crash
Review URL: http://codereview.chromium.org/3415007
TBR=sergeyu@chromium.org
Review URL: http://codereview.chromium.org/3425008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added closed_task parameter in this method. This parameter is used to
notify the caller when the stream is actually closed. Callbacks may
be called until closed_task is executed.
BUG=55755
TEST=Unittests, audio still works, doesn't crash
Review URL: http://codereview.chromium.org/3415007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=55732
TEST=Create a ntp that is small enough that the theme
attribution or chrome/chromium icon does not show up. Refresh
the page. The attribution or icon should still not be
visible.
Review URL: http://codereview.chromium.org/3437004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
be passed to the IO thread or into renderers, where its
functionality can be reused without having to reimplement.
This will be used in the fix for bug 53495.
BUG=53495
TEST=unit_tests --gtest_filter=Extension*
Review URL: http://codereview.chromium.org/3432001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Creates a zip for every sample when building the samples gallery.
Add a link to download a zip to each sample in the gallery.
Adds initial zips for all samples.
BUG=52088
TEST=None
Review URL: http://codereview.chromium.org/3395001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trigger X11 error, look at the error dialog
Review URL: http://codereview.chromium.org/3425006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3395005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also removed a function that is no longer called.
BUG=None
TEST=Build works.
Review URL: http://codereview.chromium.org/3453006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove incorrect check for needs_repainting in OnWasRestored. This check, when in place, causes us to drop the needs_repainting_on_restore_ repaints.
Patch submitted by: nduca@chromium.org
BUG=55515
TEST=
Review URL: http://codereview.chromium.org/3411007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
class.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3408006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=13291
TEST=interactive_ui_tests:AccessibilityWinBrowserTest.TestNotification*
Review URL: http://codereview.chromium.org/3341021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This makes browser.h not depend on extension.h.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3399008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is upstreaming a Gentoo Linux patch.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3380004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=compiles
Review URL: http://codereview.chromium.org/3380009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
script is executed by /bin/sh. On many systems, /bin/sh does not have support
for "[[". We could either switch to a different shell (e.g. /bin/bash), we
could switch to using "[" instead, or we could avoid the entire problem by
using "${:+}" variable expansion.
I tested that the latter does the right thing with /bin/bash, /bin/ash,
/bin/dash, /bin/zsh, /bin/sh (the latter being a symbolic link to /bin/dash).
So, I think we are on the safe side.
BUG=54132
TEST=Start Chrome and notice that there no longer is an error message about "[[" being unavailable
Review URL: http://codereview.chromium.org/3412004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
host string + port.
Review URL: http://codereview.chromium.org/3420001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none.
TEST=Use extension to drive the tts engines on Windows and Mac. Had key bindings so that verification of:
decrease rate, increase rate, decrease pitch, increase pitch, decrease volume, and increase volume worked. Verified that the limits, when reached, did not have any adverse effects.
Review URL: http://codereview.chromium.org/3325021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59572 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IO loop used for OCSP.
Refactor nss_ocsp.cc code even more. Split up OCSP initialization into two LazyInstances. One is for the IO loop. One is for registration of OCSP callbacks in NSS, which will load NSS into memory. Sync and the normal network stack race to set their loop at the IO loop used by OCSP. We fix that by providing a SetMessageLoopForOCSP() function which will be called in the IOThread initialization code which runs before the sync thread starts up. Since we split this up from the registration of the OCSP callbacks, it won't also eagerly load NSS, which previously regressed startup time. Note that the URLRequestContext pointer is still a global, not associated with either of the LazyInstances, because it's used by worker threads which can run past the lifetime of the LazyInstances.
BUG=36740
TEST=none
Review URL: http://codereview.chromium.org/3446001
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/3424010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Linux Reliability Builder test directory output is < 100 MB.
Review URL: http://codereview.chromium.org/3398004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crosbug.com/6379
TEST=Help dialogs occur on welcome screen, login screen.
Review URL: http://codereview.chromium.org/3330017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=54833
TEST=none
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/3399009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59567 0039d316-1c4b-4281-b951-d872f2087c98
|