| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
new Auth service which will issue auth tokens.
I'd like to get it in and continue hacking on it so I can stop colliding so badly with merges.
I've ported over the existing unit tests. Eventually gaia_authenticator.cc is going away. For the time being, i'll be number two.
This is now done, with a pile of unit tests. I am trying to run the interactive tests but I was getting numerous unrelated failures and need to resync ChromiumOS to a working build.
TEST=unit tests, manually log in, out, enter wrong password.
BUG=47091
Review URL: http://codereview.chromium.org/2801015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the header file resulting in
these objects being initialized wherever the form_field.h is included. All this happens during LoadLibrary of
chrome.dll.
Moving the definitions of the string objects to the source file.
Bug=48097
Review URL: http://codereview.chromium.org/2883016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Notify the data has changed so the bookmark editor tree populates itself.
BUG=47872
TEST=Open a bookmark editor and see if there's a tree
Review URL: http://codereview.chromium.org/2832045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Not used anywhere yet, no functionality change.
BUG=45547
TEST=none
Review URL: http://codereview.chromium.org/2815042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
in a form that has already been auto-filled.
BUG=47436
TEST=AutoFillManagerTest.GetFieldSuggestionsWithDuplicateValues
Review URL: http://codereview.chromium.org/2855030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2866039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
i.e. http://build.chromium.org/buildbot/waterfall/builders/XP%20Tests%20(dbg)(1)/builds/25113/steps/sync_unit_tests/logs/stdio
BUG=39070
TEST=SyncerThreadWithSyncerTest.Pause
Review URL: http://codereview.chromium.org/2852038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Wrap the model in a GtkTreeSortable. This corrects editing of
content exception entries in the presence of sorted columns.
- Also adds unit tests for this window.
BUG=47841
TEST=ContentExceptionsWindowGtkUnittest.* + see bug
Review URL: http://codereview.chromium.org/2876032
TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/2838039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47756
TEST=start up chrome with a new User Data Dir. Set up sync -> enter username/pw. On the "choose data types" screen that comes next, the "keep everything synced" radio button should be selected.
Review URL: http://codereview.chromium.org/2854030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As we add more metrics to Chrome OS, it makes sense to monitor this
to ensure it doesn't become a performance issue given that the
code runs every 30 seconds.
BUG=none
TEST=installed on device,looked at about:histograms,ran unit tests
Review URL: http://codereview.chromium.org/2814043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Switching to the new TranslateManager code (renaming TranslateManager2 to TranslateManager and similarly for all similar classes).
Original review:
http://codereview.chromium.org/2825032/show
BUG=40828
TEST=Make sure translate still works as expected on all platforms.
Review URL: http://codereview.chromium.org/2885015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
experiment to see how much time was spent doing background painting. This
resulted in incorrect opacity for Pepper plugins repainting themselves.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2830034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
radius of the close button hover state circle a bit.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2833050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Issue 35198 can not be reproduced locally. To enable users to do experiments, three command line flags are added to chrome:
--issue35198-crxdir-browser: Have the browser process create the directory in which the extension will be unzipped.
--issue35198-logging: Enable log messages from directory creation in the utility process to be moved to the browser process.
--issue35198-permission: Use the most permissive file permissions possible on the extension unpack directory.
BUG=35198
TEST=manual
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51231
Review URL: http://codereview.chromium.org/2802018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Wrap the model in a GtkTreeSortable. This corrects editing of
content exception entries in the presence of sorted columns.
- Also adds unit tests for this window.
BUG=47841
TEST=ContentExceptionsWindowGtkUnittest.* + see bug
Review URL: http://codereview.chromium.org/2876032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=48030
TEST=none
Review URL: http://codereview.chromium.org/2859038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
use them from views and gfx.
Sorry for the new patch on this and not an update. Not sure what happened.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2809047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
in inserting into the wrong parent.
BUG=40544
TEST=see bug
Review URL: http://codereview.chromium.org/2856027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Methods stubbed out for now, and not used anywhere yet.
BUG=45547
TEST=none
Review URL: http://codereview.chromium.org/2847041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=--bookmark-menu no longer does anything
Review URL: http://codereview.chromium.org/2853024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable chromoting host process if chrome is started with
--type=service --enable-chromoting
BUG=none
TEST=chrome --type=service --enable-chromoting
Review URL: http://codereview.chromium.org/2813038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specifically,
geolocation_exceptions_window_controller => simple_content_exceptions_window_controller (mac)
geolocation_exceptions_view => simple_content_exceptions_view (win)
geolocation_content_exceptions_window => simple_content_exceptions_window (linux)
It's now easy to use it to show desktop notification exceptions as well.
No functionality change.
BUG=45547
TEST=geolocation exceptions dialog still works
Review URL: http://codereview.chromium.org/2835031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46408
TEST=See bug description.
Review URL: http://codereview.chromium.org/2882007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ran tests for a few hours on windows without seeing a failure.
BUG=44026
TEST=BrowserAppRefocusTest.*
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51362
Review URL: http://codereview.chromium.org/2870036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This means, if you press enter, it'll work the same as if you clicked OK.
BUG=47752
TEST=Set up sync -> enter username/pw, press enter on choose datatypes screen, it should start syncing and eventually get to "success".
Review URL: http://codereview.chromium.org/2876017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2850038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that the HttpNetworkTransaction correctly handles asynchronous auth token
generation, HttpAuthHandlerNegotiate can be turned into a state machine. This
also removes the need for the externally exposed "Resolve Canonical Name"
details to users of this handler.
BUG=42222
TEST=net_unittests
Review URL: http://codereview.chromium.org/2867022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Version 18 means use the Favicons file (if the TopSites flag is on).
This avoids the check for a Thumbnails DB file on startup.
BUG=None
TEST=ThumbnailDatabaseTest, HistoryBackendTest
Review URL: http://codereview.chromium.org/2884013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=levin
Review URL: http://codereview.chromium.org/2842039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=yurys
Review URL: http://codereview.chromium.org/2812037
TBR=kinuko@chromium.org
Review URL: http://codereview.chromium.org/2878019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=levin
Review URL: http://codereview.chromium.org/2847040
TBR=yurys@chromium.org
Review URL: http://codereview.chromium.org/2858041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=levin
Review URL: http://codereview.chromium.org/2847040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=yurys
Review URL: http://codereview.chromium.org/2812037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
failing after WebKit roll
TBR=levin
Review URL: http://codereview.chromium.org/2806047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
derive from it.
No functionality change.
This will be used to share the content settings exceptions dialog code between geolocation and notifications.
BUG=45547
Review URL: http://codereview.chromium.org/2838037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crosbug.com/4321
TEST=Go though OOBE process. When update has initiated and failed update screen proceeds.
Review URL: http://codereview.chromium.org/2836039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
DevToolsManager::GetInstance
BUG=47806
Review URL: http://codereview.chromium.org/2878010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the download shelf and other places. Delete the original pdfs. This is in line with the new top chrome refresh.
BUG=44574
TEST=none
Review URL: http://codereview.chromium.org/2805055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
destructor. This isn't really needed now that we've disabled phantom
tabs, but I'm doing in case we end up reenabling phantom tabs.
BUG=45541
TEST=covered by unit test.
Review URL: http://codereview.chromium.org/2800037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ran tests for a few hours on windows without seeing a failure.
BUG=44026
TEST=BrowserAppRefocusTest.*
Review URL: http://codereview.chromium.org/2870036
TBR=skerner@chromium.org
Review URL: http://codereview.chromium.org/2865031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Ran tests for a few hours on windows without seeing a failure.
BUG=44026
TEST=BrowserAppRefocusTest.*
Review URL: http://codereview.chromium.org/2870036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Before this change New User sometime blinck after successful login.
Review URL: http://codereview.chromium.org/2878018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=crosbug.com/3280
TEST=See login with on Chrome OS.
Review URL: http://codereview.chromium.org/2848033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47277
TEST=none
Review URL: http://codereview.chromium.org/2876020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=levin
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2810043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47518
TEST=none
Review URL: http://codereview.chromium.org/2832042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
yet been set.
BUG=chromium-os:3957
TEST=On a new install, set the language to Japanese, log in, and check that English and all Japanese IMEs are enabled.
Review URL: http://codereview.chromium.org/2804032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Several sync integration tests were failing because the fact that
notifications were enabled was not detected by the sync clients. This
changelist adds a call to NudgeSyncer() in OnNotificationStateChange()
so that the syncer thread is made aware of the fact that notifications
have been enabled. This change caused the integration test pass rate to
increase from ~20% to 90+%.
BUG=47240
TEST=sync_integration_tests
Review URL: http://codereview.chromium.org/2814045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- login/user_manager.cc
Register a new Local State item, "PreferredKeyboardLayout".
- login/wizard_controller.cc
Set up keyboards for the current locale. For example, when |locale| is "en-US", enable US qwerty and US dvorak keyboard layouts.
- login/language_switch_menu.cc
Enable the keyboard layouts that are necessary for the new locale.
- login/account_screen.h
When the account creation screen is shown, enable input methods (e.g. Chinese, Japanese, Korean) so that users could input their first and last names. Disable them when the screen is closed.
- status/language_menu_button.cc
Update the Locale State when a user switches keyboard layout.
BUG=chromium-os:2619
TEST=manual & the browser_tests
Review URL: http://codereview.chromium.org/2806026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51340 0039d316-1c4b-4281-b951-d872f2087c98
|