| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=674
TEST=none
Review URL: http://codereview.chromium.org/9042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
chrome.exe so there's no need to call anything on Vista and later to activate it.
Review URL: http://codereview.chromium.org/9050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
then renavigating very quickly.
BUG=2855
Review URL: http://codereview.chromium.org/9330
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This patch blocks all the extensions that we register.
R=nsylvain
BUG=1463961
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9265
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
initialization. This allows the thread to be reused later.
Review URL: http://codereview.chromium.org/9276
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
reflect its rage change."
This issue is caused by my code that cannot extract a target clause from a composition string when there is an input clause after a target clause.
when a user changes the range of a target clause, Japanese IMEs creates a composite clause which consists of a new target clause and an input clause. My IME code treats such composite clause as a target clause and cannot reflect the change.
To fix this problem, this code changes the algorithm which extracts a target clause.
Review URL: http://codereview.chromium.org/8970
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
so that we restore the window if minimized/iconified and give focus to
the search field.
BUG=4038 4044
TEST=see bugs
Review URL: http://codereview.chromium.org/9069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the bookmarks folder tree model to return custom icons for search and
recently bookmarked.
BUG=674
TEST=none
Review URL: http://codereview.chromium.org/9047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=nsylvain
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9292
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Use using_hunspell.scons and using_wtl.scon instead of
by-hand additions to CPPPATH and CPPDEFINES.
* Only add $CHROME_DIR/tools/build/win on Windows systems.
* Add 'hunspell' to LIBS in using_hunspell.scons so we don't
have to add it by hand.
Review URL: http://codereview.chromium.org/9071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=3912
Review URL: http://codereview.chromium.org/9273
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NPObject was deallocated by the script controller but WebPluginDelegateProxy wasn't telling NPObjectStub that it's contained object was garbage soon enough.
BUG=1036087
Review URL: http://codereview.chromium.org/9066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Sandbox is currently having a problem with this so it is disabled.
Fixed a few stray items.
Review URL: http://codereview.chromium.org/9259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(while leaving the HTTP authentication dialog support) and add a new type of constrained window which owns all blocked popups. Rip out dead unit tests.
Review URL: http://codereview.chromium.org/8782
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- the numbers were out of sync with result_codes.h
- can't use result_codes.h in base project so I extracted
the generic part of it.
Rahul: I hope I don't break installer assumptions here.
Dan: don't feel obligated to review.
Review URL: http://codereview.chromium.org/9012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
was a crash in the browser in the IPC handler codepath which handles scrolling.
The crash occured because of a failure to find the backing store for the RenderWidgetHost instance. We would end up dereferencing a NULL backing store pointer and crash.
The fix for this is to check for a NULL backing store and return.
R=darin
Bug=3907
Review URL: http://codereview.chromium.org/9056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Adds a menu button on the bookmark manager. If I finish up import
I'll add a second one for importing.
. Creating new page/folder from menu items selects new item in table.
. I changed around the FolderBookmarkTableModel to copy the contents
into a vector (now extends VectorBackedTabledModel). This is
necessitated by TableView not providing a moved notification. The
problem with previous approach is that I sent out ModelChanged on
any change, which loses selection and causes things to snap around.
I considered adding a moved method to TableView, but it's too much
work at this time.
. Added persisting of divider location in bookmark manager.
. When focus is on table pressing enter on a folder descends into the
folder, and pressing backspace goes back up a folder.
BUG=674
TEST=none
Review URL: http://codereview.chromium.org/8967
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
prompting the user.
BUG=1445145
Review URL: http://codereview.chromium.org/8943
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
my earlier experiment.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Move params to "distribution" group
- Add "import_search_engine", "show_welcome_page" params
- Now the welcome page and the bubble actually work
- Some cleanup
BUG=1394863
Review URL: http://codereview.chromium.org/9207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
bindings, this doesn't actually expose the DB code to web pages.
Review URL: http://codereview.chromium.org/7982
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=3961
Review URL: http://codereview.chromium.org/8983
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
WebFrame::ExecuteJavaScript() instead.
Review URL: http://codereview.chromium.org/8826
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
time, as much as 3.5ms. Altough the lock is not contended in this case, be more precise about when we need to hold the lock. Also clean up a static initialization to use LazyInstance.
Review URL: http://codereview.chromium.org/9246
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
* Rename chrome/common/SConscript to chrome/common/common.scons.
* Use the new using_*.scons files for settings.
* Split build of ipc_tests.exe into chrome/common/ipc_tests.scons.
Review URL: http://codereview.chromium.org/9253
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
system level install case.
BUG=1455516.
Review URL: http://codereview.chromium.org/8974
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Move chrome/browser/SConscript => chrome/browser/browser.scons.
* Use using_*.scons files instead of by-hand settings.
* Add new using_*.scons files:
breakpad/using_breakpad.scons
chrome/third_party/hunspell/using_hunspell.scons
chrome/third_party/wtl/using_wtl.scons
google_update/using_google_update.scons
third_party/npapi/using_npapi.scons
* Delete some unused CPPPATH directories.
Review URL: http://codereview.chromium.org/9243
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
refer to the *.res files we need directly by name, instead of trying
to get them from the (no longer shared) the construction environment.
Review URL: http://codereview.chromium.org/9242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9241
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=1208
Review URL: http://codereview.chromium.org/8991
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Rename SConscript.unit_tests to test/unit/unit_tests.scons.
* Add a new chrome/chrome.scons "master" for building everything
chrome. Have it just load the existing SConscript file, and
the new test/unit/unit_tests.scons file. We'll move things from
SConscript (or elsewhere) into chrome.scons as they get convertd.
* Change build/SConscript.main to load chrome/chrome.scons.
* Add new using_libjpeg.scons, using_libxml.scons, and using_libxslt.scons
"properties" files.
* Convert test/unit/unit_tests.scons to use the available using_*.scons files.
* Combine settings that were scattered throught test/unit/unit_tests.scons
to make it a little more readable.
* Add $CHROME_DIR/ to the beginning of the file listed in
test/unit/unit_tests.scons, since they're now being interpreted
from a SConscript file down two directory levels.
Review URL: http://codereview.chromium.org/9005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
More comprehensive changes will be made for post 1.0.
This is good enough for 1.0.
TBR=sidchat
BUG=1723
TEST=In Accept-Language menu, Germain (Switzerland), French(Canada), etc are listed.
Review URL: http://codereview.chromium.org/9027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=ben
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=3956
Review URL: http://codereview.chromium.org/8987
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
entry (instead of displaying the whole path). This unifies the display of titles for local and remote files.
For anyone watching, this is how tab titles will change:
'http://blah.com/index.html' will be 'index.html'
'http://blah.com/meat%20pie.pdf' will be 'meat pie.pdf'
'file://C:/blah/blue%20cheese.txt' will be 'blue cheese.txt' (previously this sometimes changed between the URL and blue%20cheese.txt depending on how the file was opened).
BUG=2529,2375
Review URL: http://codereview.chromium.org/8973
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
- this one is back mergeable, I hope.
Review URL: http://codereview.chromium.org/9000
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=glen
Review URL: http://codereview.chromium.org/9002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=2906
Review URL: http://codereview.chromium.org/8753
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
of the dragged tab container.
http://crbug.com/3939
Review URL: http://codereview.chromium.org/8800
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Add a unittest for label.cc
Review URL: http://codereview.chromium.org/8902
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- skip or not first run dialgos
- on skip import silently search provider only
BUG=1394863
Review URL: http://codereview.chromium.org/8758
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
page navigations in timers and reads the history length to validate it.
When we receive a request to initiate a navigation in the browser, we send out the request to the renderer and then immediately read the history length and send it out in an update history length request. This causes the test to fail at times as it reads a stale history length.
When we receive the DidAddHistoryItem notification in the renderer, we should not update the history length for the start page navigation. This results in the test failure at times as it reads an incorrect history length.
R=jam
Review URL: http://codereview.chromium.org/8898
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4344 0039d316-1c4b-4281-b951-d872f2087c98
|